[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Vinod Kone (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287014#comment-15287014
 ] 

Vinod Kone commented on MESOS-3781:
---

Committed the chain. I'm keepin the ticket open for a review for CHANGELOG 
update. Can you please send it?


commit 2e409a5257cf4d53040959cae0edfbd7cf1a1af9
Author: Jay Guo 
Date:   Tue May 17 09:58:46 2016 -0700

Renamed all flag variables from keyword 'slave' to 'agent'.

The following flags variables were updated:
--agent_reregister_timeout
--recovery_agent_removal_limit
--agent_removal_rate_limit
--authenticate_agents
--agent_ping_timeout
--max_agent_ping_timeouts
--max_executors_per_agent
--agent_subsystems

Review: https://reviews.apache.org/r/47406/

commit c8f2c26f90cb8966ba45fce9fc070c5a20a5cd8a
Author: Jay Guo 
Date:   Tue May 17 09:58:15 2016 -0700

Replaced 'slave' with 'agent' in flag names.

Original names are marked as deprecated.

Review: https://reviews.apache.org/r/45200/


> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Jay Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15249314#comment-15249314
 ] 

Jay Guo commented on MESOS-3781:


OK, let's revisit deprecation implementation when it's done. Thx!

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Vinod Kone (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248858#comment-15248858
 ] 

Vinod Kone commented on MESOS-3781:
---

Let me work on adding multiple name support to flags and then you can base your 
deprecation patch based on that.

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Jay Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245223#comment-15245223
 ] 

Jay Guo commented on MESOS-3781:


Here's what I understand from your comments:
1. We should enable multi-named flags in FlagsBase
2. While loading flag values from cmd/env in FlagsBase::load(), it generates 
warnings by determining actual name being used. (Add check logic to 
__Flag.load__ lambda? It takes __DeprecatedName__ struct in capture, as well as 
the _name_ used to actual load the value, and generate warnings if _name_ falls 
into DeprecatedName) Something like this:
```cpp
flag.load = [t1, deprecatedNames](FlagsBase*, const std::string& name, const 
std::string& value) -> Try {
  ...
  if (deprecatedNames.find(name)) { deprecationWarning(name); }
  ...
};
```
3. Add duplicate names to all applicable flags

My concerns:
1. Why both _Name_ and _deprecatedName_ structs? Since we only need to know 
whether it is deprecated. Also, I don't see any instance that has __multiple__ 
deprecated names, so why vector of structs?
2. If the sole purpose of having this vector of structs is to search for 
deprecated names, I suggest to use _set_ instead.
3. Are we overengineering this? 'slave' flags will eventually be removed, along 
with deprecatedNames. Nevertheless, I like the idea of having multi-name flags.

Thanks!

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Vinod Kone (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242173#comment-15242173
 ] 

Vinod Kone commented on MESOS-3781:
---

Another option that BenM suggested, which I quite like, is to let Flags::add() 
take a list of "Name" and "DeprecatedName" structs instead of a list of 
strings. The idea is to have 2 structs (Name and DeprecatedName) both of which 
are default constructible from a string. The advantage is that we can clearly 
identify which of the names is deprecated and automatically generate a warning 
when a deprecated name is being loaded. 

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Vinod Kone (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237546#comment-15237546
 ] 

Vinod Kone commented on MESOS-3781:
---

I took a look at the review you posted and discussed w/ [~bmahler] on better 
ways to do it.

Here is what I've in mind

--> First do a review where you change the Flag *variables* but keep the old 
*names*. For example

{code}
  add(::authenticate_agents,
 "authenticate_slaves",
 "..help string.",
 false);
{code}

Note that this needs changes in master.cpp and other files where these flags 
are accessed.

2) Another review where we add support for Flags::add() to take multiple names 
instead of a single name as argument. This is similar to the multi-name support 
in python's argparse.

{code}
  template 
  void add(
  T1* t1,
  const std::vector& names,
  const std::string& help,
  const T2& t2,
  F validate);
{code}

Note this would need changes to FlagsBase and Flag classes.
{code}
 struct Flag
 {
...
-  std::string name;
+  std::vector names;
...
}

struct FlagsBase
{
...
-  std::map flags_;
+  std::map flags_;
...
}
{code}

Note that we need a shared_ptr in FlagsBase because multiple flag names can 
correspond to the same Flag object.

3) Another review to update master binary flags that contain "slave" keyword to 
have an additional name with "agent" keyword. Example

{code}
  add(::authenticate_agents,
  {"authenticate_slaves", "authenticated_agents"},
  "If `true`, only authenticated slaves are allowed to register.\n"
  "If `false`, unauthenticated slaves are also allowed to register.\n"
  "--authenticate_slaves flag is *DEPRECATED* in favor of 
--authenticate_agents.",
  false);
{code}

4) Another review to update slave binary flags as above.

How does that sound?

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Jay Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236912#comment-15236912
 ] 

Jay Guo commented on MESOS-3781:


OK, will do next time. Thanks!

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Vinod Kone (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235826#comment-15235826
 ] 

Vinod Kone commented on MESOS-3781:
---

This is the work flow we use. Open --> Accept --> In Progress --> Reviewable.

There should be buttons up top for making these transitions. Sometimes the 
buttons are at the top level and sometimes they are underneath the "Workflow" 
button. Once a ticket is "In Progress", you can click "Post Review" button to 
post the RB link as the comment and transition the ticket to "Reviewable".

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Jay Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234590#comment-15234590
 ] 

Jay Guo commented on MESOS-3781:


Hi, I updated the patch https://reviews.apache.org/r/45200/ please take a look. 
BTW, how to change a story to reviewable? I'll do it next time. THx

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Vinod Kone (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220619#comment-15220619
 ] 

Vinod Kone commented on MESOS-3781:
---

Can you transition the tickets to reviewable once you post a review? I'll do it 
this time. Thanks.

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Jay Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208018#comment-15208018
 ] 

Jay Guo commented on MESOS-3781:


[~vinodkone] we submitted a patch here: https://reviews.apache.org/r/45200/ 

please review. Thx

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Vinod Kone (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205292#comment-15205292
 ] 

Vinod Kone commented on MESOS-3781:
---

Yup. I think that's the plan. You should make sure to call out that the old 
flags are deprecated (in flags description, CHANGELOG, docs etc.).

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3781) Replace Master/Slave Terminology Phase I - Add duplicate agent flags

[Jay Guo (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203895#comment-15203895
 ] 

Jay Guo commented on MESOS-3781:


As I pick up this ticket, just wanna confirm the actual requirements. Are we 
going to duplicate following flags with keyword {{agent}}?
In {{src/master/flags.hpp}}
* slave_reregister_timeout
* recovery_slave_removal_limit
* slave_removal_rate_limit
* authenticate_slaves
* slave_ping_timeout
* max_slave_ping_timeouts
* max_executors_per_slave

In {{src/slave/flags.hpp}}
* slave_subsystems

[~darroyo]

> Replace Master/Slave Terminology Phase I - Add duplicate agent flags 
> -
>
> Key: MESOS-3781
> URL: https://issues.apache.org/jira/browse/MESOS-3781
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: Jay Guo
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)