[jira] [Commented] (MESOS-3977) http::_operation() creates unnecessary filter, rescinds unnecessarily
[ https://issues.apache.org/jira/browse/MESOS-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021958#comment-15021958 ] Neil Conway commented on MESOS-3977: I believe that logic is ensuring that, if an outstanding offer shares no resources in common with the required resources, we don't try to rescind the offer. i.e., doesn't seem related as far as I can tell. > http::_operation() creates unnecessary filter, rescinds unnecessarily > - > > Key: MESOS-3977 > URL: https://issues.apache.org/jira/browse/MESOS-3977 > Project: Mesos > Issue Type: Bug >Reporter: Neil Conway >Priority: Minor > Labels: mesosphere, reservations > > This function is used by the /reserve, /unreserve, /create-volume, and > /destroy-volume endpoints. It has a few worts: > 1. It installs a 5-second filter when rescinding an offer. However, the > cluster state might change so that the filter is actually undesirable. For > example, this scenario: > * Create DR, make offer > * Create PV => rescinds previous offer, sets filter, makes offer > * Destroy PV => rescinds previous offer > After the last step, we'll wait 5 seconds for the filter to expire before > re-offering the DR. > 2. If there are sufficient available resources at the target slave, we don't > actually need to rescind any offers in the first place. However, _operation() > rescinds offers unconditionally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3977) http::_operation() creates unnecessary filter, rescinds unnecessarily
[ https://issues.apache.org/jira/browse/MESOS-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022055#comment-15022055 ] Guangya Liu commented on MESOS-3977: I see, yes, we should do some checking to see if the slave has enough resources before rescind offers instead of pessimistically rescind offers. > http::_operation() creates unnecessary filter, rescinds unnecessarily > - > > Key: MESOS-3977 > URL: https://issues.apache.org/jira/browse/MESOS-3977 > Project: Mesos > Issue Type: Bug >Reporter: Neil Conway >Priority: Minor > Labels: mesosphere, reservations > > This function is used by the /reserve, /unreserve, /create-volume, and > /destroy-volume endpoints. It has a few worts: > 1. It installs a 5-second filter when rescinding an offer. However, the > cluster state might change so that the filter is actually undesirable. For > example, this scenario: > * Create DR, make offer > * Create PV => rescinds previous offer, sets filter, makes offer > * Destroy PV => rescinds previous offer > After the last step, we'll wait 5 seconds for the filter to expire before > re-offering the DR. > 2. If there are sufficient available resources at the target slave, we don't > actually need to rescind any offers in the first place. However, _operation() > rescinds offers unconditionally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3977) http::_operation() creates unnecessary filter, rescinds unnecessarily
[
https://issues.apache.org/jira/browse/MESOS-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020360#comment-15020360
]
Guangya Liu commented on MESOS-3977:
[~neilc] I think that the {{http::_operation()}} already make some checking for
this in
https://github.com/apache/mesos/blob/master/src/master/http.cpp#L2128-L2133 ,
if there are enough resources on the slave, then the operation will not rescind
offers. Comments?
> http::_operation() creates unnecessary filter, rescinds unnecessarily
> -
>
> Key: MESOS-3977
> URL: https://issues.apache.org/jira/browse/MESOS-3977
> Project: Mesos
> Issue Type: Bug
>Reporter: Neil Conway
>Priority: Minor
> Labels: mesosphere, reservations
>
> This function is used by the /reserve, /unreserve, /create-volume, and
> /destroy-volume endpoints. It has a few worts:
> 1. It installs a 5-second filter when rescinding an offer. However, the
> cluster state might change so that the filter is actually undesirable. For
> example, this scenario:
> * Create DR, make offer
> * Create PV => rescinds previous offer, sets filter, makes offer
> * Destroy PV => rescinds previous offer
> After the last step, we'll wait 5 seconds for the filter to expire before
> re-offering the DR.
> 2. If there are sufficient available resources at the target slave, we don't
> actually need to rescind any offers in the first place. However, _operation()
> rescinds offers unconditionally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
