[jira] [Commented] (MESOS-4316) Support get non-default weights by /weights

[Adam B (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256616#comment-15256616
 ] 

Adam B commented on MESOS-4316:
---

commit d014d994b4513f9dcf9d33a293e847505bfb10fb
Author: Adam B 
Date:   Mon Apr 25 05:09:44 2016 -0700

Fixed unsigned int comparison.

commit 03168ce650856bffdcf172c3e87d85c2e2dd8f6b
Author: Yongqiao Wang 
Date:   Mon Apr 25 04:23:16 2016 -0700

Added positive tests for /weights endpoint.

Review: https://reviews.apache.org/r/46139/

> Support get non-default weights by /weights
> ---
>
> Key: MESOS-4316
> URL: https://issues.apache.org/jira/browse/MESOS-4316
> Project: Mesos
>  Issue Type: Task
>Reporter: Yongqiao Wang
>Assignee: Yongqiao Wang
>Priority: Minor
>  Labels: mesosphere
> Fix For: 0.29.0
>
>
> Like /quota, we should also add query logic for /weights to keep consistent. 
> Then /roles no longer needs to show weight information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-4316) Support get non-default weights by /weights

[Yongqiao Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238672#comment-15238672
 ] 

Yongqiao Wang commented on MESOS-4316:
--

Append the RR for positive tests: https://reviews.apache.org/r/46139/

> Support get non-default weights by /weights
> ---
>
> Key: MESOS-4316
> URL: https://issues.apache.org/jira/browse/MESOS-4316
> Project: Mesos
>  Issue Type: Task
>Reporter: Yongqiao Wang
>Assignee: Yongqiao Wang
>Priority: Minor
>  Labels: mesosphere
> Fix For: 0.29.0
>
>
> Like /quota, we should also add query logic for /weights to keep consistent. 
> Then /roles no longer needs to show weight information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-4316) Support get non-default weights by /weights

[Adam B (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234055#comment-15234055
 ] 

Adam B commented on MESOS-4316:
---

I committed these first two patches, but we still need at least one test for 
the positive path, where somebody requests to GET /weights, and is returned 
some basic values. This issue cannot be closed until such a test has been 
created.

commit 0e5680c51ce7479f294cc654007a007f2eaeb05d
Author: Yongqiao Wang 
Date:   Sun Apr 10 00:40:50 2016 -0700

Added authentication test for /weights GET request.

Review: https://reviews.apache.org/r/45203/

commit a28f9e5e4180c26cd708cdf6dada3ba24813926d
Author: Yongqiao Wang 
Date:   Sun Apr 10 00:19:43 2016 -0700

Supported querying weight infos via /weights.

Review: https://reviews.apache.org/r/44512/


> Support get non-default weights by /weights
> ---
>
> Key: MESOS-4316
> URL: https://issues.apache.org/jira/browse/MESOS-4316
> Project: Mesos
>  Issue Type: Task
>Reporter: Yongqiao Wang
>Assignee: Yongqiao Wang
>Priority: Minor
>  Labels: mesosphere
> Fix For: 0.29.0
>
>
> Like /quota, we should also add query logic for /weights to keep consistent. 
> Then /roles no longer needs to show weight information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-4316) Support get non-default weights by /weights

[Yongqiao Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208089#comment-15208089
 ] 

Yongqiao Wang commented on MESOS-4316:
--

Append test RR: https://reviews.apache.org/r/45203/

> Support get non-default weights by /weights
> ---
>
> Key: MESOS-4316
> URL: https://issues.apache.org/jira/browse/MESOS-4316
> Project: Mesos
>  Issue Type: Task
>Reporter: Yongqiao Wang
>Assignee: Yongqiao Wang
>Priority: Minor
>  Labels: mesosphere
>
> Like /quota, we should also add query logic for /weights to keep consistent. 
> Then /roles no longer needs to show weight information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-4316) Support get non-default weights by /weights

[Yongqiao Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182668#comment-15182668
 ] 

Yongqiao Wang commented on MESOS-4316:
--

Only add the GET for /weights in the same release as the PUT/POST. We can't 
change what's displayed in /roles without going through a deprecation cycle, 
but we can show the weights in both places for now.

> Support get non-default weights by /weights
> ---
>
> Key: MESOS-4316
> URL: https://issues.apache.org/jira/browse/MESOS-4316
> Project: Mesos
>  Issue Type: Task
>Reporter: Yongqiao Wang
>Assignee: Yongqiao Wang
>Priority: Minor
>
> Like /quota, we should also add query logic for /weights to keep consistent. 
> Then /roles no longer needs to show weight information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)