[ 
https://issues.apache.org/jira/browse/MESOS-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219708#comment-15219708
 ] 

Joerg Schad commented on MESOS-5071:
------------------------------------

We propose to replace the clone option by a namespaces options and allow 
subprocess to choose the right clone behavior internally. This would result in 
the following subprocess interface.

{code}
Try<Subprocess> subprocess(
      const std::string& path,
      std::vector<std::string> argv,
      const Subprocess::IO& in,
      const Subprocess::IO& out,
      const Subprocess::IO& err,
      const Option<flags::FlagsBase>& flags,
      const Option<std::map<std::string, std::string>>& environment,
      const std::vector<Subprocess::Hook>& parent_hooks,
      const std::vector<Subprocess::ChildHook>& child_hooks,
      const Watchdog watchdog,
      const Option<int>& namespaces);
{code}


> Refactor the clone option to subprocess.
> ----------------------------------------
>
>                 Key: MESOS-5071
>                 URL: https://issues.apache.org/jira/browse/MESOS-5071
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Joerg Schad
>            Assignee: Joerg Schad
>
> The clone option in subprocess is only used (at least in the Mesos codebase) 
> to specify custom namespace flags to clone. It feels having the clone 
> function in the subprocess interface is too explicit for this functionality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to