[jira] [Commented] (MESOS-5582) Create a `cgroups/devices` isolator.

2017-09-07 Thread Zhitao Li (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157331#comment-16157331
 ] 

Zhitao Li commented on MESOS-5582:
--

Can this be closed already?

> Create a `cgroups/devices` isolator.
> 
>
> Key: MESOS-5582
> URL: https://issues.apache.org/jira/browse/MESOS-5582
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Kevin Klues
>Assignee: Kevin Klues
>  Labels: gpu, isolator, mesosphere
>
> Currently, all the logic for the `cgroups/devices` isolator is bundled into 
> the Nvidia GPU Isolator. We should abstract it out into it's own component 
> and remove the redundant logic from the Nvidia GPU Isolator. Assuming the 
> guaranteed ordering between isolators from MESOS-5581, we can be sure that 
> the dependency order between the `cgroups/devices` and `gpu/nvidia` isolators 
> is met.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MESOS-5582) Create a `cgroups/devices` isolator.

2016-06-14 Thread Benjamin Mahler (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330504#comment-15330504
 ] 

Benjamin Mahler commented on MESOS-5582:


Fix for a double cgroups::destoy issue that was introduced:

{noformat}
commit e29ce100873f0901a6f4af13db5b25d5524b613f
Author: Kevin Klues 
Date:   Tue Jun 14 13:11:08 2016 -0700

Fixed bug with double destruction of cgroups devices subsystem.

In a previous commit, the `cgroups/devices` isolator was abstracted
out of the Nvidia GPU isolator. However, the code for destroying the
devices susbsystem wasn't removed from the GPU isolator, causing it to
"double destroy" the subsystem upon cleanup. This commit removed this
redundant code.

Review: https://reviews.apache.org/r/48578/
{noformat}

> Create a `cgroups/devices` isolator.
> 
>
> Key: MESOS-5582
> URL: https://issues.apache.org/jira/browse/MESOS-5582
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Kevin Klues
>Assignee: Kevin Klues
>  Labels: gpu, isolator, mesosphere
>
> Currently, all the logic for the `cgroups/devices` isolator is bundled into 
> the Nvidia GPU Isolator. We should abstract it out into it's own component 
> and remove the redundant logic from the Nvidia GPU Isolator. Assuming the 
> guaranteed ordering between isolators from MESOS-5581, we can be sure that 
> the dependency order between the `cgroups/devices` and `gpu/nvidia` isolators 
> is met.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-5582) Create a `cgroups/devices` isolator.

2016-06-09 Thread Benjamin Mahler (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323373#comment-15323373
 ] 

Benjamin Mahler commented on MESOS-5582:


Isolator committed here:

{noformat}
commit 1d60fdafe6abfa29ff147bd5a56efc4968c7d637
Author: Kevin Klues 
Date:   Thu Jun 9 13:41:09 2016 -0700

Created a `cgroups/devices` isolator.

Previously, all the logic for the `cgroups/devices` isolator was
bundled into the Nvidia GPU Isolator. Now we have abstracted it out
into it's own component and removed the redundant logic from the
Nvidia GPU Isolator. Because of the new guaranteed ordering between
isolators, we can be sure that the dependency order between the
`cgroups/devices` and `gpu/nvidia` isolators is met.

Review: https://reviews.apache.org/r/48478/
{noformat}

We'll follow up with tests before closing this.

> Create a `cgroups/devices` isolator.
> 
>
> Key: MESOS-5582
> URL: https://issues.apache.org/jira/browse/MESOS-5582
> Project: Mesos
>  Issue Type: Improvement
>Reporter: Kevin Klues
>Assignee: Kevin Klues
>  Labels: gpu, isolator, mesosphere
>
> Currently, all the logic for the `cgroups/devices` isolator is bundled into 
> the Nvidia GPU Isolator. We should abstract it out into it's own component 
> and remove the redundant logic from the Nvidia GPU Isolator. Assuming the 
> guaranteed ordering between isolators from MESOS-5581, we can be sure that 
> the dependency order between the `cgroups/devices` and `gpu/nvidia` isolators 
> is met.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)