[jira] [Commented] (MESOS-5604) Check for incorrect use of `.then` (as opposed to `.then(defer(self() ))`).

[Jie Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326551#comment-15326551
 ] 

Jie Yu commented on MESOS-5604:
---

commit 9ad4f3fb85892c8a29e08182e1a48dee0e6ada47
Author: Joerg Schad 
Date:   Sun Jun 12 10:28:02 2016 -0700

Fixed continuation logic in docker containerizer.

Previously the continuation followed via \\\`.then(\\\[=\\\]\\\`, which
potentially executes the continuation on a different process. This patch
fixes this behavior (it should run on the same process) and avoids
potential race conditions.

Review: https://reviews.apache.org/r/48599/

> Check for incorrect use of `.then` (as opposed to `.then(defer(self() ))`).
> ---
>
> Key: MESOS-5604
> URL: https://issues.apache.org/jira/browse/MESOS-5604
> Project: Mesos
>  Issue Type: Task
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> We recently experienced a race condition (MESOS-5587) as we used .then() 
> instead of .then(defer(self() ).
> When looking at the code base we found a number of other potentially wrong 
> uses which could cause race conditions. 
> This Jira is supposed to track the investigation effort in this matter.
> Note that this problem does not only apply to .then, but also for example to 
> .onAny(). From looking at the codebase, it just seems we are more disciplined 
> when using .onAny(). Hence we first look at .then().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-5604) Check for incorrect use of `.then` (as opposed to `.then(defer(self() ))`).

[Joerg Schad (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326479#comment-15326479
 ] 

Joerg Schad commented on MESOS-5604:


Fixed continuation logic in docker.cpp.
https://reviews.apache.org/r/48599/

> Check for incorrect use of `.then` (as opposed to `.then(defer(self() ))`).
> ---
>
> Key: MESOS-5604
> URL: https://issues.apache.org/jira/browse/MESOS-5604
> Project: Mesos
>  Issue Type: Task
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> We recently experienced a race condition (MESOS-5587) as we used .then() 
> instead of .then(defer(self() ).
> When looking at the code base we found a number of other potentially wrong 
> uses which could cause race conditions. 
> This Jira is supposed to track the investigation effort in this matter.
> Note that this problem does not only apply to .then, but also for example to 
> .onAny(). From looking at the codebase, it just seems we are more disciplined 
> when using .onAny(). Hence we first look at .then().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-5604) Check for incorrect use of `.then` (as opposed to `.then(defer(self() ))`).

[Joerg Schad (JIRA)]

[ 
https://issues.apache.org/jira/browse/MESOS-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326035#comment-15326035
 ] 

Joerg Schad commented on MESOS-5604:


Started document collecting potential misuses of .then.
Please note this is WIP!

https://docs.google.com/document/d/1jCe-3wAgPMIn-m_OjlNckRVa4LOxHWgr7WHJnuFseeQ

> Check for incorrect use of `.then` (as opposed to `.then(defer(self() ))`).
> ---
>
> Key: MESOS-5604
> URL: https://issues.apache.org/jira/browse/MESOS-5604
> Project: Mesos
>  Issue Type: Task
>Reporter: Joerg Schad
>Assignee: Joerg Schad
>
> We recently experienced a race condition (MESOS-5587) as we used .then() 
> instead of .then(defer(self() ).
> When looking at the code base we found a number of other potentially wrong 
> uses which could cause race conditions. 
> This Jira is supposed to track the investigation effort in this matter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)