[jira] [Commented] (MESOS-6457) Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING.
[ https://issues.apache.org/jira/browse/MESOS-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629426#comment-15629426 ] Gastón Kleiman commented on MESOS-6457: --- I am afraid that {{TASK_LOST}} is not a terminal state. A slave rejoining the cluster after a master failover might make tasks go from {{TASK_LOST}} to {{TASK_RUNNING}}. If I understand Neil correctly, tasks could do the {{TASK_KILLING => TASK_LOST => TASK_RUNNING}} transition only if an executor transitions them while the slave is disconnected from the cluster. > Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING. > - > > Key: MESOS-6457 > URL: https://issues.apache.org/jira/browse/MESOS-6457 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.28.2, 1.0.1 >Reporter: Gastón Kleiman >Assignee: Gastón Kleiman >Priority: Blocker > > A task can currently transition from {{TASK_KILLING}} to {{TASK_RUNNING}}, if > for example it starts/stops passing a health check once it got into the > {{TASK_KILLING}} state. > I think that this behaviour is counterintuitive. It also makes the life of > framework/tools developers harder, since they have to keep track of the > complete task status history in order to know if a task is being killed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6457) Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING.
[ https://issues.apache.org/jira/browse/MESOS-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629376#comment-15629376 ] Alexander Rukletsov commented on MESOS-6457: I though {{TASK_LOST}} is a terminal state, hence the transition is valid. > Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING. > - > > Key: MESOS-6457 > URL: https://issues.apache.org/jira/browse/MESOS-6457 > Project: Mesos > Issue Type: Bug >Affects Versions: 0.28.2, 1.0.1 >Reporter: Gastón Kleiman >Assignee: Gastón Kleiman >Priority: Blocker > > A task can currently transition from {{TASK_KILLING}} to {{TASK_RUNNING}}, if > for example it starts/stops passing a health check once it got into the > {{TASK_KILLING}} state. > I think that this behaviour is counterintuitive. It also makes the life of > framework/tools developers harder, since they have to keep track of the > complete task status history in order to know if a task is being killed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6457) Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING.
[ https://issues.apache.org/jira/browse/MESOS-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626095#comment-15626095 ] Neil Conway commented on MESOS-6457: {{TASK_KILLING}} to {{TASK_LOST}} is definitely possible. {{TASK_KILLING}} => {{TASK_LOST}} => {{TASK_RUNNING}} should be possible if {{TASK_KILLING}} => {{TASK_RUNNING}} is possible (I haven't looked into whether allowing the latter transition is a good idea or not...) > Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING. > - > > Key: MESOS-6457 > URL: https://issues.apache.org/jira/browse/MESOS-6457 > Project: Mesos > Issue Type: Bug >Reporter: Gastón Kleiman >Assignee: Gastón Kleiman >Priority: Blocker > > A task can currently transition from {{TASK_KILLING}} to {{TASK_RUNNING}}, if > for example it starts/stops passing a health check once it got into the > {{TASK_KILLING}} state. > I think that this behaviour is counterintuitive. It also makes the life of > framework/tools developers harder, since they have to keep track of the > complete task status history in order to know if a task is being killed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6457) Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING.
[ https://issues.apache.org/jira/browse/MESOS-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626057#comment-15626057 ] Gastón Kleiman commented on MESOS-6457: --- [~zhitao] yes, this behaviour only affect the default and the command executors. I believe that it is still possible for a task in {{TASK_KILLING}} to transition to {{TASK_LOST}}. Given that {{TASK_LOST}} is not a terminal state, I don't know if it would then be possible for the task to transition to {{TASK_RUNNING}} instead of to {{TASK_KILLING}}/{{TASK_KILLED}}. Maybe [~neilc] knows. > Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING. > - > > Key: MESOS-6457 > URL: https://issues.apache.org/jira/browse/MESOS-6457 > Project: Mesos > Issue Type: Bug >Reporter: Gastón Kleiman >Assignee: Gastón Kleiman >Priority: Blocker > > A task can currently transition from {{TASK_KILLING}} to {{TASK_RUNNING}}, if > for example it starts/stops passing a health check once it got into the > {{TASK_KILLING}} state. > I think that this behaviour is counterintuitive. It also makes the life of > framework/tools developers harder, since they have to keep track of the > complete task status history in order to know if a task is being killed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6457) Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING.
[ https://issues.apache.org/jira/browse/MESOS-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622713#comment-15622713 ] Zhitao Li commented on MESOS-6457: -- Is this behavior only possible when framework opt-in to use Mesos's own health check (aka custom executors which do not use Mesos health check should not affected)? > Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING. > - > > Key: MESOS-6457 > URL: https://issues.apache.org/jira/browse/MESOS-6457 > Project: Mesos > Issue Type: Bug >Reporter: Gastón Kleiman >Assignee: Gastón Kleiman >Priority: Blocker > > A task can currently transition from {{TASK_KILLING}} to {{TASK_RUNNING}}, if > for example it starts/stops passing a health check once it got into the > {{TASK_KILLING}} state. > I think that this behaviour is counterintuitive. It also makes the life of > framework/tools developers harder, since they have to keep track of the > complete task status history in order to know if a task is being killed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-6457) Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING
[ https://issues.apache.org/jira/browse/MESOS-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601353#comment-15601353 ] Gastón Kleiman commented on MESOS-6457: --- cc/ [~alexr] [~bmahler] > Tasks shouldn't transition from TASK_KILLING to TASK_RUNNING > > > Key: MESOS-6457 > URL: https://issues.apache.org/jira/browse/MESOS-6457 > Project: Mesos > Issue Type: Bug >Reporter: Gastón Kleiman > > A task can currently transition from {{TASK_KILLING}} to {{TASK_RUNNING}}, if > for example it starts/stops passing a health check once it got into the > {{TASK_KILLING}} state. > I think that this behaviour is counterintuitive. It also makes the life of > framework/tools developers harder, since they have to keep track of the > complete task status history in order to know if a task is being killed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)