[jira] [Commented] (MESOS-6815) Enable glog stack traces when we call things like `ABORT` on Windows
[ https://issues.apache.org/jira/browse/MESOS-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924963#comment-15924963 ] Andrew Schwartzmeyer commented on MESOS-6815: - NOTE: The currently applied patches explicitly don't install the `SIGABRT` handler for Windows. This can be done at any time in a separate commit, if we want them. The patches enable stack tracing for uses of `LOG_FATAL` in tests. > Enable glog stack traces when we call things like `ABORT` on Windows > > > Key: MESOS-6815 > URL: https://issues.apache.org/jira/browse/MESOS-6815 > Project: Mesos > Issue Type: Bug > Components: stout >Reporter: Alex Clemmer >Assignee: Andrew Schwartzmeyer >Priority: Critical > Labels: mesosphere, microsoft, windows-mvp > Fix For: 1.3.0 > > > Currently in the Windows builds, if we call `ABORT` (etc.) we will simply > bail out, with no stack traces. > This is highly undesirable. Stack traces are important for operating clusters > in production. We should work to enable this behavior, including possibly > working with glog to add this support if they currently they do not natively > support it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MESOS-6815) Enable glog stack traces when we call things like `ABORT` on Windows
[ https://issues.apache.org/jira/browse/MESOS-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904254#comment-15904254 ] Andrew Schwartzmeyer commented on MESOS-6815: - Patch series adding patches to CMake build on Windows: https://reviews.apache.org/r/57491/ and https://reviews.apache.org/r/57490/. > Enable glog stack traces when we call things like `ABORT` on Windows > > > Key: MESOS-6815 > URL: https://issues.apache.org/jira/browse/MESOS-6815 > Project: Mesos > Issue Type: Bug > Components: stout >Reporter: Alex Clemmer >Assignee: Andrew Schwartzmeyer >Priority: Critical > Labels: microsoft, windows-mvp > > Currently in the Windows builds, if we call `ABORT` (etc.) we will simply > bail out, with no stack traces. > This is highly undesirable. Stack traces are important for operating clusters > in production. We should work to enable this behavior, including possibly > working with glog to add this support if they currently they do not natively > support it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MESOS-6815) Enable glog stack traces when we call things like `ABORT` on Windows
[ https://issues.apache.org/jira/browse/MESOS-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904253#comment-15904253 ] Andrew Schwartzmeyer commented on MESOS-6815: - PR updating Glog tarball: https://github.com/3rdparty/mesos-3rdparty/pull/10 > Enable glog stack traces when we call things like `ABORT` on Windows > > > Key: MESOS-6815 > URL: https://issues.apache.org/jira/browse/MESOS-6815 > Project: Mesos > Issue Type: Bug > Components: stout >Reporter: Alex Clemmer >Assignee: Andrew Schwartzmeyer >Priority: Critical > Labels: microsoft, windows-mvp > > Currently in the Windows builds, if we call `ABORT` (etc.) we will simply > bail out, with no stack traces. > This is highly undesirable. Stack traces are important for operating clusters > in production. We should work to enable this behavior, including possibly > working with glog to add this support if they currently they do not natively > support it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MESOS-6815) Enable glog stack traces when we call things like `ABORT` on Windows
[ https://issues.apache.org/jira/browse/MESOS-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904251#comment-15904251 ] Andrew Schwartzmeyer commented on MESOS-6815: - Please see updated PR https://github.com/google/glog/pull/168. I'm most unhappy with the amount of frames to skip when generating a stack trace, as I can't seem to reliably remove the Google log functions. Perhaps we should set it to skip none? > Enable glog stack traces when we call things like `ABORT` on Windows > > > Key: MESOS-6815 > URL: https://issues.apache.org/jira/browse/MESOS-6815 > Project: Mesos > Issue Type: Bug > Components: stout >Reporter: Alex Clemmer >Assignee: Andrew Schwartzmeyer >Priority: Critical > Labels: microsoft, windows-mvp > > Currently in the Windows builds, if we call `ABORT` (etc.) we will simply > bail out, with no stack traces. > This is highly undesirable. Stack traces are important for operating clusters > in production. We should work to enable this behavior, including possibly > working with glog to add this support if they currently they do not natively > support it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MESOS-6815) Enable glog stack traces when we call things like `ABORT` on Windows
[ https://issues.apache.org/jira/browse/MESOS-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904250#comment-15904250 ] Andrew Schwartzmeyer commented on MESOS-6815: - Unpaused, patches available. > Enable glog stack traces when we call things like `ABORT` on Windows > > > Key: MESOS-6815 > URL: https://issues.apache.org/jira/browse/MESOS-6815 > Project: Mesos > Issue Type: Bug > Components: stout >Reporter: Alex Clemmer >Assignee: Andrew Schwartzmeyer >Priority: Critical > Labels: microsoft, windows-mvp > > Currently in the Windows builds, if we call `ABORT` (etc.) we will simply > bail out, with no stack traces. > This is highly undesirable. Stack traces are important for operating clusters > in production. We should work to enable this behavior, including possibly > working with glog to add this support if they currently they do not natively > support it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MESOS-6815) Enable glog stack traces when we call things like `ABORT` on Windows
[ https://issues.apache.org/jira/browse/MESOS-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838849#comment-15838849 ] Andrew Schwartzmeyer commented on MESOS-6815: - Work in progress is here: https://github.com/andschwa/glog/tree/test, with an open but unfinished pull request here: https://github.com/google/glog/pull/151. This is currently paused. The status is that stack tracing works, but relying on a signal handler to report the stack trace does not provide the desired behavior. On Linux, the stack trace is reported from the thread that the signal was called; but it seems on Windows that the stack trace is reported from the thread on which the signal handler was installed, regardless of the thread from which it was called. I believe the correct approach is to slightly change how Glog reports stack tracing (at least for Windows) to not rely on signal handlers. > Enable glog stack traces when we call things like `ABORT` on Windows > > > Key: MESOS-6815 > URL: https://issues.apache.org/jira/browse/MESOS-6815 > Project: Mesos > Issue Type: Bug > Components: stout >Reporter: Alex Clemmer >Assignee: Andrew Schwartzmeyer >Priority: Critical > Labels: microsoft, windows-mvp > > Currently in the Windows builds, if we call `ABORT` (etc.) we will simply > bail out, with no stack traces. > This is highly undesirable. Stack traces are important for operating clusters > in production. We should work to enable this behavior, including possibly > working with glog to add this support if they currently they do not natively > support it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
