[jira] [Commented] (MESOS-8301) Support moving into defer/dispatch/install handlers.
[
https://issues.apache.org/jira/browse/MESOS-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279346#comment-16279346
]
Michael Park commented on MESOS-8301:
-
{noformat}
commit 8014e3f9e1838745a6f3af7c1e2a557bd74349b0
Author: Dmitry Zhuk
Date: Tue Dec 5 11:20:55 2017 -0800
Added `CallableOnce` support in `Future`.
`Future` guarantees that callbacks are called at most once, so it can
use `lambda::CallableOnce` to expicitly declare this, and allow
corresponding optimizations with moves.
Review: https://reviews.apache.org/r/63638/
{noformat}
{noformat}
commit 09b72e9bbf87793ce84df5d5f9d5f292c60fa5ee
Author: Dmitry Zhuk
Date: Tue Dec 5 11:20:41 2017 -0800
Added `CallableOnce` support in `defer`.
This allows `defer` result to be converted to `CallableOnce`, ensuring
that bound arguments are moved, when call is made, and avoiding making
copies of bound arguments.
Review: https://reviews.apache.org/r/63637/
{noformat}
> Support moving into defer/dispatch/install handlers.
>
>
> Key: MESOS-8301
> URL: https://issues.apache.org/jira/browse/MESOS-8301
> Project: Mesos
> Issue Type: Improvement
> Components: libprocess
>Reporter: Benjamin Mahler
>Assignee: Dmitry Zhuk
>
> Currently, dispatch and defer will take copies of the provided arguments.
> Also, a protobuf message handler cannot move the supplied message. We should
> support moves for these for efficiency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-8301) Support moving into defer/dispatch/install handlers.
[
https://issues.apache.org/jira/browse/MESOS-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279347#comment-16279347
]
Michael Park commented on MESOS-8301:
-
{noformat}
commit bbd8381ebce3522841e80ae53f56b3049342f15b
Author: Dmitry Zhuk
Date: Tue Dec 5 13:47:53 2017 -0800
Replaced `std::shared_ptr` with `std::unique_ptr` in `Future`.
Review: https://reviews.apache.org/r/63913/
{noformat}
{noformat}
commit bca8c6a05d03a2162c04703a9c1ac8172fdfae8a
Author: Dmitry Zhuk
Date: Tue Dec 5 13:45:56 2017 -0800
Replaced `std::shared_ptr` with `std::unique_ptr` in `dispatch`.
Since `dispatch` can now handle move-only parameters, `Promise` and
function object can be wrapped into `std::unique_ptr` for efficiency.
{noformat}
> Support moving into defer/dispatch/install handlers.
>
>
> Key: MESOS-8301
> URL: https://issues.apache.org/jira/browse/MESOS-8301
> Project: Mesos
> Issue Type: Improvement
> Components: libprocess
>Reporter: Benjamin Mahler
>Assignee: Dmitry Zhuk
>
> Currently, dispatch and defer will take copies of the provided arguments.
> Also, a protobuf message handler cannot move the supplied message. We should
> support moves for these for efficiency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-8301) Support moving into defer/dispatch/install handlers.
[
https://issues.apache.org/jira/browse/MESOS-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279344#comment-16279344
]
Michael Park commented on MESOS-8301:
-
{noformat}
commit 13eda27802cfe05800d4dcbed22c46ca7b46bafb
Author: Dmitry Zhuk
Date: Tue Dec 5 10:40:37 2017 -0800
Prepared `defer` for use in callable-once contexts.
This changes `defer` to use `lambda::partial` instead of `std::bind`,
which allows it be used in callable-once contexts.
Review: https://reviews.apache.org/r/63635/
{noformat}
{noformat}
commit 0d9ce98e9df97be06144d2e29cf23a9c090a06b3
Author: Dmitry Zhuk
Date: Tue Dec 5 10:39:47 2017 -0800
Changed dispatch to use callable once functors.
`dispatch` guarantees that functor will be called at most once, and
therefore it allows optimizations, such as moves of deferred objects.
Review: https://reviews.apache.org/r/63634/
{noformat}
> Support moving into defer/dispatch/install handlers.
>
>
> Key: MESOS-8301
> URL: https://issues.apache.org/jira/browse/MESOS-8301
> Project: Mesos
> Issue Type: Improvement
> Components: libprocess
>Reporter: Benjamin Mahler
>Assignee: Dmitry Zhuk
>
> Currently, dispatch and defer will take copies of the provided arguments.
> Also, a protobuf message handler cannot move the supplied message. We should
> support moves for these for efficiency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-8301) Support moving into defer/dispatch/install handlers.
[
https://issues.apache.org/jira/browse/MESOS-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279337#comment-16279337
]
Michael Park commented on MESOS-8301:
-
{noformat}
commit ececa115966067551e00098f973f0104a0782730
Author: Michael Park
Date: Tue Dec 5 09:57:51 2017 -0800
Removed `constexpr`-ness from `cpp17::invoke`.
`std::invoke` is not marked `constexpr`.
Review: https://reviews.apache.org/r/64332/
{noformat}
{noformat}
commit 59329cbc605d578572e90db62070b2bb99fdbb9c
Author: Michael Park
Date: Tue Dec 5 09:57:40 2017 -0800
Added more `cpp17::invoke` test cases.
Review: https://reviews.apache.org/r/64331/
{noformat}
> Support moving into defer/dispatch/install handlers.
>
>
> Key: MESOS-8301
> URL: https://issues.apache.org/jira/browse/MESOS-8301
> Project: Mesos
> Issue Type: Improvement
> Components: libprocess
>Reporter: Benjamin Mahler
>Assignee: Dmitry Zhuk
>
> Currently, dispatch and defer will take copies of the provided arguments.
> Also, a protobuf message handler cannot move the supplied message. We should
> support moves for these for efficiency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-8301) Support moving into defer/dispatch/install handlers.
[
https://issues.apache.org/jira/browse/MESOS-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279336#comment-16279336
]
Michael Park commented on MESOS-8301:
-
{noformat}
commit 8670d2e9224485b94a40654d4a2102d8340fe4ac
Author: Michael Park
Date: Mon Dec 4 17:25:36 2017 -0800
Added `lambda::partial` to .
Review: https://reviews.apache.org/r/64274/
{noformat}
{noformat}
commit 3b9db404cb0b50edef1958423b26364e63ccaa27
Author: Michael Park
Date: Mon Dec 4 17:25:33 2017 -0800
Added `cpp17::invoke` in .
Review: https://reviews.apache.org/r/64248/
{noformat}
> Support moving into defer/dispatch/install handlers.
>
>
> Key: MESOS-8301
> URL: https://issues.apache.org/jira/browse/MESOS-8301
> Project: Mesos
> Issue Type: Improvement
> Components: libprocess
>Reporter: Benjamin Mahler
>Assignee: Dmitry Zhuk
>
> Currently, dispatch and defer will take copies of the provided arguments.
> Also, a protobuf message handler cannot move the supplied message. We should
> support moves for these for efficiency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MESOS-8301) Support moving into defer/dispatch/install handlers.
[
https://issues.apache.org/jira/browse/MESOS-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279325#comment-16279325
]
Benjamin Mahler commented on MESOS-8301:
{{install}} support:
{noformat}
commit 8cd1bd2fcb8a4d2330a781a86b62e55ada6d4984
Author: Dmitry Zhuk
Date: Wed Nov 15 14:19:39 2017 -0800
Enabled rvalue reference parameters in protobuf handlers.
Using rvalue reference parameter in protobuf handler opts-out of arena
usage, and allows the handler to move the message.
Review: https://reviews.apache.org/r/63639/
{noformat}
> Support moving into defer/dispatch/install handlers.
>
>
> Key: MESOS-8301
> URL: https://issues.apache.org/jira/browse/MESOS-8301
> Project: Mesos
> Issue Type: Improvement
> Components: libprocess
>Reporter: Benjamin Mahler
>Assignee: Dmitry Zhuk
>
> Currently, dispatch and defer will take copies of the provided arguments.
> Also, a protobuf message handler cannot move the supplied message. We should
> support moves for these for efficiency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
