[jira] [Commented] (MESOS-8916) Allocation logic cleanup.
[ https://issues.apache.org/jira/browse/MESOS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565483#comment-16565483 ] Vinod Kone commented on MESOS-8916: --- commit f0284a51d188d32522c460c7e276ea80316eabd9 Author: Meng Zhu [m...@mesosphere.io|mailto:m...@mesosphere.io]Date: Thu Jun 21 09:09:39 2018 -0700 Modified `createStrippedScalarQuantity()` to clear all metadata fields. Currently `createStrippedScalarQuantity()` strips resource meta-data and transforms dynamic reservations into a static reservation. However, no current code depends on the reservations in resources returned by this helper function. This leads to boilerplate code around call sites and performance overhead. This patch updates the function to clear all reservation information. Review: https://reviews.apache.org/r/67615/ > Allocation logic cleanup. > - > > Key: MESOS-8916 > URL: https://issues.apache.org/jira/browse/MESOS-8916 > Project: Mesos > Issue Type: Epic > Components: allocation >Reporter: Benjamin Mahler >Assignee: Meng Zhu >Priority: Major > Labels: mesosphere > Fix For: 1.7.0 > > > The allocation logic has grown organically and is now very hard to read and > maintain. This epic will track cleanups to improve the readability of the > core allocation logic: > * Add a function for returning the subset of frameworks that are capable of > receiving offers from the agent. This moves the capability checking out of > the core allocation logic and means the loops can just iterate over a smaller > set of framework candidates rather than having to write 'continue' cases. > This covers the GPU_RESOURCES and REGION_AWARE capabilities. > * Similarly, add a function that allows framework capability based filtering > of resources. This pulls out the filtering logic from the core allocation > logic and instead the core allocation logic can just all out to the > capability filtering function. This covers the SHARED_RESOURCES, > REVOCABLE_RESOURCES and RESERVATION_REFINEMENT capabilities. Note that in > order to implement this one, we must refactor the shared resources logic in > order to have the resource generation occur regardless of the framework > capability (followed by getting filtered out via this new function if the > framework is not capable). > * Update the scalar quantity related functions to also strip static > reservation metadata. Currently there is extra code in the allocator across > many places (including the allocation logic) to perform this in the > call-sites. > * Track across allocation cycles or pull out the following into functions: > quantity of quota that is currently "charged" to a role, amount of "headroom" > that is needed/available for unsatisfied quota guarantees. > * Pull out the resource shrinking function. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MESOS-8916) Allocation logic cleanup.
[ https://issues.apache.org/jira/browse/MESOS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532115#comment-16532115 ] Meng Zhu commented on MESOS-8916: - Update the scalar quantity related functions to also strip static reservation metadata. Currently there is extra code in the allocator across many places (including the allocation logic) to perform this in the call-sites. https://reviews.apache.org/r/67615/ > Allocation logic cleanup. > - > > Key: MESOS-8916 > URL: https://issues.apache.org/jira/browse/MESOS-8916 > Project: Mesos > Issue Type: Epic > Components: allocation >Reporter: Benjamin Mahler >Assignee: Meng Zhu >Priority: Major > > The allocation logic has grown organically and is now very hard to read and > maintain. This epic will track cleanups to improve the readability of the > core allocation logic: > * Add a function for returning the subset of frameworks that are capable of > receiving offers from the agent. This moves the capability checking out of > the core allocation logic and means the loops can just iterate over a smaller > set of framework candidates rather than having to write 'continue' cases. > This covers the GPU_RESOURCES and REGION_AWARE capabilities. > * Similarly, add a function that allows framework capability based filtering > of resources. This pulls out the filtering logic from the core allocation > logic and instead the core allocation logic can just all out to the > capability filtering function. This covers the SHARED_RESOURCES, > REVOCABLE_RESOURCES and RESERVATION_REFINEMENT capabilities. Note that in > order to implement this one, we must refactor the shared resources logic in > order to have the resource generation occur regardless of the framework > capability (followed by getting filtered out via this new function if the > framework is not capable). > * Update the scalar quantity related functions to also strip static > reservation metadata. Currently there is extra code in the allocator across > many places (including the allocation logic) to perform this in the > call-sites. > * Track across allocation cycles or pull out the following into functions: > quantity of quota that is currently "charged" to a role, amount of "headroom" > that is needed/available for unsatisfied quota guarantees. > * Pull out the resource shrinking function. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MESOS-8916) Allocation logic cleanup.
[ https://issues.apache.org/jira/browse/MESOS-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532114#comment-16532114 ] Meng Zhu commented on MESOS-8916: - Similarly, add a function that allows framework capability based filtering of resources. This pulls out the filtering logic from the core allocation logic and instead the core allocation logic can just all out to the capability filtering function. This covers the SHARED_RESOURCES, REVOCABLE_RESOURCES and RESERVATION_REFINEMENT capabilities. Note that in order to implement this one, we must refactor the shared resources logic in order to have the resource generation occur regardless of the framework capability (followed by getting filtered out via this new function if the framework is not capable). https://reviews.apache.org/r/67827/ > Allocation logic cleanup. > - > > Key: MESOS-8916 > URL: https://issues.apache.org/jira/browse/MESOS-8916 > Project: Mesos > Issue Type: Epic > Components: allocation >Reporter: Benjamin Mahler >Assignee: Meng Zhu >Priority: Major > > The allocation logic has grown organically and is now very hard to read and > maintain. This epic will track cleanups to improve the readability of the > core allocation logic: > * Add a function for returning the subset of frameworks that are capable of > receiving offers from the agent. This moves the capability checking out of > the core allocation logic and means the loops can just iterate over a smaller > set of framework candidates rather than having to write 'continue' cases. > This covers the GPU_RESOURCES and REGION_AWARE capabilities. > * Similarly, add a function that allows framework capability based filtering > of resources. This pulls out the filtering logic from the core allocation > logic and instead the core allocation logic can just all out to the > capability filtering function. This covers the SHARED_RESOURCES, > REVOCABLE_RESOURCES and RESERVATION_REFINEMENT capabilities. Note that in > order to implement this one, we must refactor the shared resources logic in > order to have the resource generation occur regardless of the framework > capability (followed by getting filtered out via this new function if the > framework is not capable). > * Update the scalar quantity related functions to also strip static > reservation metadata. Currently there is extra code in the allocator across > many places (including the allocation logic) to perform this in the > call-sites. > * Track across allocation cycles or pull out the following into functions: > quantity of quota that is currently "charged" to a role, amount of "headroom" > that is needed/available for unsatisfied quota guarantees. > * Pull out the resource shrinking function. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
