Joerg Schad created MESOS-3879:
----------------------------------
Summary: Incorrect and inconsistent include order for
<gmock/gmock.h> and <gtest/gtest.h>.
Key: MESOS-3879
URL: https://issues.apache.org/jira/browse/MESOS-3879
Project: Mesos
Issue Type: Bug
Reporter: Joerg Schad
Assignee: Joerg Schad
Priority: Minor
We currently have an inconsistent (and mostly incorrect) include order for
<gmock/gmock.h> and <gtest/gtest.h> (see below). Some files include them
(incorrectly) between the c and cpp standard header, while other correclt
include them afterwards. According to the [Google Styleguide|
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes]
the second include order is correct.
{code:title=external_containerizer_test.cpp}
#include <unistd.h>
#include <gmock/gmock.h>
#include <string>
{code}
{code:title=launcher.hpp}
#include <vector>
#include <gmock/gmock.h>
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
