[jira] [Commented] (METRON-975) Normalize logging and switch to common idiom with SLF4J
[ https://issues.apache.org/jira/browse/METRON-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107939#comment-16107939 ] ASF GitHub Bot commented on METRON-975: --- Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/599 +1 (non-binding) the sooner we get this in the better. It has performance benefits, and the longer we wait the more work and trouble it will create. No reason not to get it done, lots to get it in. > Normalize logging and switch to common idiom with SLF4J > --- > > Key: METRON-975 > URL: https://issues.apache.org/jira/browse/METRON-975 > Project: Metron > Issue Type: Improvement >Reporter: Michael Miklavcic >Assignee: Michael Miklavcic > > We currently have a mixture of logging approaches scattered throughout the > codebase. Log4j, slf4j, and commons logging. In addition, there are some > deprecated idioms being used to declare loggers (post-jdk 7) and format > strings within the logging statements. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-975) Normalize logging and switch to common idiom with SLF4J
[ https://issues.apache.org/jira/browse/METRON-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107937#comment-16107937 ] ASF GitHub Bot commented on METRON-975: --- Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/599 Any comments on this? I've been merging/resolving conflicts with master as they come in. > Normalize logging and switch to common idiom with SLF4J > --- > > Key: METRON-975 > URL: https://issues.apache.org/jira/browse/METRON-975 > Project: Metron > Issue Type: Improvement >Reporter: Michael Miklavcic >Assignee: Michael Miklavcic > > We currently have a mixture of logging approaches scattered throughout the > codebase. Log4j, slf4j, and commons logging. In addition, there are some > deprecated idioms being used to declare loggers (post-jdk 7) and format > strings within the logging statements. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-746) Build Custom Checkstyle and IDE formatting settings
[ https://issues.apache.org/jira/browse/METRON-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107806#comment-16107806 ] ASF GitHub Bot commented on METRON-746: --- Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/577 > Build Custom Checkstyle and IDE formatting settings > --- > > Key: METRON-746 > URL: https://issues.apache.org/jira/browse/METRON-746 > Project: Metron > Issue Type: Improvement >Reporter: Justin Leet >Assignee: Justin Leet >Priority: Minor > > We need a custom checkstyle.xml based off the sun convention checkstyle. > Based on a discussion thread, there are a few things that need to be setup > * Two space indents > * Line Length longer than 80 (pretty popular in the discussion, but not > officially part of our code style) > * Appropriate warn/error levels set so we don't immediately start failing > every build. > * Importable IntelliJ code style at minimum, but I'd also like to see Eclipse > if possible to avoid forcing a given dev environment. IntelliJ allows for > importing a checkstyle.xml to use as the basis. We can export the resulting > formatting settings for people. > * Ensure Travis actually runs checkstyle during our builds -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-746) Build Custom Checkstyle and IDE formatting settings
[ https://issues.apache.org/jira/browse/METRON-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107583#comment-16107583 ] ASF GitHub Bot commented on METRON-746: --- Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/577 +1. I get why we didn't include the code formatting rules in the source tree like the checkstyle.xml (covers more than 1 IDE). But we should link to the setup instructions in our dev guide somewhere. > Build Custom Checkstyle and IDE formatting settings > --- > > Key: METRON-746 > URL: https://issues.apache.org/jira/browse/METRON-746 > Project: Metron > Issue Type: Improvement >Reporter: Justin Leet >Assignee: Justin Leet >Priority: Minor > > We need a custom checkstyle.xml based off the sun convention checkstyle. > Based on a discussion thread, there are a few things that need to be setup > * Two space indents > * Line Length longer than 80 (pretty popular in the discussion, but not > officially part of our code style) > * Appropriate warn/error levels set so we don't immediately start failing > every build. > * Importable IntelliJ code style at minimum, but I'd also like to see Eclipse > if possible to avoid forcing a given dev environment. IntelliJ allows for > importing a checkstyle.xml to use as the basis. We can export the resulting > formatting settings for people. > * Ensure Travis actually runs checkstyle during our builds -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-1060) Add performance timing logging to enrichment topology
[ https://issues.apache.org/jira/browse/METRON-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107430#comment-16107430 ] ASF GitHub Bot commented on METRON-1060: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/665 > Add performance timing logging to enrichment topology > - > > Key: METRON-1060 > URL: https://issues.apache.org/jira/browse/METRON-1060 > Project: Metron > Issue Type: Improvement >Reporter: Michael Miklavcic >Assignee: Michael Miklavcic > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-681) CSVConverter should trim values
[
https://issues.apache.org/jira/browse/METRON-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107268#comment-16107268
]
ASF GitHub Bot commented on METRON-681:
---
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/674#discussion_r130342209
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/csv/CSVParserTest.java
---
@@ -87,15 +87,15 @@ public void test() throws IOException {
Assert.assertEquals("grok", o.get("col3"));
}
{
- String line = "foo, bar, grok";
+ String line = " foo , bar , grok ";
--- End diff --
This should really be implemented as a separate test function (additional)
since we're adding functionality here. you can definitely use the same form,
but we're testing a different unit of functionality.
> CSVConverter should trim values
> ---
>
> Key: METRON-681
> URL: https://issues.apache.org/jira/browse/METRON-681
> Project: Metron
> Issue Type: Improvement
>Affects Versions: 0.3.0
>Reporter: Bas van de Lustgraaf
>Priority: Minor
> Labels: newbie
>
> Using the CSVParser, there is no option to trim the values.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (METRON-681) CSVConverter should trim values
[ https://issues.apache.org/jira/browse/METRON-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107261#comment-16107261 ] ASF GitHub Bot commented on METRON-681: --- Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/674 Yes. Does X with incoming .. trims all values > CSVConverter should trim values > --- > > Key: METRON-681 > URL: https://issues.apache.org/jira/browse/METRON-681 > Project: Metron > Issue Type: Improvement >Affects Versions: 0.3.0 >Reporter: Bas van de Lustgraaf >Priority: Minor > Labels: newbie > > Using the CSVParser, there is no option to trim the values. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (METRON-271) Add graph DB to the platform
[ https://issues.apache.org/jira/browse/METRON-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Fowler reassigned METRON-271: -- Assignee: Otto Fowler (was: Nick Allen) > Add graph DB to the platform > > > Key: METRON-271 > URL: https://issues.apache.org/jira/browse/METRON-271 > Project: Metron > Issue Type: New Feature >Reporter: James Sirota >Assignee: Otto Fowler > Labels: 0.2.2BETA, METRON_ML > > I propose adding a graph database (Titan or others) so we can use graph > mining as feature inputs to some of our models and anomaly detectors -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-681) CSVConverter should trim values
[ https://issues.apache.org/jira/browse/METRON-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107055#comment-16107055 ] ASF GitHub Bot commented on METRON-681: --- Github user basvdl commented on the issue: https://github.com/apache/metron/pull/674 @ottobackwards you mean something like https://github.com/apache/metron/blob/master/metron-platform/metron-common/src/main/java/org/apache/metron/common/writer/BulkMessageWriter.java#L34 > CSVConverter should trim values > --- > > Key: METRON-681 > URL: https://issues.apache.org/jira/browse/METRON-681 > Project: Metron > Issue Type: Improvement >Affects Versions: 0.3.0 >Reporter: Bas van de Lustgraaf >Priority: Minor > Labels: newbie > > Using the CSVParser, there is no option to trim the values. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
