[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548151163 Updated this to include a new `Upgrade_steps.md" readme. This should provide more context on how/where to run this script. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc edited a comment on issue #1546: METRON-2239 Metron Automated backup and restore
mmiklavc edited a comment on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548151163 Updated this to include a new `Upgrade_steps.md` readme. This should provide more context on how/where to run this script. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (METRON-2306) [UI] Grok parsers' timestamp field should be hidden if not new
[ https://issues.apache.org/jira/browse/METRON-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Ardell updated METRON-2306: - Summary: [UI] Grok parsers' timestamp field should be hidden if not new (was: [UI] Grok parsers' timestamp field should be hidden) > [UI] Grok parsers' timestamp field should be hidden if not new > -- > > Key: METRON-2306 > URL: https://issues.apache.org/jira/browse/METRON-2306 > Project: Metron > Issue Type: Bug >Reporter: Shane Ardell >Priority: Major > Attachments: Screen Shot 2019-10-30 at 4.41.14 PM.png, Screen Shot > 2019-10-30 at 4.41.21 PM.png > > > Right now, existing Grok parsers in the UI have two timestamp name fields. > One is a field is used to force a user to add a name in the case of creating > a grok parser, and the other allows the user to edit the existing name (or > delete it altogether!). See the attached image for reference. > A simple fix would be to hide the first mentioned instance if the parser > isn't new. We also might want to remove the capability to delete the > timestampField in the second instance since that's a required field for Grok > parsers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [metron] mmiklavc commented on issue #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1
mmiklavc commented on issue #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551#issuecomment-548127114 This is labeled "METRON-2232", but is this actually "METRON-2223"? It's not syncing with Jira currently. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (METRON-2306) [UI] Grok parsers' timestamp field should be hidden
Shane Ardell created METRON-2306: Summary: [UI] Grok parsers' timestamp field should be hidden Key: METRON-2306 URL: https://issues.apache.org/jira/browse/METRON-2306 Project: Metron Issue Type: Bug Reporter: Shane Ardell Attachments: Screen Shot 2019-10-30 at 4.41.14 PM.png, Screen Shot 2019-10-30 at 4.41.21 PM.png Right now, existing Grok parsers in the UI have two timestamp name fields. One is a field is used to force a user to add a name in the case of creating a grok parser, and the other allows the user to edit the existing name (or delete it altogether!). See the attached image for reference. A simple fix would be to hide the first mentioned instance if the parser isn't new. We also might want to remove the capability to delete the timestampField in the second instance since that's a required field for Grok parsers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [metron] sardell edited a comment on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI
sardell edited a comment on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-548101122 I just tested this and I noticed that after I make and save a few searches where I edit the timestamp out of the search, it will be added back into the saved search.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] sardell commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI
sardell commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-548101122 I just tested this and I noticed that after I make and save a few searches where I edit the timestamp out of the search, it will be added back into the saved search. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1546: METRON-2239 Metron Automated backup and restore
nickwallen commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548060674 > @ottobackwards: what would be the steps for a current user to use this to prepare for the next big upgrade? We will definitely need some notes on upgrading; I agree with @ottobackwards there. > @mmiklavc: WRT added instructions for the upgrade, I've debated where these belong I think we should handle any upgrading notes in our existing `Upgrading.md` document and do that work as a separate PR. I think the README changes included in this PR sufficiently covers how to use the script itself. The expectation being that a user would have to pull down this script from master into their legacy environment to upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen opened a new pull request #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1
nickwallen opened a new pull request #1551: METRON-2232 Reconcile Versions in Root POM with HDP 3.1 URL: https://github.com/apache/metron/pull/1551 This change includes a few clean-up items that are needed prior to the `feature/METRON-2088-support-hdp-3.1` feature branch being merged into master. I validated each of the component versions that we are building against to ensure they match against [HDP-3.1](https://docs.cloudera.com/HDPDocuments/HDP3/HDP-3.1.0/release-notes/content/comp_versions.html). Each of these changes are included in separate commits to make review a bit simpler. These include. * Removed the legacy `HDP-2.5.0.0` profile from the root POM. * Changed the Spark dependency from 2.3.1 to 2.3.2 to match HDP-3.1 * Removed a `storm-kafka` dependency from the root POM that was never needed. * Moved all properties defining versions of core platform components to the `HDP-3.1` profile. * Reorganized existing version properties into separate sections for (1) build dependencies (2) test dependencies and (3) build tooling * Removed unused properties. * Pulled out some of the build tooling versions into properties to match what we had done in other places. I validated this by comparing the version numbers output by `mvn dependency:tree` from before and after the change. The only version changes introduced by this PR involve the Spark change. This in addition to the basic acceptance testing were used to validate the change. I'd be happy to break any of these changes out into separate PRs should a reviewer think that is needed. ## Acceptance Testing This PR should be tested using the centos7 development environment. 1. Start up the centos7 dev environment. ``` cd metron-deployment/development/centos7 vagrant destroy -f vagrant up ``` ### Basic Indexing and Enrichment Ensure that we can continue to parse, enrich, and index telemetry. Verify data is flowing through the system, from parsing to indexing 1. Open Ambari and navigate to the Metron service http://node1:8080/#/main/services/METRON/summary 1. Open the Alerts UI. Verify alerts show up in the main UI - click the search icon (you may need to wait a moment for them to appear) 1. Go to the Alerts UI and ensure that an ever increasing number of telemetry from Bro, Snort, and YAF are visible by watching the total alert count increase over time. 1. Ensure that geoip enrichment is occurring. The telemetry should contain fields like `enrichments:geo:ip_src_addr:location_point`. 1. Head back to Ambari and select the Kibana service http://node1:8080/#/main/services/KIBANA/summary 1. Open the Kibana dashboard via the "Metron UI" option in the quick links 1. Verify the dashboard is populating ## Pull Request Checklist - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact
[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore
mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-548057601 @ottobackwards - I ran shellcheck and modified some exit codes. Other than that, it's warnings about shell expansion on variables, which we also have all over in other scripts. I think it should be good to go from that perspective. WRT added instructions for the upgrade, I've debated where these belong. With the ES upgrade we placed instructions right in the module - https://github.com/apache/metron/blob/b9a130ca96774add38865d3934ed61ca19599b87/metron-platform/metron-elasticsearch/metron-elasticsearch-common/README.md#upgrading-from-233-to-56. We have an existing `Upgrading` document - https://github.com/apache/metron/blob/b9a130ca96774add38865d3934ed61ca19599b87/Upgrading.md, however this is primarily some line items with pointers to other details. What do you think about adding a new README in the project root named something like`Upgrade_steps.md`? In master, we'd start with the existing backup/restore process outline. For the HDP 3.1 feature branch, I'd expand out those details to include things like specifying that we need to upgrade from Centos 6 to 7. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos
nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549#issuecomment-548010087 This has been merged into the feature branch. Thanks @MohanDV ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen closed pull request #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos
nickwallen closed pull request #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] asfgit closed pull request #1548: METRON-2303 Change Default HDFS Port for Batch Profiler
asfgit closed pull request #1548: METRON-2303 Change Default HDFS Port for Batch Profiler URL: https://github.com/apache/metron/pull/1548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen closed pull request #1542: METRON-2233 Deprecate CentOS 6 Development Environment
nickwallen closed pull request #1542: METRON-2233 Deprecate CentOS 6 Development Environment URL: https://github.com/apache/metron/pull/1542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment
nickwallen commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment URL: https://github.com/apache/metron/pull/1542#issuecomment-547997647 Thanks for the review @mmiklavc . This has been merged into the feature branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1
mmiklavc commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#issuecomment-547996513 Wanted to add 1 note for posterity. This was/is a big PR, however 5,045 lines out of the 5,218 are simply classes we had to copy from HBase in order to get integrations working around a defect wrt HDFS (notes in the code itself). The actual overall size of code/pom changes in this PR without those files is only 173 lines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen closed pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1
nickwallen closed pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1
nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#issuecomment-547995461 This has been merged into the feature branch; yay! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc closed pull request #1362: METRON-2043 Fix profiler-client dependencies
mmiklavc closed pull request #1362: METRON-2043 Fix profiler-client dependencies URL: https://github.com/apache/metron/pull/1362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1362: METRON-2043 Fix profiler-client dependencies
mmiklavc commented on issue #1362: METRON-2043 Fix profiler-client dependencies URL: https://github.com/apache/metron/pull/1362#issuecomment-547991621 Closing this PR - this was addressed in part via another fix here - https://github.com/apache/metron/pull/1525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment
mmiklavc commented on issue #1542: METRON-2233 Deprecate CentOS 6 Development Environment URL: https://github.com/apache/metron/pull/1542#issuecomment-547989143 lgtm @nickwallen, thanks! +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] sardell opened a new pull request #1550: METRON-2304: Update node and npm version to LTS releases
sardell opened a new pull request #1550: METRON-2304: Update node and npm
version to LTS releases
URL: https://github.com/apache/metron/pull/1550
## Contributor Comments
Link to ASF ticket here: https://issues.apache.org/jira/browse/METRON-2304
We are currently using node 9.11.1 and npm 6.2.0 in the project (this is
specified in both the Alerts UI and Management UI pom.xml files). This version
of node is no longer supported. Per Node.js' documents, "Production
applications should only use Active LTS or Maintenance LTS releases."
In this PR, I updated the project to use the current active LTS release
(10.17.0). I also updated the npm version to the latest minor/patch release
(6.11.3).
In addition, I added an .nvmrc file to the Management UI so that local
developers using nvm will be able to use the same version as our production
build.
## Testing
There shouldn't be a noticeable difference since node v10 is just the LTS
release of v9 and npm is primarily used to manage front-end dependencies. If
you run `mvn install -pl ':metron-config'` and `mvn install -pl
':metron-alerts'`, you will notice the versions of node and npm mentioned above
are installed. The tests suites for both UIs will also be ran and should pass.
To visually test for regressions, spin up full dev and open both the Alerts and
Management UI. You should see no differences.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be
created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and
running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered by building and verifying the site-book? If not then run the
following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
- [ ] Have you ensured that any documentation diagrams have been updated,
along with their source files, using [draw.io](https://www.draw.io/)? See
[Metron Development
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines)
for instructions.
Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time
mmiklavc commented on issue #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time URL: https://github.com/apache/metron/pull/1547#issuecomment-547984938 +1 by inspection, thanks for the fix @tiborm. Made one small note about the test setup, if you're inclined to fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on a change in pull request #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time
mmiklavc commented on a change in pull request #1547: METRON-2302: [UI] Change
the default polling interval for Alerts UI to longer time
URL: https://github.com/apache/metron/pull/1547#discussion_r340713898
##
File path:
metron-interface/metron-alerts/src/app/alerts/alerts-list/auto-polling/auto-polling.service.spec.ts
##
@@ -486,18 +489,18 @@ describe('AutoPollingService', () => {
expect(searchServiceFake.search).toHaveBeenCalledTimes(1);
- tick(getIntervalInMS());
+ tick(localAutoPollingSvc.getInterval() * 1000);
Review comment:
You may want to consider normalizing your abstraction for the tick
calculations, i.e. you're using a nice function `getIntervalInMS()` in some
places, but removed it here bc you're using a `localAutoPollingSvc` rather than
the global `autoPollingService`. Not a blocker, but something to consider if
you're inclined.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1548: METRON-2303 Change Default HDFS Port for Batch Profiler
mmiklavc commented on issue #1548: METRON-2303 Change Default HDFS Port for Batch Profiler URL: https://github.com/apache/metron/pull/1548#issuecomment-547981128 lgtm, thanks for the fix @nickwallen. I ran through this test recently, independent of this PR, and found the same. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on a change in pull request #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos
mmiklavc commented on a change in pull request #1549: METRON-2305: Unable to
Add Enrichment Coprocessor with Kerberos
URL: https://github.com/apache/metron/pull/1549#discussion_r340708849
##
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
##
@@ -268,7 +268,7 @@ def set_hbase_acls(self):
self.__params.hbase_principal_name,
execute_user=self.__params.hbase_user)
-cmd = "echo \"grant '{0}', 'RW', '{1}'\" | hbase shell -n"
+cmd = "echo \"grant '{0}', 'CRW', '{1}'\" | hbase shell -n"
Review comment:
I was wondering the same - good clarifications, thanks guys
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos
mmiklavc commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549#issuecomment-547980409 Piling on my +1 as well - thanks @MohanDV! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1
nickwallen commented on issue #1523: METRON-2232 Upgrade to Hadoop 3.1.1 URL: https://github.com/apache/metron/pull/1523#issuecomment-547949974 +1 Looks good. I previously ran this through a bulk of the testing steps described above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1
nickwallen commented on a change in pull request #1523: METRON-2232 Upgrade to
Hadoop 3.1.1
URL: https://github.com/apache/metron/pull/1523#discussion_r340669150
##
File path: metron-platform/metron-common/pom.xml
##
@@ -347,11 +347,6 @@
${project.parent.version}
test
-
-commons-beanutils
Review comment:
Yes, I think that is the right approach. Let's get these bits in and see if
we need to clean anything else up after.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1
mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to
Hadoop 3.1.1
URL: https://github.com/apache/metron/pull/1523#discussion_r340660373
##
File path: metron-platform/metron-common/pom.xml
##
@@ -347,11 +347,6 @@
${project.parent.version}
test
-
-commons-beanutils
Review comment:
@nickwallen I think if we reset this, we will probably need another full
round of testing. This may cause random classpath issue downstream yet that we
hadn't seen before. I think we serendipitously landed on the right beanutils
version (1.9.2) via commons-validator. Given that this is a FB, I was thinking
we could do another full round of validation on our cleanup PR with the final
pom changes. What do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to Hadoop 3.1.1
mmiklavc commented on a change in pull request #1523: METRON-2232 Upgrade to
Hadoop 3.1.1
URL: https://github.com/apache/metron/pull/1523#discussion_r340660373
##
File path: metron-platform/metron-common/pom.xml
##
@@ -347,11 +347,6 @@
${project.parent.version}
test
-
-commons-beanutils
Review comment:
@nickwallen I think if we reset this, we will probably need another full
round of testing. This may cause random classpath issue downstream yet that we
hadn't seen before. I think we serendipitously landed on the right beanutils
version (1.9.3) via commons-validator. Given that this is a FB, I was thinking
we could do another full round of validation on our cleanup PR with the final
pom changes. What do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos
nickwallen commented on issue #1549: METRON-2305: Unable to Add Enrichment Coprocessor with Kerberos URL: https://github.com/apache/metron/pull/1549#issuecomment-547936910 +1 Looks great. Thanks for the fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (METRON-2305) Unable to Add Enrichment Coprocessor with Kerberos
[
https://issues.apache.org/jira/browse/METRON-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Allen updated METRON-2305:
---
Summary: Unable to Add Enrichment Coprocessor with Kerberos (was: provide
hbase acl to metron user before altering enrichment table and adding
coprocessor)
> Unable to Add Enrichment Coprocessor with Kerberos
> --
>
> Key: METRON-2305
> URL: https://issues.apache.org/jira/browse/METRON-2305
> Project: Metron
> Issue Type: Bug
>Reporter: Mohan Venkateshaiah
>Assignee: Mohan Venkateshaiah
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> metron enrichment topology fails to star on pre kerberized cluster with
> insufficent permission to load the hbase coprocessor,
> {code:java}
> 2019-10-30 12:18:29,579 - Loading HBase coprocessor for enrichments
> 2019-10-30 12:18:29,580 - See
> https://hbase.apache.org/2.0/book.html#load_coprocessor_in_shell for more
> detail
> 2019-10-30 12:18:29,580 - HBase coprocessor setup - first disabling the
> enrichments HBase table.
> 2019-10-30 12:18:29,580 - Executing command echo "disable 'enrichment'" |
> hbase shell -n
> 2019-10-30 12:18:29,580 - Execute['echo "disable 'enrichment'" | hbase shell
> -n'] {'logoutput': True, 'tries': 1, 'user': 'metron'}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/hdp/3.1.4.0-315/phoenix/phoenix-5.0.0.3.1.4.0-315-server.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/hdp/3.1.4.0-315/hadoop/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> Took 1.4908 secondsERROR RuntimeError:
> org.apache.hadoop.hbase.security.AccessDeniedException: Insufficient
> permissions (user=met...@hwx.site, scope=default:enrichment,
> params=[table=default:enrichment],action=CREATE)
> 2019-10-30 12:18:38,833 - Skipping stack-select on METRON because it does not
> exist in the stack-select package structure.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [metron] nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.
nickwallen commented on a change in pull request #1549: METRON-2305: provide
required hbase acl to metron user before altering enrichment table and adding
coprocessor.
URL: https://github.com/apache/metron/pull/1549#discussion_r340647115
##
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
##
@@ -268,7 +268,7 @@ def set_hbase_acls(self):
self.__params.hbase_principal_name,
execute_user=self.__params.hbase_user)
-cmd = "echo \"grant '{0}', 'RW', '{1}'\" | hbase shell -n"
+cmd = "echo \"grant '{0}', 'CRW', '{1}'\" | hbase shell -n"
Review comment:
Ah, ok. I was curious why this worked before without 'C'. But it really
didn't work before. This bug here is "Unable to Add Enrichment Coprocessor
with Kerberos".
This has only previously worked when the coprocessor is added first (without
Kerberos), then kerberize, and after kerberization the coprocessor is already
there, so we don't hit the bug.
The two fixes in your PR are to:
1. Allow 'C' for 'metron' users
2. Enable ACLs before loading coprocessor.
This makes sense to me now. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.
nickwallen commented on a change in pull request #1549: METRON-2305: provide
required hbase acl to metron user before altering enrichment table and adding
coprocessor.
URL: https://github.com/apache/metron/pull/1549#discussion_r340647115
##
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
##
@@ -268,7 +268,7 @@ def set_hbase_acls(self):
self.__params.hbase_principal_name,
execute_user=self.__params.hbase_user)
-cmd = "echo \"grant '{0}', 'RW', '{1}'\" | hbase shell -n"
+cmd = "echo \"grant '{0}', 'CRW', '{1}'\" | hbase shell -n"
Review comment:
Ah, ok. I was curious why this worked before without 'C'. But it really
didn't work before. This bug here is "Unable to Add Coprocessor with
Kerberos".
This has only previously worked when the coprocessor is added first (without
Kerberos), then kerberize, and after kerberization the coprocessor is already
there, so we don't hit the bug.
The two fixes in your PR are to:
1. Allow 'C' for 'metron' users
2. Enable ACLs before loading coprocessor.
This makes sense to me now. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] MohanDV commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.
MohanDV commented on a change in pull request #1549: METRON-2305: provide
required hbase acl to metron user before altering enrichment table and adding
coprocessor.
URL: https://github.com/apache/metron/pull/1549#discussion_r340642524
##
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
##
@@ -268,7 +268,7 @@ def set_hbase_acls(self):
self.__params.hbase_principal_name,
execute_user=self.__params.hbase_user)
-cmd = "echo \"grant '{0}', 'RW', '{1}'\" | hbase shell -n"
+cmd = "echo \"grant '{0}', 'CRW', '{1}'\" | hbase shell -n"
Review comment:
@nickwallen In the HBase coprocessor setup -metron user does altering table
with enable and disable while adding coprocessor. This requires CREATE(C)
permission.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] nickwallen commented on a change in pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.
nickwallen commented on a change in pull request #1549: METRON-2305: provide
required hbase acl to metron user before altering enrichment table and adding
coprocessor.
URL: https://github.com/apache/metron/pull/1549#discussion_r340639509
##
File path:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
##
@@ -268,7 +268,7 @@ def set_hbase_acls(self):
self.__params.hbase_principal_name,
execute_user=self.__params.hbase_user)
-cmd = "echo \"grant '{0}', 'RW', '{1}'\" | hbase shell -n"
+cmd = "echo \"grant '{0}', 'CRW', '{1}'\" | hbase shell -n"
Review comment:
Do we need to change 'RW' to 'CRW' here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [metron] MohanDV opened a new pull request #1549: METRON-2305: provide required hbase acl to metron user before altering enrichment table and adding coprocessor.
MohanDV opened a new pull request #1549: METRON-2305: provide required hbase
acl to metron user before altering enrichment table and adding coprocessor.
URL: https://github.com/apache/metron/pull/1549
## Contributor Comments
metron enrichment topology fails to star on pre kerberized cluster with
insufficent permission to load the hbase coprocessor [METRON-2305](
https://issues.apache.org/jira/browse/METRON-2305). This pr will provide
required hbase acl to metron user before altering enrichment table and adding
coprocessor.
### Steps to reproduce
1. Deploy multinode metron cluster
2. Kerberize the cluster before starting the indexing server
3. starting enrichment service fails while kinit the solr user.
### Verified the fix using a multinode cluster
```
2019-10-30 12:39:36,170 - Loading HBase coprocessor for enrichments
2019-10-30 12:39:36,170 - See
https://hbase.apache.org/2.0/book.html#load_coprocessor_in_shell for more detail
2019-10-30 12:39:36,170 - HBase coprocessor setup - first disabling the
enrichments HBase table.
2019-10-30 12:39:36,170 - Executing command echo "disable 'enrichment'" |
hbase shell -n
2019-10-30 12:39:36,171 - Execute['echo "disable 'enrichment'" | hbase shell
-n'] {'logoutput': True, 'tries': 1, 'user': 'metron'}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/phoenix/phoenix-5.0.0.3.1.4.0-315-server.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/hadoop/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
Took 1.1231 seconds
2019-10-30 12:39:44,512 - HBase coprocessor setup - altering table and
adding coprocessor.
2019-10-30 12:39:44,512 - Executing command
/usr/hcp/2.0.0.0-4/metron/bin/load_enrichment_coprocessor.sh enrichment
hdfs://ctr-e141-1563959304486-63852-01-05.hwx.site:8020
/apps/metron/coprocessor
org.apache.metron.hbase.coprocessor.EnrichmentCoprocessor
ctr-e141-1563959304486-63852-01-11.hwx.site:2181
2019-10-30 12:39:44,513 -
Execute['/usr/hcp/2.0.0.0-4/metron/bin/load_enrichment_coprocessor.sh
enrichment hdfs://ctr-e141-1563959304486-63852-01-05.hwx.site:8020
/apps/metron/coprocessor
org.apache.metron.hbase.coprocessor.EnrichmentCoprocessor
ctr-e141-1563959304486-63852-01-11.hwx.site:2181'] {'logoutput': True,
'tries': 1, 'user': 'metron'}
Altering enrichment to add coprocessor.
Executing: alter 'enrichment', METHOD => 'table_att',
'Coprocessor'=>'hdfs://ctr-e141-1563959304486-63852-01-05.hwx.site:8020/apps/metron/coprocessor/metron-hbase-server-0.7.2.2.0.0.0-4-uber.jar|org.apache.metron.hbase.coprocessor.EnrichmentCoprocessor||zookeeperUrl=ctr-e141-1563959304486-63852-01-11.hwx.site:2181'
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/phoenix/phoenix-5.0.0.3.1.4.0-315-server.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/hadoop/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
HBase Shell
Use "help" to get list of supported commands.
Use "exit" to quit this interactive shell.
For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell
Version 2.0.2.3.1.4.0-315, r, Fri Aug 23 05:15:48 UTC 2019
Took 0.0015 seconds
stty: standard input: Inappropriate ioctl for device
alter 'enrichment', METHOD => 'table_att',
'Coprocessor'=>'hdfs://ctr-e141-1563959304486-63852-01-05.hwx.site:8020/apps/metron/coprocessor/metron-hbase-server-0.7.2.2.0.0.0-4-uber.jar|org.apache.metron.hbase.coprocessor.EnrichmentCoprocessor||zookeeperUrl=ctr-e141-1563959304486-63852-01-11.hwx.site:2181'
Updating all regions with the new schema...
All regions updated.
Done.
Took 2.1859 seconds
Done
2019-10-30 12:39:58,073 - HBase coprocessor setup - re-enabling enrichments
table.
2019-10-30 12:39:58,074 - Executing command echo "enable'enrichment'" |
hbase shell -n
2019-10-30 12:39:58,074 - Execute['echo "enable'enrichment'" | hbase shell
-n'] {'logoutput': True, 'tries': 1, 'user': 'metron'}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/phoenix/phoenix-5.0.0.3.1.4.0-315-server.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/hadoop/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
explanation.
SLF4J:
[jira] [Updated] (METRON-2305) provide hbase acl to metron user before altering enrichment table and adding coprocessor
[
https://issues.apache.org/jira/browse/METRON-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mohan Venkateshaiah updated METRON-2305:
Summary: provide hbase acl to metron user before altering enrichment table
and adding coprocessor (was: provide hbase acl to metron before altering
enrichment table and adding coprocessor)
> provide hbase acl to metron user before altering enrichment table and adding
> coprocessor
>
>
> Key: METRON-2305
> URL: https://issues.apache.org/jira/browse/METRON-2305
> Project: Metron
> Issue Type: Bug
>Reporter: Mohan Venkateshaiah
>Assignee: Mohan Venkateshaiah
>Priority: Major
>
> metron enrichment topology fails to star on pre kerberized cluster with
> insufficent permission to load the hbase coprocessor,
> {code:java}
> 2019-10-30 12:18:29,579 - Loading HBase coprocessor for enrichments
> 2019-10-30 12:18:29,580 - See
> https://hbase.apache.org/2.0/book.html#load_coprocessor_in_shell for more
> detail
> 2019-10-30 12:18:29,580 - HBase coprocessor setup - first disabling the
> enrichments HBase table.
> 2019-10-30 12:18:29,580 - Executing command echo "disable 'enrichment'" |
> hbase shell -n
> 2019-10-30 12:18:29,580 - Execute['echo "disable 'enrichment'" | hbase shell
> -n'] {'logoutput': True, 'tries': 1, 'user': 'metron'}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/hdp/3.1.4.0-315/phoenix/phoenix-5.0.0.3.1.4.0-315-server.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/hdp/3.1.4.0-315/hadoop/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> Took 1.4908 secondsERROR RuntimeError:
> org.apache.hadoop.hbase.security.AccessDeniedException: Insufficient
> permissions (user=met...@hwx.site, scope=default:enrichment,
> params=[table=default:enrichment],action=CREATE)
> 2019-10-30 12:18:38,833 - Skipping stack-select on METRON because it does not
> exist in the stack-select package structure.
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (METRON-2305) provide hbase acl to metron before altering enrichment table and adding coprocessor
Mohan Venkateshaiah created METRON-2305:
---
Summary: provide hbase acl to metron before altering enrichment
table and adding coprocessor
Key: METRON-2305
URL: https://issues.apache.org/jira/browse/METRON-2305
Project: Metron
Issue Type: Bug
Reporter: Mohan Venkateshaiah
Assignee: Mohan Venkateshaiah
metron enrichment topology fails to star on pre kerberized cluster with
insufficent permission to load the hbase coprocessor,
{code:java}
2019-10-30 12:18:29,579 - Loading HBase coprocessor for enrichments
2019-10-30 12:18:29,580 - See
https://hbase.apache.org/2.0/book.html#load_coprocessor_in_shell for more detail
2019-10-30 12:18:29,580 - HBase coprocessor setup - first disabling the
enrichments HBase table.
2019-10-30 12:18:29,580 - Executing command echo "disable 'enrichment'" | hbase
shell -n
2019-10-30 12:18:29,580 - Execute['echo "disable 'enrichment'" | hbase shell
-n'] {'logoutput': True, 'tries': 1, 'user': 'metron'}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/phoenix/phoenix-5.0.0.3.1.4.0-315-server.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/hdp/3.1.4.0-315/hadoop/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
Took 1.4908 secondsERROR RuntimeError:
org.apache.hadoop.hbase.security.AccessDeniedException: Insufficient
permissions (user=met...@hwx.site, scope=default:enrichment,
params=[table=default:enrichment],action=CREATE)
2019-10-30 12:18:38,833 - Skipping stack-select on METRON because it does not
exist in the stack-select package structure.
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [metron] nickwallen commented on issue #1544: METRON-2301 Building Against Wrong Storm Flux Version
nickwallen commented on issue #1544: METRON-2301 Building Against Wrong Storm Flux Version URL: https://github.com/apache/metron/pull/1544#issuecomment-547876138 Thanks for the review @ottobackwards . I have merged this into the feature branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] nickwallen closed pull request #1544: METRON-2301 Building Against Wrong Storm Flux Version
nickwallen closed pull request #1544: METRON-2301 Building Against Wrong Storm Flux Version URL: https://github.com/apache/metron/pull/1544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
