[GitHub] [metron] ottobackwards commented on pull request #1581: [MINOR] study

2020-05-21 Thread GitBox 


ottobackwards commented on pull request #1581:
URL: https://github.com/apache/metron/pull/1581#issuecomment-632196780


   Hi @LeeJiangchuan, thanks for the contribution.
   Can you change your pr title to start with the jira number?   METRON-.   
If you have not opened a jira for this change, we do require it.
   
   This is a good resource: 
https://cwiki.apache.org/confluence/display/METRON/Metron+Development+Environment+Setup+Instructions#MetronDevelopmentEnvironmentSetupInstructions-HowtoStartContributing
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox 


vikgmdev commented on a change in pull request #47:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428765442



##
File path: README.md
##
@@ -179,6 +179,48 @@ event zeek_init() =-10
 }
 ```
 
+ Dynamically send each zeek log to a topic with its same name.
+
+ * ej. `CONN::LOG` logs are sent to the `conn` topic or `Known::CERTS_LOG` to 
the `known-certs` topic.
+
+```
+@load packages/metron-bro-plugin-kafka/Apache/Kafka
+redef Kafka::logs_to_send = set(DHCP::LOG, RADIUS::LOG, DNS::LOG);
+redef Kafka::topic_name = "";
+redef Kafka::tag_json = T;
+
+event zeek_init() =-10
+{
+for (stream_id in Log::active_streams) {
+# Convert stream type enum to string
+const stream_string: string = fmt("%s", stream_id);
+
+# replace `::` by `_` from the log string name
+   # ej. CONN::LOG to CONN_LOG or Known::CERTS_LOG to Known_CERTS_LOG
+const stream_name: string = sub(stream_string, /::/, "_");
+
+# lowercase the whole string for nomalization
+const topic_name_lower: string = to_lower(stream_name);
+
+# remove the _log at the of each topic name
+const topic_name_under: string = sub(topic_name_lower, /_log$/, "");
+
+# replace `_` by `-` for compatibility with acceptable Kafka topic naes

Review comment:
   Yes, I referred to that but you're right it's more a personal 
preference, should I remove it from the example?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox 


vikgmdev commented on a change in pull request #47:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428759769



##
File path: README.md
##
@@ -179,6 +179,48 @@ event zeek_init() =-10
 }
 ```
 
+ Dynamically send each zeek log to a topic with its same name.
+
+ * ej. `CONN::LOG` logs are sent to the `conn` topic or `Known::CERTS_LOG` to 
the `known-certs` topic.
+
+```
+@load packages/metron-bro-plugin-kafka/Apache/Kafka
+redef Kafka::logs_to_send = set(DHCP::LOG, RADIUS::LOG, DNS::LOG);
+redef Kafka::topic_name = "";
+redef Kafka::tag_json = T;
+
+event zeek_init() =-10
+{
+for (stream_id in Log::active_streams) {
+# Convert stream type enum to string
+const stream_string: string = fmt("%s", stream_id);
+
+# replace `::` by `_` from the log string name
+   # ej. CONN::LOG to CONN_LOG or Known::CERTS_LOG to Known_CERTS_LOG

Review comment:
   On it, thanks.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] vikgmdev commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox 


vikgmdev commented on a change in pull request #47:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428759024



##
File path: README.md
##
@@ -179,6 +179,48 @@ event zeek_init() =-10
 }
 ```
 
+ Dynamically send each zeek log to a topic with its same name.
+
+ * ej. `CONN::LOG` logs are sent to the `conn` topic or `Known::CERTS_LOG` to 
the `known-certs` topic.

Review comment:
   Oh, yup, I refer to **e.g.** sorry for the typo and I should improve my 
grammatic.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox 


ottobackwards commented on pull request #47:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/47#issuecomment-632103636


   I have added Victor to the jira contributors role and assigned the jira to 
him



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (METRON-2357) Extends the example 4 of the bro-kafka plugin

2020-05-21 Thread Otto Fowler (Jira) 


 [ 
https://issues.apache.org/jira/browse/METRON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Otto Fowler reassigned METRON-2357:
---

Assignee: Victor Garcia  (was: Jon Zeolla)

> Extends the example 4 of  the bro-kafka plugin
> --
>
> Key: METRON-2357
> URL: https://issues.apache.org/jira/browse/METRON-2357
> Project: Metron
>  Issue Type: Improvement
>Reporter: Victor Garcia
>Assignee: Victor Garcia
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Extends the current [Example 
> 4]([https://github.com/apache/metron-bro-plugin-kafka#example-4---send-each-zeek-log-to-a-unique-topic])
>  on the metron-bro-plugin-kafka, to include a dynamic version.
> It will demonstrate how to automatically send each zeek log to a topic with 
> the same name.
> For instance the `CONN::LOG` log to be sent to the `conn` topic or 
> `Known::CERTS_LOG` to the `known-certs` topic without defining a 
> `{{Log::Filter`}} for each of those.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #47: METRON-2357: Extends example 4 with a dynamic version

2020-05-21 Thread GitBox 


JonZeolla commented on a change in pull request #47:
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/47#discussion_r428631726



##
File path: README.md
##
@@ -179,6 +179,48 @@ event zeek_init() =-10
 }
 ```
 
+ Dynamically send each zeek log to a topic with its same name.
+
+ * ej. `CONN::LOG` logs are sent to the `conn` topic or `Known::CERTS_LOG` to 
the `known-certs` topic.
+
+```
+@load packages/metron-bro-plugin-kafka/Apache/Kafka
+redef Kafka::logs_to_send = set(DHCP::LOG, RADIUS::LOG, DNS::LOG);
+redef Kafka::topic_name = "";
+redef Kafka::tag_json = T;
+
+event zeek_init() =-10
+{
+for (stream_id in Log::active_streams) {
+# Convert stream type enum to string
+const stream_string: string = fmt("%s", stream_id);
+
+# replace `::` by `_` from the log string name
+   # ej. CONN::LOG to CONN_LOG or Known::CERTS_LOG to Known_CERTS_LOG
+const stream_name: string = sub(stream_string, /::/, "_");
+
+# lowercase the whole string for nomalization
+const topic_name_lower: string = to_lower(stream_name);
+
+# remove the _log at the of each topic name
+const topic_name_under: string = sub(topic_name_lower, /_log$/, "");
+
+# replace `_` by `-` for compatibility with acceptable Kafka topic naes

Review comment:
   I assume you are referring to 
[this](https://github.com/apache/kafka/blob/d63e0181bb7b9b4f5ed088abc00d7b32aeb0/core/src/main/scala/kafka/admin/TopicCommand.scala#L198-L199)?
  Because otherwise, _ appears to be an allowed character in a topic name.

##
File path: README.md
##
@@ -179,6 +179,48 @@ event zeek_init() =-10
 }
 ```
 
+ Dynamically send each zeek log to a topic with its same name.
+
+ * ej. `CONN::LOG` logs are sent to the `conn` topic or `Known::CERTS_LOG` to 
the `known-certs` topic.
+
+```
+@load packages/metron-bro-plugin-kafka/Apache/Kafka
+redef Kafka::logs_to_send = set(DHCP::LOG, RADIUS::LOG, DNS::LOG);
+redef Kafka::topic_name = "";
+redef Kafka::tag_json = T;
+
+event zeek_init() =-10
+{
+for (stream_id in Log::active_streams) {
+# Convert stream type enum to string
+const stream_string: string = fmt("%s", stream_id);
+
+# replace `::` by `_` from the log string name
+   # ej. CONN::LOG to CONN_LOG or Known::CERTS_LOG to Known_CERTS_LOG

Review comment:
   Nit: Please keep the indentation consistent.

##
File path: README.md
##
@@ -179,6 +179,48 @@ event zeek_init() =-10
 }
 ```
 
+ Dynamically send each zeek log to a topic with its same name.
+
+ * ej. `CONN::LOG` logs are sent to the `conn` topic or `Known::CERTS_LOG` to 
the `known-certs` topic.
+
+```
+@load packages/metron-bro-plugin-kafka/Apache/Kafka
+redef Kafka::logs_to_send = set(DHCP::LOG, RADIUS::LOG, DNS::LOG);
+redef Kafka::topic_name = "";
+redef Kafka::tag_json = T;
+
+event zeek_init() =-10
+{
+for (stream_id in Log::active_streams) {
+# Convert stream type enum to string
+const stream_string: string = fmt("%s", stream_id);
+
+# replace `::` by `_` from the log string name
+   # ej. CONN::LOG to CONN_LOG or Known::CERTS_LOG to Known_CERTS_LOG
+const stream_name: string = sub(stream_string, /::/, "_");
+
+# lowercase the whole string for nomalization
+const topic_name_lower: string = to_lower(stream_name);
+
+# remove the _log at the of each topic name
+const topic_name_under: string = sub(topic_name_lower, /_log$/, "");
+
+# replace `_` by `-` for compatibility with acceptable Kafka topic naes

Review comment:
   naes typo

##
File path: README.md
##
@@ -179,6 +179,48 @@ event zeek_init() =-10
 }
 ```
 
+ Dynamically send each zeek log to a topic with its same name.
+
+ * ej. `CONN::LOG` logs are sent to the `conn` topic or `Known::CERTS_LOG` to 
the `known-certs` topic.
+
+```
+@load packages/metron-bro-plugin-kafka/Apache/Kafka
+redef Kafka::logs_to_send = set(DHCP::LOG, RADIUS::LOG, DNS::LOG);
+redef Kafka::topic_name = "";
+redef Kafka::tag_json = T;
+
+event zeek_init() =-10
+{
+for (stream_id in Log::active_streams) {
+# Convert stream type enum to string
+const stream_string: string = fmt("%s", stream_id);
+
+# replace `::` by `_` from the log string name
+   # ej. CONN::LOG to CONN_LOG or Known::CERTS_LOG to Known_CERTS_LOG
+const stream_name: string = sub(stream_string, /::/, "_");
+
+# lowercase the whole string for nomalization
+const topic_name_lower: string = to_lower(stream_name);
+
+# remove the _log at the of each topic name
+const topic_name_under: string = sub(topic_name_lower, /_log$/, "");
+
+# replace `_` by `-` for compatibility with acceptable Kafka topic naes
+const topic_name: string = sub(topic_name_under, /_/, "-");
+
+if (|Kafka::logs_to_send| == 0 || stream_id in

[jira] [Assigned] (METRON-2357) Extends the example 4 of the bro-kafka plugin

2020-05-21 Thread Jon Zeolla (Jira) 


 [ 
https://issues.apache.org/jira/browse/METRON-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jon Zeolla reassigned METRON-2357:
--

Assignee: Jon Zeolla

> Extends the example 4 of  the bro-kafka plugin
> --
>
> Key: METRON-2357
> URL: https://issues.apache.org/jira/browse/METRON-2357
> Project: Metron
>  Issue Type: Improvement
>Reporter: Victor Garcia
>Assignee: Jon Zeolla
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Extends the current [Example 
> 4]([https://github.com/apache/metron-bro-plugin-kafka#example-4---send-each-zeek-log-to-a-unique-topic])
>  on the metron-bro-plugin-kafka, to include a dynamic version.
> It will demonstrate how to automatically send each zeek log to a topic with 
> the same name.
> For instance the `CONN::LOG` log to be sent to the `conn` topic or 
> `Known::CERTS_LOG` to the `known-certs` topic without defining a 
> `{{Log::Filter`}} for each of those.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [metron] LeeJiangchuan opened a new pull request #1581: [MINOR] study

2020-05-21 Thread GitBox 


LeeJiangchuan opened a new pull request #1581:
URL: https://github.com/apache/metron/pull/1581


   ## Contributor Comments
   [Please place any comments here.  A description of the problem/enhancement, 
how to reproduce the issue, your testing methodology, etc.]
   
   I modified a misspelled word. So this pull request is a trivial rework/ code 
cleanup without ant test coverage
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be 
created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [ ] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   
   ### For code changes:
   - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
   - [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
 ```
 mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
 ```
   
   - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and 
running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered by building and verifying the site-book? If not then run the 
following commands and the verify changes via 
`site-book/target/site/index.html`:
   
 ```
 cd site-book
 mvn site
 ```
   
   - [ ] Have you ensured that any documentation diagrams have been updated, 
along with their source files, using [draw.io](https://www.draw.io/)? See 
[Metron Development 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines)
 for instructions.
   
    Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for 
your personal repository such that your branches are built there before 
submitting a pull request.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org