[GitHub] [metron] mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent
mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent URL: https://github.com/apache/metron/pull/1460#issuecomment-511416161 > @mmiklavc Thanks for reviewing the Angular upgrade PR so fast. Rather than force pushing to update this PR, I think I'm going to close this and open a new PR containing only the Central Navigation work once I merge the Angular update into master. I think things will be a little cleaner that way. I'll be sure to reference this discussion in the new PR so folks aren't confused. Is this okay with you? Works for me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent
mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent URL: https://github.com/apache/metron/pull/1460#issuecomment-510973797 > I also had to upgrade our version of Angular to the latest stable 7 release. Upgrading from 6 to 7 did not introduce any breaking changes. This should be performed in a separate PR in advance of this work. We pretty universally split any and all upgrade tasks from features that depend on that work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent
mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent URL: https://github.com/apache/metron/pull/1460#issuecomment-510942417 > (this was intentional in the original implementation, but feedback from users over time seems to indicate separating the personas is not necessarily beneficial) Can you elaborate on this? Is there a discuss thread or user list around this, or did this come from offline communications? I personally like this change, but I'm concerned that I don't recall having seen any discussion in the community around making the UI's have a common nav backbone. Again, I think this change is a good idea and it's pretty easy to justify imo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [metron] mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent
mmiklavc commented on issue #1460: METRON-2179: Make navigation in both UIs consistent URL: https://github.com/apache/metron/pull/1460#issuecomment-510938577 > Now, breathe a sigh of relief. 藍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
