[GitHub] metron issue #951: METRON-1479 Add editorconfig - create guideline for code ...

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/951
  
-1 as this has become an abandoned PR.  I will open a request to close this 
PR.


---


[GitHub] metron issue #951: METRON-1479 Add editorconfig - create guideline for code ...

2018-05-15 Thread sardell
Github user sardell commented on the issue:

https://github.com/apache/metron/pull/951
  
I think this is a good addition, as .editorconfig is included by default 
with Angular CLI-generated projects and gives consistent formatting between 
different contributors' editors. However, I do think this PR is really big and 
could be a little scary for a PR reviewer to look at. If it's easier, maybe we 
can break down how this could be committed and submitted for an easier review. 
Should be relatively easy to recreate most of this work with VS code's Format 
Code option.


---