[jira] [Commented] (METRON-1275) Fix Metron Documentation

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242345#comment-16242345
 ] 

ASF GitHub Bot commented on METRON-1275:


Github user cestella commented on the issue:

https://github.com/apache/metron/pull/833
  
Piling on with a +1, great job @JonZeolla 


> Fix Metron Documentation
> 
>
> Key: METRON-1275
> URL: https://issues.apache.org/jira/browse/METRON-1275
> Project: Metron
>  Issue Type: Bug
>Reporter: Jon Zeolla
>Assignee: Jon Zeolla
>
> I am combing through Metron documentation and I will have various updates for 
> minor fixes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (METRON-1275) Fix Metron Documentation

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242281#comment-16242281
 ] 

ASF GitHub Bot commented on METRON-1275:


Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/833
  
@JonZeolla I am assuming you just added additional options that are now 
available.  That being the case, +1 from me.


> Fix Metron Documentation
> 
>
> Key: METRON-1275
> URL: https://issues.apache.org/jira/browse/METRON-1275
> Project: Metron
>  Issue Type: Bug
>Reporter: Jon Zeolla
>Assignee: Jon Zeolla
>
> I am combing through Metron documentation and I will have various updates for 
> minor fixes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (METRON-1275) Fix Metron Documentation

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242277#comment-16242277
 ] 

ASF GitHub Bot commented on METRON-1275:


Github user nickwallen commented on a diff in the pull request:

https://github.com/apache/metron/pull/833#discussion_r149420478
  
--- Diff: metron-platform/Performance-tuning-guide.md ---
@@ -219,38 +219,49 @@ And we ran our bro parser topology with the following 
options. We did not need t
 though you could certainly do so if necessary. Notice that we only needed 
1 worker.
 
 ```
-/usr/metron/0.4.0/bin/start_parser_topology.sh -k $BROKERLIST -z 
$ZOOKEEPER -s bro -ksp SASL_PLAINTEXT
--ot enrichments
+/usr/metron/0.4.2/bin/start_parser_topology.sh \
 -e ~metron/.storm/storm-bro.config \
 -esc ~/.storm/spout-bro.config \
--sp 24 \
--snt 24 \
+-k $BROKERLIST \
+-ksp SASL_PLAINTEXT \
--- End diff --

Oops, sorry that's already how the docs were.  I wasn't following what you 
were doing here.  All you're doing is a reformat.  LGTM.


> Fix Metron Documentation
> 
>
> Key: METRON-1275
> URL: https://issues.apache.org/jira/browse/METRON-1275
> Project: Metron
>  Issue Type: Bug
>Reporter: Jon Zeolla
>Assignee: Jon Zeolla
>
> I am combing through Metron documentation and I will have various updates for 
> minor fixes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (METRON-1275) Fix Metron Documentation

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242272#comment-16242272
 ] 

ASF GitHub Bot commented on METRON-1275:


Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/833
  
Yes @lvets your +1 is definitely relevant.  I wish more community members 
would review PRs.


> Fix Metron Documentation
> 
>
> Key: METRON-1275
> URL: https://issues.apache.org/jira/browse/METRON-1275
> Project: Metron
>  Issue Type: Bug
>Reporter: Jon Zeolla
>Assignee: Jon Zeolla
>
> I am combing through Metron documentation and I will have various updates for 
> minor fixes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (METRON-1275) Fix Metron Documentation

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/METRON-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242266#comment-16242266
 ] 

ASF GitHub Bot commented on METRON-1275:


Github user lvets commented on the issue:

https://github.com/apache/metron/pull/833
  
I don't know whether my +1 is actually relevant, but here it goes: +1. 
Looks good to me :)


> Fix Metron Documentation
> 
>
> Key: METRON-1275
> URL: https://issues.apache.org/jira/browse/METRON-1275
> Project: Metron
>  Issue Type: Bug
>Reporter: Jon Zeolla
>Assignee: Jon Zeolla
>
> I am combing through Metron documentation and I will have various updates for 
> minor fixes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)