[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580320#comment-16580320 ] Michael Miklavcic commented on METRON-1735: --- Is this done? PR is closed and appears to be merged but the Jira is still open. > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Assignee: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580179#comment-16580179 ] ASF GitHub Bot commented on METRON-1735: Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1160 > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Assignee: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579894#comment-16579894 ] ASF GitHub Bot commented on METRON-1735: Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1160 +1 by inspection. Thanks for catching this, it's a good fix. > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Assignee: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578946#comment-16578946 ] ASF GitHub Bot commented on METRON-1735: Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1160 @justinleet it was something that needed to be fixed and should be good now. > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Assignee: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578695#comment-16578695 ] ASF GitHub Bot commented on METRON-1735: GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/1160 METRON-1735: Empty print status option causes NPE ## Contributor Comments This is a regression in the feature branch introduced by https://github.com/apache/metron/pull/1138. The default behavior of PcapJob is that it should not print status by default and not fail when that setting is missing. ### Changed Included - Changed the default behavior of the Pcap CLI to print status by default - Removed the print status flag from the CLI - Fixed bug in getting print status option in PcapJob - Added getter/setting methods to PcapJob for testing purposes - Added test cases ### Testing Still testing in full dev. - You should get result in the Pcap UI now - The print status option in the CLI should be missing - The CLI should print status every time ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1735 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1160 commit d13db64c9ae816fded89128a99cd5d6a8a71648c Author: merrimanr Date: 2018-08-10T22:03:25Z initial commit > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Assignee: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to
[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578694#comment-16578694 ] ASF GitHub Bot commented on METRON-1735: Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1160 > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Assignee: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578600#comment-16578600 ] ASF GitHub Bot commented on METRON-1735: Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1160 @merrimanr Could you bump Travis? Looks like a maven connection issue, rather than something to actually be fixed. > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Assignee: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to false. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1735) Empty print status option causes NPE
[ https://issues.apache.org/jira/browse/METRON-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576920#comment-16576920 ] ASF GitHub Bot commented on METRON-1735: GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1160 METRON-1735: Empty print status option causes NPE ## Contributor Comments This is a regression in the feature branch introduced by https://github.com/apache/metron/pull/1138. The default behavior of PcapJob is that it should not print status by default and not fail when that setting is missing. ### Changed Included - Changed the default behavior of the Pcap CLI to print status by default - Removed the print status flag from the CLI - Fixed bug in getting print status option in PcapJob - Added getter/setting methods to PcapJob for testing purposes - Added test cases ### Testing Still testing in full dev. - You should get result in the Pcap UI now - The print status option in the CLI should be missing - The CLI should print status every time ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-1735 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1160 commit d13db64c9ae816fded89128a99cd5d6a8a71648c Author: merrimanr Date: 2018-08-10T22:03:25Z initial commit > Empty print status option causes NPE > > > Key: METRON-1735 > URL: https://issues.apache.org/jira/browse/METRON-1735 > Project: Metron > Issue Type: Sub-task >Reporter: Ryan Merriman >Priority: Major > > REST does not set a print job status property causing a NPE in PcapJob > because the property is never added to the config. The PcapJob should > default to false. -- This message was sent by
