[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761974#comment-15761974 ] ASF GitHub Bot commented on METRON-625: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/396 > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15761967#comment-15761967 ] ASF GitHub Bot commented on METRON-625: --- Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/396 +1 by inspection. Thanks for fixing! > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751632#comment-15751632 ] ASF GitHub Bot commented on METRON-625: --- Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/396 @ottobackwards There shouldn't be, no. > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751625#comment-15751625 ] ASF GitHub Bot commented on METRON-625: --- Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/396 So it there is nothing with that value out there so there are no serialization issues > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751616#comment-15751616 ] ASF GitHub Bot commented on METRON-625: --- Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/396 Are there upgrade issues with the QUERY change? > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751621#comment-15751621 ] ASF GitHub Bot commented on METRON-625: --- Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/396 @ottobackwards I don't think so because it never worked (at least not in any of our apache releases; I checked yesterday). Nobody could be depending on this functionality unless they fixed it like I have here. > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751175#comment-15751175 ] ASF GitHub Bot commented on METRON-625: --- Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/396 Where is QUERY documented? I can't find it. What I did find is this in the Parser readme: Message Filter - a filter defining which messages can be dropped. This feature is only present in the Java paerer adapters Maybe you can fix the spelling of Java paerer? > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749836#comment-15749836 ] ASF GitHub Bot commented on METRON-625: --- Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/396 What do you think of renaming `QUERY` to `STELLAR` like we did with `fieldTransformation`? I don't think anyone is using this since it doesn't work, so it would likely not be a regression. ;) > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[
https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749686#comment-15749686
]
ASF GitHub Bot commented on METRON-625:
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/396#discussion_r92503461
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -76,12 +77,15 @@ public void prepare(Map stormConf, TopologyContext
context, OutputCollector coll
if(getSensorParserConfig() == null) {
filter = new GenericMessageFilter();
}
-else if(filter == null) {
+if(filter == null) {
getSensorParserConfig().getParserConfig().putIfAbsent("stellarContext",
stellarContext);
- filter = Filters.get(getSensorParserConfig().getFilterClassName()
- , getSensorParserConfig().getParserConfig()
- );
+
if(!StringUtils.isEmpty(getSensorParserConfig().getFilterClassName())) {
--- End diff --
Agreed. I removed `GenericMessageFilter` for clarity.
> Parser Filters cannot be specified from the sensor config
> -
>
> Key: METRON-625
> URL: https://issues.apache.org/jira/browse/METRON-625
> Project: Metron
> Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Casey Stella
>
> Parser filters cannot be specified because of a logic error in the prepare
> for the ParserBolt. Specifically, we are loading the filter from the config
> only if the filter member variable is null. Unfortunately, this will never
> be null, because it is initialized to a default implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[
https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749619#comment-15749619
]
ASF GitHub Bot commented on METRON-625:
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/396#discussion_r92498864
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -76,12 +77,15 @@ public void prepare(Map stormConf, TopologyContext
context, OutputCollector coll
if(getSensorParserConfig() == null) {
filter = new GenericMessageFilter();
}
-else if(filter == null) {
+if(filter == null) {
getSensorParserConfig().getParserConfig().putIfAbsent("stellarContext",
stellarContext);
- filter = Filters.get(getSensorParserConfig().getFilterClassName()
- , getSensorParserConfig().getParserConfig()
- );
+
if(!StringUtils.isEmpty(getSensorParserConfig().getFilterClassName())) {
--- End diff --
Well, it was confusing to see. Why does GenericMessageFilter exist at all
then? At the very least I would think to put a comment in to explain why you
are doing it that way for maintenance purposes if you leave it like that.
> Parser Filters cannot be specified from the sensor config
> -
>
> Key: METRON-625
> URL: https://issues.apache.org/jira/browse/METRON-625
> Project: Metron
> Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Casey Stella
>
> Parser filters cannot be specified because of a logic error in the prepare
> for the ParserBolt. Specifically, we are loading the filter from the config
> only if the filter member variable is null. Unfortunately, this will never
> be null, because it is initialized to a default implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[
https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749597#comment-15749597
]
ASF GitHub Bot commented on METRON-625:
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/396#discussion_r92497084
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -76,12 +77,15 @@ public void prepare(Map stormConf, TopologyContext
context, OutputCollector coll
if(getSensorParserConfig() == null) {
filter = new GenericMessageFilter();
}
-else if(filter == null) {
+if(filter == null) {
getSensorParserConfig().getParserConfig().putIfAbsent("stellarContext",
stellarContext);
- filter = Filters.get(getSensorParserConfig().getFilterClassName()
- , getSensorParserConfig().getParserConfig()
- );
+
if(!StringUtils.isEmpty(getSensorParserConfig().getFilterClassName())) {
--- End diff --
If it is null, don't we want to put in the GenericMessageFilter() as well?
> Parser Filters cannot be specified from the sensor config
> -
>
> Key: METRON-625
> URL: https://issues.apache.org/jira/browse/METRON-625
> Project: Metron
> Issue Type: Bug
>Reporter: Casey Stella
>Assignee: Casey Stella
>
> Parser filters cannot be specified because of a logic error in the prepare
> for the ParserBolt. Specifically, we are loading the filter from the config
> only if the filter member variable is null. Unfortunately, this will never
> be null, because it is initialized to a default implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (METRON-625) Parser Filters cannot be specified from the sensor config
[ https://issues.apache.org/jira/browse/METRON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749515#comment-15749515 ] ASF GitHub Bot commented on METRON-625: --- GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/396 METRON-625: Parser Filters cannot be specified from the sensor config Parser filters cannot be specified because of a logic error in the prepare for the ParserBolt. Specifically, we are loading the filter from the config only if the filter member variable is null. Unfortunately, this will never be null, because it is initialized to a default implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron METRON-625 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-metron/pull/396.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #396 commit 654fc9ab6809662104bda3763917551921aaae85 Author: cstella Date: 2016-12-14T21:19:44Z METRON-625: Parser Filters cannot be specified from the sensor config > Parser Filters cannot be specified from the sensor config > - > > Key: METRON-625 > URL: https://issues.apache.org/jira/browse/METRON-625 > Project: Metron > Issue Type: Bug >Reporter: Casey Stella >Assignee: Casey Stella > > Parser filters cannot be specified because of a logic error in the prepare > for the ParserBolt. Specifically, we are loading the filter from the config > only if the filter member variable is null. Unfortunately, this will never > be null, because it is initialized to a default implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
