[jira] [Created] (NIFI-3537) Got Error when try to start NIFI
xiaoxue li created NIFI-3537: Summary: Got Error when try to start NIFI Key: NIFI-3537 URL: https://issues.apache.org/jira/browse/NIFI-3537 Project: Apache NiFi Issue Type: Bug Reporter: xiaoxue li Priority: Critical When try to start NIFI on our Windows server, got below error. Please help to check. 2017-02-28 04:46:16,192 ERROR [main] org.apache.nifi.NiFi Failure to launch NiFi due to java.net.ConnectException: Connection refused: connect java.net.ConnectException: Connection refused: connect at java.net.TwoStacksPlainSocketImpl.socketConnect(Native Method) ~[na:1.8.0_66] at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) ~[na:1.8.0_66] at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) ~[na:1.8.0_66] at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) ~[na:1.8.0_66] at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172) ~[na:1.8.0_66] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) ~[na:1.8.0_66] at java.net.Socket.connect(Socket.java:589) ~[na:1.8.0_66] at java.net.Socket.connect(Socket.java:538) ~[na:1.8.0_66] at org.apache.nifi.BootstrapListener.sendCommand(BootstrapListener.java:100) ~[nifi-runtime-0.6.1.jar:0.6.1] at org.apache.nifi.BootstrapListener.start(BootstrapListener.java:83) ~[nifi-runtime-0.6.1.jar:0.6.1] at org.apache.nifi.NiFi.(NiFi.java:83) ~[nifi-runtime-0.6.1.jar:0.6.1] at org.apache.nifi.NiFi.main(NiFi.java:227) ~[nifi-runtime-0.6.1.jar:0.6.1] 2017-02-28 04:46:16,192 INFO [Thread-1] org.apache.nifi.NiFi Initiating shutdown of Jetty web server... 2017-02-28 04:46:16,192 INFO [Thread-1] org.apache.nifi.NiFi Jetty web server shutdown completed (nicely or otherwise). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-2613) Support extracting content from Microsoft Excel (.xlxs) documents
[ https://issues.apache.org/jira/browse/NIFI-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887280#comment-15887280 ] ASF GitHub Bot commented on NIFI-2613: -- Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 Thanks, @jdye64, that got it. I was able to build just fine with contrib-check and everything. On to new topics: * **License/Notice** - We need a separate LICENSE and NOTICE files for nifi-poi-nar. I was reminded by the recent LICENSE/NOTICE discussion on the mailing list about what to include in NAR bundles, and it applies here. Good news, you've already put together most of the text for the nifi-assembly LICENSE/NOTICE, and there are many examples of the file layout in other NARs. I think a reasonably comparable NAR referencing another Apache project is [nifi-ignite-nar](https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-nar/src/main/resources/META-INF). * **Sheet in Filename** - Output filenames all have the UNKNOWN sheet name, like `35200238025098_UNKNOWN.csv`. How about adding a sheet name check to one of the unit tests? * **Error Cases** - What will make this fail? > Support extracting content from Microsoft Excel (.xlxs) documents > - > > Key: NIFI-2613 > URL: https://issues.apache.org/jira/browse/NIFI-2613 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Jeremy Dyer >Assignee: Jeremy Dyer > > Microsoft Excel is a wildly popular application that businesses rely heavily > on to store, visualize, and calculate data. Any single company most likely > has thousands of Excel documents containing data that could be very valuable > if ingested via NiFi and combined with other datasources. Apache POI is a > popular 100% Java library for parsing several Microsoft document formats > including Excel. Apache POI is extremely flexible and can do several things. > This issue would focus solely on using Apache POI to parse an incoming .xlxs > document and convert it to CSV. The processor should be capable of limiting > which excel sheets. CSV seems like the natural choice for outputting each row > since this feature is already available in Excel and feels very natural to > most Excel sheet designs. > This capability should most likely introduce a new "poi" module as I envision > many more capabilities around parsing Microsoft documents could come from > this base effort. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 Thanks, @jdye64, that got it. I was able to build just fine with contrib-check and everything. On to new topics: * **License/Notice** - We need a separate LICENSE and NOTICE files for nifi-poi-nar. I was reminded by the recent LICENSE/NOTICE discussion on the mailing list about what to include in NAR bundles, and it applies here. Good news, you've already put together most of the text for the nifi-assembly LICENSE/NOTICE, and there are many examples of the file layout in other NARs. I think a reasonably comparable NAR referencing another Apache project is [nifi-ignite-nar](https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-nar/src/main/resources/META-INF). * **Sheet in Filename** - Output filenames all have the UNKNOWN sheet name, like `35200238025098_UNKNOWN.csv`. How about adding a sheet name check to one of the unit tests? * **Error Cases** - What will make this fail? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3189) ConsumeKafka 0.9 and 0.10 can cause consumer rebalance when backpressure is engaged
[ https://issues.apache.org/jira/browse/NIFI-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887238#comment-15887238 ] ASF GitHub Bot commented on NIFI-3189: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1527 @bbende It turned out to be updating Kafka client is sufficient for 0.10. Confirmed that ConsumeKafka_0_10 can rejoin the consumer group when it resumes after being back-pressure engaged more than 5 minutes. For 0.9, I've added the manual connection retaining logic using paused poll. - For ConsumeKafka_0_10, use latest client library Above issue has been addressed by KIP-62. The latest Kafka consumer poll checks if the client instance is still valid, and rejoin the group if not, before consuming messages. - For ConsumeKafka (0.9), added manual retention logic using pause/resume Kafka client 0.9 doesn't have background thread heartbeat, so similar machanism is added manually. Use Kafka pause/resume consumer API to tell Kafka server that the client stops consuming messages but is still alive. Another internal thread is used to perform paused poll periodically based on the time passed since the last onTrigger(poll) is executed. > ConsumeKafka 0.9 and 0.10 can cause consumer rebalance when backpressure is > engaged > --- > > Key: NIFI-3189 > URL: https://issues.apache.org/jira/browse/NIFI-3189 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.1.0 >Reporter: Joseph Witt >Assignee: Koji Kawamura > > ConsumeKafka processors can alert to rebalance issues when backpressure is > engaged on the output connection and is then freed up. This is because we're > not doing anything with those consumers for a period of time and the kafka > client detects this and initiates a rebalance. We should ensure that even > when we cannot send more data due to back pressure that we at least have some > sort of keep alive behavior with the kafka client. Or, if that isn't an > option we should at least document the situation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1527: NIFI-3189: ConsumeKafka & Back-pressure. ConsumeKafka_0_10
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1527 @bbende It turned out to be updating Kafka client is sufficient for 0.10. Confirmed that ConsumeKafka_0_10 can rejoin the consumer group when it resumes after being back-pressure engaged more than 5 minutes. For 0.9, I've added the manual connection retaining logic using paused poll. - For ConsumeKafka_0_10, use latest client library Above issue has been addressed by KIP-62. The latest Kafka consumer poll checks if the client instance is still valid, and rejoin the group if not, before consuming messages. - For ConsumeKafka (0.9), added manual retention logic using pause/resume Kafka client 0.9 doesn't have background thread heartbeat, so similar machanism is added manually. Use Kafka pause/resume consumer API to tell Kafka server that the client stops consuming messages but is still alive. Another internal thread is used to perform paused poll periodically based on the time passed since the last onTrigger(poll) is executed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-3536) Add GetSOAP Processor
Andrew Psaltis created NIFI-3536: Summary: Add GetSOAP Processor Key: NIFI-3536 URL: https://issues.apache.org/jira/browse/NIFI-3536 Project: Apache NiFi Issue Type: New Feature Reporter: Andrew Psaltis Assignee: Andrew Psaltis Although it may seem like everyone is now using REST or at least RESTful services there still remains a need for many enterprises to interact with SOAP endpoints. This JIRA is for a new processor that supports interacting with SOAP endpoints. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3268) Add AUTO_INCREMENT column in GenerateTableFetch to benefit index
[ https://issues.apache.org/jira/browse/NIFI-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886825#comment-15886825 ] ASF GitHub Bot commented on NIFI-3268: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @qfdk I understand. It's ok to have Travis test failure with other USER_LANGUAGE than English for now. Since the test has passed with English locale, we can move forward. We're aware of several tests can fail with other locale, and actively fixing those tests right now, for example, [NIFI-3466](https://issues.apache.org/jira/browse/NIFI-3466). In order to add new capability to this generic processor, we need to test with variety Database engines as many user use it with different databases. If you verified it with PostgreSQL, then I'd try reviewing this with other database such as Oracle, SQL server or MySQL. > Add AUTO_INCREMENT column in GenerateTableFetch to benefit index > > > Key: NIFI-3268 > URL: https://issues.apache.org/jira/browse/NIFI-3268 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.1.1 > Environment: - ubuntu 16.04 > - java version "1.8.0_111" > - Java(TM) SE Runtime Environment (build 1.8.0_111-b14) > - Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode) >Reporter: qfdk > Labels: easyfix > Fix For: 1.2.0 > > > I added AUTO_INCREMENT column in GenerateTableFetch to benefit index column > By default this processor uses OFFSET, i have problems with large data. > somme column has index so we could use index to speed up query time. > I posted question here : > https://community.hortonworks.com/questions/72586/how-can-i-use-an-array-with-putelasticsearch.html > If you indexed un column (id), you could use this sql > ``` > select xxx > From x > where 20=>id > order by id > limit 20 > ``` > “OFFSET is bad for skipping previous rows.” [Online]. Available: > http://Use-The-Index-Luke.com/sql/partial-results/fetch-next-page. [Accessed: > 27-Dec-2016]. > Thank you in advance -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @qfdk I understand. It's ok to have Travis test failure with other USER_LANGUAGE than English for now. Since the test has passed with English locale, we can move forward. We're aware of several tests can fail with other locale, and actively fixing those tests right now, for example, [NIFI-3466](https://issues.apache.org/jira/browse/NIFI-3466). In order to add new capability to this generic processor, we need to test with variety Database engines as many user use it with different databases. If you verified it with PostgreSQL, then I'd try reviewing this with other database such as Oracle, SQL server or MySQL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-3439) Making password property in HiveConnectionPool a hidden show.
[ https://issues.apache.org/jira/browse/NIFI-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-3439: -- Status: Patch Available (was: In Progress) > Making password property in HiveConnectionPool a hidden show. > - > > Key: NIFI-3439 > URL: https://issues.apache.org/jira/browse/NIFI-3439 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.1.1 > Environment: Google Chrome browser >Reporter: Ramakrishnan V >Assignee: Scott Aslan >Priority: Minor > Labels: ControllerService, Hive, security > Original Estimate: 168h > Remaining Estimate: 168h > > When user types the password in the password attribute in hive connection > pool controller service, the characters are visible. Once completed the > password is encrypted and no longer visible. > shouldn't be me made as normal hidden show password box ? > The user always has the option to delete the controller service and > re-configure if he has entered a wrong password. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3439) Making password property in HiveConnectionPool a hidden show.
[ https://issues.apache.org/jira/browse/NIFI-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886707#comment-15886707 ] ASF GitHub Bot commented on NIFI-3439: -- GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1546 [NIFI-3439] when users type into sensitive property fields in NiFI, t… …he values on the screen/browser should be masked *** unless specified by user to show plain text. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-3439 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1546.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1546 commit efade07d5ea39229073124bb8dd96b08387aabd7 Author: Scott AslanDate: 2017-02-27T17:19:05Z [NIFI-3439] when users type into sensitive property fields in NiFI, the values on the screen/browser should be masked *** unless specified by user to show plain text. > Making password property in HiveConnectionPool a hidden show. > - > > Key: NIFI-3439 > URL: https://issues.apache.org/jira/browse/NIFI-3439 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.1.1 > Environment: Google Chrome browser >Reporter: Ramakrishnan V >Assignee: Scott Aslan >Priority: Minor > Labels: ControllerService, Hive, security > Original Estimate: 168h > Remaining Estimate: 168h > > When user types the password in the password attribute in hive connection > pool controller service, the characters are visible. Once completed the > password is encrypted and no longer visible. > shouldn't be me made as normal hidden show password box ? > The user always has the option to delete the controller service and > re-configure if he has entered a wrong password. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1546: [NIFI-3439] when users type into sensitive property...
GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1546 [NIFI-3439] when users type into sensitive property fields in NiFI, t⦠â¦he values on the screen/browser should be masked *** unless specified by user to show plain text. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-3439 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1546.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1546 commit efade07d5ea39229073124bb8dd96b08387aabd7 Author: Scott AslanDate: 2017-02-27T17:19:05Z [NIFI-3439] when users type into sensitive property fields in NiFI, the values on the screen/browser should be masked *** unless specified by user to show plain text. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-3535) Use keytab for local filesystem
Sunile Manjee created NIFI-3535: --- Summary: Use keytab for local filesystem Key: NIFI-3535 URL: https://issues.apache.org/jira/browse/NIFI-3535 Project: Apache NiFi Issue Type: Improvement Components: Core Framework Affects Versions: 1.0.1, 1.1.1 Environment: ie redhat Reporter: Sunile Manjee Priority: Critical For enterprises which require strict access control to local file systems, the requirement is to enable nifi processors which access local file system to use keytab or another process to use user account which was used during nifi authentication. without such enforcement all users within a restricted group have access to full local file system via nifi processor. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3490) TLS Toolkit - define SAN in standalone mode
[ https://issues.apache.org/jira/browse/NIFI-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886508#comment-15886508 ] ASF GitHub Bot commented on NIFI-3490: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1530 I verified the contrib-check, all tests pass, smoke tests on flows work, and the tool now generates SANs in standalone mode. ``` #5: ObjectId: 2.5.29.17 Criticality=false SubjectAlternativeName [ DNSName: nifi.vip.org DNSName: localhost DNSName: nifi-01 ] ``` If you remove the short code or change the client/server short code to match, I'll +1 and merge. > TLS Toolkit - define SAN in standalone mode > --- > > Key: NIFI-3490 > URL: https://issues.apache.org/jira/browse/NIFI-3490 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > Labels: tls-toolkit > Fix For: 1.2.0 > > > Following NIFI-3331, it would be useful to have the same option (add Subject > Alternative Names in certificates) when using the TLS toolkit in standalone > mode. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1530: NIFI-3490 added SAN option for TLS toolkit in standalone m...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1530 I verified the contrib-check, all tests pass, smoke tests on flows work, and the tool now generates SANs in standalone mode. ``` #5: ObjectId: 2.5.29.17 Criticality=false SubjectAlternativeName [ DNSName: nifi.vip.org DNSName: localhost DNSName: nifi-01 ] ``` If you remove the short code or change the client/server short code to match, I'll +1 and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-3366) MoveHDFS Processor
[ https://issues.apache.org/jira/browse/NIFI-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gray Gwizdz updated NIFI-3366: -- Attachment: 0001-MoveHDFS-Processor.patch Attached patch demonstrates the ability to move a file from one directory to another on HDFS. > MoveHDFS Processor > -- > > Key: NIFI-3366 > URL: https://issues.apache.org/jira/browse/NIFI-3366 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec >Priority: Minor > Attachments: 0001-MoveHDFS-Processor.patch > > > Today the PutHDFS Processor merely places a file into HDFS from NiFi. There > are times when we may want to move Files/Directories around on HDFS as part > of a workflow. This could be after the PutHDFS processor has placed the > file, or from some other trigger. > Initially we are targeting to take a flow file attribute of an absolute HDFS > path, and be able to move it to a target HDFS Path using the Filesystem > RENAME API. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3366) MoveHDFS Processor
[ https://issues.apache.org/jira/browse/NIFI-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886497#comment-15886497 ] Gray Gwizdz commented on NIFI-3366: --- Ford Motor Company is interested in this functionality, and has developed a patch to fix this need. > MoveHDFS Processor > -- > > Key: NIFI-3366 > URL: https://issues.apache.org/jira/browse/NIFI-3366 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec >Priority: Minor > > Today the PutHDFS Processor merely places a file into HDFS from NiFi. There > are times when we may want to move Files/Directories around on HDFS as part > of a workflow. This could be after the PutHDFS processor has placed the > file, or from some other trigger. > Initially we are targeting to take a flow file attribute of an absolute HDFS > path, and be able to move it to a target HDFS Path using the Filesystem > RENAME API. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi-minifi-cpp issue #20: Adding an initial GitHub PR template.
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/20 Totally missed the snark on this thread. I can't meet the requirements of a non-existent PR if they aren't there yet. ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-3364) NiFi start-up fails to honor N in definitions java.arg.N as made in conf/bootstrap.conf
[ https://issues.apache.org/jira/browse/NIFI-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russell Bateman updated NIFI-3364: -- Attachment: RunNiFi.java There are sufficient comments including horizontal rules in this file. > NiFi start-up fails to honor N in definitions java.arg.N as made in > conf/bootstrap.conf > --- > > Key: NIFI-3364 > URL: https://issues.apache.org/jira/browse/NIFI-3364 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Affects Versions: 0.8.0, 0.7.1, 1.2.0, 1.1.1, 1.0.1 > Environment: Any and all platforms and environments. >Reporter: Russell Bateman >Priority: Critical > Labels: easyfix, patch > Attachments: RunNiFi.java > > > In albeit rare cases, JVM argument ordering is important. The present > implementation of the sense of java.arg.N leaves N ignored in the final list > when presented to the JVM at launch. > Two examples of insurmountably critical ordering are the use the Java Flight > Recorder and the JMX remote arguments in support of using Java Mission > Control remotely to connect to and profile (what's being done by) NiFi. > Attached is a coded solution for replacing this block of code in RunNiFi.java: > for (final Map.Entryentry : props.entrySet()) { > final String key = entry.getKey(); > final String value = entry.getValue(); > > if (key.startsWith("java.arg")) { > javaAdditionalArgs.add(value); > } > } -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3364) NiFi start-up fails to honor N in definitions java.arg.N as made in conf/bootstrap.conf
[ https://issues.apache.org/jira/browse/NIFI-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886457#comment-15886457 ] Russell Bateman commented on NIFI-3364: --- Sorry, I don't know why the attachment didn't take. I'm struggling to figure out how to do it. I'll keep trying. > NiFi start-up fails to honor N in definitions java.arg.N as made in > conf/bootstrap.conf > --- > > Key: NIFI-3364 > URL: https://issues.apache.org/jira/browse/NIFI-3364 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Affects Versions: 0.8.0, 0.7.1, 1.2.0, 1.1.1, 1.0.1 > Environment: Any and all platforms and environments. >Reporter: Russell Bateman >Priority: Critical > Labels: easyfix, patch > > In albeit rare cases, JVM argument ordering is important. The present > implementation of the sense of java.arg.N leaves N ignored in the final list > when presented to the JVM at launch. > Two examples of insurmountably critical ordering are the use the Java Flight > Recorder and the JMX remote arguments in support of using Java Mission > Control remotely to connect to and profile (what's being done by) NiFi. > Attached is a coded solution for replacing this block of code in RunNiFi.java: > for (final Map.Entryentry : props.entrySet()) { > final String key = entry.getKey(); > final String value = entry.getValue(); > > if (key.startsWith("java.arg")) { > javaAdditionalArgs.add(value); > } > } -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3530) PutHiveStreaming doesn't fully utilize *-site.xml files
[ https://issues.apache.org/jira/browse/NIFI-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-3530: --- Resolution: Fixed Status: Resolved (was: Patch Available) > PutHiveStreaming doesn't fully utilize *-site.xml files > --- > > Key: NIFI-3530 > URL: https://issues.apache.org/jira/browse/NIFI-3530 > Project: Apache NiFi > Issue Type: Bug >Reporter: Bryan Rosander >Assignee: Bryan Rosander > Fix For: 1.2.0 > > > PutHiveStreaming doesn't always pass the HiveConf object down to the Hive api > when it is needed. This causes problems with a kerberized or otherwise > non-default setup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3530) PutHiveStreaming doesn't fully utilize *-site.xml files
[ https://issues.apache.org/jira/browse/NIFI-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886430#comment-15886430 ] ASF subversion and git services commented on NIFI-3530: --- Commit cfe899d1898aa6c5f8d36e6e92562805b54f7d5d in nifi's branch refs/heads/master from [~bryanrosan...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=cfe899d ] NIFI-3530 - Ensuring configuration and ugi information is passed down to Hive in PutHiveStreaming NIFI-3530 - closing renewer in PutHiveStreaming.cleanup(), making npe less likely in HiveWriter.toString() This closes #1544 > PutHiveStreaming doesn't fully utilize *-site.xml files > --- > > Key: NIFI-3530 > URL: https://issues.apache.org/jira/browse/NIFI-3530 > Project: Apache NiFi > Issue Type: Bug >Reporter: Bryan Rosander >Assignee: Bryan Rosander > Fix For: 1.2.0 > > > PutHiveStreaming doesn't always pass the HiveConf object down to the Hive api > when it is needed. This causes problems with a kerberized or otherwise > non-default setup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3530) PutHiveStreaming doesn't fully utilize *-site.xml files
[ https://issues.apache.org/jira/browse/NIFI-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886432#comment-15886432 ] ASF GitHub Bot commented on NIFI-3530: -- Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1544 +1 LGTM, thanks for this fix! Merging to master > PutHiveStreaming doesn't fully utilize *-site.xml files > --- > > Key: NIFI-3530 > URL: https://issues.apache.org/jira/browse/NIFI-3530 > Project: Apache NiFi > Issue Type: Bug >Reporter: Bryan Rosander >Assignee: Bryan Rosander > Fix For: 1.2.0 > > > PutHiveStreaming doesn't always pass the HiveConf object down to the Hive api > when it is needed. This causes problems with a kerberized or otherwise > non-default setup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-3530) PutHiveStreaming doesn't fully utilize *-site.xml files
[ https://issues.apache.org/jira/browse/NIFI-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-3530: --- Fix Version/s: 1.2.0 Status: Patch Available (was: Open) > PutHiveStreaming doesn't fully utilize *-site.xml files > --- > > Key: NIFI-3530 > URL: https://issues.apache.org/jira/browse/NIFI-3530 > Project: Apache NiFi > Issue Type: Bug >Reporter: Bryan Rosander >Assignee: Bryan Rosander > Fix For: 1.2.0 > > > PutHiveStreaming doesn't always pass the HiveConf object down to the Hive api > when it is needed. This causes problems with a kerberized or otherwise > non-default setup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi-minifi-cpp pull request #60: MINIFI-225: Apply first round of CPP linte...
Github user phrocker closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3530) PutHiveStreaming doesn't fully utilize *-site.xml files
[ https://issues.apache.org/jira/browse/NIFI-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886431#comment-15886431 ] ASF subversion and git services commented on NIFI-3530: --- Commit cfe899d1898aa6c5f8d36e6e92562805b54f7d5d in nifi's branch refs/heads/master from [~bryanrosan...@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=cfe899d ] NIFI-3530 - Ensuring configuration and ugi information is passed down to Hive in PutHiveStreaming NIFI-3530 - closing renewer in PutHiveStreaming.cleanup(), making npe less likely in HiveWriter.toString() This closes #1544 > PutHiveStreaming doesn't fully utilize *-site.xml files > --- > > Key: NIFI-3530 > URL: https://issues.apache.org/jira/browse/NIFI-3530 > Project: Apache NiFi > Issue Type: Bug >Reporter: Bryan Rosander >Assignee: Bryan Rosander > Fix For: 1.2.0 > > > PutHiveStreaming doesn't always pass the HiveConf object down to the Hive api > when it is needed. This causes problems with a kerberized or otherwise > non-default setup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3530) PutHiveStreaming doesn't fully utilize *-site.xml files
[ https://issues.apache.org/jira/browse/NIFI-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886433#comment-15886433 ] ASF GitHub Bot commented on NIFI-3530: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1544 > PutHiveStreaming doesn't fully utilize *-site.xml files > --- > > Key: NIFI-3530 > URL: https://issues.apache.org/jira/browse/NIFI-3530 > Project: Apache NiFi > Issue Type: Bug >Reporter: Bryan Rosander >Assignee: Bryan Rosander > Fix For: 1.2.0 > > > PutHiveStreaming doesn't always pass the HiveConf object down to the Hive api > when it is needed. This causes problems with a kerberized or otherwise > non-default setup. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1544: NIFI-3530 - Ensuring configuration and ugi information is ...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1544 +1 LGTM, thanks for this fix! Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1544: NIFI-3530 - Ensuring configuration and ugi informat...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #60: MINIFI-225: Apply first round of CPP linter and c...
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/60 I'm going to do this one file at a time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #60: MINIFI-225: Apply first round of CPP linte...
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/60 MINIFI-225: Apply first round of CPP linter and code style fixes Included and applied Google code style CPP formatter for eclipse. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-225 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 506818c4b80a533b55613cc624490cd27abc073f Author: Marc ParisiDate: 2017-02-27T19:53:41Z MINIFI-225: Apply first round of CPP linter and code style fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #60: MINIFI-225: Apply first round of CPP linter and c...
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/60 Added xml formatter in thirdparty/codestyle dir. Usually I would add this to /contrib. Please advise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #57: MINIFI-83: Allow appenders to be specified...
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #57: MINIFI-83: Allow appenders to be specified and au...
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/57 Looks great, thanks. Will get this merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #57: MINIFI-83: Allow appenders to be specified...
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/57#discussion_r103283648 --- Diff: libminifi/include/LogAppenders.h --- @@ -0,0 +1,292 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ +#define LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ + +#include "BaseLogger.h" +#include "spdlog/sinks/null_sink.h" +#include "spdlog/sinks/ostream_sink.h" +#include +#include "Configure.h" + +template +static std::string getUniqueName() { + std::string name = LOG_NAME; + name += " -- "; + name += abi::__cxa_demangle(typeid(T).name(), 0, 0, 0); + spdlog::drop(name); + return name; +} + +/** + * Null appender sets a null sink, thereby performing no logging. + */ +class NullAppender: public BaseLogger { +public: + /** +* Base constructor that creates the null sink. +*/ + explicit NullAppender() : + ::BaseLogger("off") { + auto null_sink = std::make_shared(); + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, null_sink); + configured_level_ = off; + setLogLevel(); + } + + /** +* Move constructor for the null appender. +*/ + explicit NullAppender(const NullAppender &) : + ::BaseLogger(std::move(other)) { + + } + +}; + +/** + * Basic output stream configuration that uses a supplied ostream + * + * Design : extends LoggerConfiguration using the logger and log level + * encapsulated within the base configuration class. + */ +class OutputStreamAppender: public BaseLogger { + +public: + + static const char *nifi_log_output_stream_error_stderr; + + /** +* Output stream move constructor. +*/ + explicit OutputStreamAppender(const OutputStreamAppender &) : + ::BaseLogger(std::move(other)) { + + } + + /** +* Base constructor. Creates a ostream sink. +* @param stream incoming stream reference. +* @param config configuration. +*/ + explicit OutputStreamAppender(Configure *config) : + ::BaseLogger("info") { + auto ostream_sink = std::make_shared( + std::cout); + + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, ostream_sink); + + std::string use_std_err; + + if (NULL != config + && config->get(nifi_log_output_stream_error_stderr, + use_std_err)) { + + std::transform(use_std_err.begin(), use_std_err.end(), + use_std_err.begin(), ::tolower); + + if (use_std_err == "true") { + std::string err_unique_name = + getUniqueName(); + auto error_ostream_sink = std::make_shared< + spdlog::sinks::ostream_sink_mt>(std::cerr); + stderr_ = std::make_shared(err_unique_name, + error_ostream_sink); + } + } else + stderr_ = nullptr; + + std::string log_level; + if (NULL != config + && config->get(BaseLogger::nifi_log_level, log_level)) { + setLogLevel(log_level); + } else + setLogLevel("info"); + + } + + /** +* Base constructor. Creates a ostream sink. +* @param stream incoming stream reference. +* @param config configuration. +*/ +
[GitHub] nifi-minifi-cpp pull request #57: MINIFI-83: Allow appenders to be specified...
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/57#discussion_r103284475 --- Diff: libminifi/include/LogAppenders.h --- @@ -0,0 +1,292 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ +#define LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ + +#include "BaseLogger.h" +#include "spdlog/sinks/null_sink.h" +#include "spdlog/sinks/ostream_sink.h" +#include +#include "Configure.h" + +template +static std::string getUniqueName() { + std::string name = LOG_NAME; + name += " -- "; + name += abi::__cxa_demangle(typeid(T).name(), 0, 0, 0); + spdlog::drop(name); + return name; +} + +/** + * Null appender sets a null sink, thereby performing no logging. + */ +class NullAppender: public BaseLogger { +public: + /** +* Base constructor that creates the null sink. +*/ + explicit NullAppender() : + ::BaseLogger("off") { + auto null_sink = std::make_shared(); + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, null_sink); + configured_level_ = off; + setLogLevel(); + } + + /** +* Move constructor for the null appender. +*/ + explicit NullAppender(const NullAppender &) : + ::BaseLogger(std::move(other)) { + + } + +}; + +/** + * Basic output stream configuration that uses a supplied ostream + * + * Design : extends LoggerConfiguration using the logger and log level + * encapsulated within the base configuration class. + */ +class OutputStreamAppender: public BaseLogger { + +public: + + static const char *nifi_log_output_stream_error_stderr; + + /** +* Output stream move constructor. +*/ + explicit OutputStreamAppender(const OutputStreamAppender &) : + ::BaseLogger(std::move(other)) { + + } + + /** +* Base constructor. Creates a ostream sink. +* @param stream incoming stream reference. +* @param config configuration. +*/ + explicit OutputStreamAppender(Configure *config) : + ::BaseLogger("info") { + auto ostream_sink = std::make_shared( + std::cout); + + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, ostream_sink); + + std::string use_std_err; + + if (NULL != config + && config->get(nifi_log_output_stream_error_stderr, + use_std_err)) { + + std::transform(use_std_err.begin(), use_std_err.end(), + use_std_err.begin(), ::tolower); + + if (use_std_err == "true") { + std::string err_unique_name = + getUniqueName(); + auto error_ostream_sink = std::make_shared< + spdlog::sinks::ostream_sink_mt>(std::cerr); + stderr_ = std::make_shared(err_unique_name, + error_ostream_sink); + } + } else --- End diff -- I did that in a few places apparently... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #57: MINIFI-83: Allow appenders to be specified...
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/57#discussion_r103284177 --- Diff: libminifi/include/LogAppenders.h --- @@ -0,0 +1,292 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ +#define LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ + +#include "BaseLogger.h" +#include "spdlog/sinks/null_sink.h" +#include "spdlog/sinks/ostream_sink.h" +#include +#include "Configure.h" + +template +static std::string getUniqueName() { + std::string name = LOG_NAME; + name += " -- "; + name += abi::__cxa_demangle(typeid(T).name(), 0, 0, 0); + spdlog::drop(name); + return name; +} + +/** + * Null appender sets a null sink, thereby performing no logging. + */ +class NullAppender: public BaseLogger { +public: + /** +* Base constructor that creates the null sink. +*/ + explicit NullAppender() : + ::BaseLogger("off") { + auto null_sink = std::make_shared(); + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, null_sink); + configured_level_ = off; + setLogLevel(); + } + + /** +* Move constructor for the null appender. +*/ + explicit NullAppender(const NullAppender &) : + ::BaseLogger(std::move(other)) { + + } + +}; + +/** + * Basic output stream configuration that uses a supplied ostream + * + * Design : extends LoggerConfiguration using the logger and log level + * encapsulated within the base configuration class. + */ +class OutputStreamAppender: public BaseLogger { + +public: + + static const char *nifi_log_output_stream_error_stderr; + + /** +* Output stream move constructor. +*/ + explicit OutputStreamAppender(const OutputStreamAppender &) : + ::BaseLogger(std::move(other)) { + + } + + /** +* Base constructor. Creates a ostream sink. +* @param stream incoming stream reference. +* @param config configuration. +*/ + explicit OutputStreamAppender(Configure *config) : + ::BaseLogger("info") { + auto ostream_sink = std::make_shared( + std::cout); + + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, ostream_sink); + + std::string use_std_err; + + if (NULL != config + && config->get(nifi_log_output_stream_error_stderr, + use_std_err)) { + + std::transform(use_std_err.begin(), use_std_err.end(), + use_std_err.begin(), ::tolower); + + if (use_std_err == "true") { + std::string err_unique_name = + getUniqueName(); + auto error_ostream_sink = std::make_shared< + spdlog::sinks::ostream_sink_mt>(std::cerr); + stderr_ = std::make_shared(err_unique_name, + error_ostream_sink); + } + } else --- End diff -- Good catch, thanks. I'll update this when you're finished commenting so I don't make your life harder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #57: MINIFI-83: Allow appenders to be specified...
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/57#discussion_r103283615 --- Diff: libminifi/include/LogAppenders.h --- @@ -0,0 +1,292 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ +#define LIBMINIFI_INCLUDE_LOGAPPENDERS_H_ + +#include "BaseLogger.h" +#include "spdlog/sinks/null_sink.h" +#include "spdlog/sinks/ostream_sink.h" +#include +#include "Configure.h" + +template +static std::string getUniqueName() { + std::string name = LOG_NAME; + name += " -- "; + name += abi::__cxa_demangle(typeid(T).name(), 0, 0, 0); + spdlog::drop(name); + return name; +} + +/** + * Null appender sets a null sink, thereby performing no logging. + */ +class NullAppender: public BaseLogger { +public: + /** +* Base constructor that creates the null sink. +*/ + explicit NullAppender() : + ::BaseLogger("off") { + auto null_sink = std::make_shared(); + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, null_sink); + configured_level_ = off; + setLogLevel(); + } + + /** +* Move constructor for the null appender. +*/ + explicit NullAppender(const NullAppender &) : + ::BaseLogger(std::move(other)) { + + } + +}; + +/** + * Basic output stream configuration that uses a supplied ostream + * + * Design : extends LoggerConfiguration using the logger and log level + * encapsulated within the base configuration class. + */ +class OutputStreamAppender: public BaseLogger { + +public: + + static const char *nifi_log_output_stream_error_stderr; + + /** +* Output stream move constructor. +*/ + explicit OutputStreamAppender(const OutputStreamAppender &) : + ::BaseLogger(std::move(other)) { + + } + + /** +* Base constructor. Creates a ostream sink. +* @param stream incoming stream reference. +* @param config configuration. +*/ + explicit OutputStreamAppender(Configure *config) : + ::BaseLogger("info") { + auto ostream_sink = std::make_shared( + std::cout); + + std::string unique_name = getUniqueName(); + logger_ = std::make_shared(unique_name, ostream_sink); + + std::string use_std_err; + + if (NULL != config + && config->get(nifi_log_output_stream_error_stderr, + use_std_err)) { + + std::transform(use_std_err.begin(), use_std_err.end(), + use_std_err.begin(), ::tolower); + + if (use_std_err == "true") { + std::string err_unique_name = + getUniqueName(); + auto error_ostream_sink = std::make_shared< + spdlog::sinks::ostream_sink_mt>(std::cerr); + stderr_ = std::make_shared(err_unique_name, + error_ostream_sink); + } + } else --- End diff -- minor: believe we should make use of braces around else clause as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3490) TLS Toolkit - define SAN in standalone mode
[ https://issues.apache.org/jira/browse/NIFI-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886287#comment-15886287 ] ASF GitHub Bot commented on NIFI-3490: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1530 That's a good point; not every flag needs a short code. SANs, while useful, are definitely less common than some of the other features of the toolkit. > TLS Toolkit - define SAN in standalone mode > --- > > Key: NIFI-3490 > URL: https://issues.apache.org/jira/browse/NIFI-3490 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > Labels: tls-toolkit > Fix For: 1.2.0 > > > Following NIFI-3331, it would be useful to have the same option (add Subject > Alternative Names in certificates) when using the TLS toolkit in standalone > mode. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1530: NIFI-3490 added SAN option for TLS toolkit in standalone m...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1530 That's a good point; not every flag needs a short code. SANs, while useful, are definitely less common than some of the other features of the toolkit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2613) Support extracting content from Microsoft Excel (.xlxs) documents
[ https://issues.apache.org/jira/browse/NIFI-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886269#comment-15886269 ] ASF GitHub Bot commented on NIFI-2613: -- Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64, I am still having trouble with the root `pom.xml` file. The version number is still `1.0.0-SNAPSHOT` [on line 1006](https://github.com/apache/nifi/pull/929/files/474a08eda8497d47468e511e3642766995dad62a#diff-600376dffeb79835ede4a0b285078036). The commit you referenced above did correct version numbers in the nifi-poi-bundle project, but not the root NiFi project POM. How are you testing the build and the build output? I have experienced two scenarios: 1.) **Clean System** - Build fails at nifi-assembly, because the root pom.xml specifies nifi-poi-nar 1.0.0-SNAPSHOT, which is not in the local Maven repository: > [ERROR] Failed to execute goal on project nifi-assembly: Could not resolve dependencies for project org.apache.nifi:nifi-assembly:pom:1.2.0-SNAPSHOT: Could not find artifact org.apache.nifi:nifi-poi-nar:nar:1.0.0-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) 2.) **Reused System** - Build succeeds because the older nifi-poi-nar-1.0.0-SNAPSHOT.nar still exists in the local Maven repository, but the output assembly files contain nifi-poi-nar-1.0.0-SNAPSHOT.nar. In neither case do I get the lastest NAR output. Would you please try deleting the contents of `~/.m2/repository/org/apache/nifi/nifi-poi*` and running a full `mvn clean install`? > Support extracting content from Microsoft Excel (.xlxs) documents > - > > Key: NIFI-2613 > URL: https://issues.apache.org/jira/browse/NIFI-2613 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Jeremy Dyer >Assignee: Jeremy Dyer > > Microsoft Excel is a wildly popular application that businesses rely heavily > on to store, visualize, and calculate data. Any single company most likely > has thousands of Excel documents containing data that could be very valuable > if ingested via NiFi and combined with other datasources. Apache POI is a > popular 100% Java library for parsing several Microsoft document formats > including Excel. Apache POI is extremely flexible and can do several things. > This issue would focus solely on using Apache POI to parse an incoming .xlxs > document and convert it to CSV. The processor should be capable of limiting > which excel sheets. CSV seems like the natural choice for outputting each row > since this feature is already available in Excel and feels very natural to > most Excel sheet designs. > This capability should most likely introduce a new "poi" module as I envision > many more capabilities around parsing Microsoft documents could come from > this base effort. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64, I am still having trouble with the root `pom.xml` file. The version number is still `1.0.0-SNAPSHOT` [on line 1006](https://github.com/apache/nifi/pull/929/files/474a08eda8497d47468e511e3642766995dad62a#diff-600376dffeb79835ede4a0b285078036). The commit you referenced above did correct version numbers in the nifi-poi-bundle project, but not the root NiFi project POM. How are you testing the build and the build output? I have experienced two scenarios: 1.) **Clean System** - Build fails at nifi-assembly, because the root pom.xml specifies nifi-poi-nar 1.0.0-SNAPSHOT, which is not in the local Maven repository: > [ERROR] Failed to execute goal on project nifi-assembly: Could not resolve dependencies for project org.apache.nifi:nifi-assembly:pom:1.2.0-SNAPSHOT: Could not find artifact org.apache.nifi:nifi-poi-nar:nar:1.0.0-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) 2.) **Reused System** - Build succeeds because the older nifi-poi-nar-1.0.0-SNAPSHOT.nar still exists in the local Maven repository, but the output assembly files contain nifi-poi-nar-1.0.0-SNAPSHOT.nar. In neither case do I get the lastest NAR output. Would you please try deleting the contents of `~/.m2/repository/org/apache/nifi/nifi-poi*` and running a full `mvn clean install`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886261#comment-15886261 ] ASF GitHub Bot commented on NIFI-3465: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1545 Thanks @scottyaslan. This has been merged to master. > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Fix For: 1.2.0 > > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886262#comment-15886262 ] ASF GitHub Bot commented on NIFI-3465: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1545 > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Fix For: 1.2.0 > > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1545: [NIFI-3465] change CS and RT warning tooltip viewpo...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886260#comment-15886260 ] ASF subversion and git services commented on NIFI-3465: --- Commit 1978c986b532d0869c3398eb1018514ba9b8de24 in nifi's branch refs/heads/master from [~scottyaslan] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1978c98 ] [NIFI-3465] change CS and RT warning tooltip viewports to a visible and connected DOM element. This closes #1545 > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1545: [NIFI-3465] change CS and RT warning tooltip viewports to ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1545 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886242#comment-15886242 ] ASF GitHub Bot commented on NIFI-3465: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1545 Will review... > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1545: [NIFI-3465] change CS and RT warning tooltip viewports to ...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1545 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-3465: -- Status: Patch Available (was: In Progress) > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886227#comment-15886227 ] ASF GitHub Bot commented on NIFI-3465: -- GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1545 [NIFI-3465] change CS and RT warning tooltip viewports to a visible a… …nd connected DOM element. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-3465 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1545.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1545 commit 5738ad26d671b865d9fc54dc6eddef9530627267 Author: Scott AslanDate: 2017-02-27T17:59:33Z [NIFI-3465] change CS and RT warning tooltip viewports to a visible and connected DOM element. > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1545: [NIFI-3465] change CS and RT warning tooltip viewpo...
GitHub user scottyaslan opened a pull request: https://github.com/apache/nifi/pull/1545 [NIFI-3465] change CS and RT warning tooltip viewports to a visible a⦠â¦nd connected DOM element. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/scottyaslan/nifi NIFI-3465 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1545.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1545 commit 5738ad26d671b865d9fc54dc6eddef9530627267 Author: Scott AslanDate: 2017-02-27T17:59:33Z [NIFI-3465] change CS and RT warning tooltip viewports to a visible and connected DOM element. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886222#comment-15886222 ] Scott Aslan commented on NIFI-3465: --- This is indeed an issue caused by the jQuery upgrade. The upgrade guide states: When using the .offset() method, the first item in the jQuery collection must be a DOM element that has a DOM getBoundingClientRect() method. (All browsers supported by jQuery 3.0 have this API.) Any other input may result in jQuery throwing an error. Also note that the element must be visible and currently in a document (i.e., not disconnected). For the qtip2 tooltip in question we are setting the viewport: $(window) which does not meet the criteria outlined in the jQuery upgrade guide. I believe we can simply change the viewport for this tooltip to be $('#shell-container')... One other note: while the tooltips do seem to be functioning properly (aside from the issue stated here) it should be noted that the qtip2 docs state that: "qTip2 requires jQuery 1.6 and up, and is also compatible with the new jQuery 2.x releases." and do not mention support for jQuery 3.x... > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (NIFI-3465) Controller Services Validation Tooltips Not Working
[ https://issues.apache.org/jira/browse/NIFI-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-3465: - Assignee: Scott Aslan > Controller Services Validation Tooltips Not Working > --- > > Key: NIFI-3465 > URL: https://issues.apache.org/jira/browse/NIFI-3465 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.2.0 >Reporter: James Wing >Assignee: Scott Aslan > Attachments: nifi-controller-service-validation-tooltip-small.png > > > The tooltips for Controller Services validation errors are not working in > recent master builds. Repro steps: > # Open the Process Group Configuration dialog > # Select the Controller Services tab > # Add a new Controller Service > # Select AWSCredentialsProviderControllerService and click Add > # Make it invalid, for example: > #* Edit the AWSCredentialsProviderControllerService > #* In Properties, type something into the Access Key field - "foo" > #* Click Apply to save and close > #* Service should now be invalid > # Hover over the validation warning icon in the left column > I believe the problem was introduced with the jQuery upgrade in > [6170f64|https://github.com/apache/nifi/commit/6170f6442ed45dd084617cb4f39085640f49ebc5], > but I'm not good enough with the UI to tell how it's broken. > There is a workaround - validation errors are coming from the server, and you > can see them in the network section of the browser dev tools. > !nifi-controller-service-validation-tooltip-small.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (NIFI-3439) Making password property in HiveConnectionPool a hidden show.
[ https://issues.apache.org/jira/browse/NIFI-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-3439: - Assignee: Scott Aslan > Making password property in HiveConnectionPool a hidden show. > - > > Key: NIFI-3439 > URL: https://issues.apache.org/jira/browse/NIFI-3439 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.1.1 > Environment: Google Chrome browser >Reporter: Ramakrishnan V >Assignee: Scott Aslan >Priority: Minor > Labels: ControllerService, Hive, security > Original Estimate: 168h > Remaining Estimate: 168h > > When user types the password in the password attribute in hive connection > pool controller service, the characters are visible. Once completed the > password is encrypted and no longer visible. > shouldn't be me made as normal hidden show password box ? > The user always has the option to delete the controller service and > re-configure if he has entered a wrong password. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (NIFI-3527) ExecuteScript body editor is not multiline and does not accept ctrl+enter
[ https://issues.apache.org/jira/browse/NIFI-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFI-3527. --- Resolution: Duplicate Issue was resolved with this commit: https://github.com/apache/nifi/commit/2c374bafaa34f48810717455bc36a7ad0ad9b4b9#diff-2fa2433de363e809b5d143bd30627916R127 > ExecuteScript body editor is not multiline and does not accept ctrl+enter > - > > Key: NIFI-3527 > URL: https://issues.apache.org/jira/browse/NIFI-3527 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.1.1 >Reporter: dmitry zakharov >Assignee: Scott Aslan > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (NIFI-3527) ExecuteScript body editor is not multiline and does not accept ctrl+enter
[ https://issues.apache.org/jira/browse/NIFI-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-3527: - Assignee: Scott Aslan > ExecuteScript body editor is not multiline and does not accept ctrl+enter > - > > Key: NIFI-3527 > URL: https://issues.apache.org/jira/browse/NIFI-3527 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.1.1 >Reporter: dmitry zakharov >Assignee: Scott Aslan > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3490) TLS Toolkit - define SAN in standalone mode
[ https://issues.apache.org/jira/browse/NIFI-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886135#comment-15886135 ] ASF GitHub Bot commented on NIFI-3490: -- Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1530 I agree that changing flags is likely to cause confusion although since we haven't had a release yet, I would hope it would be minimal impact. Consistency across modes of operation will help reduce surprise which is always a good thing. Do we expect this to be something most users specify or is it a more advanced usecase? If it's more advanced and less common then a short version of the argument may not be necessary. > TLS Toolkit - define SAN in standalone mode > --- > > Key: NIFI-3490 > URL: https://issues.apache.org/jira/browse/NIFI-3490 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > Labels: tls-toolkit > Fix For: 1.2.0 > > > Following NIFI-3331, it would be useful to have the same option (add Subject > Alternative Names in certificates) when using the TLS toolkit in standalone > mode. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1530: NIFI-3490 added SAN option for TLS toolkit in standalone m...
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/1530 I agree that changing flags is likely to cause confusion although since we haven't had a release yet, I would hope it would be minimal impact. Consistency across modes of operation will help reduce surprise which is always a good thing. Do we expect this to be something most users specify or is it a more advanced usecase? If it's more advanced and less common then a short version of the argument may not be necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2613) Support extracting content from Microsoft Excel (.xlxs) documents
[ https://issues.apache.org/jira/browse/NIFI-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886102#comment-15886102 ] ASF GitHub Bot commented on NIFI-2613: -- Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64 Thanks for the update. I'll look into why I'm seeing the POM issue. Don't worry about squashing, I'll take care of that when we're ready to merge. > Support extracting content from Microsoft Excel (.xlxs) documents > - > > Key: NIFI-2613 > URL: https://issues.apache.org/jira/browse/NIFI-2613 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Jeremy Dyer >Assignee: Jeremy Dyer > > Microsoft Excel is a wildly popular application that businesses rely heavily > on to store, visualize, and calculate data. Any single company most likely > has thousands of Excel documents containing data that could be very valuable > if ingested via NiFi and combined with other datasources. Apache POI is a > popular 100% Java library for parsing several Microsoft document formats > including Excel. Apache POI is extremely flexible and can do several things. > This issue would focus solely on using Apache POI to parse an incoming .xlxs > document and convert it to CSV. The processor should be capable of limiting > which excel sheets. CSV seems like the natural choice for outputting each row > since this feature is already available in Excel and feels very natural to > most Excel sheet designs. > This capability should most likely introduce a new "poi" module as I envision > many more capabilities around parsing Microsoft documents could come from > this base effort. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64 Thanks for the update. I'll look into why I'm seeing the POM issue. Don't worry about squashing, I'll take care of that when we're ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #57: MINIFI-83: Allow appenders to be specified and au...
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/57 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3490) TLS Toolkit - define SAN in standalone mode
[ https://issues.apache.org/jira/browse/NIFI-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886037#comment-15886037 ] ASF GitHub Bot commented on NIFI-3490: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1530 In general I would push to keep the flags consistent across client/server and standalone mode. On the other hand, I am hesitant to change a flag that already exists in the wild (although, it was just committed to master; it's not in a release yet). I guess talking through that to myself, I would vote for "change the client/server flag to be consistent with standalone" but I would also welcome input from @brosander and @joewitt . > TLS Toolkit - define SAN in standalone mode > --- > > Key: NIFI-3490 > URL: https://issues.apache.org/jira/browse/NIFI-3490 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Minor > Labels: tls-toolkit > Fix For: 1.2.0 > > > Following NIFI-3331, it would be useful to have the same option (add Subject > Alternative Names in certificates) when using the TLS toolkit in standalone > mode. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1530: NIFI-3490 added SAN option for TLS toolkit in standalone m...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1530 In general I would push to keep the flags consistent across client/server and standalone mode. On the other hand, I am hesitant to change a flag that already exists in the wild (although, it was just committed to master; it's not in a release yet). I guess talking through that to myself, I would vote for "change the client/server flag to be consistent with standalone" but I would also welcome input from @brosander and @joewitt . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2941) Clicking the relationship name should toggle the checkbox status in processor settings
[ https://issues.apache.org/jira/browse/NIFI-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886021#comment-15886021 ] ASF GitHub Bot commented on NIFI-2941: -- Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/1538 :) > Clicking the relationship name should toggle the checkbox status in processor > settings > -- > > Key: NIFI-2941 > URL: https://issues.apache.org/jira/browse/NIFI-2941 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Andy LoPresto >Assignee: Scott Aslan >Priority: Trivial > Labels: beginner, ui > Fix For: 1.2.0 > > > When configuring a processor, the available relationships > ({{success}}/{{failure}}, {{matched}}/{{unmatched}}, dynamic relationships) > can be selected to auto-terminate. However, clicking the label does not > toggle the appropriate checkbox. Only clicks within the checkbox are > recognized. To improve the user experience, I suggest increasing the target > area to include the labels as many web forms do. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1538: [NIFI-2941] allow users to click checkbox labels to toggle...
Github user scottyaslan commented on the issue: https://github.com/apache/nifi/pull/1538 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2941) Clicking the relationship name should toggle the checkbox status in processor settings
[ https://issues.apache.org/jira/browse/NIFI-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886020#comment-15886020 ] ASF GitHub Bot commented on NIFI-2941: -- Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1538 Thanks @scottyaslan . This is very useful. > Clicking the relationship name should toggle the checkbox status in processor > settings > -- > > Key: NIFI-2941 > URL: https://issues.apache.org/jira/browse/NIFI-2941 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Andy LoPresto >Assignee: Scott Aslan >Priority: Trivial > Labels: beginner, ui > Fix For: 1.2.0 > > > When configuring a processor, the available relationships > ({{success}}/{{failure}}, {{matched}}/{{unmatched}}, dynamic relationships) > can be selected to auto-terminate. However, clicking the label does not > toggle the appropriate checkbox. Only clicks within the checkbox are > recognized. To improve the user experience, I suggest increasing the target > area to include the labels as many web forms do. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1538: [NIFI-2941] allow users to click checkbox labels to toggle...
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/1538 Thanks @scottyaslan . This is very useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...
Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/929 @jvwing the ```ConvertAvroToParquet``` had slipped my mind thanks for the reminder there. The POM references had been fixed in a previous fix at https://github.com/apache/nifi/pull/929/commits/474a08eda8497d47468e511e3642766995dad62a#diff-e7171c7f07ed58f51e4643dc340432f8R22 I'm unsure what your preference for reviewing is but let me know if this is getting to the point where you would like for me to squash the commits or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2613) Support extracting content from Microsoft Excel (.xlxs) documents
[ https://issues.apache.org/jira/browse/NIFI-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885911#comment-15885911 ] ASF GitHub Bot commented on NIFI-2613: -- Github user jdye64 commented on the issue: https://github.com/apache/nifi/pull/929 @jvwing the ```ConvertAvroToParquet``` had slipped my mind thanks for the reminder there. The POM references had been fixed in a previous fix at https://github.com/apache/nifi/pull/929/commits/474a08eda8497d47468e511e3642766995dad62a#diff-e7171c7f07ed58f51e4643dc340432f8R22 I'm unsure what your preference for reviewing is but let me know if this is getting to the point where you would like for me to squash the commits or not. > Support extracting content from Microsoft Excel (.xlxs) documents > - > > Key: NIFI-2613 > URL: https://issues.apache.org/jira/browse/NIFI-2613 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Jeremy Dyer >Assignee: Jeremy Dyer > > Microsoft Excel is a wildly popular application that businesses rely heavily > on to store, visualize, and calculate data. Any single company most likely > has thousands of Excel documents containing data that could be very valuable > if ingested via NiFi and combined with other datasources. Apache POI is a > popular 100% Java library for parsing several Microsoft document formats > including Excel. Apache POI is extremely flexible and can do several things. > This issue would focus solely on using Apache POI to parse an incoming .xlxs > document and convert it to CSV. The processor should be capable of limiting > which excel sheets. CSV seems like the natural choice for outputting each row > since this feature is already available in Excel and feels very natural to > most Excel sheet designs. > This capability should most likely introduce a new "poi" module as I envision > many more capabilities around parsing Microsoft documents could come from > this base effort. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi-minifi-cpp issue #59: MINIFI-224 - fixes for locating ZLIB on Ubuntu 16...
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/59 Hey @jdye64, I was unable to recreate this using the Ubuntu 16.10 Docker image before patch. Could you specify some additional information concerning the environment that triggered it? Additionally, it looks like there was a build issue https://s3.amazonaws.com/archive.travis-ci.org/jobs/205337185/log.txt in Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (NIFI-2941) Clicking the relationship name should toggle the checkbox status in processor settings
[ https://issues.apache.org/jira/browse/NIFI-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-2941: -- Resolution: Fixed Fix Version/s: 1.2.0 Status: Resolved (was: Patch Available) > Clicking the relationship name should toggle the checkbox status in processor > settings > -- > > Key: NIFI-2941 > URL: https://issues.apache.org/jira/browse/NIFI-2941 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Andy LoPresto >Assignee: Scott Aslan >Priority: Trivial > Labels: beginner, ui > Fix For: 1.2.0 > > > When configuring a processor, the available relationships > ({{success}}/{{failure}}, {{matched}}/{{unmatched}}, dynamic relationships) > can be selected to auto-terminate. However, clicking the label does not > toggle the appropriate checkbox. Only clicks within the checkbox are > recognized. To improve the user experience, I suggest increasing the target > area to include the labels as many web forms do. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1538: [NIFI-2941] allow users to click checkbox labels to toggle...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1538 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2941) Clicking the relationship name should toggle the checkbox status in processor settings
[ https://issues.apache.org/jira/browse/NIFI-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885897#comment-15885897 ] ASF GitHub Bot commented on NIFI-2941: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1538 Thanks @scottyaslan. This has been merged to master. > Clicking the relationship name should toggle the checkbox status in processor > settings > -- > > Key: NIFI-2941 > URL: https://issues.apache.org/jira/browse/NIFI-2941 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Andy LoPresto >Assignee: Scott Aslan >Priority: Trivial > Labels: beginner, ui > > When configuring a processor, the available relationships > ({{success}}/{{failure}}, {{matched}}/{{unmatched}}, dynamic relationships) > can be selected to auto-terminate. However, clicking the label does not > toggle the appropriate checkbox. Only clicks within the checkbox are > recognized. To improve the user experience, I suggest increasing the target > area to include the labels as many web forms do. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-2941) Clicking the relationship name should toggle the checkbox status in processor settings
[ https://issues.apache.org/jira/browse/NIFI-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885894#comment-15885894 ] ASF subversion and git services commented on NIFI-2941: --- Commit d98426cc3d15ea6b506c2d3173e0ce5d8a4b5565 in nifi's branch refs/heads/master from [~scottyaslan] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=d98426c ] [NIFI-2941] allow users to click checkbox labels to toggle the checkbox. This closes #1538 > Clicking the relationship name should toggle the checkbox status in processor > settings > -- > > Key: NIFI-2941 > URL: https://issues.apache.org/jira/browse/NIFI-2941 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Andy LoPresto >Assignee: Scott Aslan >Priority: Trivial > Labels: beginner, ui > > When configuring a processor, the available relationships > ({{success}}/{{failure}}, {{matched}}/{{unmatched}}, dynamic relationships) > can be selected to auto-terminate. However, clicking the label does not > toggle the appropriate checkbox. Only clicks within the checkbox are > recognized. To improve the user experience, I suggest increasing the target > area to include the labels as many web forms do. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-2941) Clicking the relationship name should toggle the checkbox status in processor settings
[ https://issues.apache.org/jira/browse/NIFI-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885896#comment-15885896 ] ASF GitHub Bot commented on NIFI-2941: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1538 > Clicking the relationship name should toggle the checkbox status in processor > settings > -- > > Key: NIFI-2941 > URL: https://issues.apache.org/jira/browse/NIFI-2941 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Andy LoPresto >Assignee: Scott Aslan >Priority: Trivial > Labels: beginner, ui > > When configuring a processor, the available relationships > ({{success}}/{{failure}}, {{matched}}/{{unmatched}}, dynamic relationships) > can be selected to auto-terminate. However, clicking the label does not > toggle the appropriate checkbox. Only clicks within the checkbox are > recognized. To improve the user experience, I suggest increasing the target > area to include the labels as many web forms do. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi pull request #1538: [NIFI-2941] allow users to click checkbox labels to...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2891) The last tab selected/edited should be remembered when configuring a connection
[ https://issues.apache.org/jira/browse/NIFI-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885853#comment-15885853 ] ASF GitHub Bot commented on NIFI-2891: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1535 > The last tab selected/edited should be remembered when configuring a > connection > --- > > Key: NIFI-2891 > URL: https://issues.apache.org/jira/browse/NIFI-2891 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0, 0.7.0 >Reporter: Andrew Lim >Assignee: Scott Aslan >Priority: Trivial > Fix For: 1.2.0 > > > When you configure a processor, the Configure Processor window opens with the > tab that was most recently selected. > This same behavior should occur when configuring a connection. For example, > if a user changes the back pressure settings on a connection, the next > Configuration Connection dialog should open with the Settings tab selected. > The current behavior is that the Details tab is always the default. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-2891) The last tab selected/edited should be remembered when configuring a connection
[ https://issues.apache.org/jira/browse/NIFI-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885852#comment-15885852 ] ASF GitHub Bot commented on NIFI-2891: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1535 Thanks @scottyaslan. This has been merged to master. > The last tab selected/edited should be remembered when configuring a > connection > --- > > Key: NIFI-2891 > URL: https://issues.apache.org/jira/browse/NIFI-2891 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0, 0.7.0 >Reporter: Andrew Lim >Assignee: Scott Aslan >Priority: Trivial > Fix For: 1.2.0 > > > When you configure a processor, the Configure Processor window opens with the > tab that was most recently selected. > This same behavior should occur when configuring a connection. For example, > if a user changes the back pressure settings on a connection, the next > Configuration Connection dialog should open with the Settings tab selected. > The current behavior is that the Details tab is always the default. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (NIFI-2891) The last tab selected/edited should be remembered when configuring a connection
[ https://issues.apache.org/jira/browse/NIFI-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-2891: -- Resolution: Fixed Fix Version/s: 1.2.0 Status: Resolved (was: Patch Available) > The last tab selected/edited should be remembered when configuring a > connection > --- > > Key: NIFI-2891 > URL: https://issues.apache.org/jira/browse/NIFI-2891 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0, 0.7.0 >Reporter: Andrew Lim >Assignee: Scott Aslan >Priority: Trivial > Fix For: 1.2.0 > > > When you configure a processor, the Configure Processor window opens with the > tab that was most recently selected. > This same behavior should occur when configuring a connection. For example, > if a user changes the back pressure settings on a connection, the next > Configuration Connection dialog should open with the Settings tab selected. > The current behavior is that the Details tab is always the default. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1535: [NIFI-2891] persist selected tab for connection configurat...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1535 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1535: [NIFI-2891] persist selected tab for connection con...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-2891) The last tab selected/edited should be remembered when configuring a connection
[ https://issues.apache.org/jira/browse/NIFI-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885851#comment-15885851 ] ASF subversion and git services commented on NIFI-2891: --- Commit a76641b252a6fdb9e7c80611089c71d9bd065042 in nifi's branch refs/heads/master from [~scottyaslan] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=a76641b ] [NIFI-2891] persist selected tab for connection configuration dialog, except for when creating a new connection the dialog will open with the details tab visible since users will need to select a connection relationship. This closes #1535 > The last tab selected/edited should be remembered when configuring a > connection > --- > > Key: NIFI-2891 > URL: https://issues.apache.org/jira/browse/NIFI-2891 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0, 0.7.0 >Reporter: Andrew Lim >Assignee: Scott Aslan >Priority: Trivial > > When you configure a processor, the Configure Processor window opens with the > tab that was most recently selected. > This same behavior should occur when configuring a connection. For example, > if a user changes the back pressure settings on a connection, the next > Configuration Connection dialog should open with the Settings tab selected. > The current behavior is that the Details tab is always the default. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-2891) The last tab selected/edited should be remembered when configuring a connection
[ https://issues.apache.org/jira/browse/NIFI-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885817#comment-15885817 ] ASF GitHub Bot commented on NIFI-2891: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1535 Will review... > The last tab selected/edited should be remembered when configuring a > connection > --- > > Key: NIFI-2891 > URL: https://issues.apache.org/jira/browse/NIFI-2891 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0, 0.7.0 >Reporter: Andrew Lim >Assignee: Scott Aslan >Priority: Trivial > > When you configure a processor, the Configure Processor window opens with the > tab that was most recently selected. > This same behavior should occur when configuring a connection. For example, > if a user changes the back pressure settings on a connection, the next > Configuration Connection dialog should open with the Settings tab selected. > The current behavior is that the Details tab is always the default. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3038) Update layout of Cluster Summary window
[ https://issues.apache.org/jira/browse/NIFI-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885815#comment-15885815 ] ASF GitHub Bot commented on NIFI-3038: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1534 Couple quick comments... - The cluster summary dialogs for the other types of components should probably be updated as well. - With the new layout, we can probably remove some of the width restrictions (or at least increase the values). > Update layout of Cluster Summary window > --- > > Key: NIFI-3038 > URL: https://issues.apache.org/jira/browse/NIFI-3038 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Rob Moran >Assignee: Scott Aslan >Priority: Minor > > To make the Cluster Summary window more consistent with other > areas of the application, move the selected component details to align left > and move the refresh action and timestamp to the bottom left (below the > table). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1535: [NIFI-2891] persist selected tab for connection configurat...
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1535 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1534: [NIFI-3038] Update cluster summary dialog layout
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1534 Couple quick comments... - The cluster summary dialogs for the other types of components should probably be updated as well. - With the new layout, we can probably remove some of the width restrictions (or at least increase the values). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3038) Update layout of Cluster Summary window
[ https://issues.apache.org/jira/browse/NIFI-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885797#comment-15885797 ] ASF GitHub Bot commented on NIFI-3038: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1534 Will review... > Update layout of Cluster Summary window > --- > > Key: NIFI-3038 > URL: https://issues.apache.org/jira/browse/NIFI-3038 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.0.0 >Reporter: Rob Moran >Assignee: Scott Aslan >Priority: Minor > > To make the Cluster Summary window more consistent with other > areas of the application, move the selected component details to align left > and move the refresh action and timestamp to the bottom left (below the > table). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1534: [NIFI-3038] Update cluster summary dialog layout
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1534 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3268) Add AUTO_INCREMENT column in GenerateTableFetch to benefit index
[ https://issues.apache.org/jira/browse/NIFI-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885695#comment-15885695 ] ASF GitHub Bot commented on NIFI-3268: -- Github user qfdk commented on the issue: https://github.com/apache/nifi/pull/1376 @ijokarumawak yes you are right, It's my post :) Because the **new master** can't passer travis-ci. I tried to compile it with travis-ci so i committed several updates to launch travis-ci job :( > Add AUTO_INCREMENT column in GenerateTableFetch to benefit index > > > Key: NIFI-3268 > URL: https://issues.apache.org/jira/browse/NIFI-3268 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.1.1 > Environment: - ubuntu 16.04 > - java version "1.8.0_111" > - Java(TM) SE Runtime Environment (build 1.8.0_111-b14) > - Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode) >Reporter: qfdk > Labels: easyfix > Fix For: 1.2.0 > > > I added AUTO_INCREMENT column in GenerateTableFetch to benefit index column > By default this processor uses OFFSET, i have problems with large data. > somme column has index so we could use index to speed up query time. > I posted question here : > https://community.hortonworks.com/questions/72586/how-can-i-use-an-array-with-putelasticsearch.html > If you indexed un column (id), you could use this sql > ``` > select xxx > From x > where 20=>id > order by id > limit 20 > ``` > “OFFSET is bad for skipping previous rows.” [Online]. Available: > http://Use-The-Index-Luke.com/sql/partial-results/fetch-next-page. [Accessed: > 27-Dec-2016]. > Thank you in advance -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...
Github user qfdk commented on the issue: https://github.com/apache/nifi/pull/1376 @ijokarumawak yes you are right, It's my post :) Because the **new master** can't passer travis-ci. I tried to compile it with travis-ci so i committed several updates to launch travis-ci job :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (NIFI-3268) Add AUTO_INCREMENT column in GenerateTableFetch to benefit index
[ https://issues.apache.org/jira/browse/NIFI-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885687#comment-15885687 ] ASF GitHub Bot commented on NIFI-3268: -- Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @patricker Thank you for pointing that out. It can vary among databases. Peter, What RDB do you usually use? @qfdk I thought you're using PostgreSQL by reading the [HCC question](https://community.hortonworks.com/questions/72586/how-can-i-use-an-array-with-putelasticsearch.html) you posted. It would be great if we can review it together to see whether this PR can work with different databases. @qfdk I saw you've committed several updates, is it ready to another review cycle? > Add AUTO_INCREMENT column in GenerateTableFetch to benefit index > > > Key: NIFI-3268 > URL: https://issues.apache.org/jira/browse/NIFI-3268 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.1.1 > Environment: - ubuntu 16.04 > - java version "1.8.0_111" > - Java(TM) SE Runtime Environment (build 1.8.0_111-b14) > - Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode) >Reporter: qfdk > Labels: easyfix > Fix For: 1.2.0 > > > I added AUTO_INCREMENT column in GenerateTableFetch to benefit index column > By default this processor uses OFFSET, i have problems with large data. > somme column has index so we could use index to speed up query time. > I posted question here : > https://community.hortonworks.com/questions/72586/how-can-i-use-an-array-with-putelasticsearch.html > If you indexed un column (id), you could use this sql > ``` > select xxx > From x > where 20=>id > order by id > limit 20 > ``` > “OFFSET is bad for skipping previous rows.” [Online]. Available: > http://Use-The-Index-Luke.com/sql/partial-results/fetch-next-page. [Accessed: > 27-Dec-2016]. > Thank you in advance -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1376 @patricker Thank you for pointing that out. It can vary among databases. Peter, What RDB do you usually use? @qfdk I thought you're using PostgreSQL by reading the [HCC question](https://community.hortonworks.com/questions/72586/how-can-i-use-an-array-with-putelasticsearch.html) you posted. It would be great if we can review it together to see whether this PR can work with different databases. @qfdk I saw you've committed several updates, is it ready to another review cycle? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (NIFI-3534) Add support for impersonating a user with HDFS processors
Andrew Psaltis created NIFI-3534: Summary: Add support for impersonating a user with HDFS processors Key: NIFI-3534 URL: https://issues.apache.org/jira/browse/NIFI-3534 Project: Apache NiFi Issue Type: Bug Reporter: Andrew Psaltis Assignee: Andrew Psaltis When using the HDFS processors, specifically PutHDFS there are times when a user wants to impersonate a user so that the files written to HDFS are done as the remote user. In cases where Kerberos is not used, this is not possible. Currently there is the ability for NiFi to change the permissions using the Remote Owner and Remote Group, however, this only works if NiFi is running as a user that has HDFS super user privilege. By providing the ability to set a Remote User, NiFi can then impersonate the user and the permission checks will be done in Hadoop land. -- This message was sent by Atlassian JIRA (v6.3.15#6346)