[GitHub] nifi issue #2045: NIFI-4250 - Elasticsearch 5 delete processor

2017-08-12 Thread mattyb149 
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2045
  
Makes sense to me, plus once the Extension Registry is in place, that might 
be the right spot for additional delete ES processors etc. I will review this 
for inclusion, thanks in advance!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4250) Create support for deleting document by id from elasticsearch 5

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124757#comment-16124757
 ] 

ASF GitHub Bot commented on NIFI-4250:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2045
  
Makes sense to me, plus once the Extension Registry is in place, that might 
be the right spot for additional delete ES processors etc. I will review this 
for inclusion, thanks in advance!


> Create support for deleting document by id from elasticsearch 5
> ---
>
> Key: NIFI-4250
> URL: https://issues.apache.org/jira/browse/NIFI-4250
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: delete, elasticsearch
>
> Create a processor to delete documents from elasticsearch 5 based on document 
> id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #2045: NIFI-4250 - Elasticsearch 5 delete processor

2017-08-12 Thread mans2singh 
Github user mans2singh commented on the issue:

https://github.com/apache/nifi/pull/2045
  
@mattyb149 

Regarding having a separate delete processor - I prefer single 
responsibility principle since it avoids confusion and mixing up configuration, 
processing logic, error handling, testing, maintenance etc.  Along the same 
lines ElasticSearch provides separate JAVA delete/put/get request builders.  
Besides, overloading put and delete is confusing to me from the REST semantics.

Let me know your thoughts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4250) Create support for deleting document by id from elasticsearch 5

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124743#comment-16124743
 ] 

ASF GitHub Bot commented on NIFI-4250:
--

Github user mans2singh commented on the issue:

https://github.com/apache/nifi/pull/2045
  
@mattyb149 

Regarding having a separate delete processor - I prefer single 
responsibility principle since it avoids confusion and mixing up configuration, 
processing logic, error handling, testing, maintenance etc.  Along the same 
lines ElasticSearch provides separate JAVA delete/put/get request builders.  
Besides, overloading put and delete is confusing to me from the REST semantics.

Let me know your thoughts.


> Create support for deleting document by id from elasticsearch 5
> ---
>
> Key: NIFI-4250
> URL: https://issues.apache.org/jira/browse/NIFI-4250
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: delete, elasticsearch
>
> Create a processor to delete documents from elasticsearch 5 based on document 
> id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4250) Create support for deleting document by id from elasticsearch 5

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124703#comment-16124703
 ] 

ASF GitHub Bot commented on NIFI-4250:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2045
  
Don't worry about the ANTLR stuff, that seems to trip up Travis sometimes. 
I can review this either this weekend or early next week. One quick question is 
whether you think it would be too confusing for the user to just add "delete" 
as an operation to PutElasticsearch(5), it would require doc updates and such. 
I'm just thinking that after one version of a Delete ES processor is available, 
the rest would be desired, requested, and possibly implemented. If that were 
the case, would it be better to have 3 new processors for delete, or to update 
the 3 Put processors to accept delete? I'm not leaning one way or the other, 
I'm interested in your thoughts and others' in order to provide the best user 
experience.


> Create support for deleting document by id from elasticsearch 5
> ---
>
> Key: NIFI-4250
> URL: https://issues.apache.org/jira/browse/NIFI-4250
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: delete, elasticsearch
>
> Create a processor to delete documents from elasticsearch 5 based on document 
> id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #2045: NIFI-4250 - Elasticsearch 5 delete processor

2017-08-12 Thread mattyb149 
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/2045
  
Don't worry about the ANTLR stuff, that seems to trip up Travis sometimes. 
I can review this either this weekend or early next week. One quick question is 
whether you think it would be too confusing for the user to just add "delete" 
as an operation to PutElasticsearch(5), it would require doc updates and such. 
I'm just thinking that after one version of a Delete ES processor is available, 
the rest would be desired, requested, and possibly implemented. If that were 
the case, would it be better to have 3 new processors for delete, or to update 
the 3 Put processors to accept delete? I'm not leaning one way or the other, 
I'm interested in your thoughts and others' in order to provide the best user 
experience.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124635#comment-16124635
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user YolandaMDavis commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2065#discussion_r132821753
  
--- Diff: 
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
 ---
@@ -269,15 +269,23 @@ private String ensureNodeExists(ZooKeeper zooKeeper, 
String path, CreateMode cre
 }
 }
 
-private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode) {
-// For the NiFi use case, all nodes will be migrated to 
CREATOR_ALL_ACL
+private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL) {
+// If useExistingACL is false, for the NiFi use cases, all nodes 
will be migrated to CREATOR_ALL_ACL
 final DataStatAclNode migratedNode = new 
DataStatAclNode(node.getPath(), node.getData(), node.getStat(),
-destinationAuthMode.equals(AuthMode.OPEN) ? 
ZooDefs.Ids.OPEN_ACL_UNSAFE : ZooDefs.Ids.CREATOR_ALL_ACL,
+determineNodeACL(node,destinationAuthMode,useExistingACL),
 node.getEphemeralOwner());
 LOGGER.info("transformed original node {} to {}", node, 
migratedNode);
 return migratedNode;
 }
 
+private List determineNodeACL(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL){
--- End diff --

Sure no problem


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #2065: NIFI-4255 - added flag to allow migration of existi...

2017-08-12 Thread YolandaMDavis 
Github user YolandaMDavis commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2065#discussion_r132821753
  
--- Diff: 
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
 ---
@@ -269,15 +269,23 @@ private String ensureNodeExists(ZooKeeper zooKeeper, 
String path, CreateMode cre
 }
 }
 
-private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode) {
-// For the NiFi use case, all nodes will be migrated to 
CREATOR_ALL_ACL
+private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL) {
+// If useExistingACL is false, for the NiFi use cases, all nodes 
will be migrated to CREATOR_ALL_ACL
 final DataStatAclNode migratedNode = new 
DataStatAclNode(node.getPath(), node.getData(), node.getStat(),
-destinationAuthMode.equals(AuthMode.OPEN) ? 
ZooDefs.Ids.OPEN_ACL_UNSAFE : ZooDefs.Ids.CREATOR_ALL_ACL,
+determineNodeACL(node,destinationAuthMode,useExistingACL),
 node.getEphemeralOwner());
 LOGGER.info("transformed original node {} to {}", node, 
migratedNode);
 return migratedNode;
 }
 
+private List determineNodeACL(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL){
--- End diff --

Sure no problem


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4062) Provide an option to disable DTD validation for EvaluateXPath and EvaluateXQuery

2017-08-12 Thread Joseph Witt (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124626#comment-16124626
 ] 

Joseph Witt commented on NIFI-4062:
---

no problem at all [~arunodhaya80]  you did just fine.  thanks

> Provide an option to disable DTD validation for EvaluateXPath and 
> EvaluateXQuery
> 
>
> Key: NIFI-4062
> URL: https://issues.apache.org/jira/browse/NIFI-4062
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Koji Kawamura
>Assignee: Arun Manivannan
>  Labels: beginner
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document 
> has DOCTYPE definition in it, especially using external DTD. It would be 
> useful if these processor provides a property to disable DTD validation when 
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4062) Provide an option to disable DTD validation for EvaluateXPath and EvaluateXQuery

2017-08-12 Thread Arun Manivannan (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124595#comment-16124595
 ] 

Arun Manivannan commented on NIFI-4062:
---

[~joewitt] Sorry about that.  Will follow through in my subsequent commits.  
This is my first contribution.  Trying hard to fit myself into the process.

> Provide an option to disable DTD validation for EvaluateXPath and 
> EvaluateXQuery
> 
>
> Key: NIFI-4062
> URL: https://issues.apache.org/jira/browse/NIFI-4062
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Koji Kawamura
>Assignee: Arun Manivannan
>  Labels: beginner
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document 
> has DOCTYPE definition in it, especially using external DTD. It would be 
> useful if these processor provides a property to disable DTD validation when 
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4062) Provide an option to disable DTD validation for EvaluateXPath and EvaluateXQuery

2017-08-12 Thread Joseph Witt (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124590#comment-16124590
 ] 

Joseph Witt commented on NIFI-4062:
---

Fix version can be applied when we have review traction nearing a merge.  
Thanks for contributing.

> Provide an option to disable DTD validation for EvaluateXPath and 
> EvaluateXQuery
> 
>
> Key: NIFI-4062
> URL: https://issues.apache.org/jira/browse/NIFI-4062
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Koji Kawamura
>Assignee: Arun Manivannan
>  Labels: beginner
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document 
> has DOCTYPE definition in it, especially using external DTD. It would be 
> useful if these processor provides a property to disable DTD validation when 
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4062) Provide an option to disable DTD validation for EvaluateXPath and EvaluateXQuery

2017-08-12 Thread Joseph Witt (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt updated NIFI-4062:
--
Fix Version/s: (was: 1.4.0)

> Provide an option to disable DTD validation for EvaluateXPath and 
> EvaluateXQuery
> 
>
> Key: NIFI-4062
> URL: https://issues.apache.org/jira/browse/NIFI-4062
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Koji Kawamura
>Assignee: Arun Manivannan
>  Labels: beginner
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document 
> has DOCTYPE definition in it, especially using external DTD. It would be 
> useful if these processor provides a property to disable DTD validation when 
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (NIFI-4062) Provide an option to disable DTD validation for EvaluateXPath and EvaluateXQuery

2017-08-12 Thread Arun Manivannan (JIRA) 

 [ 
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Manivannan updated NIFI-4062:
--
Fix Version/s: 1.4.0
   Status: Patch Available  (was: In Progress)

> Provide an option to disable DTD validation for EvaluateXPath and 
> EvaluateXQuery
> 
>
> Key: NIFI-4062
> URL: https://issues.apache.org/jira/browse/NIFI-4062
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Koji Kawamura
>Assignee: Arun Manivannan
>  Labels: beginner
> Fix For: 1.4.0
>
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document 
> has DOCTYPE definition in it, especially using external DTD. It would be 
> useful if these processor provides a property to disable DTD validation when 
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4255) Add support for providing ACLs for paths in Zookeeper Migration tool

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124582#comment-16124582
 ] 

ASF GitHub Bot commented on NIFI-4255:
--

Github user jtstorck commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2065#discussion_r132818810
  
--- Diff: 
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
 ---
@@ -269,15 +269,23 @@ private String ensureNodeExists(ZooKeeper zooKeeper, 
String path, CreateMode cre
 }
 }
 
-private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode) {
-// For the NiFi use case, all nodes will be migrated to 
CREATOR_ALL_ACL
+private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL) {
+// If useExistingACL is false, for the NiFi use cases, all nodes 
will be migrated to CREATOR_ALL_ACL
 final DataStatAclNode migratedNode = new 
DataStatAclNode(node.getPath(), node.getData(), node.getStat(),
-destinationAuthMode.equals(AuthMode.OPEN) ? 
ZooDefs.Ids.OPEN_ACL_UNSAFE : ZooDefs.Ids.CREATOR_ALL_ACL,
+determineNodeACL(node,destinationAuthMode,useExistingACL),
 node.getEphemeralOwner());
 LOGGER.info("transformed original node {} to {}", node, 
migratedNode);
 return migratedNode;
 }
 
+private List determineNodeACL(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL){
--- End diff --

Rather than having this method get invoked from transformNode, can you do 
this as a stage in the completable future before transformNode is invoked?  I'd 
like to keep all the method coordination controlled by the CompletableFuture 
stages rather than having methods invoke each other.


> Add support for providing ACLs for paths in Zookeeper Migration tool
> 
>
> Key: NIFI-4255
> URL: https://issues.apache.org/jira/browse/NIFI-4255
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.3.0
>Reporter: Yolanda M. Davis
>Assignee: Yolanda M. Davis
>
> Currently in the Zookeeper migration utility there is support for applying 
> acls when importing zookeeper data (Znodes).  However this support only 
> applies default ACLs values (either Open or Creator specific), and the value 
> used depends on if security is enabled or disabled in the destination 
> Zookeeper instance. This may become problematic if the user/identity used to 
> import zookeeper data does not align with the users/identities that require 
> read/modify rights on the imported Znodes. This also doesn't provide users 
> flexibility in defining specific rights or applying additional authorizations 
> on paths.
> Enhancing the existing utility to support providing ACL information would 
> offer users more flexibility in defining permissions and authentication 
> schemes on znodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #2065: NIFI-4255 - added flag to allow migration of existi...

2017-08-12 Thread jtstorck 
Github user jtstorck commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2065#discussion_r132818810
  
--- Diff: 
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
 ---
@@ -269,15 +269,23 @@ private String ensureNodeExists(ZooKeeper zooKeeper, 
String path, CreateMode cre
 }
 }
 
-private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode) {
-// For the NiFi use case, all nodes will be migrated to 
CREATOR_ALL_ACL
+private DataStatAclNode transformNode(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL) {
+// If useExistingACL is false, for the NiFi use cases, all nodes 
will be migrated to CREATOR_ALL_ACL
 final DataStatAclNode migratedNode = new 
DataStatAclNode(node.getPath(), node.getData(), node.getStat(),
-destinationAuthMode.equals(AuthMode.OPEN) ? 
ZooDefs.Ids.OPEN_ACL_UNSAFE : ZooDefs.Ids.CREATOR_ALL_ACL,
+determineNodeACL(node,destinationAuthMode,useExistingACL),
 node.getEphemeralOwner());
 LOGGER.info("transformed original node {} to {}", node, 
migratedNode);
 return migratedNode;
 }
 
+private List determineNodeACL(DataStatAclNode node, AuthMode 
destinationAuthMode, boolean useExistingACL){
--- End diff --

Rather than having this method get invoked from transformNode, can you do 
this as a stage in the completable future before transformNode is invoked?  I'd 
like to keep all the method coordination controlled by the CompletableFuture 
stages rather than having methods invoke each other.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4237) EncryptionOperationNotPossibleException in nifi-bootstrap.log might suggest underlying cause

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124552#comment-16124552
 ] 

ASF GitHub Bot commented on NIFI-4237:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2077
  
I have a *number* of questions about the existing implementation, but those 
will be addressed in NIFI-3116. 


> EncryptionOperationNotPossibleException in nifi-bootstrap.log might suggest 
> underlying cause
> 
>
> Key: NIFI-4237
> URL: https://issues.apache.org/jira/browse/NIFI-4237
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.3.0
>Reporter: Russell Bateman
>Assignee: Andy LoPresto
>Priority: Minor
>  Labels: encryption, logging, security
> Fix For: 1.4.0
>
>
> Our Ansible instructions upgraded NiFi and created a new 
> {{nifi.sensitive.props.key}}. In _nifi.properties_ this property, if extant, 
> is used to encrypt sensitive properties in _flow.xml.gz_. Thus, upon 
> relaunching NiFi, the wrong key was used to decrypt resulting in the reported 
> failure to start, _flow.xml.gz_ is no longer useful.
> We found the problem and fixed it after Mark Payne suggested a possible 
> cause, but if this state of things can be determined, it might save on 
> community support for this situation if the logged message were to suggest 
> what's at the bottom of this problem. The top of the stack trace appears in 
> _logs/nifi-app.log_ as below:
> 2017-07-25 23:23:31,148 WARN [main] org.apache.nifi.web.server.JettyServer
> Failed to start web server... shutting down.
> org.apache.nifi.encrypt.EncryptionException:
> org.jasypt.exceptions.EncryptionOperationNotPossibleException
> at
> org.apache.nifi.encrypt.StringEncryptor.decrypt(StringEncryptor.java:149)
> ~[nifi-framework-core-1.1.2.jar:1.1.2]
> at
> org.apache.nifi.controller.serialization.FlowFromDOMFactory.decrypt(FlowFromDOMFactory.java:474)
> ~[nifi-framework-core-1.1.2.jar:1.1.2]
> at...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #2077: NIFI-4237 Improve error messaging on encryption failures

2017-08-12 Thread alopresto 
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/2077
  
I have a *number* of questions about the existing implementation, but those 
will be addressed in NIFI-3116. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4262) MergeContent - option to add merged uuid in original flow files

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124508#comment-16124508
 ] 

ASF GitHub Bot commented on NIFI-4262:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2056
  
Done, thanks @mattyb149 !


> MergeContent - option to add merged uuid in original flow files
> ---
>
> Key: NIFI-4262
> URL: https://issues.apache.org/jira/browse/NIFI-4262
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>
> With the apparition of Wait/Notify processors it is now possible tackle new 
> challenges when it comes to synchronize the execution of different parts of 
> the workflow.
> The objective here is the following:
> Flow files are sent to a MergeContent processor. Merged flow files are then 
> sent to a processor A while original flow files are sent to a processor B. I 
> want to trigger processor B when and only when processor A has completed.
> To use the Wait/Notify approach, a common attribute must be available to be 
> used as a signal in the distributed cache. This JIRA is about adding a 
> processor property allowing a user to add the UUID of the merged flow file as 
> a new attribute of all the original flow files that are constituting the 
> merged flow file.
> The template attached to NIFI-4028 can be used for this use case. Note that 
> the fix for NIFI-4028 is needed to solve the use case described in this JIRA.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #2056: NIFI-4262 - MergeContent - option to add merged uuid in or...

2017-08-12 Thread pvillard31 
Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2056
  
Done, thanks @mattyb149 !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4062) Provide an option to disable DTD validation for EvaluateXPath and EvaluateXQuery

2017-08-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124484#comment-16124484
 ] 

ASF GitHub Bot commented on NIFI-4062:
--

GitHub user arunma opened a pull request:

https://github.com/apache/nifi/pull/2079

NIFI-4062 Provide an option to disable DTD validation for EvaluateXPa…

…th and EvaluateXQuery

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arunma/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2079


commit d6d131228c6e9c31bae54c3ea9d733c917b1d7ce
Author: Arun Manivannan 
Date:   2017-08-12T05:41:18Z

NIFI-4062 Provide an option to disable DTD validation for EvaluateXPath and 
EvaluateXQuery




> Provide an option to disable DTD validation for EvaluateXPath and 
> EvaluateXQuery
> 
>
> Key: NIFI-4062
> URL: https://issues.apache.org/jira/browse/NIFI-4062
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.0.0
>Reporter: Koji Kawamura
>Assignee: Arun Manivannan
>  Labels: beginner
>
> Currently EvaluateXPath and EvaluateXQuery can fail if the source document 
> has DOCTYPE definition in it, especially using external DTD. It would be 
> useful if these processor provides a property to disable DTD validation when 
> evaluate XPath or XQuery.
> References:
> https://community.hortonworks.com/questions/107121/does-evaluatexpath-support-doctype.html
> https://stackoverflow.com/questions/243728/how-to-disable-dtd-at-runtime-in-javas-xpath



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #2079: NIFI-4062 Provide an option to disable DTD validati...

2017-08-12 Thread arunma 
GitHub user arunma opened a pull request:

https://github.com/apache/nifi/pull/2079

NIFI-4062 Provide an option to disable DTD validation for EvaluateXPa…

…th and EvaluateXQuery

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arunma/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2079


commit d6d131228c6e9c31bae54c3ea9d733c917b1d7ce
Author: Arun Manivannan 
Date:   2017-08-12T05:41:18Z

NIFI-4062 Provide an option to disable DTD validation for EvaluateXPath and 
EvaluateXQuery




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---