date:20180515

[jira] [Updated] (NIFI-4198) *ElasticsearchHttp processors do not expose Proxy settings

2018-05-15 Thread Koji Kawamura (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Koji Kawamura updated NIFI-4198:

   Resolution: Fixed
Fix Version/s: 1.7.0
   Status: Resolved  (was: Patch Available)

> *ElasticsearchHttp processors do not expose Proxy settings
> --
>
> Key: NIFI-4198
> URL: https://issues.apache.org/jira/browse/NIFI-4198
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Andre F de Miranda
>Assignee: Arun Manivannan
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf, 
> NIFI-4198-ElasticProxy.xml
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4198) *ElasticsearchHttp processors do not expose Proxy settings

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476840#comment-16476840
 ] 

ASF GitHub Bot commented on NIFI-4198:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2094


> *ElasticsearchHttp processors do not expose Proxy settings
> --
>
> Key: NIFI-4198
> URL: https://issues.apache.org/jira/browse/NIFI-4198
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Andre F de Miranda
>Assignee: Arun Manivannan
>Priority: Major
> Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf, 
> NIFI-4198-ElasticProxy.xml
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2094: NIFI-4198 *ElasticsearchHttp processors do not expo...

2018-05-15 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2094


---

[jira] [Commented] (NIFI-4198) *ElasticsearchHttp processors do not expose Proxy settings

2018-05-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476838#comment-16476838
 ] 

ASF subversion and git services commented on NIFI-4198:
---

Commit 01a01a3dfc1769988be82b43f1eb8c9340e2e159 in nifi's branch 
refs/heads/master from [~arunmane]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=01a01a3 ]

NIFI-4198 *ElasticsearchHttp processors do not expose Proxy settings

This closes #2094.

Signed-off-by: Koji Kawamura 


> *ElasticsearchHttp processors do not expose Proxy settings
> --
>
> Key: NIFI-4198
> URL: https://issues.apache.org/jira/browse/NIFI-4198
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Andre F de Miranda
>Assignee: Arun Manivannan
>Priority: Major
> Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf, 
> NIFI-4198-ElasticProxy.xml
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4198) *ElasticsearchHttp processors do not expose Proxy settings

2018-05-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476839#comment-16476839
 ] 

ASF subversion and git services commented on NIFI-4198:
---

Commit de1ad3eb6f68d060fc8584d2b1275a295b82078a in nifi's branch 
refs/heads/master from [~ijokarumawak]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=de1ad3e ]

NIFI-4198: ElasticsearchHttp processors Proxy settings

- Added Expression Language support with variable registry at proxy user
and password


> *ElasticsearchHttp processors do not expose Proxy settings
> --
>
> Key: NIFI-4198
> URL: https://issues.apache.org/jira/browse/NIFI-4198
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Andre F de Miranda
>Assignee: Arun Manivannan
>Priority: Major
> Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf, 
> NIFI-4198-ElasticProxy.xml
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4198) *ElasticsearchHttp processors do not expose Proxy settings

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476833#comment-16476833
 ] 

ASF GitHub Bot commented on NIFI-4198:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2094
  
@mattyb149 I was able to use a Proxy server with basic authentication 
without issue. I wonder if your Nginx can be used as a forward proxy. Nginx is 
generally used as a reverse proxy which resides on the server side and routes 
incoming client requests into backend server applications. While forward proxy 
tends to be in the client side network to go through company firewall ... etc.

https://stackoverflow.com/questions/46060028/how-to-use-nginx-as-forward-proxy-for-any-requested-location

@arunma The code LGTM, except, I believe the proxy username/password 
property descriptor should support variable registry EL. I'm going to add EL 
support and merge this. Thanks!


> *ElasticsearchHttp processors do not expose Proxy settings
> --
>
> Key: NIFI-4198
> URL: https://issues.apache.org/jira/browse/NIFI-4198
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Andre F de Miranda
>Assignee: Arun Manivannan
>Priority: Major
> Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf, 
> NIFI-4198-ElasticProxy.xml
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2094: NIFI-4198 *ElasticsearchHttp processors do not expose Prox...

2018-05-15 Thread ijokarumawak

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2094
  
@mattyb149 I was able to use a Proxy server with basic authentication 
without issue. I wonder if your Nginx can be used as a forward proxy. Nginx is 
generally used as a reverse proxy which resides on the server side and routes 
incoming client requests into backend server applications. While forward proxy 
tends to be in the client side network to go through company firewall ... etc.

https://stackoverflow.com/questions/46060028/how-to-use-nginx-as-forward-proxy-for-any-requested-location

@arunma The code LGTM, except, I believe the proxy username/password 
property descriptor should support variable registry EL. I'm going to add EL 
support and merge this. Thanks!


---

[jira] [Commented] (NIFI-4175) Add Proxy Properties to SFTP Processors

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476780#comment-16476780
 ] 

ASF GitHub Bot commented on NIFI-4175:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2018
  
@trixpan Since this PR is really close to get merged, but got inactive, and 
I have another PR tackling the same theme, I have merged your commit into my PR 
in #2704. SOCKS proxy support is also added there. When #2704 is merged 
successfully after being reviewed, this PR will be closed, too.

I hope continuing work at #2704 would be fine for you. Please let me know 
if not the case.

@trixpan @pvillard31 @jugi92 would you please take a look on #2704 and post 
any feedback there, thanks!


> Add Proxy Properties to SFTP Processors
> ---
>
> Key: NIFI-4175
> URL: https://issues.apache.org/jira/browse/NIFI-4175
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Grant Langlois
>Assignee: Andre F de Miranda
>Priority: Minor
>
> Add proxy server configuration as properties to the Nifi SFTP components. 
> Specifically add properties for:
> Proxy Type: JSCH supported proxies including SOCKS4, SOCKS5 and HTTP
> Proxy Host
> Proxy Port
> Proxy Username
> Proxy Password
> This would allow these properties to be configured for each processor. These 
> properties would align with what is configurable for the JSCH session and 
> shouldn't require any additional dependencies.
> This proposal is similar to what is already implemented for the FTP processors



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2018: NIFI-4175 - Add HTTP proxy support to *SFTP processors

2018-05-15 Thread ijokarumawak

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2018
  
@trixpan Since this PR is really close to get merged, but got inactive, and 
I have another PR tackling the same theme, I have merged your commit into my PR 
in #2704. SOCKS proxy support is also added there. When #2704 is merged 
successfully after being reviewed, this PR will be closed, too.

I hope continuing work at #2704 would be fine for you. Please let me know 
if not the case.

@trixpan @pvillard31 @jugi92 would you please take a look on #2704 and post 
any feedback there, thanks!


---

[jira] [Commented] (NIFI-4199) NiFi processors should be able to share proxy settings

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476778#comment-16476778
 ] 

ASF GitHub Bot commented on NIFI-4199:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
Now this PR includes SFTP processors and SOCKS proxy support for SFTP as 
well.


> NiFi processors should be able to share proxy settings
> --
>
> Key: NIFI-4199
> URL: https://issues.apache.org/jira/browse/NIFI-4199
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andre F de Miranda
>Assignee: Koji Kawamura
>Priority: Major
>
> Currently, configuring proxy settings for NiFi processors may be a tedious 
> process that requires the DFM to set proxy settings on individual processors. 
> This leads to:
> * Duplication of work
> * Management overhead (as password must be changed on multiple locations)
> * Lower security (as proxy credentials must be known by "n" DFMs)
> Ideally, NiFi should offer a way to minimise duplication of work by offering 
> a something similar to the Standard SSL Context services. This way, the DFM 
> could set the proxy settings once an all authorised users could tap into 
> those settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-15 Thread ijokarumawak

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
Now this PR includes SFTP processors and SOCKS proxy support for SFTP as 
well.


---

[jira] [Commented] (NIFI-5188) DruidTranquilityController does not fully support Druid aggregator

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476716#comment-16476716
 ] 

ASF GitHub Bot commented on NIFI-5188:
--

Github user dkhwangbo commented on the issue:

https://github.com/apache/nifi/pull/2696
  
@joewitt @pvillard31 @mattyb149 Any ideas?


> DruidTranquilityController does not fully support Druid aggregator
> --
>
> Key: NIFI-5188
> URL: https://issues.apache.org/jira/browse/NIFI-5188
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.6.0
>Reporter: Dongkyu Hwangbo
>Priority: Major
>
> Currently DruidTranquilityController does not fully support Druid aggregator 
> because of some code line hard-codeded in 
> DruidTranquilityController#getAggregatorList.
> {code:java}
> ...
> if (aggregator.get("type").equalsIgnoreCase("count")) {
> aggregatorList.add(getCountAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("doublesum")) {
> aggregatorList.add(getDoubleSumAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("doublemax")) {
> aggregatorList.add(getDoubleMaxAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("doublemin")) {
> aggregatorList.add(getDoubleMinAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("longsum")) {
> aggregatorList.add(getLongSumAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("longmax")) {
> aggregatorList.add(getLongMaxAggregator(aggregator));
> } else if (aggregator.get("type").equalsIgnoreCase("longmin")) {
> aggregatorList.add(getLongMinAggregator(aggregator));
> }
> ...
> {code}
> DruidTranquilityController cannot ingest other Druid aggregator not defined 
> in above like cardinality, hyperUnique, thetaSketch and so on. Full 
> aggregator list is in 
> [here|http://druid.io/docs/0.9.2/querying/aggregations.html]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2696: NIFI-5188: DruidTranquilityController does not fully suppo...

2018-05-15 Thread dkhwangbo

Github user dkhwangbo commented on the issue:

https://github.com/apache/nifi/pull/2696
  
@joewitt @pvillard31 @mattyb149 Any ideas?


---

[jira] [Commented] (NIFI-4407) Non-EL statement processed as expression language

2018-05-15 Thread Ed Berezitsky (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476709#comment-16476709
 ] 

Ed Berezitsky commented on NIFI-4407:
-

[~markap14], [~pvillard],

Not clear whether you guys agreed it is a bug or not :). IMO it's not a bug. 
But issue is still opened...

So, improvement can be made: we can add a property "Evaluate Text" (true/false) 
with default as "true", so it will be backward compatible.

Thoughts?

> Non-EL statement processed as expression language
> -
>
> Key: NIFI-4407
> URL: https://issues.apache.org/jira/browse/NIFI-4407
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.1.1, 1.0.1, 1.3.0
>Reporter: Pierre Villard
>Priority: Critical
>
> If you take a GFF with custom text: {{test$$foo}}
> The generated text will be: {{test$foo}}
> The property supports expression language and one $ is removed during the EL 
> evaluation step. This can be an issue if a user wants to use a value 
> containing to consecutive $$ (such as in password fields).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-15 Thread ijokarumawak

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
@MikeThomsen We can combine ProxyConfigurationService into ES or Solr, the 
CS just let users manage proxy settings in a centralized place. I will take a 
look on #2094 to see how I can help review that one. Thanks.


---

[jira] [Commented] (NIFI-4199) NiFi processors should be able to share proxy settings

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476638#comment-16476638
 ] 

ASF GitHub Bot commented on NIFI-4199:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
@MikeThomsen We can combine ProxyConfigurationService into ES or Solr, the 
CS just let users manage proxy settings in a centralized place. I will take a 
look on #2094 to see how I can help review that one. Thanks.


> NiFi processors should be able to share proxy settings
> --
>
> Key: NIFI-4199
> URL: https://issues.apache.org/jira/browse/NIFI-4199
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andre F de Miranda
>Assignee: Koji Kawamura
>Priority: Major
>
> Currently, configuring proxy settings for NiFi processors may be a tedious 
> process that requires the DFM to set proxy settings on individual processors. 
> This leads to:
> * Duplication of work
> * Management overhead (as password must be changed on multiple locations)
> * Lower security (as proxy credentials must be known by "n" DFMs)
> Ideally, NiFi should offer a way to minimise duplication of work by offering 
> a something similar to the Standard SSL Context services. This way, the DFM 
> could set the proxy settings once an all authorised users could tap into 
> those settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-15 Thread ijokarumawak

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
@jugi92 FTPTransfer supports SOCKS proxy. Specifically at these lines:
```
 if (proxyType == Proxy.Type.HTTP) {
-client = new FTPHTTPClient(proxyHost, proxyPort, 
ctx.getProperty(HTTP_PROXY_USERNAME).getValue(), 
ctx.getProperty(HTTP_PROXY_PASSWORD).getValue());
+client = new FTPHTTPClient(proxyHost, proxyPort, 
proxyConfig.getProxyUserName(), proxyConfig.getProxyUserPassword());
 } else {
 client = new FTPClient();
 if (proxyType == Proxy.Type.SOCKS) {
 client.setSocketFactory(new SocksProxySocketFactory(new 
Proxy(proxyType, new InetSocketAddress(proxyHost, proxyPort;
 }
 }
```

https://github.com/apache/nifi/pull/2704/files#diff-6e7e715d42f332cbe404edd9afbcaafaL533

For processors those don't support SOCKS proxy, following validation code 
should be added into their customValidate method, to confirm that 
ProxyConfigurationService is configured with the supported proxy type(s):
```
ProxyConfiguration.validateProxyType(validationContext, results, 
Proxy.Type.HTTP);
```

ProxyConfigurationService just holds the centralized proxy settings, each 
processor is responsible to use the settings with its own relying SDK/API way.

I checked #2018 but the PR doesn't look active. I will take a closer look 
on SFTP processor and #2018 to see if I can include SFTP ones into this PR, too.


---

[jira] [Commented] (NIFI-4199) NiFi processors should be able to share proxy settings

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476634#comment-16476634
 ] 

ASF GitHub Bot commented on NIFI-4199:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
@jugi92 FTPTransfer supports SOCKS proxy. Specifically at these lines:
```
 if (proxyType == Proxy.Type.HTTP) {
-client = new FTPHTTPClient(proxyHost, proxyPort, 
ctx.getProperty(HTTP_PROXY_USERNAME).getValue(), 
ctx.getProperty(HTTP_PROXY_PASSWORD).getValue());
+client = new FTPHTTPClient(proxyHost, proxyPort, 
proxyConfig.getProxyUserName(), proxyConfig.getProxyUserPassword());
 } else {
 client = new FTPClient();
 if (proxyType == Proxy.Type.SOCKS) {
 client.setSocketFactory(new SocksProxySocketFactory(new 
Proxy(proxyType, new InetSocketAddress(proxyHost, proxyPort;
 }
 }
```

https://github.com/apache/nifi/pull/2704/files#diff-6e7e715d42f332cbe404edd9afbcaafaL533

For processors those don't support SOCKS proxy, following validation code 
should be added into their customValidate method, to confirm that 
ProxyConfigurationService is configured with the supported proxy type(s):
```
ProxyConfiguration.validateProxyType(validationContext, results, 
Proxy.Type.HTTP);
```

ProxyConfigurationService just holds the centralized proxy settings, each 
processor is responsible to use the settings with its own relying SDK/API way.

I checked #2018 but the PR doesn't look active. I will take a closer look 
on SFTP processor and #2018 to see if I can include SFTP ones into this PR, too.


> NiFi processors should be able to share proxy settings
> --
>
> Key: NIFI-4199
> URL: https://issues.apache.org/jira/browse/NIFI-4199
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andre F de Miranda
>Assignee: Koji Kawamura
>Priority: Major
>
> Currently, configuring proxy settings for NiFi processors may be a tedious 
> process that requires the DFM to set proxy settings on individual processors. 
> This leads to:
> * Duplication of work
> * Management overhead (as password must be changed on multiple locations)
> * Lower security (as proxy credentials must be known by "n" DFMs)
> Ideally, NiFi should offer a way to minimise duplication of work by offering 
> a something similar to the Standard SSL Context services. This way, the DFM 
> could set the proxy settings once an all authorised users could tap into 
> those settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4199) NiFi processors should be able to share proxy settings

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476626#comment-16476626
 ] 

ASF GitHub Bot commented on NIFI-4199:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
@ottobackwards I assume you were talking about this, #2016. That one adds 
user/password for proxy authentication at abstract AWS processor. This PR adds 
ProxyConfigurationService, which can be added on top of #2016 for AWS 
processors proxy configurations to be managed by the centralized Controller 
Service. Please look at the FTP and HTTP processors in this PR, AWS ones can 
adopt the CS same way.


> NiFi processors should be able to share proxy settings
> --
>
> Key: NIFI-4199
> URL: https://issues.apache.org/jira/browse/NIFI-4199
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andre F de Miranda
>Assignee: Koji Kawamura
>Priority: Major
>
> Currently, configuring proxy settings for NiFi processors may be a tedious 
> process that requires the DFM to set proxy settings on individual processors. 
> This leads to:
> * Duplication of work
> * Management overhead (as password must be changed on multiple locations)
> * Lower security (as proxy credentials must be known by "n" DFMs)
> Ideally, NiFi should offer a way to minimise duplication of work by offering 
> a something similar to the Standard SSL Context services. This way, the DFM 
> could set the proxy settings once an all authorised users could tap into 
> those settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-15 Thread ijokarumawak

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2704
  
@ottobackwards I assume you were talking about this, #2016. That one adds 
user/password for proxy authentication at abstract AWS processor. This PR adds 
ProxyConfigurationService, which can be added on top of #2016 for AWS 
processors proxy configurations to be managed by the centralized Controller 
Service. Please look at the FTP and HTTP processors in this PR, AWS ones can 
adopt the CS same way.


---

[jira] [Updated] (NIFI-4980) Typo in ReportAtlasLineage kafka kerberos service name property

2018-05-15 Thread Koji Kawamura (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Koji Kawamura updated NIFI-4980:

   Resolution: Fixed
Fix Version/s: 1.7.0
   Status: Resolved  (was: Patch Available)

> Typo in ReportAtlasLineage kafka kerberos service name property
> ---
>
> Key: NIFI-4980
> URL: https://issues.apache.org/jira/browse/NIFI-4980
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.5.0
>Reporter: Koji Kawamura
>Assignee: Koji Kawamura
>Priority: Trivial
> Fix For: 1.7.0
>
> Attachments: nifi-4980-screenshot1.png, nifi-4980-screenshot2.png
>
>
> "Kafka Kerberos Service Name" property name is 
> "kafka-kerberos-service-name-kafka". 'kafka' is redundant.
> It should be "kafka-kerberos-service-name".
> This is reported by [~nayakmahesh616].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5198) Upgrade hoek

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476488#comment-16476488
 ] 

ASF GitHub Bot commented on NIFI-5198:
--

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-fds/pull/2

[NIFI-5198] update tooling versions

Thank you for submitting a contribution to Apache NiFi Fluid Design System.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
- [ ] Have you written or updated the Apache NiFi Fluid Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-fds NIFI-5198

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-fds/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit d8ef37397477f722b7a2adabc19cd6154eb9193c
Author: Scott Aslan 
Date:   2018-05-15T21:20:38Z

[NIFI-5198] update tooling versions




> Upgrade hoek
> 
>
> Key: NIFI-5198
> URL: https://issues.apache.org/jira/browse/NIFI-5198
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-5198) Upgrade hoek

2018-05-15 Thread Scott Aslan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-5198:
--
Status: Patch Available  (was: In Progress)

https://github.com/apache/nifi-fds/pull/2

> Upgrade hoek
> 
>
> Key: NIFI-5198
> URL: https://issues.apache.org/jira/browse/NIFI-5198
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-fds pull request #2: [NIFI-5198] update tooling versions

2018-05-15 Thread scottyaslan

GitHub user scottyaslan opened a pull request:

https://github.com/apache/nifi-fds/pull/2

[NIFI-5198] update tooling versions

Thank you for submitting a contribution to Apache NiFi Fluid Design System.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with either NIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you ensured that a full build and that the full suite of unit 
tests is executed via npm run clean:install at the root nifi-fds folder?
- [ ] Have you written or updated the Apache NiFi Fluid Design System demo 
application to demonstrate any new functionality, provide examples of usage, 
and to verify your changes via npm start at the nifi-fds/target folder?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-fds?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-fds?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scottyaslan/nifi-fds NIFI-5198

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-fds/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit d8ef37397477f722b7a2adabc19cd6154eb9193c
Author: Scott Aslan 
Date:   2018-05-15T21:20:38Z

[NIFI-5198] update tooling versions




---

[jira] [Closed] (NIFIREG-170) Upgrade hoek

2018-05-15 Thread Scott Aslan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFIREG-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan closed NIFIREG-170.
---
Resolution: Fixed

Opened https://issues.apache.org/jira/browse/NIFI-5198 to track upgrade of hoek 
in NiFi.

> Upgrade hoek
> 
>
> Key: NIFIREG-170
> URL: https://issues.apache.org/jira/browse/NIFIREG-170
> Project: NiFi Registry
>  Issue Type: Bug
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
> Fix For: 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (NIFI-5198) Upgrade hoek

2018-05-15 Thread Scott Aslan (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan reassigned NIFI-5198:
-

Assignee: Scott Aslan

> Upgrade hoek
> 
>
> Key: NIFI-5198
> URL: https://issues.apache.org/jira/browse/NIFI-5198
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (NIFI-5198) Upgrade hoek

2018-05-15 Thread Scott Aslan (JIRA)

Scott Aslan created NIFI-5198:
-

 Summary: Upgrade hoek
 Key: NIFI-5198
 URL: https://issues.apache.org/jira/browse/NIFI-5198
 Project: Apache NiFi
  Issue Type: Improvement
  Components: FDS
Reporter: Scott Aslan






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MINIFICPP-497) Getting flow status for a processor returns "no processor"

2018-05-15 Thread Aldrin Piri (JIRA)

Aldrin Piri created MINIFICPP-497:
-

 Summary: Getting flow status for a processor returns "no processor"
 Key: MINIFICPP-497
 URL: https://issues.apache.org/jira/browse/MINIFICPP-497
 Project: NiFi MiNiFi C++
  Issue Type: Bug
Affects Versions: 0.5.0
Reporter: Aldrin Piri
 Fix For: 0.5.0


As reported in 
[https://github.com/apache/nifi-minifi/pull/125#issuecomment-388471369.]

I suspect it might have something to do with some adjustments to name/id 
handling but further research would need to be handled to confirm.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-5175) NiFi built with Java 1.8 needs to run on Java 9

2018-05-15 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5175:
--
Description: 
The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||Status||
|JAXB classes cannot be found on the classpath|Add 
"--add-modules=java.xml.bind" to the commant that starts NiFi|Done|
|NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
stop|Detect if NiFi is running on Java 9, and reflectively invoke 
Process.pid(), which was newly added to the Process API in Java 9|Done|

 

 
||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
9+||Description||Solution||
|WARNING: An illegal reflective access operation has occurred
 ..._specific class usage snipped_...
 WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
 WARNING: All illegal access operations will be denied in a future 
release|Reflective invocations are common in the code used in NiFi and its 
dependencies on Java 1.8|Full compliant migration to Java 9 and use 
dependencies that are Java 9 compliant|

  was:
The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||Status||
|JAXB classes cannot be found on the classpath|Start NiFi with 
--add-modules=java.xml.bind|Done|
|NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
stop|Detect if NiFi is running on Java 9, and reflectively invoke 
Process.pid(), which was newly added to the Process API in Java 9|Done|

 

 
||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
9+||Description||Solution||
|WARNING: An illegal reflective access operation has occurred
 ..._specific class usage snipped_...
 WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
 WARNING: All illegal access operations will be denied in a future 
release|Reflective invocations are common in the code used in NiFi and its 
dependencies on Java 1.8|Full compliant migration to Java 9 and use 
dependencies that are Java 9 compliant|


> NiFi built with Java 1.8 needs to run on Java 9
> ---
>
> Key: NIFI-5175
> URL: https://issues.apache.org/jira/browse/NIFI-5175
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> The following issues have been encountered while attempting to run a Java 
> 1.8-built NiFi on Java 9:
> ||Issue||Solution||Status||
> |JAXB classes cannot be found on the classpath|Add 
> "--add-modules=java.xml.bind" to the commant that starts NiFi|Done|
> |NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
> stop|Detect if NiFi is running on Java 9, and reflectively invoke 
> Process.pid(), which was newly added to the Process API in Java 9|Done|
>  
> 
>  
> ||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
> 9+||Description||Solution||
> |WARNING: An illegal reflective access operation has occurred
>  ..._specific class usage snipped_...
>  WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
>  WARNING: All illegal access operations will be denied in a future 
> release|Reflective invocations are common in the code used in NiFi and its 
> dependencies on Java 1.8|Full compliant migration to Java 9 and use 
> dependencies that are Java 9 compliant|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-5175) NiFi built with Java 1.8 needs to run on Java 9

2018-05-15 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5175:
--
Description: 
The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||Status||
|JAXB classes cannot be found on the classpath|Add 
"--add-modules=java.xml.bind" to the commant that starts NiFi|Done|
|NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
stop|Detect if NiFi is running on Java 9, and reflectively invoke 
Process.pid(), which was newly added to the Process API in Java 9|Done|

 

 
||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
9+||Description||Solution||
|WARNING: An illegal reflective access operation has occurred
 ..._specific class usage snipped_...
 WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
 WARNING: All illegal access operations will be denied in a future 
release|Reflective invocations are common in the code used in NiFi and its 
dependencies in Java 1.8|Full compliant migration to Java 9 and use 
dependencies that are Java 9 compliant|

  was:
The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||Status||
|JAXB classes cannot be found on the classpath|Add 
"--add-modules=java.xml.bind" to the commant that starts NiFi|Done|
|NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
stop|Detect if NiFi is running on Java 9, and reflectively invoke 
Process.pid(), which was newly added to the Process API in Java 9|Done|

 

 
||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
9+||Description||Solution||
|WARNING: An illegal reflective access operation has occurred
 ..._specific class usage snipped_...
 WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
 WARNING: All illegal access operations will be denied in a future 
release|Reflective invocations are common in the code used in NiFi and its 
dependencies on Java 1.8|Full compliant migration to Java 9 and use 
dependencies that are Java 9 compliant|


> NiFi built with Java 1.8 needs to run on Java 9
> ---
>
> Key: NIFI-5175
> URL: https://issues.apache.org/jira/browse/NIFI-5175
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> The following issues have been encountered while attempting to run a Java 
> 1.8-built NiFi on Java 9:
> ||Issue||Solution||Status||
> |JAXB classes cannot be found on the classpath|Add 
> "--add-modules=java.xml.bind" to the commant that starts NiFi|Done|
> |NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
> stop|Detect if NiFi is running on Java 9, and reflectively invoke 
> Process.pid(), which was newly added to the Process API in Java 9|Done|
>  
> 
>  
> ||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
> 9+||Description||Solution||
> |WARNING: An illegal reflective access operation has occurred
>  ..._specific class usage snipped_...
>  WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
>  WARNING: All illegal access operations will be denied in a future 
> release|Reflective invocations are common in the code used in NiFi and its 
> dependencies in Java 1.8|Full compliant migration to Java 9 and use 
> dependencies that are Java 9 compliant|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-5175) NiFi built with Java 1.8 needs to run on Java 9

2018-05-15 Thread Jeff Storck (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Storck updated NIFI-5175:
--
Description: 
The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||Status||
|JAXB classes cannot be found on the classpath|Start NiFi with 
--add-modules=java.xml.bind|Done|
|NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
stop|Detect if NiFi is running on Java 9, and reflectively invoke 
Process.pid(), which was newly added to the Process API in Java 9|Done|

 

 
||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
9+||Description||Solution||
|WARNING: An illegal reflective access operation has occurred
 ..._specific class usage snipped_...
 WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
 WARNING: All illegal access operations will be denied in a future 
release|Reflective invocations are common in the code used in NiFi and its 
dependencies on Java 1.8|Full compliant migration to Java 9 and use 
dependencies that are Java 9 compliant|

  was:
The following issues have been encountered while attempting to run a Java 
1.8-built NiFi on Java 9:
||Issue||Solution||Status||
|Java 9 ServiceLoader requires providers have a default no-arg public 
constructor|Add no-arg public constructors|In Progress|
|NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
stop|Detect if NiFi is running on Java 9, and reflectively invoke 
Process.pid(), which was newly added to the Process API in Java 9|Done|

 

 
||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
9+||Description||Solution||
|WARNING: An illegal reflective access operation has occurred
 ..._specific class usage snipped_...
 WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
 WARNING: All illegal access operations will be denied in a future 
release|Reflective invocations are common in the code used in NiFi and its 
dependencies on Java 1.8|Full compliant migration to Java 9 and use 
dependencies that are Java 9 compliant|


> NiFi built with Java 1.8 needs to run on Java 9
> ---
>
> Key: NIFI-5175
> URL: https://issues.apache.org/jira/browse/NIFI-5175
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> The following issues have been encountered while attempting to run a Java 
> 1.8-built NiFi on Java 9:
> ||Issue||Solution||Status||
> |JAXB classes cannot be found on the classpath|Start NiFi with 
> --add-modules=java.xml.bind|Done|
> |NiFI boostrap not able to determine PID, restarts nifi after nifi.sh 
> stop|Detect if NiFi is running on Java 9, and reflectively invoke 
> Process.pid(), which was newly added to the Process API in Java 9|Done|
>  
> 
>  
> ||Unaddressed issues/warnings with NiFi compiled on Java 1.8 running on Java 
> 9+||Description||Solution||
> |WARNING: An illegal reflective access operation has occurred
>  ..._specific class usage snipped_...
>  WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
>  WARNING: All illegal access operations will be denied in a future 
> release|Reflective invocations are common in the code used in NiFi and its 
> dependencies on Java 1.8|Full compliant migration to Java 9 and use 
> dependencies that are Java 9 compliant|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5141) ValidateRecord considers a record invalid if it has an integer value and schema says double, even if strict type checking is disabled

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476421#comment-16476421
 ] 

ASF GitHub Bot commented on NIFI-5141:
--

Github user bdesert commented on the issue:

https://github.com/apache/nifi/pull/2679
  
+1.
No more comments from my side.


> ValidateRecord considers a record invalid if it has an integer value and 
> schema says double, even if strict type checking is disabled
> -
>
> Key: NIFI-5141
> URL: https://issues.apache.org/jira/browse/NIFI-5141
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
>  Labels: Record, beginner, newbie, validation
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2679: NIFI-5141: Updated regex for doubles to allow for numbers ...

2018-05-15 Thread bdesert

Github user bdesert commented on the issue:

https://github.com/apache/nifi/pull/2679
  
+1.
No more comments from my side.


---

[jira] [Commented] (NIFI-5145) MockPropertyValue.evaluateExpressionLanguage(FlowFile) cannot handle null inputs

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476404#comment-16476404
 ] 

ASF GitHub Bot commented on NIFI-5145:
--

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2672
  
[Added a Jira ticket](https://issues.apache.org/jira/browse/NIFI-5197) to 
track the issue with the invalid scope bugs.


> MockPropertyValue.evaluateExpressionLanguage(FlowFile) cannot handle null 
> inputs
> 
>
> Key: NIFI-5145
> URL: https://issues.apache.org/jira/browse/NIFI-5145
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
>
> The method mentioned in the title line cannot handle null inputs, even though 
> the main NiFi execution classes can handle that scenario. This forces hack to 
> pass testing with nulls that looks like this:
> String val = flowFile != null ? 
> context.getProperty(PROP).evaluateExpressionLanguage(flowfile).getValue() : 
> context.getProperty(PROP).evaluateExpressionLanguage(new 
> HashMap()).getValue();



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-15 Thread MikeThomsen

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2672
  
[Added a Jira ticket](https://issues.apache.org/jira/browse/NIFI-5197) to 
track the issue with the invalid scope bugs.


---

[jira] [Created] (NIFI-5197) Fix invalid expression language scope declarations

2018-05-15 Thread Mike Thomsen (JIRA)

Mike Thomsen created NIFI-5197:
--

 Summary: Fix invalid expression language scope declarations
 Key: NIFI-5197
 URL: https://issues.apache.org/jira/browse/NIFI-5197
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Mike Thomsen
Assignee: Mike Thomsen


Some of the expression language scope declarations are wrong, such as declaring 
VARIABLE_REGISTRY and then passing in a flowfile as the argument in the 
processor. These need to be hunted down and cleaned up in one single commit. 
Each set of unit and integration tests should be run to verify where problems 
reside.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (NIFI-5196) AbstractJMSProcessor can leave connection hanging open

2018-05-15 Thread Nick Coleman (JIRA)

Nick Coleman created NIFI-5196:
--

 Summary: AbstractJMSProcessor can leave connection hanging open
 Key: NIFI-5196
 URL: https://issues.apache.org/jira/browse/NIFI-5196
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Affects Versions: 1.6.0
Reporter: Nick Coleman


ConsumeJMS and PublishJMS are based on AbstractJMSProcessor.  They can cause a 
connection to the MQ Server to be opened and not be closed until the NiFi 
server is rebooted.

This can create a problem for an MQ when the initial setup entered is wrong for 
an IBM MQ system that only allows one connection per user.  Subsequent 
connections are blocked as the first remains open.  Another potential problem 
even if the subsequent connection works is the original connection is still 
open and taking up resources.

A simple change to the AbstractJMSProcessor would be in the onTrigger() 
function:

 
{code:java}
@Override
public void onTrigger(ProcessContext context, ProcessSession session) throws 
ProcessException {
T worker = workerPool.poll();
if (worker == null) {
worker = buildTargetResource(context);
}

boolean offered = false;
try {
rendezvousWithJms(context, session, worker);
offered = workerPool.offer(worker);
}
finally {
if (!offered) {
worker.shutdown();
}
}
}{code}
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5141) ValidateRecord considers a record invalid if it has an integer value and schema says double, even if strict type checking is disabled

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476358#comment-16476358
 ] 

ASF GitHub Bot commented on NIFI-5141:
--

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2679
  
@bdesert good call! I updated the regex so that it allows for expressions 
like "13." and added a unit test that tests lots of different possible 
combinations. Thanks!


> ValidateRecord considers a record invalid if it has an integer value and 
> schema says double, even if strict type checking is disabled
> -
>
> Key: NIFI-5141
> URL: https://issues.apache.org/jira/browse/NIFI-5141
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
>  Labels: Record, beginner, newbie, validation
> Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2679: NIFI-5141: Updated regex for doubles to allow for numbers ...

2018-05-15 Thread markap14

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2679
  
@bdesert good call! I updated the regex so that it allows for expressions 
like "13." and added a unit test that tests lots of different possible 
combinations. Thanks!


---

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476333#comment-16476333
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2705
  
LGTM, +1  FWIW


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-15 Thread ottobackwards

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2705
  
LGTM, +1  FWIW


---

[jira] [Commented] (NIFI-5169) Upgrade to JsonPath 2.4.0

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476324#comment-16476324
 ] 

ASF GitHub Bot commented on NIFI-5169:
--

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2705#discussion_r188393536
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java
 ---
@@ -112,10 +111,10 @@ static String getResultRepresentation(Object 
jsonPathResult, String defaultValue
 public ValidationResult validate(final String subject, final 
String input, final ValidationContext context) {
 String error = null;
 if (isStale(subject, input)) {
-if (JsonPathExpressionValidator.isValidExpression(input)) {
+try {
 JsonPath compiledJsonPath = JsonPath.compile(input);
 cacheComputedValue(subject, input, compiledJsonPath);
--- End diff --

I should have a `isBlank` check there, so good catch.


> Upgrade to JsonPath 2.4.0
> -
>
> Key: NIFI-5169
> URL: https://issues.apache.org/jira/browse/NIFI-5169
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 1.6.0
>Reporter: Dennis Dahlmann
>Assignee: Mike Thomsen
>Priority: Major
>  Labels: JSON
> Fix For: 1.7.0
>
>
> A newer version (2.4.0) of JsonPath is availabel at  
> [github|[https://github.com/json-path/JsonPath].]
> With this version a currently existing bug is fixed, take this JSON
> {"Epoch timestamp [s]":"1486373924","temperature [C]":"20"}
> and try to get the value of "Epoch timestamp [s]" with $.['Epoch timestamp 
> [s]'] this will result in an empty result with version 2.0.0 which is 
> currently, but with version 2.4.0 you get the right value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-15 Thread MikeThomsen

Github user MikeThomsen commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2705#discussion_r188393536
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java
 ---
@@ -112,10 +111,10 @@ static String getResultRepresentation(Object 
jsonPathResult, String defaultValue
 public ValidationResult validate(final String subject, final 
String input, final ValidationContext context) {
 String error = null;
 if (isStale(subject, input)) {
-if (JsonPathExpressionValidator.isValidExpression(input)) {
+try {
 JsonPath compiledJsonPath = JsonPath.compile(input);
 cacheComputedValue(subject, input, compiledJsonPath);
--- End diff --

I should have a `isBlank` check there, so good catch.


---

[jira] [Commented] (NIFI-5145) MockPropertyValue.evaluateExpressionLanguage(FlowFile) cannot handle null inputs

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476323#comment-16476323
 ] 

ASF GitHub Bot commented on NIFI-5145:
--

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2672
  
@mattyb149 I just changed the override to be the one without a parameter. I 
agree that there should be a task for squashing the scope bugs, but do the few 
that got squashed here need to be cherry picked out or should they just stay in?


> MockPropertyValue.evaluateExpressionLanguage(FlowFile) cannot handle null 
> inputs
> 
>
> Key: NIFI-5145
> URL: https://issues.apache.org/jira/browse/NIFI-5145
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Major
>
> The method mentioned in the title line cannot handle null inputs, even though 
> the main NiFi execution classes can handle that scenario. This forces hack to 
> pass testing with nulls that looks like this:
> String val = flowFile != null ? 
> context.getProperty(PROP).evaluateExpressionLanguage(flowfile).getValue() : 
> context.getProperty(PROP).evaluateExpressionLanguage(new 
> HashMap()).getValue();



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-15 Thread MikeThomsen

Github user MikeThomsen commented on the issue:

https://github.com/apache/nifi/pull/2672
  
@mattyb149 I just changed the override to be the one without a parameter. I 
agree that there should be a task for squashing the scope bugs, but do the few 
that got squashed here need to be cherry picked out or should they just stay in?


---

[GitHub] nifi issue #2693: NIFI-950: Make component validation asynchronous

2018-05-15 Thread markap14

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2693
  
@mcgilman I pushed a new commit that i think should address the feedback. 
Thanks!


---

[jira] [Commented] (NIFI-950) Perform component validation asynchronously

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476316#comment-16476316
 ] 

ASF GitHub Bot commented on NIFI-950:
-

Github user markap14 commented on the issue:

https://github.com/apache/nifi/pull/2693
  
@mcgilman I pushed a new commit that i think should address the feedback. 
Thanks!


> Perform component validation asynchronously
> ---
>
> Key: NIFI-950
> URL: https://issues.apache.org/jira/browse/NIFI-950
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joseph Percivall
>Priority: Major
> Attachments: self_reference_flow_fix.xml
>
>
> I created a flow that is a self referencing http loop. The flow was working 
> fine but I wanted to save the template for later testing. I downloaded the 
> the flow as a template. Then I tried testing a thread.sleep in the beginning 
> of onConfigured, createSSLContext, and validate methods of 
> StandardSSLContextService. I did a mvn clean install in the 
> nifi-nar-bundles/nifi-standard-services/nifi-ssl-context-bundle/nifi-ssl-context-service
>  directory. Then a mvn clean install in the nifi-assembly directory. After I 
> imported the template the UI became very slow when clicking to different 
> windows of the UI such as configuring a processor and the controller services 
> window.
> I then stashed my changes and rebuilt the files. Once again I imported my 
> template, and attempting to configure a processor or accessing the controller 
> services window became very slow.
> The flow xml is attached. 
> ---
> The description and attachment showed an issue where long running validation 
> caused the UI to become unresponsive. This validation should be done 
> asynchronously so that the UI always remains responsive. Initial thoughts...
> - new state to indicate that validation is in progress
> - a mechanism for refreshing validation results
> - time out for waiting for validation to complete? or need to always be 
> validating all components in case their validity is based on something 
> environmental (like a configuration file that is modified outside of the 
> application)?
> - provide better support for components that are running and become invalid
> -- related to this we need to provide guidance regarding the difference 
> between become invalid and when we should use features like bulletins and 
> yielding to rely runtime issues



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-fds issue #1: [NIFI-5164] upgrade to angular v5.2.0, angular-material v...

2018-05-15 Thread mcgilman

Github user mcgilman commented on the issue:

https://github.com/apache/nifi-fds/pull/1
  
Thanks @scottyaslan! This has been merged to master.


---

[jira] [Commented] (NIFI-5164) Upgrade Apache NiFi FDS to Angular 5.2

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476278#comment-16476278
 ] 

ASF GitHub Bot commented on NIFI-5164:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi-fds/pull/1
  
Thanks @scottyaslan! This has been merged to master.


> Upgrade Apache NiFi FDS to Angular 5.2
> --
>
> Key: NIFI-5164
> URL: https://issues.apache.org/jira/browse/NIFI-5164
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>
> Upgrading nifi-fds to latest Angular v5.2.0 will unblock upgrade of 
> @angular/material and @covalent/core from beta versions. It will also allow 
> the Apache NiFi Registry to upgrade to Angular v5.2.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (NIFI-5164) Upgrade Apache NiFi FDS to Angular 5.2

2018-05-15 Thread Matt Gilman (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-5164.
---
Resolution: Fixed

> Upgrade Apache NiFi FDS to Angular 5.2
> --
>
> Key: NIFI-5164
> URL: https://issues.apache.org/jira/browse/NIFI-5164
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>
> Upgrading nifi-fds to latest Angular v5.2.0 will unblock upgrade of 
> @angular/material and @covalent/core from beta versions. It will also allow 
> the Apache NiFi Registry to upgrade to Angular v5.2.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5164) Upgrade Apache NiFi FDS to Angular 5.2

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476275#comment-16476275
 ] 

ASF GitHub Bot commented on NIFI-5164:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-fds/pull/1


> Upgrade Apache NiFi FDS to Angular 5.2
> --
>
> Key: NIFI-5164
> URL: https://issues.apache.org/jira/browse/NIFI-5164
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>
> Upgrading nifi-fds to latest Angular v5.2.0 will unblock upgrade of 
> @angular/material and @covalent/core from beta versions. It will also allow 
> the Apache NiFi Registry to upgrade to Angular v5.2.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-fds pull request #1: [NIFI-5164] upgrade to angular v5.2.0, angular-mat...

2018-05-15 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-fds/pull/1


---

[jira] [Commented] (MINIFICPP-403) Enable tagging of flowfiles with flow metadata information in C++

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476239#comment-16476239
 ] 

ASF GitHub Bot commented on MINIFICPP-403:
--

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/331

MINIFICPP-403: Update connectables so that they contain a reference t…

…o the flow

identifier. With this approach the flow identifier will be updated with C2
and automatically apply to any processors applied as a result of that update

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-403

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit ba075e0e7594ac2855321646dde5ec04d60077b5
Author: Marc Parisi 
Date:   2018-05-15T17:45:02Z

MINIFICPP-403: Update connectables so that they contain a reference to the 
flow
identifier. With this approach the flow identifier will be updated with C2
and automatically apply to any processors applied as a result of that update




> Enable tagging of flowfiles with flow metadata information in C++
> -
>
> Key: MINIFICPP-403
> URL: https://issues.apache.org/jira/browse/MINIFICPP-403
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: bqiu
>Assignee: bqiu
>Priority: Minor
> Fix For: 1.0.0
>
>
> Provide framework level support to tag flowfiles with metadata about the flow 
> that created them.
> Design proposal
> Right now, MiNiFi support core attributes like 
> // FlowFile Attribute
> enum FlowAttribute {
>  // The flowfile's path indicates the relative directory to which a FlowFile 
> belongs and does not contain the filename
>  PATH = 0,
>  // The flowfile's absolute path indicates the absolute directory to which a 
> FlowFile belongs and does not contain the filename
>  ABSOLUTE_PATH,
>  // The filename of the FlowFile. The filename should not contain any 
> directory structure.
>  FILENAME,
>  // A unique UUID assigned to this FlowFile.
>  UUID,
>  // A numeric value indicating the FlowFile priority
>  priority,
>  // The MIME Type of this FlowFile
>  MIME_TYPE,
>  // Specifies the reason that a FlowFile is being discarded
>  DISCARD_REASON,
>  // Indicates an identifier other than the FlowFile's UUID that is known to 
> refer to this FlowFile.
>  ALTERNATE_IDENTIFIER,
>  MAX_FLOW_ATTRIBUTES
> };
> So one approach is in the flow YAML file, specific the list of core flow 
> attributes along with the processors that inject/import/create the flow files.
> When flow was created/imported/injected by this processor, we can apply these 
> core attributes to the new flow.
> Also user can define their own core attributes template and EL for populate 
> value for these core attributes, for example protocol, TTL, record route 
> (expected route), key, version, etc.
> In current implementation, FILENAME, PATH and UUID are required attributes 
> when flow was created, others are optional
> // Populate the default attributes
> addKeyedAttribute(FILENAME,
> std::to_string(getTimeNano()));
> addKeyedAttribute(PATH, DEFAULT_FLOWFILE_PATH);
>

[GitHub] nifi-minifi-cpp pull request #331: MINIFICPP-403: Update connectables so tha...

2018-05-15 Thread phrocker

GitHub user phrocker opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/331

MINIFICPP-403: Update connectables so that they contain a reference tâ¦

â¦o the flow

identifier. With this approach the flow identifier will be updated with C2
and automatically apply to any processors applied as a result of that update

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
 in the commit message?

- [ ] Does your PR title start with MINIFI- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-403

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit ba075e0e7594ac2855321646dde5ec04d60077b5
Author: Marc Parisi 
Date:   2018-05-15T17:45:02Z

MINIFICPP-403: Update connectables so that they contain a reference to the 
flow
identifier. With this approach the flow identifier will be updated with C2
and automatically apply to any processors applied as a result of that update




---

[jira] [Commented] (MINIFICPP-472) Implement date manipulation EL functions

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476229#comment-16476229
 ] 

ASF GitHub Bot commented on MINIFICPP-472:
--

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/315
  
Ah, seems to be in the 3rd party date lib. We might need to disable these 
date fns when an old compiler is in use (similar to how we disable regex).

The lib should support C++11 though, so will look into it a bit more before 
making the call.


> Implement date manipulation EL functions
> 
>
> Key: MINIFICPP-472
> URL: https://issues.apache.org/jira/browse/MINIFICPP-472
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
>
> [Date 
> Manipulation|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#dates]
>  * 
> [format|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#format]
>  * 
> [toDate|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#todate]
>  * 
> [now|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#now]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions

2018-05-15 Thread achristianson

Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/315
  
Ah, seems to be in the 3rd party date lib. We might need to disable these 
date fns when an old compiler is in use (similar to how we disable regex).

The lib should support C++11 though, so will look into it a bit more before 
making the call.


---

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476221#comment-16476221
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2698
  
Thanks for the review guys 


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread Otto Fowler (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476220#comment-16476220
 ] 

Otto Fowler commented on NIFI-5077:
---

[~ramondg] you should be all set if you take the master build until 1.7.0 
release!

> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi issue #2698: NIFI-5077 ExtractGrok support for `keep empty captures`

2018-05-15 Thread ottobackwards

Github user ottobackwards commented on the issue:

https://github.com/apache/nifi/pull/2698
  
Thanks for the review guys 


---

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476216#comment-16476216
 ] 

ASF subversion and git services commented on NIFI-5077:
---

Commit ccedc71c8b89e1792d79197f399b37b1ac541e3f in nifi's branch 
refs/heads/master from [~ottobackwards]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ccedc71 ]

NIFI-5077 ExtractGrok support for `keep empty captures`

Support for the new option to keep empty captures.  I did not add to the 
GrokReader because I am not sure of the effect on
the schema extraction.

Signed-off-by: Pierre Villard 

This closes #2698.


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread Pierre Villard (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-5077:
-
Issue Type: Improvement  (was: Bug)

> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread Pierre Villard (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-5077:
-
Component/s: (was: Core Framework)
 Extensions

> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread Pierre Villard (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-5077:
-
   Resolution: Fixed
Fix Version/s: 1.7.0
   Status: Resolved  (was: Patch Available)

> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476217#comment-16476217
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2698


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Fix For: 1.7.0
>
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2698


---

[GitHub] nifi issue #2698: NIFI-5077 ExtractGrok support for `keep empty captures`

2018-05-15 Thread pvillard31

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2698
  
Thanks @ottobackwards, merging to master


---

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476212#comment-16476212
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2698
  
Thanks @ottobackwards, merging to master


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread Pierre Villard (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard resolved NIFIREG-160.

   Resolution: Fixed
 Assignee: Bryan Bende  (was: Pierre Villard)
Fix Version/s: 0.2.0

> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Bryan Bende
>Priority: Major
> Fix For: 0.2.0
>
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476209#comment-16476209
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user pvillard31 commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
Merged to master, thanks!


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Bryan Bende
>Priority: Major
> Fix For: 0.2.0
>
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
Merged to master, thanks!


---

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476208#comment-16476208
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user asfgit closed the pull request at:

https://github.com/apache/nifi-registry/pull/117


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-registry pull request #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/nifi-registry/pull/117


---

[jira] [Commented] (MINIFICPP-472) Implement date manipulation EL functions

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476190#comment-16476190
 ] 

ASF GitHub Bot commented on MINIFICPP-472:
--

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/315
  
Looks like there are still build issues:
https://api.travis-ci.org/v3/job/379278498/log.txt

https://travis-ci.org/apiri/nifi-minifi-cpp/builds/379278497


> Implement date manipulation EL functions
> 
>
> Key: MINIFICPP-472
> URL: https://issues.apache.org/jira/browse/MINIFICPP-472
> Project: NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Andrew Christianson
>Assignee: Andrew Christianson
>Priority: Major
>
> [Date 
> Manipulation|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#dates]
>  * 
> [format|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#format]
>  * 
> [toDate|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#todate]
>  * 
> [now|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#now]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476189#comment-16476189
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user bbende commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
@pvillard31 thanks for the review, i'm fine with you doing the minor 
cleanup on merge, thanks!


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread bbende

Github user bbende commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
@pvillard31 thanks for the review, i'm fine with you doing the minor 
cleanup on merge, thanks!


---

[GitHub] nifi-minifi-cpp issue #315: MINIFICPP-472 Added date formatting EL functions

2018-05-15 Thread apiri

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/315
  
Looks like there are still build issues:
https://api.travis-ci.org/v3/job/379278498/log.txt

https://travis-ci.org/apiri/nifi-minifi-cpp/builds/379278497


---

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476187#comment-16476187
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user pvillard31 commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
@bbende  I just did some tests with various possible configurations and 
different hooks, it's working as expected. The dedicated log file is really 
great and useful. Let me know if you want to do something regarding my comments 
or I can take care of it while merging if you are OK with it.


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-registry issue #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi-registry/pull/117
  
@bbende  I just did some tests with various possible configurations and 
different hooks, it's working as expected. The dedicated log file is really 
great and useful. Let me know if you want to do something regarding my comments 
or I can take care of it while merging if you are OK with it.


---

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476145#comment-16476145
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188350335
  
--- Diff: 
nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/StandardFlowSnapshotContext.java
 ---
@@ -33,8 +33,8 @@
 private final String flowName;
 private final int version;
 private final String comments;
-private final long snapshotTimestamp;
--- End diff --

Really nitpick but I think the changes on this class seem unnecessary, no?


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476144#comment-16476144
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188357732
  
--- Diff: pom.xml ---
@@ -110,8 +110,8 @@
 2.1
 2.26
 2.9.2
-2.0.0.M7
-5.0.0.RELEASE
+2.0.2.RELEASE
--- End diff --

It seems we are also specifying the versions in the notice files. Should be 
updated as well.


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476143#comment-16476143
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188356239
  
--- Diff: 
nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/hook/TestScriptEventHookProvider.java
 ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.registry.provider.hook;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+import org.apache.nifi.registry.extension.ExtensionManager;
+import org.apache.nifi.registry.properties.NiFiRegistryProperties;
+import org.apache.nifi.registry.provider.ProviderCreationException;
+import org.apache.nifi.registry.provider.ProviderFactory;
+import org.apache.nifi.registry.provider.StandardProviderFactory;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class TestScriptEventHookProvider {
+
+@Test(expected = ProviderCreationException.class)
+public void testBadScriptProvider() {
--- End diff --

can't test on my side but is it going to work for a build on Windows?


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-registry pull request #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188357732
  
--- Diff: pom.xml ---
@@ -110,8 +110,8 @@
 2.1
 2.26
 2.9.2
-2.0.0.M7
-5.0.0.RELEASE
+2.0.2.RELEASE
--- End diff --

It seems we are also specifying the versions in the notice files. Should be 
updated as well.


---

[GitHub] nifi-registry pull request #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188356239
  
--- Diff: 
nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/hook/TestScriptEventHookProvider.java
 ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.registry.provider.hook;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+import org.apache.nifi.registry.extension.ExtensionManager;
+import org.apache.nifi.registry.properties.NiFiRegistryProperties;
+import org.apache.nifi.registry.provider.ProviderCreationException;
+import org.apache.nifi.registry.provider.ProviderFactory;
+import org.apache.nifi.registry.provider.StandardProviderFactory;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class TestScriptEventHookProvider {
+
+@Test(expected = ProviderCreationException.class)
+public void testBadScriptProvider() {
--- End diff --

can't test on my side but is it going to work for a build on Windows?


---

[GitHub] nifi-registry pull request #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188356638
  
--- Diff: 
nifi-registry-framework/src/test/java/org/apache/nifi/registry/service/TestRegistryService.java
 ---
@@ -81,6 +81,7 @@
 public void setup() {
 metadataService = mock(MetadataService.class);
 flowPersistenceProvider = mock(FlowPersistenceProvider.class);
+// eventHookProvider = mock(EventHookProvider.class);
--- End diff --

To be removed?


---

[GitHub] nifi-registry pull request #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188350335
  
--- Diff: 
nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/StandardFlowSnapshotContext.java
 ---
@@ -33,8 +33,8 @@
 private final String flowName;
 private final int version;
 private final String comments;
-private final long snapshotTimestamp;
--- End diff --

Really nitpick but I think the changes on this class seem unnecessary, no?


---

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476141#comment-16476141
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188356638
  
--- Diff: 
nifi-registry-framework/src/test/java/org/apache/nifi/registry/service/TestRegistryService.java
 ---
@@ -81,6 +81,7 @@
 public void setup() {
 metadataService = mock(MetadataService.class);
 flowPersistenceProvider = mock(FlowPersistenceProvider.class);
+// eventHookProvider = mock(EventHookProvider.class);
--- End diff --

To be removed?


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFIREG-160) Implement a hook provider

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFIREG-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476142#comment-16476142
 ] 

ASF GitHub Bot commented on NIFIREG-160:


Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188356509
  
--- Diff: 
nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/hook/TestScriptEventHookProvider.java
 ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.registry.provider.hook;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+import org.apache.nifi.registry.extension.ExtensionManager;
+import org.apache.nifi.registry.properties.NiFiRegistryProperties;
+import org.apache.nifi.registry.provider.ProviderCreationException;
+import org.apache.nifi.registry.provider.ProviderFactory;
+import org.apache.nifi.registry.provider.StandardProviderFactory;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class TestScriptEventHookProvider {
+
+@Test(expected = ProviderCreationException.class)
+public void testBadScriptProvider() {
--- End diff --

ok nevermind, since we expect it to fail, it should also fail on Windows


> Implement a hook provider
> -
>
> Key: NIFIREG-160
> URL: https://issues.apache.org/jira/browse/NIFIREG-160
> Project: NiFi Registry
>  Issue Type: New Feature
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>
> In order to extend NiFi Registry and NiFi CLI features to integrate with 
> automated deployment pipelines, it would be useful to provide a hook 
> extension point that can be configured by users to trigger actions when a new 
> flow snapshot version is committed in the Registry.
> A first implementation of this extension point could be a "script hook": a 
> script would be executed when a new flow snapshot version is committed. 
> Arguments passed to the script would be: bucket ID, flow ID, version, author 
> and comment.
> This would enable a lot of scenarios including automatically deploy flows 
> from one environment to another.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi-registry pull request #117: NIFIREG-160 Implement a hook provider

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi-registry/pull/117#discussion_r188356509
  
--- Diff: 
nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/hook/TestScriptEventHookProvider.java
 ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.registry.provider.hook;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+import org.apache.nifi.registry.extension.ExtensionManager;
+import org.apache.nifi.registry.properties.NiFiRegistryProperties;
+import org.apache.nifi.registry.provider.ProviderCreationException;
+import org.apache.nifi.registry.provider.ProviderFactory;
+import org.apache.nifi.registry.provider.StandardProviderFactory;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class TestScriptEventHookProvider {
+
+@Test(expected = ProviderCreationException.class)
+public void testBadScriptProvider() {
--- End diff --

ok nevermind, since we expect it to fail, it should also fail on Windows


---

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476103#comment-16476103
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188355616
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
--- End diff --

done


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476104#comment-16476104
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188355650
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -234,6 +247,11 @@ public void onStopped() {
 
 @OnScheduled
 public void onScheduled(final ProcessContext context) throws 
GrokException, IOException {
+
+if (context.getProperty(KEEP_EMPTY_CAPTURES).isSet()) {
--- End diff --

done


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread ottobackwards

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188355650
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -234,6 +247,11 @@ public void onStopped() {
 
 @OnScheduled
 public void onScheduled(final ProcessContext context) throws 
GrokException, IOException {
+
+if (context.getProperty(KEEP_EMPTY_CAPTURES).isSet()) {
--- End diff --

done


---

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread ottobackwards

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188355616
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
--- End diff --

done


---

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476099#comment-16476099
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188354997
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
+.defaultValue("true")
--- End diff --

No, currently the empties are returned, this maintains that


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread ottobackwards

Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188354997
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
+.defaultValue("true")
--- End diff --

No, currently the empties are returned, this maintains that


---

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476066#comment-16476066
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188345184
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
+.defaultValue("true")
--- End diff --

isn't defaulting to true a change of the current behavior?


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476064#comment-16476064
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188345339
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -234,6 +247,11 @@ public void onStopped() {
 
 @OnScheduled
 public void onScheduled(final ProcessContext context) throws 
GrokException, IOException {
+
+if (context.getProperty(KEEP_EMPTY_CAPTURES).isSet()) {
--- End diff --

with required=true, you would not need to check if the property is set 
anymore


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-5077) Grok support for Empty Captures

2018-05-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476065#comment-16476065
 ] 

ASF GitHub Bot commented on NIFI-5077:
--

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188344570
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
--- End diff --

since it's an "allowable values"-type of property, we usually set 
required=true


> Grok support for Empty Captures
> ---
>
> Key: NIFI-5077
> URL: https://issues.apache.org/jira/browse/NIFI-5077
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.6.0
> Environment: CentOS 7
>Reporter: Ramon de Graaff
>Assignee: Otto Fowler
>Priority: Major
> Attachments: grok.xml
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Pattern matches but also attaches null values.
> grok-pattern:
> {{TEST %\{A}|%\{B}}}
> {{A %\{INT:test}}}
> {{B %\{INT:test}}}
> {{INT (?:[+-]?(?:[0-9]+))}}
> flowfile-content:
> {{1}}
> Flow file attributes after match:
> {{grok.A}}
> {{1}}
> {{grok.TEST}}
> {{1}}
> {{grok.test}}
> {{[1, null]}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188345339
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -234,6 +247,11 @@ public void onStopped() {
 
 @OnScheduled
 public void onScheduled(final ProcessContext context) throws 
GrokException, IOException {
+
+if (context.getProperty(KEEP_EMPTY_CAPTURES).isSet()) {
--- End diff --

with required=true, you would not need to check if the property is set 
anymore


---

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188345184
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
+.defaultValue("true")
--- End diff --

isn't defaulting to true a change of the current behavior?


---

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread pvillard31

Github user pvillard31 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2698#discussion_r188344570
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
 ---
@@ -102,6 +103,15 @@
 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
 .build();
 
+public static final PropertyDescriptor KEEP_EMPTY_CAPTURES = new 
PropertyDescriptor.Builder()
+.name("Keep Empty Captures")
+.description("If true, then empty capture values will be 
included in the returned capture map.")
+.required(false)
--- End diff --

since it's an "allowable values"-type of property, we usually set 
required=true


---

1 2 >

1 - 100 of 164 matches

Mail list logo