[jira] [Comment Edited] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754536#comment-16754536 ] Mr TheSegfault edited comment on MINIFICPP-722 at 1/29/19 3:04 AM: --- [~srr] [~palokam] Not sure you are interested, but here's a quick video ( don't judge the quality. it's a pretty hastily made video ) I've made of a feature I'm working on [https://www.youtube.com/watch?v=Nv9QbWosPX0=youtu.be] It's a feature that can be conditionally included or excluded so for those who don't want embedded JNI call don't need to include that feature into their agent. was (Author: phrocker): [~srr] [~palokam] Not sure you are interested, but here's a quick video ( don't judge the quality. it's a pretty hastily made video ) I've made of a feature I'm working on [https://www.youtube.com/watch?v=Nv9QbWosPX0=youtu.be] > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > Time Spent: 10m > Remaining Estimate: 0h > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754536#comment-16754536 ] Mr TheSegfault commented on MINIFICPP-722: -- [~srr] [~palokam] Not sure you are interested, but here's a quick video I've made of a feature I'm working on https://www.youtube.com/watch?v=Nv9QbWosPX0=youtu.be > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > Time Spent: 10m > Remaining Estimate: 0h > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754536#comment-16754536 ] Mr TheSegfault edited comment on MINIFICPP-722 at 1/29/19 2:56 AM: --- [~srr] [~palokam] Not sure you are interested, but here's a quick video ( don't judge the quality. it's a pretty hastily made video ) I've made of a feature I'm working on [https://www.youtube.com/watch?v=Nv9QbWosPX0=youtu.be] was (Author: phrocker): [~srr] [~palokam] Not sure you are interested, but here's a quick video I've made of a feature I'm working on https://www.youtube.com/watch?v=Nv9QbWosPX0=youtu.be > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > Time Spent: 10m > Remaining Estimate: 0h > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251666314 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -602,6 +599,28 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina return webappContext; } +private void addHTTPHeaders(WebAppContext webappContext) { +// Add a filter to set the X-Frame-Options header +FilterHolder xfoFilter = new FilterHolder(new XFrameOptionsFilter()); +xfoFilter.setName(XFrameOptionsFilter.class.getSimpleName()); +webappContext.addFilter(xfoFilter, "/*", EnumSet.allOf(DispatcherType.class)); + +// Add a filter to set the Content Security Policy frame-ancestors directive +FilterHolder cspFilter = new FilterHolder(new ContentSecurityPolicyFilter()); Review comment: Yes, that did what I was describing. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251666039 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -586,7 +586,14 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina // configure the max form size (3x the default) webappContext.setMaxFormContentSize(60); -addHTTPHeaders(webappContext); +ArrayList> filters = new ArrayList<>(); Review comment: I think you could do ``` final String ALL_PATHS = "/*"; List> filters = new ArrayList>(Arrays.asList(XFrameOptionsFilter.class, ContentSecurityPolicyFilter.class, XSSProtectionFilter.class)); if (props.isHTTPSConfigured()) { filters.add(StrictTransportSecurityFilter.class); } filters.forEach { (filter) -> addFilters(filter, ALL_PATHS, webappContext)); ``` That will create an `ArrayList` around the original `array` but allow for modification (_i.e. adding the STS filter if necessary_). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251666039 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -586,7 +586,14 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina // configure the max form size (3x the default) webappContext.setMaxFormContentSize(60); -addHTTPHeaders(webappContext); +ArrayList> filters = new ArrayList<>(); Review comment: I think you could do ```final String ALL_PATHS = "/*"; List> filters = new ArrayList>(Arrays.asList(XFrameOptionsFilter.class, ContentSecurityPolicyFilter.class, XSSProtectionFilter.class)); if (props.isHTTPSConfigured()) { filters.add(StrictTransportSecurityFilter.class); } filters.forEach { (filter) -> addFilters(filter, ALL_PATHS, webappContext));``` That will create an `ArrayList` around the original `array` but allow for modification (_i.e. adding the STS filter if necessary_). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251664991 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -602,6 +599,28 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina return webappContext; } +private void addHTTPHeaders(WebAppContext webappContext) { +// Add a filter to set the X-Frame-Options header +FilterHolder xfoFilter = new FilterHolder(new XFrameOptionsFilter()); +xfoFilter.setName(XFrameOptionsFilter.class.getSimpleName()); +webappContext.addFilter(xfoFilter, "/*", EnumSet.allOf(DispatcherType.class)); + +// Add a filter to set the Content Security Policy frame-ancestors directive +FilterHolder cspFilter = new FilterHolder(new ContentSecurityPolicyFilter()); +cspFilter.setName(ContentSecurityPolicyFilter.class.getSimpleName()); +webappContext.addFilter(cspFilter, "/*", EnumSet.allOf(DispatcherType.class)); + +// Add a filter to set the HSTS header Review comment: Talked to @mcgilman and we believe the performance impact of using multiple filters will be negligible. Don't worry about this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251664715 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -602,6 +599,28 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina return webappContext; } +private void addHTTPHeaders(WebAppContext webappContext) { +// Add a filter to set the X-Frame-Options header +FilterHolder xfoFilter = new FilterHolder(new XFrameOptionsFilter()); Review comment: No no, that makes perfect sense and is evidence that you've actually worked on this, while I just looked at the code. Keep it this way to help with debugging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-5980) HBase List LookupService
Mike Thomsen created NIFI-5980: -- Summary: HBase List LookupService Key: NIFI-5980 URL: https://issues.apache.org/jira/browse/NIFI-5980 Project: Apache NiFi Issue Type: New Feature Reporter: Mike Thomsen Assignee: Mike Thomsen The existing lookup service is designed to return records. This makes it unsuitable for cases where someone wants to pull out a list of keys or values from the returned row and inject that into the record. For example, someone looking to add a list of roles to a record for downstream security constraints somewhere might store a lookup in HBase between the data item and its roles. Stored like this: :security:role_admin = 1 :security:role_auditor = 1 When the flow does a lookup on the item, ex. during a reingest event, these fields could be pulled out of HBase and inserted as a List into the record. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754326#comment-16754326 ] Mr TheSegfault commented on MINIFICPP-722: -- I submitted a PR that fixes a log statement that I noticed when I spun up an instance to address this. I just wanted to give credit to this ticket as helping locate the log statement issue. Thanks > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > Time Spent: 10m > Remaining Estimate: 0h > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] phrocker opened a new pull request #478: MINIFICPP-722: Fix log statement that was printing incorrect values b…
phrocker opened a new pull request #478: MINIFICPP-722: Fix log statement that was printing incorrect values b… URL: https://github.com/apache/nifi-minifi-cpp/pull/478 …ecause the format was incorrect Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754310#comment-16754310 ] Mr TheSegfault commented on MINIFICPP-722: -- [~srr] Np. Happy to explore the possibility of implementing this in C++. Let me know if you want to create a ticket for this. > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754301#comment-16754301 ] Rama Rao Srikakulapu commented on MINIFICPP-722: Thanks [~phrocker].. Just realized it.. Thank you > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (NIFIREG-209) Support rebuilding metadata DB from Git repo
[ https://issues.apache.org/jira/browse/NIFIREG-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-209. - Resolution: Fixed Fix Version/s: 0.4.0 > Support rebuilding metadata DB from Git repo > > > Key: NIFIREG-209 > URL: https://issues.apache.org/jira/browse/NIFIREG-209 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > Fix For: 0.4.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Since the release of git persistence for flow storage, many users have asked > if there is a way to stand up a new NiFi Registry instance and just point it > at an existing git repo of flows. > Currently the issue is that the git repo is only used for the persistence of > flow content, and the metadata comes from a relational database, so if you > lost your server and don't have a copy of the DB then the git repo alone > isn't enough. > In general the DB should be backed up, or an external DB with HA (Postgres) > should be used instead of the H2 DB, but we should also be able to offer a > way to bootstrap a new NiFi Registry instance from a git repo of flows. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754282#comment-16754282 ] Mr TheSegfault commented on MINIFICPP-722: -- [~srr]Thanks for that. We don't have ReplaceText in MiNiFi C++. Is this something that you need? > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit closed pull request #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp…
asfgit closed pull request #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp… URL: https://github.com/apache/nifi-registry/pull/144 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bbende commented on issue #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp…
bbende commented on issue #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp… URL: https://github.com/apache/nifi-registry/pull/144#issuecomment-458262915 Seems like a few people have tested this out and signed off, so I'm going to merge this to master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rama Rao Srikakulapu updated MINIFICPP-722: --- Attachment: config.yml > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754269#comment-16754269 ] Rama Rao Srikakulapu commented on MINIFICPP-722: Here is the flow file - [^config.yml] > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > Attachments: config.yml > > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree…
mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree… URL: https://github.com/apache/nifi/pull/3253#discussion_r251553453 ## File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/schema/inference/SchemaInferenceUtil.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.schema.inference; + +import org.apache.nifi.components.AllowableValue; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.components.PropertyDescriptor.Builder; +import org.apache.nifi.context.PropertyContext; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.schema.access.SchemaAccessStrategy; +import org.apache.nifi.serialization.RecordSchemaCacheService; + +import java.util.function.Supplier; + +public class SchemaInferenceUtil { +public static final AllowableValue INFER_SCHEMA = new AllowableValue("infer-schema", "Infer Schema", Review comment: Maybe add (and call) an overridden version of `AvroTypeUtil.extractAvroSchema()` that won't validate field names, it could be used in MergeRecord when `getSchemaText()` returns null, and in Record Writers when writing the schema to an attribute, e.g. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree…
mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree… URL: https://github.com/apache/nifi/pull/3253#discussion_r251514076 ## File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/remote/io/socket/ssl/SSLSocketChannel.java ## @@ -582,7 +583,12 @@ public int read(final byte[] buffer, final int offset, final int len) throws IOE continue; } case CLOSED: -throw new IOException("Channel is closed"); +copied = copyFromAppDataBuffer(buffer, offset, len); Review comment: Did something else sneak in here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree…
mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree… URL: https://github.com/apache/nifi/pull/3253#discussion_r251517480 ## File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/schema/inference/SchemaInferenceUtil.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.schema.inference; + +import org.apache.nifi.components.AllowableValue; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.components.PropertyDescriptor.Builder; +import org.apache.nifi.context.PropertyContext; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.schema.access.SchemaAccessStrategy; +import org.apache.nifi.serialization.RecordSchemaCacheService; + +import java.util.function.Supplier; + +public class SchemaInferenceUtil { +public static final AllowableValue INFER_SCHEMA = new AllowableValue("infer-schema", "Infer Schema", Review comment: Should we add either another option (or hardcode the behavior) to normalize the field names when creating a Avro schema? Alternatively we'd need a way for each reader (possibly writer as well?) to skip field validation when doing schema things. We have such a thing in the AvroSchemaRegistry, but I think it'd be required for schema inference to be fully useful. I ran into this when inferring the schema for provenance events, some attributes have `.` in the name, which causes a failure when extracting the schema: ``` 2019-01-28 12:32:03,735 ERROR [Timer-Driven Process Thread-8] o.a.nifi.processors.standard.MergeRecord MergeRecord[id=3ae34ae7-0166-1000-c69a-5846d15a6584] Failed to bin StandardFlowFileRecord[uuid=caa4fecc-b9fc-4e6b-ad8b-a2816a2197f3,claim=StandardContentClaim [resourceClaim=StandardResourceClaim[id=1548696079376-335, container=default, section=335], offset=131218, length=1387],offset=0,name=caa4fecc-b9fc-4e6b-ad8b-a2816a2197f3,size=1387] due to org.apache.avro.SchemaParseException: Illegal character in: reporting.task.type: org.apache.avro.SchemaParseException: Illegal character in: reporting.task.type org.apache.avro.SchemaParseException: Illegal character in: reporting.task.type at org.apache.avro.Schema.validateName(Schema.java:1151) at org.apache.avro.Schema.access$200(Schema.java:81) at org.apache.avro.Schema$Field.(Schema.java:403) at org.apache.avro.Schema$Field.(Schema.java:423) at org.apache.avro.Schema$Field.(Schema.java:415) at org.apache.nifi.avro.AvroTypeUtil.buildAvroField(AvroTypeUtil.java:122) at org.apache.nifi.avro.AvroTypeUtil.buildAvroSchema(AvroTypeUtil.java:203) at org.apache.nifi.avro.AvroTypeUtil.buildAvroField(AvroTypeUtil.java:121) at org.apache.nifi.avro.AvroTypeUtil.buildAvroSchema(AvroTypeUtil.java:113) at org.apache.nifi.avro.AvroTypeUtil.extractAvroSchema(AvroTypeUtil.java:93) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree…
mattyb149 commented on a change in pull request #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree… URL: https://github.com/apache/nifi/pull/3253#discussion_r251552380 ## File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/csv/CSVReader.java ## @@ -126,33 +131,27 @@ public void storeCsvFormat(final ConfigurationContext context) { @Override public RecordReader createRecordReader(final Map variables, final InputStream in, final ComponentLog logger) throws IOException, SchemaNotFoundException { // Use Mark/Reset of a BufferedInputStream in case we read from the Input Stream for the header. -final BufferedInputStream bufferedIn = new BufferedInputStream(in); -bufferedIn.mark(1024 * 1024); -final RecordSchema schema = getSchema(variables, new NonCloseableInputStream(bufferedIn), null); -bufferedIn.reset(); +in.mark(1024 * 1024); +final RecordSchema schema = getSchema(variables, new NonCloseableInputStream(in), null); +in.reset(); Review comment: Looks like something funky is going on with the mark/reset. If I use the defaults for CSVReader (Infer Schema, don't treat first line as header), I get the following exception: ``` org.apache.nifi.processor.exception.FlowFileAccessException: Could not reset stream from StandardFlowFileRecord[uuid=fb0648ce-7fc2-4507-8ecf-458fa57c03c4,claim=StandardContentClaim [resourceClaim=StandardResourceClaim[id=1548696073224-179, container=default, section=179], offset=115599, length=33],offset=0,name=fb0648ce-7fc2-4507-8ecf-458fa57c03c4,size=33] at org.apache.nifi.controller.repository.io.FlowFileAccessInputStream.reset(FlowFileAccessInputStream.java:153) at org.apache.nifi.controller.repository.io.TaskTerminationInputStream.reset(TaskTerminationInputStream.java:86) at org.apache.nifi.csv.CSVReader.createRecordReader(CSVReader.java:136) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:87) at com.sun.proxy.$Proxy232.createRecordReader(Unknown Source) at org.apache.nifi.processors.standard.AbstractRecordProcessor$1.process(AbstractRecordProcessor.java:126) at org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2897) at org.apache.nifi.processors.standard.AbstractRecordProcessor.onTrigger(AbstractRecordProcessor.java:122) at org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) at org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1162) at org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:205) at org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException: Stream has not been marked at org.apache.nifi.controller.repository.io.ContentClaimInputStream.reset(ContentClaimInputStream.java:131) at org.apache.nifi.controller.repository.io.DisableOnCloseInputStream.reset(DisableOnCloseInputStream.java:84) at org.apache.nifi.controller.repository.io.LimitedInputStream.reset(LimitedInputStream.java:123) at org.apache.nifi.controller.repository.io.DisableOnCloseInputStream.reset(DisableOnCloseInputStream.java:84) at org.apache.nifi.stream.io.ByteCountingInputStream.reset(ByteCountingInputStream.java:101) at java.io.FilterInputStream.reset(FilterInputStream.java:226) at org.apache.nifi.controller.repository.io.FlowFileAccessInputStream.reset(FlowFileAccessInputStream.java:151) ... 22 common frames omitted ``` This is an automated message from the Apache
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754237#comment-16754237 ] Mr TheSegfault commented on MINIFICPP-722: -- [~srr] Can you attach the flow by chance? > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754230#comment-16754230 ] Mr TheSegfault commented on MINIFICPP-722: -- [~srr]Thanks for that. I will dive into this right now. > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754226#comment-16754226 ] Rama Rao Srikakulapu edited comment on MINIFICPP-722 at 1/28/19 6:28 PM: - Hi, I took the code from master which is 0.6.0 and enabled MQTT. Here is the cmake command - cmake -DSKIP_TESTS=true -DENABLE_MQTT=true -DCMAKE_CXX_FLAGS=-lrt -DDISABLE_ROCKSDB=true .. Now I am seeing the following logs and still container is not starting - $ docker logs abc4cc39c2bb tail: can't open '/opt/minifi/nifi-minifi-cpp-0.6.0/logs/minifi-app.log': No such file or directory TC-Edge (MiNiFi) running with PID 18. [2019-01-infol 15:36:28.197] [main] [info] Using MINIFI_HOME=/opt/minifi/nifi-minifi-cpp-0.6.0 from environment. [2019-01-infol 15:36:28.197] [org::apache::nifi::minifi::Properties] [info] Using configuration file located at /opt/minifi/nifi-minifi-cpp-0.6.0/conf/minifi-log.properties, from ./conf/minifi-log.properties looking for /opt/minifi/nifi-minifi-cpp-0.6.0/./conf/minifi.properties setting default dir to /opt/minifi/nifi-minifi-cpp-0.6.0/content_repository Received trapped signal, beginning shutdown... was (Author: srr): Hi, I took the code from master which is 0.6.0 and enabled MQTT. Here is the cmake command - cmake -DSKIP_TESTS=true -DENABLE_MQTT=true -DCMAKE_CXX_FLAGS=-lrt -DDISABLE_ROCKSDB=true .. Now I am not seeing the following logs and still container is not starting - $ docker logs abc4cc39c2bb tail: can't open '/opt/minifi/nifi-minifi-cpp-0.6.0/logs/minifi-app.log': No such file or directory TC-Edge (MiNiFi) running with PID 18. [2019-01-infol 15:36:28.197] [main] [info] Using MINIFI_HOME=/opt/minifi/nifi-minifi-cpp-0.6.0 from environment. [2019-01-infol 15:36:28.197] [org::apache::nifi::minifi::Properties] [info] Using configuration file located at /opt/minifi/nifi-minifi-cpp-0.6.0/conf/minifi-log.properties, from ./conf/minifi-log.properties looking for /opt/minifi/nifi-minifi-cpp-0.6.0/./conf/minifi.properties setting default dir to /opt/minifi/nifi-minifi-cpp-0.6.0/content_repository Received trapped signal, beginning shutdown... > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-722) MQTT Processor failing - but cmake is fine
[ https://issues.apache.org/jira/browse/MINIFICPP-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754226#comment-16754226 ] Rama Rao Srikakulapu commented on MINIFICPP-722: Hi, I took the code from master which is 0.6.0 and enabled MQTT. Here is the cmake command - cmake -DSKIP_TESTS=true -DENABLE_MQTT=true -DCMAKE_CXX_FLAGS=-lrt -DDISABLE_ROCKSDB=true .. Now I am not seeing the following logs and still container is not starting - $ docker logs abc4cc39c2bb tail: can't open '/opt/minifi/nifi-minifi-cpp-0.6.0/logs/minifi-app.log': No such file or directory TC-Edge (MiNiFi) running with PID 18. [2019-01-infol 15:36:28.197] [main] [info] Using MINIFI_HOME=/opt/minifi/nifi-minifi-cpp-0.6.0 from environment. [2019-01-infol 15:36:28.197] [org::apache::nifi::minifi::Properties] [info] Using configuration file located at /opt/minifi/nifi-minifi-cpp-0.6.0/conf/minifi-log.properties, from ./conf/minifi-log.properties looking for /opt/minifi/nifi-minifi-cpp-0.6.0/./conf/minifi.properties setting default dir to /opt/minifi/nifi-minifi-cpp-0.6.0/content_repository Received trapped signal, beginning shutdown... > MQTT Processor failing - but cmake is fine > -- > > Key: MINIFICPP-722 > URL: https://issues.apache.org/jira/browse/MINIFICPP-722 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Prasad Alokam >Assignee: Mr TheSegfault >Priority: Blocker > > CMAKE options used: > cmake -DSKIP_TESTS=true .. -DENABLE_MQTT=TRUE -DCMAKE_CXX_FLAGS=-lrt > -DDISABLE_ROCKSDB=true > > No errors in CMAKE > Run time image have a problem > > (MiNiFi) running with PID 17. > {color:#FF}Error loading shared library libpaho-mqtt3c.so.1: No such file > or directory (needed by /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi){color} > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_setCallbacks: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_subscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_unsubscribe: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_disconnect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_isConnected: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_publishMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_freeMessage: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_connect: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_free: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_destroy: symbol not found > Error relocating /opt/minifi/nifi-minifi-cpp-0.5.0/bin/minifi: > MQTTClient_create: symbol not found > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5962) AbstractHadoopProcessor can NPE when a configuration issue happens
[ https://issues.apache.org/jira/browse/NIFI-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-5962: -- Resolution: Fixed Fix Version/s: 1.9.0 Status: Resolved (was: Patch Available) > AbstractHadoopProcessor can NPE when a configuration issue happens > -- > > Key: NIFI-5962 > URL: https://issues.apache.org/jira/browse/NIFI-5962 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.8.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.9.0 > > Time Spent: 10m > Remaining Estimate: 0h > > I was trying to configure a PutHDFS processor to connect to a kerberized HDFS > cluster, and because of an issue with the kerberos config, the login during > onScheduled failed and resulted on the configuration instance not being fully > constructed, and then going into onStopped and encountering a > NullPointerException: > {code:java} > 2019-01-17 14:12:23,359 ERROR [Timer-Driven Process Thread-8] > org.apache.nifi.util.ReflectionUtils Failed while invoking annotated method > 'public final void > org.apache.nifi.processors.hadoop.AbstractHadoopProcessor.abstractOnStopped()' > with arguments '[]'. > java.lang.reflect.InvocationTargetException: null > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:142) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:130) > at > org.apache.nifi.util.ReflectionUtils.quietlyInvokeMethodsWithAnnotations(ReflectionUtils.java:268) > at > org.apache.nifi.util.ReflectionUtils.quietlyInvokeMethodsWithAnnotation(ReflectionUtils.java:90) > at > org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$4(StandardProcessorNode.java:1547) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > Caused by: java.lang.NullPointerException: null > at > org.apache.nifi.processors.hadoop.AbstractHadoopProcessor.abstractOnStopped(AbstractHadoopProcessor.java:286) > ... 15 common frames omitted{code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit closed pull request #3270: NIFI-5962 protecting against null Configuration in AbstractHadoopProc…
asfgit closed pull request #3270: NIFI-5962 protecting against null Configuration in AbstractHadoopProc… URL: https://github.com/apache/nifi/pull/3270 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-5962) AbstractHadoopProcessor can NPE when a configuration issue happens
[ https://issues.apache.org/jira/browse/NIFI-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754211#comment-16754211 ] ASF subversion and git services commented on NIFI-5962: --- Commit 2eac0e96c73e03809b02b4a3be029842754e649f in nifi's branch refs/heads/master from Bryan Bende [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2eac0e9 ] NIFI-5962 protecting against null Configuration in AbstractHadoopProcessor onStopped This closes #3270. > AbstractHadoopProcessor can NPE when a configuration issue happens > -- > > Key: NIFI-5962 > URL: https://issues.apache.org/jira/browse/NIFI-5962 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.8.0 >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > I was trying to configure a PutHDFS processor to connect to a kerberized HDFS > cluster, and because of an issue with the kerberos config, the login during > onScheduled failed and resulted on the configuration instance not being fully > constructed, and then going into onStopped and encountering a > NullPointerException: > {code:java} > 2019-01-17 14:12:23,359 ERROR [Timer-Driven Process Thread-8] > org.apache.nifi.util.ReflectionUtils Failed while invoking annotated method > 'public final void > org.apache.nifi.processors.hadoop.AbstractHadoopProcessor.abstractOnStopped()' > with arguments '[]'. > java.lang.reflect.InvocationTargetException: null > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:142) > at > org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:130) > at > org.apache.nifi.util.ReflectionUtils.quietlyInvokeMethodsWithAnnotations(ReflectionUtils.java:268) > at > org.apache.nifi.util.ReflectionUtils.quietlyInvokeMethodsWithAnnotation(ReflectionUtils.java:90) > at > org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$4(StandardProcessorNode.java:1547) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) > at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > at java.lang.Thread.run(Thread.java:748) > Caused by: java.lang.NullPointerException: null > at > org.apache.nifi.processors.hadoop.AbstractHadoopProcessor.abstractOnStopped(AbstractHadoopProcessor.java:286) > ... 15 common frames omitted{code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251531600 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -602,6 +599,28 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina return webappContext; } +private void addHTTPHeaders(WebAppContext webappContext) { +// Add a filter to set the X-Frame-Options header +FilterHolder xfoFilter = new FilterHolder(new XFrameOptionsFilter()); Review comment: I could potentially drop that and do a much simpler add to the webappContext? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251531021 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -602,6 +599,28 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina return webappContext; } +private void addHTTPHeaders(WebAppContext webappContext) { +// Add a filter to set the X-Frame-Options header +FilterHolder xfoFilter = new FilterHolder(new XFrameOptionsFilter()); Review comment: I believe the only reason I did this was so that I could set the name for the holder/filter, which made it easier to debug when I was having issues adding filters correctly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251527821 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -583,13 +586,7 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina // configure the max form size (3x the default) webappContext.setMaxFormContentSize(60); -// add a filter to set the X-Frame-Options filter -webappContext.addFilter(new FilterHolder(FRAME_OPTIONS_FILTER), "/*", EnumSet.allOf(DispatcherType.class)); - -// add a filter to set the Content Security Policy frame-ancestors directive -FilterHolder cspFilter = new FilterHolder(new ContentSecurityPolicyFilter()); -cspFilter.setName(ContentSecurityPolicyFilter.class.getSimpleName()); -webappContext.addFilter(cspFilter, "/*", EnumSet.allOf(DispatcherType.class)); +addHTTPHeaders(webappContext); Review comment: Fixed this as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mattyb149 commented on issue #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree…
mattyb149 commented on issue #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree… URL: https://github.com/apache/nifi/pull/3253#issuecomment-458174871 Reviewing... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r251457960 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -602,6 +599,28 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina return webappContext; } +private void addHTTPHeaders(WebAppContext webappContext) { +// Add a filter to set the X-Frame-Options header +FilterHolder xfoFilter = new FilterHolder(new XFrameOptionsFilter()); +xfoFilter.setName(XFrameOptionsFilter.class.getSimpleName()); +webappContext.addFilter(xfoFilter, "/*", EnumSet.allOf(DispatcherType.class)); + +// Add a filter to set the Content Security Policy frame-ancestors directive +FilterHolder cspFilter = new FilterHolder(new ContentSecurityPolicyFilter()); Review comment: I've updated the PR with a commit to do what I think you're suggesting. Let me know if it's in any way correct :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] apiri commented on issue #465: MINIFICPP-700: Add MSI Support via CPACK
apiri commented on issue #465: MINIFICPP-700: Add MSI Support via CPACK URL: https://github.com/apache/nifi-minifi-cpp/pull/465#issuecomment-458163321 @phrocker didn't want to lose track of this. is this in a place where it is ready for another review? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kourge-ch opened a new pull request #3276: NIFI-5953 Manage GetTwitter connection retries on '420 Enhance Your C…
kourge-ch opened a new pull request #3276: NIFI-5953 Manage GetTwitter connection retries on '420 Enhance Your C… URL: https://github.com/apache/nifi/pull/3276 …alm' exceptions Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-5976) RedisConnectionPoolService doesn't use connection string in standalone mode
[ https://issues.apache.org/jira/browse/NIFI-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josef Zahner resolved NIFI-5976. Resolution: Duplicate Fix Version/s: 1.9.0 Duplicate,... original ticket: https://issues.apache.org/jira/browse/NIFI-5830 > RedisConnectionPoolService doesn't use connection string in standalone mode > --- > > Key: NIFI-5976 > URL: https://issues.apache.org/jira/browse/NIFI-5976 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.8.0 > Environment: Centos 7 > Secured NiFi 2 Node Cluster >Reporter: Josef Zahner >Priority: Major > Fix For: 1.9.0 > > > The RedisConnectionPoolService in "Redis Mode - Standalone" doesn't use the > "Connection String". If i insert _myhostname:6379_ it connects to > _localhost:6379_ instead. > *Verified by tcpdump*: > {code:java} > [tester@nifi-03 ~]$ sudo tcpdump -i any -s 1500 -X port 6379 tcpdump: verbose > output suppressed, use -v or -vv for full protocol decode listening on any, > link-type LINUX_SLL (Linux cooked), capture size 1500 bytes 13:00:13.422299 > IP localhost.52792 > localhost.6379: Flags [S], seq 2959469726, win 43690, > options [mss 65495,sackOK,TS val 1907747964 ecr 0,nop,wscale 11], length 0 > 0x: 4500 003c 00e2 4000 4006 3bd8 7f00 0001 E..<..@.@.;. 0x0010: 7f00 > 0001 ce38 18eb b065 ec9e .8...e.. 0x0020: a002 fe30 > 0204 ffd7 0402 080a .0.. 0x0030: 71b5 ec7c 0103 > 030b q..| 0x0040: > 13:00:13.422318 IP localhost.6379 > localhost.52792: Flags [R.], > seq 0, ack 2959469727, win 0, length 0 0x: 4500 0028 6d71 4000 4006 cf5c > 7f00 0001 E..(mq@.@..\ 0x0010: 7f00 0001 18eb ce38 b065 ec9f > ...8.e.. 0x0020: 5014 2da5 > P...-... 0x0030: > {code} > > *Workaround* (ssh tunnel localhost port 6379 to remote host): > {code:java} > ssh -f -C -N -L 127.0.0.1:6379:myhostname:6379 localhost > {code} > > Seems that I'm not the only one who has seen this: > [https://lists.apache.org/thread.html/412ca5acf6e31ed56ae1f871edd96a65ea27fc0d3aad9183044dfbc4@%3Cusers.nifi.apache.org%3E] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)