[jira] [Updated] (NIFI-6332) PutS3 Processor adding Cache-Control property

2019-05-29 Thread Dirk Arends (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dirk Arends updated NIFI-6332:
--
Description: 
The PutS3 Processor does not allow you to set the Cache-Control. My use case is 
to put files into S3 to be served and cached via Cloudflare. After looking at 
other issues I found NIFI-2810 which references [Github PR 
1034|[https://github.|https://github.com/apache/nifi/pull/1034] 
[com/apache/nifi/pull/1034|https://github.com/apache/nifi/pull/1034]] which 
added the property Content-Type to PutS3Object.
  
 Would there be anyone who and make these changes.

  was:
The PutS3 Processor does not allow you to set the Cache-Control. My use case is 
to put files into S3 to be served and cached via Cloudflare. After looking at 
other issues I found 
[NIFI-2810|https://issues.apache.org/jira/browse/NIFI-2810] which references 
[Github PR 1034|[https://github.com/apache/nifi/pull/1034]] which added the 
property Content-Type to PutS3Object.
 
Would there be anyone who and make these changes.


> PutS3 Processor adding Cache-Control property 
> --
>
> Key: NIFI-6332
> URL: https://issues.apache.org/jira/browse/NIFI-6332
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.8.0
>Reporter: Dirk Arends
>Priority: Major
>
> The PutS3 Processor does not allow you to set the Cache-Control. My use case 
> is to put files into S3 to be served and cached via Cloudflare. After looking 
> at other issues I found NIFI-2810 which references [Github PR 
> 1034|[https://github.|https://github.com/apache/nifi/pull/1034] 
> [com/apache/nifi/pull/1034|https://github.com/apache/nifi/pull/1034]] which 
> added the property Content-Type to PutS3Object.
>   
>  Would there be anyone who and make these changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (NIFI-6332) PutS3 Processor adding Cache-Control property

2019-05-29 Thread Dirk Arends (JIRA)
Dirk Arends created NIFI-6332:
-

 Summary: PutS3 Processor adding Cache-Control property 
 Key: NIFI-6332
 URL: https://issues.apache.org/jira/browse/NIFI-6332
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework
Affects Versions: 1.8.0
Reporter: Dirk Arends


The PutS3 Processor does not allow you to set the Cache-Control. My use case is 
to put files into S3 to be served and cached via Cloudflare. After looking at 
other issues I found 
[NIFI-2810|https://issues.apache.org/jira/browse/NIFI-2810] which references 
[Github PR 1034|[https://github.com/apache/nifi/pull/1034]] which added the 
property Content-Type to PutS3Object.
 
Would there be anyone who and make these changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (NIFI-6331) Remove dependency on external (non-Apache) HTTP resource for data feed

2019-05-29 Thread Andy LoPresto (JIRA)
Andy LoPresto created NIFI-6331:
---

 Summary: Remove dependency on external (non-Apache) HTTP resource 
for data feed
 Key: NIFI-6331
 URL: https://issues.apache.org/jira/browse/NIFI-6331
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Tools and Build
Affects Versions: 1.9.2
Reporter: Andy LoPresto


A test resource 
(https://github.com/apache/nifi/blob/master/nifi-testharness/src/test/resources/flow.xml#L85-L91)
 uses the BBC World RSS feed in a {{GetHTTP}} processor. This RSS feed is 
served over HTTP. I believe we should not rely on external (non-Apache) hosted 
services for tests, as these could change at any time, and regardless of the 
origin of the data, should prefer HTTPS unless explicitly testing HTTP 
services. 

I propose changing the test resource to use 
{{https://nifi.apache.org/security.html}} or any other page hosted on the NiFi 
site (the test flow functionality does not use any RSS features). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MINIFICPP-899) Add sensitive property capabilities.

2019-05-29 Thread Mr TheSegfault (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mr TheSegfault updated MINIFICPP-899:
-
Labels: c2  (was: )

> Add sensitive property capabilities. 
> -
>
> Key: MINIFICPP-899
> URL: https://issues.apache.org/jira/browse/MINIFICPP-899
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
>  Labels: c2
> Fix For: 0.7.0
>
>
> Should be able to add sensitive markers for properties. This matters more for 
> the manifest that is produced via c2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MINIFICPP-899) Add sensitive property capabilities.

2019-05-29 Thread Mr TheSegfault (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mr TheSegfault updated MINIFICPP-899:
-
Description: Should be able to add sensitive markers for properties. 

> Add sensitive property capabilities. 
> -
>
> Key: MINIFICPP-899
> URL: https://issues.apache.org/jira/browse/MINIFICPP-899
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
> Fix For: 0.7.0
>
>
> Should be able to add sensitive markers for properties. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MINIFICPP-899) Add sensitive property capabilities.

2019-05-29 Thread Mr TheSegfault (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mr TheSegfault updated MINIFICPP-899:
-
Description: Should be able to add sensitive markers for properties. This 
matters more for the manifest that is produced via c2.  (was: Should be able to 
add sensitive markers for properties. )

> Add sensitive property capabilities. 
> -
>
> Key: MINIFICPP-899
> URL: https://issues.apache.org/jira/browse/MINIFICPP-899
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Mr TheSegfault
>Assignee: Mr TheSegfault
>Priority: Major
> Fix For: 0.7.0
>
>
> Should be able to add sensitive markers for properties. This matters more for 
> the manifest that is produced via c2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] slyouts commented on issue #3476: NIFI-6022 ConsumeJMS - Added try/catch to protect against secondary exception in a…

2019-05-29 Thread GitBox
slyouts commented on issue #3476: NIFI-6022 ConsumeJMS - Added try/catch to 
protect against secondary exception in a…
URL: https://github.com/apache/nifi/pull/3476#issuecomment-497127872
 
 
   I'll be happy to rebase and squash the commits upon acceptance of this 
PR...unless there is some other process to handle that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MINIFICPP-899) Add sensitive property capabilities.

2019-05-29 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-899:


 Summary: Add sensitive property capabilities. 
 Key: MINIFICPP-899
 URL: https://issues.apache.org/jira/browse/MINIFICPP-899
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Mr TheSegfault
Assignee: Mr TheSegfault
 Fix For: 0.7.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6302) Prune Process Group contents

2019-05-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851325#comment-16851325
 ] 

ASF subversion and git services commented on NIFI-6302:
---

Commit 999cfdcac9bde93b125a809340ab9cfea6936bd6 in nifi's branch 
refs/heads/master from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=999cfdc ]

NIFI-6302:
- Updating integration tests to verify pruned results.

This closes #3487.

Signed-off-by: Andy LoPresto 


> Prune Process Group contents
> 
>
> Key: NIFI-6302
> URL: https://issues.apache.org/jira/browse/NIFI-6302
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Need to ensure the Process Group contents are appropriately pruned when 
> necessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] asfgit closed pull request #3487: NIFI-6302: Updating integration tests to verify pruned results

2019-05-29 Thread GitBox
asfgit closed pull request #3487: NIFI-6302: Updating integration tests to 
verify pruned results
URL: https://github.com/apache/nifi/pull/3487
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (NIFI-6302) Prune Process Group contents

2019-05-29 Thread Andy LoPresto (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto resolved NIFI-6302.
-
Resolution: Fixed

> Prune Process Group contents
> 
>
> Key: NIFI-6302
> URL: https://issues.apache.org/jira/browse/NIFI-6302
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Need to ensure the Process Group contents are appropriately pruned when 
> necessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] alopresto commented on issue #3487: NIFI-6302: Updating integration tests to verify pruned results

2019-05-29 Thread GitBox
alopresto commented on issue #3487: NIFI-6302: Updating integration tests to 
verify pruned results
URL: https://github.com/apache/nifi/pull/3487#issuecomment-497120372
 
 
   Ran `contrib-check` and all tests (including the integration tests) pass. 
+1, merging. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] slyouts commented on a change in pull request #3476: NIFI-6022 ConsumeJMS - Added try/catch to protect against secondary exception in a…

2019-05-29 Thread GitBox
slyouts commented on a change in pull request #3476: NIFI-6022 ConsumeJMS - 
Added try/catch to protect against secondary exception in a…
URL: https://github.com/apache/nifi/pull/3476#discussion_r288780421
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSConsumer.java
 ##
 @@ -126,7 +123,11 @@ public Void doInJms(final Session session) throws 
JMSException {
 // We need to call recover to ensure that in the event of
 // abrupt end or exception the current session will stop 
message
 // delivery and restart with the oldest unacknowledged 
message
-session.recover();
+try {
+session.recover();
+} catch (Exception e1) {
+// likely the session is closed...just ignore and 
press on with initial problem
 
 Review comment:
   Yes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] slyouts commented on a change in pull request #3476: NIFI-6022 ConsumeJMS - Added try/catch to protect against secondary exception in a…

2019-05-29 Thread GitBox
slyouts commented on a change in pull request #3476: NIFI-6022 ConsumeJMS - 
Added try/catch to protect against secondary exception in a…
URL: https://github.com/apache/nifi/pull/3476#discussion_r288780237
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSConsumer.java
 ##
 @@ -126,7 +123,11 @@ public Void doInJms(final Session session) throws 
JMSException {
 // We need to call recover to ensure that in the event of
 // abrupt end or exception the current session will stop 
message
 // delivery and restart with the oldest unacknowledged 
message
-session.recover();
+try {
+session.recover();
+} catch (Exception e1) {
+// likely the session is closed...just ignore and 
press on with initial problem
+}
 
 Review comment:
   I was attempting to use the Apache NiFi code style standards...if I missed 
that mark please let me know.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (NIFI-6022) ConsumeJMS - admin yielding when session.recover fails

2019-05-29 Thread Steven Youtsey (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steven Youtsey updated NIFI-6022:
-
Summary: ConsumeJMS - admin yielding when session.recover fails  (was: 
ConsumeJMS - admin yielding)

> ConsumeJMS - admin yielding when session.recover fails
> --
>
> Key: NIFI-6022
> URL: https://issues.apache.org/jira/browse/NIFI-6022
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.7.1
>Reporter: Steven Youtsey
>Assignee: Steven Youtsey
>Priority: Major
>  Labels: easyfix
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Processor admin yields when session with JMS provider is closed.
> When an exception occurs (no idea what as it was stepped on) and the session 
> is closed, the exception handler attempts to use the session and another 
> exception is thrown and not caught by the processor. See JMSConsumer, line 
> 129. Need to wrap that with a try/catch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6312) AMQP processors seem to have thread cleanup issues

2019-05-29 Thread Robert Bruno (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851297#comment-16851297
 ] 

Robert Bruno commented on NIFI-6312:


Will try building the AMQP processor with news client library and testing on a 
test cluster.   Will report back if issues are fixed.  If not hopefully I can 
generate some very isolated thread dumps.  Should be able to do this next week.

> AMQP processors seem to have thread cleanup issues
> --
>
> Key: NIFI-6312
> URL: https://issues.apache.org/jira/browse/NIFI-6312
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.9.0
>Reporter: Robert Bruno
>Priority: Major
>
> At a minimum the ConsumeAMQP processor exhibits this behavior but the 
> PublishAMQP may as well.
> If ConsumeAMQP is listening to a working AMQP server and then that server 
> name is no longer resolvable errors begin to show up in logs saying the 
> hostname can't be resolve.  This is expected.
> What isn't expected is if you then turn off the processor or even delete the 
> processor the error message persists.  The only way to resolve this is 
> restarting the nifi node.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6318) Support EL in CSV formatting properties

2019-05-29 Thread Peter Turcsanyi (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-6318:
--
Status: Patch Available  (was: Open)

> Support EL in CSV formatting properties
> ---
>
> Key: NIFI-6318
> URL: https://issues.apache.org/jira/browse/NIFI-6318
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Improve CSV components to support dynamic configuration of the CSV delimiter 
> and other formatting parameters via expression language / flowfile attributes.
> Components:
>  - CSVReader
>  - CSVRecordSetWriter
>  - ConvertExcelToCSVProcessor
> Properties:
>  - delimiter
>  - quote character
>  - escape character



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] turcsanyip opened a new pull request #3504: NIFI-6318: Support EL in CSV formatting properties

2019-05-29 Thread GitBox
turcsanyip opened a new pull request #3504: NIFI-6318: Support EL in CSV 
formatting properties
URL: https://github.com/apache/nifi/pull/3504
 
 
   CSVReader and CSVRecordSetWriter controller services and also 
ConvertExcelToCSVProcessor
   support EL for Value Separator, Quote Character and Escape Character 
properties.
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   _Enables X functionality; fixes bug NIFI-._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `master`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MINIFICPP-834) Create static links for lzma

2019-05-29 Thread Mr TheSegfault (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851279#comment-16851279
 ] 

Mr TheSegfault commented on MINIFICPP-834:
--

This may be something included via python. there is a ticket to statically 
include ( via a build ) of python...may be a worthwhile effort soon

> Create static links for lzma
> 
>
> Key: MINIFICPP-834
> URL: https://issues.apache.org/jira/browse/MINIFICPP-834
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Statically link lzma when shared libs are turned off. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MINIFICPP-810) add docker verify to travis

2019-05-29 Thread Mr TheSegfault (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mr TheSegfault updated MINIFICPP-810:
-
Priority: Blocker  (was: Major)

> add docker verify to travis
> ---
>
> Key: MINIFICPP-810
> URL: https://issues.apache.org/jira/browse/MINIFICPP-810
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Daniel Bakai
>Priority: Blocker
> Fix For: 0.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MINIFICPP-800) Add ability to docker env to load all processors.

2019-05-29 Thread Mr TheSegfault (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mr TheSegfault updated MINIFICPP-800:
-
Priority: Critical  (was: Major)

> Add ability to docker env to load all processors. 
> --
>
> Key: MINIFICPP-800
> URL: https://issues.apache.org/jira/browse/MINIFICPP-800
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Mr TheSegfault
>Assignee: Daniel Bakai
>Priority: Critical
> Fix For: 0.7.0
>
>
> Currently processors are defined with the default constructors. We should 
> augment this in the test environment so that we can use a similar path that 
> Python processors do to support better python testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread Bryan Bende (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851263#comment-16851263
 ] 

Bryan Bende commented on NIFI-6327:
---

hi [~dsargrad] , I can't really speak to the specific eclipse problems, but in 
terms of running the application, you generally run the explodes assembly that 
is built from the Maven build, which for current master would be 
nifi-assembly/target/nifi-1.10.0-SNAPSHOT-bin/nifi-1.10.0-SNAPSHOT/. I think it 
is a matter of personal preference how to do that, I personally write/modify 
code in Intellij, and then switch over to a terminal to run builds and run the 
application. I have seen others run Maven builds from with in their IDE, and 
then also use the IDE to launch the resulting assembly by calling the nifi.sh 
bash script. Depending what code you are changing, you typically don't need to 
rebuild everything, you can just rebuild the NAR you are working on and copy it 
into nifi-assembly/target/nifi-xyz-bin/nifi-xyz-bin/lib (assuming that is the 
location you run the application from).

> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png, image-2019-05-29-09-04-24-313.png, 
> image-2019-05-29-09-06-00-609.png
>
>
> I followed the following instructions to clone and build NIFI:
> [https://nifi.apache.org/quickstart.html]
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> If I click on one of the failed projects, I see the following error.
>  
> !image-2019-05-29-09-04-24-313.png!
>  
> !image-2019-05-29-09-06-00-609.png!
>  
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6312) AMQP processors seem to have thread cleanup issues

2019-05-29 Thread Robert Bruno (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851256#comment-16851256
 ] 

Robert Bruno commented on NIFI-6312:


No problem.  It has us baffled as well since it seems unlikely a processor 
could do this.  Thanks so much for the responses!

> AMQP processors seem to have thread cleanup issues
> --
>
> Key: NIFI-6312
> URL: https://issues.apache.org/jira/browse/NIFI-6312
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.9.0
>Reporter: Robert Bruno
>Priority: Major
>
> At a minimum the ConsumeAMQP processor exhibits this behavior but the 
> PublishAMQP may as well.
> If ConsumeAMQP is listening to a working AMQP server and then that server 
> name is no longer resolvable errors begin to show up in logs saying the 
> hostname can't be resolve.  This is expected.
> What isn't expected is if you then turn off the processor or even delete the 
> processor the error message persists.  The only way to resolve this is 
> restarting the nifi node.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (NIFI-6330) Upgrade Jetty to latest

2019-05-29 Thread Nathan Gough (JIRA)
Nathan Gough created NIFI-6330:
--

 Summary: Upgrade Jetty to latest
 Key: NIFI-6330
 URL: https://issues.apache.org/jira/browse/NIFI-6330
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework
Affects Versions: 1.9.2
Reporter: Nathan Gough
Assignee: Nathan Gough
 Fix For: 1.10.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] andrewmlim commented on issue #3503: NIFI-6319 Update User Guide for RPG/S2S changes for multiple URLs, batch settings, and remote input/output ports

2019-05-29 Thread GitBox
andrewmlim commented on issue #3503: NIFI-6319 Update User Guide for RPG/S2S 
changes for multiple URLs, batch settings, and remote input/output ports
URL: https://github.com/apache/nifi/pull/3503#issuecomment-497081203
 
 
   @ijokarumawak , if you have a chance, please take a look as it relates to 
the S2S work you've done recently. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] andrewmlim closed pull request #3502: NIFI-6319 Update User Guide for RPG/S2S changes for multiple URLs, ba…

2019-05-29 Thread GitBox
andrewmlim closed pull request #3502: NIFI-6319 Update User Guide for RPG/S2S 
changes for multiple URLs, ba…
URL: https://github.com/apache/nifi/pull/3502
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] andrewmlim opened a new pull request #3503: NIFI-6319 Improved RPG Ports screenshot

2019-05-29 Thread GitBox
andrewmlim opened a new pull request #3503: NIFI-6319 Improved RPG Ports 
screenshot
URL: https://github.com/apache/nifi/pull/3503
 
 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Reopened] (NIFI-6244) Allow GenerateTableFetch to partition without a max-value column

2019-05-29 Thread Matt Burgess (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess reopened NIFI-6244:


Reopening due to the possibility of duplicate and/or missing rows. We won't be 
able to use newid() on multiple fetches due to the fact that each partition 
fetch may sort the rows arbitrarily, so some rows may show up in multiple 
partitions and some rows may not show up in any partition.

I will investigate picking a column from the table (perhaps always the first 
one, or possibly finding one that definitely can be ordered) to order by. If 
that is not viable, the original PR should be reverted and this issue can be 
closed.

> Allow GenerateTableFetch to partition without a max-value column
> 
>
> Key: NIFI-6244
> URL: https://issues.apache.org/jira/browse/NIFI-6244
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> For some RDBMS systems / SQL dialects, it is not valid to try and 
> paginate/partition rows without an ORDER BY clause. MS SQL Server 2012+ is 
> one example (see 
> [here|https://stackoverflow.com/questions/49262675/issue-with-generate-table-fetch-sql-server-2016]
>  for more details).  However some systems/dialects allow for a "dummy" or 
> default ordering, which can be generated when no ordering clause is provided 
> to the database adapter. Again with MS SQL Server 2012+ as an example, you 
> can ORDER BY newid().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] andrewmlim opened a new pull request #3502: NIFI-6319 Update User Guide for RPG/S2S changes for multiple URLs, ba…

2019-05-29 Thread GitBox
andrewmlim opened a new pull request #3502: NIFI-6319 Update User Guide for 
RPG/S2S changes for multiple URLs, ba…
URL: https://github.com/apache/nifi/pull/3502
 
 
   …tch settings and remote input/output ports


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (NIFI-6319) Improve docs around Site-to-Site changes (URLs, batch settings, remote ports)

2019-05-29 Thread Andrew Lim (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim updated NIFI-6319:
-
Description: I noticed that there isn't any documentation for the ability 
to reference multiple URLs in an RPG and RPG port batch settings. New 
screenshots are needed and current screenshots need to be updated.  (was: I 
noticed that there isn't any documentation for the ability to reference 
multiple URLs in an RPG, RPG port batch setting and remote input/output ports. 
New screenshots are needed and current screenshots need to be updated.)

> Improve docs around Site-to-Site changes (URLs, batch settings, remote ports)
> -
>
> Key: NIFI-6319
> URL: https://issues.apache.org/jira/browse/NIFI-6319
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation  Website
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Minor
>
> I noticed that there isn't any documentation for the ability to reference 
> multiple URLs in an RPG and RPG port batch settings. New screenshots are 
> needed and current screenshots need to be updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6319) Improve docs around Site-to-Site changes (URLs, batch settings, remote ports)

2019-05-29 Thread Andrew Lim (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim updated NIFI-6319:
-
Description: I noticed that there isn't any documentation for the ability 
to reference multiple URLs in an RPG, RPG port batch setting and remote 
input/output ports. New screenshots are needed and current screenshots need to 
be updated.  (was: I noticed that there isn't any documentation for the ability 
to reference multiple URLs in an RPG as well as for RPG port batch settings.  
Current screenshots are out of date as a result.)

> Improve docs around Site-to-Site changes (URLs, batch settings, remote ports)
> -
>
> Key: NIFI-6319
> URL: https://issues.apache.org/jira/browse/NIFI-6319
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation  Website
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Minor
>
> I noticed that there isn't any documentation for the ability to reference 
> multiple URLs in an RPG, RPG port batch setting and remote input/output 
> ports. New screenshots are needed and current screenshots need to be updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6319) Improve docs around Site-to-Site changes (URLs, batch settings, remote ports)

2019-05-29 Thread Andrew Lim (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim updated NIFI-6319:
-
Summary: Improve docs around Site-to-Site changes (URLs, batch settings, 
remote ports)  (was: Improve docs around Site-to-Site URLs and Batch Settings)

> Improve docs around Site-to-Site changes (URLs, batch settings, remote ports)
> -
>
> Key: NIFI-6319
> URL: https://issues.apache.org/jira/browse/NIFI-6319
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation  Website
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Minor
>
> I noticed that there isn't any documentation for the ability to reference 
> multiple URLs in an RPG as well as for RPG port batch settings.  Current 
> screenshots are out of date as a result.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6323) Evaluate dependency sources

2019-05-29 Thread Matt Gilman (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-6323:
--
   Resolution: Fixed
Fix Version/s: 1.10.0
   Status: Resolved  (was: Patch Available)

> Evaluate dependency sources
> ---
>
> Key: NIFI-6323
> URL: https://issues.apache.org/jira/browse/NIFI-6323
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.9.2
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Periodic review of dependency sources. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] joewitt opened a new pull request #3501: NIFI-6329 added dist section to specify trusty

2019-05-29 Thread GitBox
joewitt opened a new pull request #3501: NIFI-6329 added dist section to 
specify trusty
URL: https://github.com/apache/nifi/pull/3501
 
 
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   _Enables X functionality; fixes bug NIFI-._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `master`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (NIFI-6329) Specify Trusty for travis-ci

2019-05-29 Thread Joseph Witt (JIRA)
Joseph Witt created NIFI-6329:
-

 Summary: Specify Trusty for travis-ci
 Key: NIFI-6329
 URL: https://issues.apache.org/jira/browse/NIFI-6329
 Project: Apache NiFi
  Issue Type: Task
Reporter: Joseph Witt


Our builds used to select Travis-CI 'trusty' node types.  All worked well.  Now 
it selects 'Xenial' by default and since then OracleJDK8 builds are failing to 
install.  We should specify we want 'Trusty'.  Once we're on java11 this will 
be probably not needed any longer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] asfgit closed pull request #3497: NIFI-6323 Changed URLs in XML files to use https:// where possible

2019-05-29 Thread GitBox
asfgit closed pull request #3497: NIFI-6323 Changed URLs in XML files to use 
https:// where possible
URL: https://github.com/apache/nifi/pull/3497
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (NIFI-6323) Evaluate dependency sources

2019-05-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851192#comment-16851192
 ] 

ASF subversion and git services commented on NIFI-6323:
---

Commit e6c843f465da98fd7dc640e53214e4aeefa61b7d in nifi's branch 
refs/heads/master from Andy LoPresto
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e6c843f ]

NIFI-6323 Changed URLs for repositories, project description, and mailing lists 
to use HTTPS.
NIFI-6323 Changed URLs for splunk.artifactoryonline.com to use HTTPS 
(certificate validity warning in browsers, but command-line connection using 
openssl s_client is successful).
NIFI-6323 Changed URLs for XMLNS schema locations to use HTTPS (the XMLNS and 
schema identifier remain http:// because they are not designed to be 
resolvable).
NIFI-6323 Fixed Maven XML schema descriptor URLs.

This closes #3497


> Evaluate dependency sources
> ---
>
> Key: NIFI-6323
> URL: https://issues.apache.org/jira/browse/NIFI-6323
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.9.2
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Periodic review of dependency sources. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6323) Evaluate dependency sources

2019-05-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851191#comment-16851191
 ] 

ASF subversion and git services commented on NIFI-6323:
---

Commit e6c843f465da98fd7dc640e53214e4aeefa61b7d in nifi's branch 
refs/heads/master from Andy LoPresto
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e6c843f ]

NIFI-6323 Changed URLs for repositories, project description, and mailing lists 
to use HTTPS.
NIFI-6323 Changed URLs for splunk.artifactoryonline.com to use HTTPS 
(certificate validity warning in browsers, but command-line connection using 
openssl s_client is successful).
NIFI-6323 Changed URLs for XMLNS schema locations to use HTTPS (the XMLNS and 
schema identifier remain http:// because they are not designed to be 
resolvable).
NIFI-6323 Fixed Maven XML schema descriptor URLs.

This closes #3497


> Evaluate dependency sources
> ---
>
> Key: NIFI-6323
> URL: https://issues.apache.org/jira/browse/NIFI-6323
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.9.2
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Periodic review of dependency sources. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6323) Evaluate dependency sources

2019-05-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851190#comment-16851190
 ] 

ASF subversion and git services commented on NIFI-6323:
---

Commit e6c843f465da98fd7dc640e53214e4aeefa61b7d in nifi's branch 
refs/heads/master from Andy LoPresto
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e6c843f ]

NIFI-6323 Changed URLs for repositories, project description, and mailing lists 
to use HTTPS.
NIFI-6323 Changed URLs for splunk.artifactoryonline.com to use HTTPS 
(certificate validity warning in browsers, but command-line connection using 
openssl s_client is successful).
NIFI-6323 Changed URLs for XMLNS schema locations to use HTTPS (the XMLNS and 
schema identifier remain http:// because they are not designed to be 
resolvable).
NIFI-6323 Fixed Maven XML schema descriptor URLs.

This closes #3497


> Evaluate dependency sources
> ---
>
> Key: NIFI-6323
> URL: https://issues.apache.org/jira/browse/NIFI-6323
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.9.2
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Periodic review of dependency sources. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6323) Evaluate dependency sources

2019-05-29 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851193#comment-16851193
 ] 

ASF subversion and git services commented on NIFI-6323:
---

Commit e6c843f465da98fd7dc640e53214e4aeefa61b7d in nifi's branch 
refs/heads/master from Andy LoPresto
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e6c843f ]

NIFI-6323 Changed URLs for repositories, project description, and mailing lists 
to use HTTPS.
NIFI-6323 Changed URLs for splunk.artifactoryonline.com to use HTTPS 
(certificate validity warning in browsers, but command-line connection using 
openssl s_client is successful).
NIFI-6323 Changed URLs for XMLNS schema locations to use HTTPS (the XMLNS and 
schema identifier remain http:// because they are not designed to be 
resolvable).
NIFI-6323 Fixed Maven XML schema descriptor URLs.

This closes #3497


> Evaluate dependency sources
> ---
>
> Key: NIFI-6323
> URL: https://issues.apache.org/jira/browse/NIFI-6323
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Affects Versions: 1.9.2
>Reporter: Andy LoPresto
>Assignee: Andy LoPresto
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Periodic review of dependency sources. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] mcgilman commented on issue #3497: NIFI-6323 Changed URLs in XML files to use https:// where possible

2019-05-29 Thread GitBox
mcgilman commented on issue #3497: NIFI-6323 Changed URLs in XML files to use 
https:// where possible
URL: https://github.com/apache/nifi/pull/3497#issuecomment-497057818
 
 
   Also +1. Successful build with cleaned mvn repo. Verified standalone and 
clustered functionality. Will merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] joewitt commented on issue #3497: NIFI-6323 Changed URLs in XML files to use https:// where possible

2019-05-29 Thread GitBox
joewitt commented on issue #3497: NIFI-6323 Changed URLs in XML files to use 
https:// where possible
URL: https://github.com/apache/nifi/pull/3497#issuecomment-497057069
 
 
   did full clean build w/contrib check.  all looks good and nifi itself still 
seems good.  +1 (assuming gilman also is)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (MINIFICPP-898) Listen port validator is broken

2019-05-29 Thread Mr TheSegfault (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mr TheSegfault resolved MINIFICPP-898.
--
Resolution: Fixed

> Listen port validator is broken
> ---
>
> Key: MINIFICPP-898
> URL: https://issues.apache.org/jira/browse/MINIFICPP-898
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Arpad Boda
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Listen port validator allows "0" , but should be called "port validator" to 
> maintain compatibility with NiFi validators. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-898) Listen port validator is broken

2019-05-29 Thread Mr TheSegfault (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851177#comment-16851177
 ] 

Mr TheSegfault commented on MINIFICPP-898:
--

We can have custom validators, so I imagine you were trying to match the name 
of an Apache NiFi Standard Validator – that is my fault for missing that as I 
made a wild assumption that we would be using a different validator. Thanks for 
fixing!

> Listen port validator is broken
> ---
>
> Key: MINIFICPP-898
> URL: https://issues.apache.org/jira/browse/MINIFICPP-898
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Arpad Boda
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Listen port validator allows "0" , but should be called "port validator" to 
> maintain compatibility with NiFi validators. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6312) AMQP processors seem to have thread cleanup issues

2019-05-29 Thread Joseph Witt (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851171#comment-16851171
 ] 

Joseph Witt commented on NIFI-6312:
---

Robert: Can you please share thread dumps and configuration details to back up 
the statement about the lock-up?  Issues in a single component should be hard 
pressed to create issues for others unless of course that thing wildly consumes 
all threads or consumes all remaining memory/etc..

> AMQP processors seem to have thread cleanup issues
> --
>
> Key: NIFI-6312
> URL: https://issues.apache.org/jira/browse/NIFI-6312
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.9.0
>Reporter: Robert Bruno
>Priority: Major
>
> At a minimum the ConsumeAMQP processor exhibits this behavior but the 
> PublishAMQP may as well.
> If ConsumeAMQP is listening to a working AMQP server and then that server 
> name is no longer resolvable errors begin to show up in logs saying the 
> hostname can't be resolve.  This is expected.
> What isn't expected is if you then turn off the processor or even delete the 
> processor the error message persists.  The only way to resolve this is 
> restarting the nifi node.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6312) AMQP processors seem to have thread cleanup issues

2019-05-29 Thread Robert Bruno (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851163#comment-16851163
 ] 

Robert Bruno commented on NIFI-6312:


Also run ran into an issue where I falsely assumed ConsumeAMQP queue field 
supported variables (would be really helpful if it did).  This mistake caused 
entire NiFi UI to lock up and required restarting all NiFi node again.

> AMQP processors seem to have thread cleanup issues
> --
>
> Key: NIFI-6312
> URL: https://issues.apache.org/jira/browse/NIFI-6312
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.9.0
>Reporter: Robert Bruno
>Priority: Major
>
> At a minimum the ConsumeAMQP processor exhibits this behavior but the 
> PublishAMQP may as well.
> If ConsumeAMQP is listening to a working AMQP server and then that server 
> name is no longer resolvable errors begin to show up in logs saying the 
> hostname can't be resolve.  This is expected.
> What isn't expected is if you then turn off the processor or even delete the 
> processor the error message persists.  The only way to resolve this is 
> restarting the nifi node.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi-minifi-cpp] asfgit closed pull request #574: MINIFICPP-898 - Listen port validator is broken

2019-05-29 Thread GitBox
asfgit closed pull request #574: MINIFICPP-898 - Listen port validator is broken
URL: https://github.com/apache/nifi-minifi-cpp/pull/574
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] phrocker commented on issue #574: MINIFICPP-898 - Listen port validator is broken

2019-05-29 Thread GitBox
phrocker commented on issue #574: MINIFICPP-898 - Listen port validator is 
broken
URL: https://github.com/apache/nifi-minifi-cpp/pull/574#issuecomment-497048707
 
 
   @bakaid Not really a regression as it is new functionality added in that. 
Arpad is trying to ensure the Apache NiFi validators are called. 
LISTEN_PORT_VALIDATOR is not one in the StandardValidators. That doesn't mean 
that we can't add a LISTEN_PORT_VALIDATOR or a regex validator reference...but 
my assumption ( which I will make in order to merge this ) is that @arpadboda 
wanted to have the standard port validator be referenced via the manifest. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] mcgilman commented on issue #3497: NIFI-6323 Changed URLs in XML files to use https:// where possible

2019-05-29 Thread GitBox
mcgilman commented on issue #3497: NIFI-6323 Changed URLs in XML files to use 
https:// where possible
URL: https://github.com/apache/nifi/pull/3497#issuecomment-497038643
 
 
   Will review...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] jtstorck commented on issue #3498: NIFI-6286 create new ScanHDFS processor

2019-05-29 Thread GitBox
jtstorck commented on issue #3498: NIFI-6286 create new ScanHDFS processor
URL: https://github.com/apache/nifi/pull/3498#issuecomment-497026983
 
 
   Reviewing...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] ottobackwards commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
ottobackwards commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-497025614
 
 
   look at you two crazy kids, working things out!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread David Sargrad (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Sargrad updated NIFI-6327:

Description: 
I followed the following instructions to clone and build NIFI:

[https://nifi.apache.org/quickstart.html]

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

If I click on one of the failed projects, I see the following error.

 

!image-2019-05-29-09-04-24-313.png!

 

!image-2019-05-29-09-06-00-609.png!

 

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!

  was:
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

If I click on one of the failed projects, I see the following error.

 

!image-2019-05-29-09-04-24-313.png!

 

!image-2019-05-29-09-06-00-609.png!

 

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!


> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png, image-2019-05-29-09-04-24-313.png, 
> image-2019-05-29-09-06-00-609.png
>
>
> I followed the following instructions to clone and build NIFI:
> [https://nifi.apache.org/quickstart.html]
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> If I click on one of the failed projects, I see the following error.
>  
> !image-2019-05-29-09-04-24-313.png!
>  
> !image-2019-05-29-09-06-00-609.png!
>  
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-819) OPC Unified Architecture Support

2019-05-29 Thread Otto Fowler (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851070#comment-16851070
 ] 

Otto Fowler commented on MINIFICPP-819:
---

That is great :)

> OPC Unified Architecture Support
> 
>
> Key: MINIFICPP-819
> URL: https://issues.apache.org/jira/browse/MINIFICPP-819
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Epic
>Reporter: Mr TheSegfault
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> The OPC unified architecture is a popular machine to machine industrial 
> protocol. There are numerous implementations and the specification itself is 
> quite complex (1,250 pages!). The aim is to provide a communication protocol 
> that is not operating system dependent but full feature which leads to the 
> complexity. I think it not reasonable that we can tackle this entire 
> specification right off the bat but rather work on bite size chunks at a 
> time. This epic will serve as the parent for all OPC related features as we 
> work toward over time, fingers crossed, supporting as much as those 1,250 
> pages of specification that reasonably makes sense.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] markap14 commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
markap14 commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-497018871
 
 
   @FrederikP I agree that we should be able to only rebuild the Evaluators in 
certain cases and this felt *really* familiar to me. I could have sworn 
that I had implemented something like that a while back. Turns out... NIFI-5801 
/ https://github.com/apache/nifi/pull/3277 - I put up a PR but it hasn't been 
reviewed yet. Unfortunately, sometimes these things get stuck in the pipeline. 
Will try to bother some people to get a review though :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] SatwikBhandiwad commented on issue #3257: NIFI-5435 Prometheus /metrics http endpoint for monitoring integration

2019-05-29 Thread GitBox
SatwikBhandiwad commented on issue #3257: NIFI-5435 Prometheus /metrics http 
endpoint for monitoring integration
URL: https://github.com/apache/nifi/pull/3257#issuecomment-497017233
 
 
   @MikeThomsen I've pushed the suggested changes. Please review and let me 
know if any changes are required. I don't know why a few travis builds have 
failed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] SatwikBhandiwad commented on a change in pull request #3257: NIFI-5435 Prometheus /metrics http endpoint for monitoring integration

2019-05-29 Thread GitBox
SatwikBhandiwad commented on a change in pull request #3257: NIFI-5435 
Prometheus /metrics http endpoint for monitoring integration
URL: https://github.com/apache/nifi/pull/3257#discussion_r288664013
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-prometheus-bundle/nifi-prometheus-reporting-task/src/main/java/org/apache/nifi/reporting/prometheus/PrometheusServer.java
 ##
 @@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.reporting.prometheus;
+
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.net.HttpURLConnection;
+import java.net.InetSocketAddress;
+
+import javax.servlet.ServletException;
+import javax.servlet.ServletOutputStream;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.nifi.controller.status.ProcessGroupStatus;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.reporting.ReportingContext;
+import org.apache.nifi.reporting.prometheus.api.PrometheusMetricsUtil;
+import org.apache.nifi.ssl.SSLContextService;
+import org.eclipse.jetty.server.Connector;
+import org.eclipse.jetty.server.HttpConfiguration;
+import org.eclipse.jetty.server.HttpConnectionFactory;
+import org.eclipse.jetty.server.SecureRequestCustomizer;
+import org.eclipse.jetty.server.Server;
+import org.eclipse.jetty.server.ServerConnector;
+import org.eclipse.jetty.server.SslConnectionFactory;
+import org.eclipse.jetty.servlet.ServletContextHandler;
+import org.eclipse.jetty.servlet.ServletHolder;
+import org.eclipse.jetty.util.ssl.SslContextFactory;
+
+import com.yammer.metrics.core.VirtualMachineMetrics;
+
+import io.prometheus.client.CollectorRegistry;
+import io.prometheus.client.exporter.common.TextFormat;
+
+public class PrometheusServer {
+private static ComponentLog logger;
+private Server server;
+private ServletContextHandler handler;
+private ReportingContext context;
+private boolean sendJvmMetrics;
+private String instanceId;
+
+class MetricsServlet extends HttpServlet {
+private CollectorRegistry nifiRegistry, jvmRegistry;
+private ProcessGroupStatus rootGroupStatus;
+
+@Override
+protected void doGet(final HttpServletRequest req, final 
HttpServletResponse resp) throws ServletException, IOException {
+logger.info("PrometheusServer Do get called");
+
+rootGroupStatus = 
PrometheusServer.this.context.getEventAccess().getControllerStatus();
+ServletOutputStream response = resp.getOutputStream();
+OutputStreamWriter osw = new OutputStreamWriter(response);
+nifiRegistry = 
PrometheusMetricsUtil.createNifiMetrics(rootGroupStatus, 
PrometheusServer.this.instanceId);
 
 Review comment:
   Thanks @mattyb149  for reviewing. I've made the suugested changes by adding 
process_group_name  and process_group_id labels to metrics , also changed 
logger to debug level.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MINIFICPP-819) OPC Unified Architecture Support

2019-05-29 Thread Mr TheSegfault (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851053#comment-16851053
 ] 

Mr TheSegfault commented on MINIFICPP-819:
--

[~otto] Security is a component that I believe [~aboda] will likely encounter, 
but the sentiment that it should be an immediate concept is spot on.

 

High level use cases come from interactions with the community in that we 
implement a client and server to support writing across nodes. A pub/sub model 
is likely to be a valid use case on community comments. We could/should 
certainly get a feel from the dev lists based on these tickets. The initial 
drivers are to support put/get verbs along with the potential to use this as a 
command and control interface. 

> OPC Unified Architecture Support
> 
>
> Key: MINIFICPP-819
> URL: https://issues.apache.org/jira/browse/MINIFICPP-819
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Epic
>Reporter: Mr TheSegfault
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> The OPC unified architecture is a popular machine to machine industrial 
> protocol. There are numerous implementations and the specification itself is 
> quite complex (1,250 pages!). The aim is to provide a communication protocol 
> that is not operating system dependent but full feature which leads to the 
> complexity. I think it not reasonable that we can tackle this entire 
> specification right off the bat but rather work on bite size chunks at a 
> time. This epic will serve as the parent for all OPC related features as we 
> work toward over time, fingers crossed, supporting as much as those 1,250 
> pages of specification that reasonably makes sense.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #574: MINIFICPP-898 - Listen port validator is broken

2019-05-29 Thread GitBox
arpadboda opened a new pull request #574: MINIFICPP-898 - Listen port validator 
is broken
URL: https://github.com/apache/nifi-minifi-cpp/pull/574
 
 
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-497000105
 
 
   Indeed there is an issue.
   This test fails in the last line:
   
   ```
   @Test
   public void testPreparedQueryWithReducingFunction() {
   final Map attributes = new HashMap<>();
   attributes.put("comma", ",");
   attributes.put("question", " how are you?");
   final StandardPreparedQuery prepared = (StandardPreparedQuery) 
Query.prepare("${anyMatchingAttribute('audi.*'):matches('hello')}");
   assertEquals("false", prepared.evaluateExpressions(attributes, 
null));
   assertEquals("false", prepared.evaluateExpressions(attributes, 
null));
   attributes.put("audience", "bla");
   assertEquals("false", prepared.evaluateExpressions(attributes, 
null));
   attributes.put("auditorium", "hello");
   assertEquals("true", prepared.evaluateExpressions(attributes, null));
   }
   ```
   
   We won't be able to look into this further until next week. (holiday in GER 
+ weekend)
   But we are willing to invest some time into this, because I think this 
really has huge impact on the performance of our cluster.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-497000105
 
 
   Indeed there is an issue there.
   This test fails in the last line:
   
   ```
   @Test
   public void testPreparedQueryWithReducingFunction() {
   final Map attributes = new HashMap<>();
   attributes.put("comma", ",");
   attributes.put("question", " how are you?");
   final StandardPreparedQuery prepared = (StandardPreparedQuery) 
Query.prepare("${anyMatchingAttribute('audi.*'):matches('hello')}");
   assertEquals("false", prepared.evaluateExpressions(attributes, 
null));
   assertEquals("false", prepared.evaluateExpressions(attributes, 
null));
   attributes.put("audience", "bla");
   assertEquals("false", prepared.evaluateExpressions(attributes, 
null));
   attributes.put("auditorium", "hello");
   assertEquals("true", prepared.evaluateExpressions(attributes, null));
   }
   ```
   
   We won't be able to look into this further until next week. (holiday in GER 
+ weekend)
   But we are willing to invest some time into this, because I think this 
really has huge impact on the performance of our cluster.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496992773
 
 
   Hi @markap14 ,
   thanks for providing some context. I will try out some of those functions. I 
just assumed that, if the tests are green, it would be fine but I never 
actually checked that those functions are even covered.
   I might add some test cases then, because I think that might help in the 
future.
   
   And as a suggestion: If those functions are indeed problematic there could 
be a check to only rebuild evaluators with expressions that contain them. That 
would already help a ton. But before looking into this I'll see if it's a 
problem in the first place.
   
   Edit: I see there are tests for those functions but probably not in context 
of a prepared query.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496992773
 
 
   Hi @markap14 ,
   thanks for providing some context. I will try out some of those functions. I 
just assumed that, if the tests are green, it would be fine but I never 
actually checked that those functions are even covered.
   I might add some test cases then, because I think that might help in the 
future.
   
   And as a suggestion: If those functions are indeed problematic there could 
be a check to only rebuild evaluators with expressions that contain them. That 
would already help a ton. But before looking into this I'll see if it's a 
problem in the first place.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MINIFICPP-898) Listen port validator is broken

2019-05-29 Thread Arpad Boda (JIRA)
Arpad Boda created MINIFICPP-898:


 Summary: Listen port validator is broken
 Key: MINIFICPP-898
 URL: https://issues.apache.org/jira/browse/MINIFICPP-898
 Project: Apache NiFi MiNiFi C++
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Arpad Boda
Assignee: Arpad Boda
 Fix For: 0.7.0


Listen port validator allows "0" , but should be called "port validator" to 
maintain compatibility with NiFi validators. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] markap14 commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
markap14 commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496986229
 
 
   I'm happy to review this when I'm able, but just to add a bit of context, I 
believe the reason that it creates the Evaluator objects every time has to do 
with specific types of Expressions, especially those containing 'reduction 
functions' such as `${anyMatchingAttribute('a.*d'):equals('1')}`. In cases like 
that, there were issues with reusing the Evaluator. Now, that was a long time 
ago, and a lot of improvements & refactorings have been done. It's entirely 
possible that this may not be the case any longer, but I'd have to spend a lot 
more time testing & re-familiarizing myself with the code before I can be too 
definitive on it. In the meantime, would recommend you try running evaluations 
that contain the `anyMatchingAttribute`, `anyAttribute`, 
`allMatchingAttributes`, `allAttributes`, etc. types of functions. Those 
functions are pretty well documented at 
https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#multi


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #529: MINIFICPP-792 - TailFile processor should handle rotation of source file

2019-05-29 Thread GitBox
arpadboda commented on a change in pull request #529: MINIFICPP-792 - TailFile 
processor should handle rotation of source file
URL: https://github.com/apache/nifi-minifi-cpp/pull/529#discussion_r288627223
 
 

 ##
 File path: extensions/standard-processors/tests/unit/TailFileTests.cpp
 ##
 @@ -113,9 +114,175 @@ TEST_CASE("TailFileWithOutDelimiter", "[tailfiletest2]") 
{
   LogTestController::getInstance().reset();
 
   // Delete the test and state file.
-std::remove(TMP_FILE);
-std::remove(STATE_FILE);
+  remove(TMP_FILE);
+  remove(STATE_FILE);
+}
+
+TEST_CASE("TailFileWithRealDelimiterAndRotate", "[tailfiletest2]") {
+  TestController testController;
+
+  const char DELIM = ',';
+  size_t expected_pieces = std::count(NEWLINE_FILE.begin(), 
NEWLINE_FILE.end(), DELIM); // The last piece is left as considered unfinished
+
+
+  LogTestController::getInstance().setTrace();
+  LogTestController::getInstance().setTrace();
+  LogTestController::getInstance().setTrace();
+  LogTestController::getInstance().setTrace();
+
+  auto plan = testController.createPlan();
+
+  char format[] = "/tmp/gt.XX";
+  char *dir = testController.createTempDirectory(format);
+
+  // Define test input file
+  std::string in_file(dir);
+  in_file.append("/testfifo.txt");
+
+  std::string state_file(dir);
+  state_file.append("tailfile.state");
+
+  std::ofstream in_file_stream(in_file);
+  in_file_stream << NEWLINE_FILE;
+  in_file_stream.flush();
+
+  // Build MiNiFi processing graph
+  auto tail_file = plan->addProcessor(
+  "TailFile",
+  "Tail");
+  plan->setProperty(
+  tail_file,
+  processors::TailFile::Delimiter.getName(), std::string(1, DELIM));
+  plan->setProperty(
+  tail_file,
+  processors::TailFile::FileName.getName(), in_file);
+  plan->setProperty(
+  tail_file,
+  processors::TailFile::StateFile.getName(), state_file);
+  auto log_attr = plan->addProcessor(
+  "LogAttribute",
+  "Log",
+  core::Relationship("success", "description"),
+  true);
+  plan->setProperty(
+  log_attr,
+  processors::LogAttribute::FlowFilesToLog.getName(), "0");
+  // Log as many FFs as it can to make sure exactly the expected amount is 
produced
+
+
+  plan->runNextProcessor();  // Tail
+  plan->runNextProcessor();  // Log
+
+  REQUIRE(LogTestController::getInstance().contains(std::string("Logged ") + 
std::to_string(expected_pieces) + " flow files"));
+
+  in_file_stream << DELIM;
+  in_file_stream.close();
+
+
+  std::string rotated_file = (in_file + ".1");
+
+  REQUIRE(rename(in_file.c_str(), rotated_file.c_str() ) == 0);
+
+  std::this_thread::sleep_for(std::chrono::milliseconds(1000)); // make sure 
the new file gets newer modification time
+
+  std::ofstream new_in_file_stream(in_file);
+  new_in_file_stream << "five" << DELIM << "six" << DELIM;
+  new_in_file_stream.close();
+
+  plan->reset();
+  plan->runNextProcessor();  // Tail
+  plan->runNextProcessor();  // Log
+
+  //Find the last flow file in the rotated file
+  REQUIRE(LogTestController::getInstance().contains("Logged 1 flow files"));
+
+  plan->reset();
+  plan->runNextProcessor();  // Tail
+  plan->runNextProcessor();  // Log
+
+  //Two new files in the new flow file
+  REQUIRE(LogTestController::getInstance().contains("Logged 2 flow files"));
 }
+
+TEST_CASE("TailFileWithMultileRolledOverFiles", "[tailfiletest2]") {
+  TestController testController;
+
+  const char DELIM = ':';
+
+  LogTestController::getInstance().setTrace();
+  LogTestController::getInstance().setTrace();
+  LogTestController::getInstance().setTrace();
+  LogTestController::getInstance().setTrace();
+
+  auto plan = testController.createPlan();
+
+  char format[] = "/tmp/gt.XX";
+  char *dir = testController.createTempDirectory(format);
+
+  std::string state_file(dir);
+  state_file.append("tailfile.state");
+
+  // Define test input file
+  std::string in_file(dir);
+  in_file.append("/fruits.txt");
+
+  for (int i = 2; 0 <= i; --i) {
+if (i < 2) {
+  std::this_thread::sleep_for(
+  std::chrono::milliseconds(1000)); // make sure the new file gets 
newer modification time
+}
+std::ofstream in_file_stream(in_file + (i > 0 ? std::to_string(i) : ""));
+for (int j = 0; j <= i; j++) {
+  in_file_stream << "Apple" << DELIM;
+}
+in_file_stream.close();
+  }
+
+  // Build MiNiFi processing graph
+  auto tail_file = plan->addProcessor(
+  "TailFile",
+  "Tail");
+  plan->setProperty(
+  tail_file,
+  processors::TailFile::Delimiter.getName(), std::string(1, DELIM));
+  plan->setProperty(
+  tail_file,
+  processors::TailFile::FileName.getName(), in_file);
+  plan->setProperty(
+  tail_file,
+  processors::TailFile::StateFile.getName(), state_file);
+  auto log_attr = plan->addProcessor(
+  "LogAttribute",
+  "Log",
+  core::Relationship("success", "description"),
+  true);
+  plan->setProperty(
+  log_attr,
+  

[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #529: MINIFICPP-792 - TailFile processor should handle rotation of source file

2019-05-29 Thread GitBox
arpadboda commented on issue #529: MINIFICPP-792 - TailFile processor should 
handle rotation of source file
URL: https://github.com/apache/nifi-minifi-cpp/pull/529#issuecomment-496984146
 
 
   Amended the PR, changes done:
   -Added unit tests 
   -Made the behaviour compatible with NiFi: MiNiFi being stopped for a while 
starts to process previous files rolled over. 
   -Fixed a previous issue: in case the file is not just rolled over between 
two "onTrigger" calls, but also written before rollover, the processor didn't 
handle that, just started reading the new file. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MINIFICPP-890) OPC Library Implementation into CMake

2019-05-29 Thread Otto Fowler (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850914#comment-16850914
 ] 

Otto Fowler commented on MINIFICPP-890:
---

Also, for the builds, the red-hat rpm for the devel of this library may not be 
built the way you would like, I think it uses amalgamations, and you may have 
to repackage.

> OPC Library Implementation into CMake
> -
>
> Key: MINIFICPP-890
> URL: https://issues.apache.org/jira/browse/MINIFICPP-890
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Jeremy Dyer
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> In order to save reinventing the wheel we should locate an Apache license 
> friendly OPC library that we can incorporate into our project. Once the 
> library is determined a simple stubbed out "opc" extension can be made that 
> for this doesn't need to do anything except pull in that external project and 
> build it as part of our CMake project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496965777
 
 
   > I'm just curious ;) In the Apache Metron project, we have a DSL, and we 
improved performance by doing something similar to what you have done here as 
well.
   > 
   > 
https://github.com/apache/metron/blob/master/metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/CachingStellarProcessor.java
   > 
   > https://issues.apache.org/jira/browse/METRON-1520
   > 
   > I'm always interested in DSL's and evaluator things
   
   Ah gotcha.
   
   Yes we have an internal expression language in our company (closed source) 
and we have some experience on this as well and I was wondering why Nifi comes 
with some kind of preparation step, but doesn't really take much advantage of 
it. Let's see what others say.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] ottobackwards commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
ottobackwards commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496964926
 
 
   I'm just curious ;)  In the Apache Metron project, we have a DSL, and we 
improved performance by doing something similar to what you have done here as 
well.
   
   
https://github.com/apache/metron/blob/master/metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/CachingStellarProcessor.java
   
   https://issues.apache.org/jira/browse/METRON-1520
   
   I'm always interested in DSL's and evaluator things
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496962921
 
 
   > Did you ever get an answer as to _why_ it works like it does to start with?
   
   No I didn't. I just thought it might be a good idea to clarify my initial 
report with a pull request. Especially since I had to get to know the code 
anyway to even open the ticket and describe the issue as best as I could. Last 
time I found a performance issue in NiFi it helped to include a possible fix 
via pull request.
   
   Do you know why it works like that or why do you ask?
   
   Edit: If I had to naively guess: I'd say this was an oversight. For me the 
current behaviour of re-building the evaluator from the tree for every 
iteration just doesn't make sense. But I'd be intrigued to find out if it is 
intended and why.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP edited a comment on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496962921
 
 
   > Did you ever get an answer as to _why_ it works like it does to start with?
   
   No I didn't. I just thought it might be a good idea to clarify my initial 
report with a pull request. Especially since I had to get to know the code 
anyway to even open the ticket and describe the issue as best as I could. Last 
time I found a performance issue in NiFi it helped to include a possible fix 
via pull request.
   
   Do you know why it works like that or why do you ask?
   
   Edit: If I had to naively guess: I'd say this was an oversight. For me 
current behaviour of re-building the evaluator from the tree for every 
iteration just doesn't make sense. But I'd be intrigued to find out if it is 
intended and why.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496962921
 
 
   > Did you ever get an answer as to _why_ it works like it does to start with?
   
   No I didn't. I just thought it might be a good idea to clarify my initial 
report with a pull request. Especially since I had to get to know the code 
anyway to even open the ticket and describe the issue as best as I could. Last 
time I found a performance issue in NiFi it helped to include a possible fix 
via pull request.
   
   Do you know why it works like that or why do you ask?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MINIFICPP-890) OPC Library Implementation into CMake

2019-05-29 Thread Arpad Boda (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850904#comment-16850904
 ] 

Arpad Boda commented on MINIFICPP-890:
--

I think it makes sense to take a look at https://asneg.github.io/ , too 

> OPC Library Implementation into CMake
> -
>
> Key: MINIFICPP-890
> URL: https://issues.apache.org/jira/browse/MINIFICPP-890
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Jeremy Dyer
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> In order to save reinventing the wheel we should locate an Apache license 
> friendly OPC library that we can incorporate into our project. Once the 
> library is determined a simple stubbed out "opc" extension can be made that 
> for this doesn't need to do anything except pull in that external project and 
> build it as part of our CMake project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] ottobackwards commented on issue #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
ottobackwards commented on issue #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500#issuecomment-496961318
 
 
   Did you ever get an answer as to _why_ it works like it does to start with?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (NIFI-6322) Evaluator Objects are rebuilt on every call even when a CompiledExpression is used

2019-05-29 Thread Frederik Petersen (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850902#comment-16850902
 ] 

Frederik Petersen commented on NIFI-6322:
-

I added a pull request at [https://github.com/apache/nifi/pull/3500] to 
demonstrate the issue with a small fix. Please have a look when you have time.

Performance is improved by 85% in our example. More detail can be found in the 
pull request.

Cheers

> Evaluator Objects are rebuilt on every call even when a CompiledExpression is 
> used
> --
>
> Key: NIFI-6322
> URL: https://issues.apache.org/jira/browse/NIFI-6322
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Frederik Petersen
>Priority: Major
>  Labels: expression-language, performance
> Attachments: Selection_094.png, image.png
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Hi, 
> While doing some CPU sampling in our production environment, we encountered 
> some strange results. It seems like that, during the evaluation of NiFi 
> expressions, the modification of a _HashSet_ is the most expensive operation 
> in this process.
> !Selection_094.png!
> This feels pretty unrealistic considering all the other processing related to 
> evaluating NiFi expressions. 
>  After reviewing some code and some profiling it just looks like this 
> _HashSet_ modification is performed way more often than required. Especially 
> that it is done at each evaluation.
> !image.png!
>  This profiling output was produced with the following unit test:
> {code:java}
> @Test
> public void testSimple() {
>  final TestRunner runner = TestRunners.newTestRunner(new RouteOnAttribute());
>  runner.setProperty(RouteOnAttribute.ROUTE_STRATEGY, 
> RouteOnAttribute.ROUTE_ANY_MATCHES.getValue());
>  runner.setProperty("filter", "${literal('b'):equals(${a})}");
>  for (int i = 0; i < 500; i++) {
>  runner.enqueue(new byte[0], new HashMap() {{
>  put("a", "b");
>  }});
>  }
>  runner.run(500);
> }{code}
> The key question is: Why are the _Evaluator_ Objects (and all the stuff 
> related to it) built twice:
>  - Once in _ExpressionCompiler.compile()_
>  - Once again in _CompiledExpression.evaluate()_
> In other words: Every call to _CompiledExpression.evaluate()_ leads to a new 
> _ExpressionCompiler_ being created and expensive calls being made. Why not 
> just reuse _Evaluator_ objects created beforehand that are stored in the 
> _CompiledExpression_?
> Is there a specific design decision behind that? It looks like there is room 
> for performance improvement, especially for heavily used processors.
> On our live system, where we perform expensive tasks like language detection, 
> mail parsing and such, this situation causes the most amount of CPU eaten by 
> the expression language evaluation.
> Thank you very much for looking into this.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] FrederikP opened a new pull request #3500: NIFI-6322: Reuse evaluator stored in CompiledExpression when creating a query.

2019-05-29 Thread GitBox
FrederikP opened a new pull request #3500: NIFI-6322: Reuse evaluator stored in 
CompiledExpression when creating a query.
URL: https://github.com/apache/nifi/pull/3500
 
 
   
    Description of PR
   
   This commit shows how performance can be improved in expression language 
evaluation with a minimal set of changes to the code. The root evaluator stored 
in CompiledExpression instances is reused when creating queries instead of 
creating evaluators over and over again using the tree.
   
    Performance comparison
   
   We ran a before/after test using a slightly changed version of the test case 
found in the expression language module and profiled it. We set the number of 
iteration to 1M to not take forever when the code is instrumented and we 
changed the expression to one where the effect is even clearer. The effect is 
noticeable with the original expression, too though. (75% less CPU time)
   
   Here is the test case with our changes:
   
   ```
   @Test
   public void test10MIterations() {
   final Map attrs = new HashMap<>();
   attrs.put("a", "world");
   
   final StandardPreparedQuery prepared = (StandardPreparedQuery) 
Query.prepare("${literal('world'):equals(${a})}");
   final long start = System.nanoTime();
   for (int i = 0; i < 100; i++) {
   assertEquals("true", prepared.evaluateExpressions(attrs, null));
   }
   final long nanos = System.nanoTime() - start;
   System.out.println(TimeUnit.NANOSECONDS.toMillis(nanos));
   }
   ```
   
   Here is the performance when run on the latest master of nifi without my 
change:
   
![before](https://user-images.githubusercontent.com/483596/58564556-6e77e080-822d-11e9-8246-3bc501c110cb.png)
   
   This is after applying my changes:
   
![after](https://user-images.githubusercontent.com/483596/58564573-78014880-822d-11e9-8b46-22fee37db11e.png)
   
   As you can see it takes about 40 seconds less with my changes. CPU time 
decreases by 85%. It gets rid of the most impactful call in every iteration: 
Query.fromTree()
   
   We have a huge amount of expressions in our production flow that's why this 
issue is so noticable for us. 
   
   Please let me know if my fix makes sense or if I'm missing something. I 
tried to keep it as simple as possible to demonstrate the issue in a clear way, 
so you might require some further changes to the structure to merge this.
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [x] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `master`)?
   
   - [x] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes? -> 
Performance verified via performance unit test as described.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MINIFICPP-897) Find and implement Modbus library

2019-05-29 Thread Jeremy Dyer (JIRA)
Jeremy Dyer created MINIFICPP-897:
-

 Summary: Find and implement Modbus library
 Key: MINIFICPP-897
 URL: https://issues.apache.org/jira/browse/MINIFICPP-897
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Jeremy Dyer
Assignee: Mr TheSegfault


Not reinventing the wheel we should find a modbus library that has an Apache 
friendly license and then part of this would involve setting up the "modbus" 
extension and building that library as a CMake external project



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MINIFICPP-896) Modbus Master Processor

2019-05-29 Thread Jeremy Dyer (JIRA)
Jeremy Dyer created MINIFICPP-896:
-

 Summary: Modbus Master Processor
 Key: MINIFICPP-896
 URL: https://issues.apache.org/jira/browse/MINIFICPP-896
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Jeremy Dyer
Assignee: Mr TheSegfault


In a Modbus network the "master" sends requests for data. The first byte of the 
message is the slave id. Every slave in the network receives the message but if 
the first byte does not match their slave id then the message is ignored by all 
slaves except the one with the matching id. This processor would need to be 
able to send these messages to the network and allow for users to construct 
standard modbus requests. This still requires some thinking and might very well 
require some supporting controller services or additional processors to make 
the implementation smooth.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MINIFICPP-895) Modbus Integration

2019-05-29 Thread Jeremy Dyer (JIRA)
Jeremy Dyer created MINIFICPP-895:
-

 Summary: Modbus Integration
 Key: MINIFICPP-895
 URL: https://issues.apache.org/jira/browse/MINIFICPP-895
 Project: Apache NiFi MiNiFi C++
  Issue Type: Epic
Reporter: Jeremy Dyer
Assignee: Mr TheSegfault
 Fix For: 0.7.0


Modbus is a de facto industry standard for communicating with electronic 
devices. Our primary goal here would be to provide a modbus implementation that 
would allow for users to connect to those electronic devices to both transfer 
and receive information from them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-819) OPC Unified Architecture Support

2019-05-29 Thread Otto Fowler (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850885#comment-16850885
 ] 

Otto Fowler commented on MINIFICPP-819:
---

What are the high level use cases?

As a user I want to be able to :

- read and write data to opc-ua node properties?
- lookup (discover) nodes?
- subscribe or publish data to opc-ua clients?

Is this going to have client functionality?  server functionality?

What encryption / security will be supported?

> OPC Unified Architecture Support
> 
>
> Key: MINIFICPP-819
> URL: https://issues.apache.org/jira/browse/MINIFICPP-819
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Epic
>Reporter: Mr TheSegfault
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> The OPC unified architecture is a popular machine to machine industrial 
> protocol. There are numerous implementations and the specification itself is 
> quite complex (1,250 pages!). The aim is to provide a communication protocol 
> that is not operating system dependent but full feature which leads to the 
> complexity. I think it not reasonable that we can tackle this entire 
> specification right off the bat but rather work on bite size chunks at a 
> time. This epic will serve as the parent for all OPC related features as we 
> work toward over time, fingers crossed, supporting as much as those 1,250 
> pages of specification that reasonably makes sense.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-890) OPC Library Implementation into CMake

2019-05-29 Thread Otto Fowler (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850881#comment-16850881
 ] 

Otto Fowler commented on MINIFICPP-890:
---

So, from my limited experience with it, the code is nice, but the amalgamation 
headers/cpp can give you troubles if you aren't using the highest level stuff.  
So, if you for example are trying to write code right above the network level ( 
you want to handle the sockets etc ) you start to have problems with type 
collisions and things.  I would turn off amalgamation.

The mailing list is pretty dead, and I have not seen anyone answer questions on 
the irc.  They are academics, and have been putting out new code and papers 
however.

> OPC Library Implementation into CMake
> -
>
> Key: MINIFICPP-890
> URL: https://issues.apache.org/jira/browse/MINIFICPP-890
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Jeremy Dyer
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> In order to save reinventing the wheel we should locate an Apache license 
> friendly OPC library that we can incorporate into our project. Once the 
> library is determined a simple stubbed out "opc" extension can be made that 
> for this doesn't need to do anything except pull in that external project and 
> build it as part of our CMake project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6328) Allow force commit when versioned flow is in conflict state

2019-05-29 Thread Bryan Bende (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-6328:
--
Status: Patch Available  (was: Open)

> Allow force commit when versioned flow is in conflict state
> ---
>
> Key: NIFI-6328
> URL: https://issues.apache.org/jira/browse/NIFI-6328
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>  Labels: SDLC
> Fix For: 1.10.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We let users revert to a previous version of a flow, but then there is no way 
> to continue making changes based on that version because it puts the flow 
> into a conflict where it says you have local changes but newer versions are 
> available. There should be a way to force commit and make the current changes 
> the latest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [nifi] bbende opened a new pull request #3499: NIFI-6328 Allowing force-commit when in LOCALLY_MODIFIED_AND_STALE state

2019-05-29 Thread GitBox
bbende opened a new pull request #3499: NIFI-6328 Allowing force-commit when in 
LOCALLY_MODIFIED_AND_STALE state
URL: https://github.com/apache/nifi/pull/3499
 
 
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   _Enables X functionality; fixes bug NIFI-._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `master`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MINIFICPP-890) OPC Library Implementation into CMake

2019-05-29 Thread Jeremy Dyer (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850875#comment-16850875
 ] 

Jeremy Dyer commented on MINIFICPP-890:
---

good timing. [~phrocker] and I were just discussing that very one. That is 
likely the one we will use.

> OPC Library Implementation into CMake
> -
>
> Key: MINIFICPP-890
> URL: https://issues.apache.org/jira/browse/MINIFICPP-890
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Jeremy Dyer
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> In order to save reinventing the wheel we should locate an Apache license 
> friendly OPC library that we can incorporate into our project. Once the 
> library is determined a simple stubbed out "opc" extension can be made that 
> for this doesn't need to do anything except pull in that external project and 
> build it as part of our CMake project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-890) OPC Library Implementation into CMake

2019-05-29 Thread Otto Fowler (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850871#comment-16850871
 ] 

Otto Fowler commented on MINIFICPP-890:
---

https://open62541.org ?

> OPC Library Implementation into CMake
> -
>
> Key: MINIFICPP-890
> URL: https://issues.apache.org/jira/browse/MINIFICPP-890
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Jeremy Dyer
>Assignee: Arpad Boda
>Priority: Major
> Fix For: 0.7.0
>
>
> In order to save reinventing the wheel we should locate an Apache license 
> friendly OPC library that we can incorporate into our project. Once the 
> library is determined a simple stubbed out "opc" extension can be made that 
> for this doesn't need to do anything except pull in that external project and 
> build it as part of our CMake project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINIFICPP-894) Define public/private APIs

2019-05-29 Thread Arpad Boda (JIRA)


[ 
https://issues.apache.org/jira/browse/MINIFICPP-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850852#comment-16850852
 ] 

Arpad Boda commented on MINIFICPP-894:
--

Great +1 for this ticket!

I would also scope Nanofi into this as we have C APIs there, which I consider 
as private (for eg. the socket layer user by S2S impl). 

> Define public/private APIs
> --
>
> Key: MINIFICPP-894
> URL: https://issues.apache.org/jira/browse/MINIFICPP-894
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Mr TheSegfault
>Priority: Major
> Fix For: 1.0.0
>
>
> Since we haven't defined these previously we can't make any big changes. As a 
> result we can define ( maybe through macros) public and private APIs that 
> allow us more flexibility to make changes. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MINIFICPP-894) Define public/private APIs

2019-05-29 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-894:


 Summary: Define public/private APIs
 Key: MINIFICPP-894
 URL: https://issues.apache.org/jira/browse/MINIFICPP-894
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Mr TheSegfault
 Fix For: 1.0.0


Since we haven't defined these previously we can't make any big changes. As a 
result we can define ( maybe through macros) public and private APIs that allow 
us more flexibility to make changes. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (NIFI-6328) Allow force commit when versioned flow is in conflict state

2019-05-29 Thread Bryan Bende (JIRA)
Bryan Bende created NIFI-6328:
-

 Summary: Allow force commit when versioned flow is in conflict 
state
 Key: NIFI-6328
 URL: https://issues.apache.org/jira/browse/NIFI-6328
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Bryan Bende
Assignee: Bryan Bende
 Fix For: 1.10.0


We let users revert to a previous version of a flow, but then there is no way 
to continue making changes based on that version because it puts the flow into 
a conflict where it says you have local changes but newer versions are 
available. There should be a way to force commit and make the current changes 
the latest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6328) Allow force commit when versioned flow is in conflict state

2019-05-29 Thread Bryan Bende (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850848#comment-16850848
 ] 

Bryan Bende commented on NIFI-6328:
---

This would be one solution to the issue described in NIFI-6028.

> Allow force commit when versioned flow is in conflict state
> ---
>
> Key: NIFI-6328
> URL: https://issues.apache.org/jira/browse/NIFI-6328
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>  Labels: SDLC
> Fix For: 1.10.0
>
>
> We let users revert to a previous version of a flow, but then there is no way 
> to continue making changes based on that version because it puts the flow 
> into a conflict where it says you have local changes but newer versions are 
> available. There should be a way to force commit and make the current changes 
> the latest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (NIFI-6314) Nested versioned process groups do not update properly

2019-05-29 Thread Bryan Bende (JIRA)


[ 
https://issues.apache.org/jira/browse/NIFI-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850842#comment-16850842
 ] 

Bryan Bende commented on NIFI-6314:
---

This will require a change in the flow diff code that lives in registry:

https://issues.apache.org/jira/browse/NIFIREG-275

> Nested versioned process groups do not update properly
> --
>
> Key: NIFI-6314
> URL: https://issues.apache.org/jira/browse/NIFI-6314
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.9.0, 1.9.1, 1.9.2
>Reporter: Bryan Bende
>Priority: Major
>  Labels: SDLC
>
> Steps to reproduce:
>  # NiFi#1 Create PGA
>  # NiFI#1 Create PGB inside PGA
>  # NiFI#1 Create some processors inside PGB
>  # NIFI#1 Start version control PGB
>  # NIFI#1 Start version control PGA
>  # NIFI#2 Import a new PG and select PGA v1 (at this point the same exact 
> flow is now in both NiFi's)
>  # NIFI#1 Go into PGB and modify the properties of some processors
>  # NIFI#1 Commit changes on PGB
>  # NIFI#1 Commit changes on PGA
>  # NIFI#2 Change version on PGA from v1 to v2 (caused PGB to be updated to v2 
> since PGA v2 points to PGB v2)
> At this point PGB in NIFI#2 thinks it has been updated to v2 according to the 
> version info in flow.xml.gz, but it the actual changes from v2 have not been 
> applied, and it shows local changes that looks like they undid what should be 
> the real changes. Choosing to revert the local changes will actually get back 
> to the real v2 state.
> You can also reproduce this using a single NiFi and having two instances of 
> the same versioned process group described above, or by having a single 
> instance of the versioned process group and changing the outer PGA back and 
> forth between v2 and v1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (MINIFICPP-893) OPC UA Client Implementation

2019-05-29 Thread Jeremy Dyer (JIRA)


 [ 
https://issues.apache.org/jira/browse/MINIFICPP-893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeremy Dyer updated MINIFICPP-893:
--
Description: 
The OPC UA architecture consists of servers and clients. The clients read the 
values from the OPC UA servers. We need a processor that behaves like an OPC UA 
client. An individual minifi agent needs the ability to support multiple OPC UA 
clients to connect to different UA servers. The client should behave something 
like "ListenTCP" where a separate thread is spun up so the client can listen to 
and receive events from the server in realtime and have much more fine grained 
control over its scheduling. 

Actually thinking about this since the protocol is Request/Response based and 
the client must initiate the request for data it might not make since to have 
the processor run in a separate thread but rather behave like the other 
processors so a user could setup the processor to say be scheduled every 5 
seconds to read data from the server.

  was:The OPC UA architecture consists of servers and clients. The clients read 
the values from the OPC UA servers. We need a processor that behaves like an 
OPC UA client. An individual minifi agent needs the ability to support multiple 
OPC UA clients to connect to different UA servers. The client should behave 
something like "ListenTCP" where a separate thread is spun up so the client can 
listen to and receive events from the server in realtime and have much more 
fine grained control over its scheduling. 


> OPC UA Client Implementation
> 
>
> Key: MINIFICPP-893
> URL: https://issues.apache.org/jira/browse/MINIFICPP-893
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Jeremy Dyer
>Assignee: Arpad Boda
>Priority: Major
>
> The OPC UA architecture consists of servers and clients. The clients read the 
> values from the OPC UA servers. We need a processor that behaves like an OPC 
> UA client. An individual minifi agent needs the ability to support multiple 
> OPC UA clients to connect to different UA servers. The client should behave 
> something like "ListenTCP" where a separate thread is spun up so the client 
> can listen to and receive events from the server in realtime and have much 
> more fine grained control over its scheduling. 
> Actually thinking about this since the protocol is Request/Response based and 
> the client must initiate the request for data it might not make since to have 
> the processor run in a separate thread but rather behave like the other 
> processors so a user could setup the processor to say be scheduled every 5 
> seconds to read data from the server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MINIFICPP-893) OPC UA Client Implementation

2019-05-29 Thread Jeremy Dyer (JIRA)
Jeremy Dyer created MINIFICPP-893:
-

 Summary: OPC UA Client Implementation
 Key: MINIFICPP-893
 URL: https://issues.apache.org/jira/browse/MINIFICPP-893
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Jeremy Dyer
Assignee: Arpad Boda


The OPC UA architecture consists of servers and clients. The clients read the 
values from the OPC UA servers. We need a processor that behaves like an OPC UA 
client. An individual minifi agent needs the ability to support multiple OPC UA 
clients to connect to different UA servers. The client should behave something 
like "ListenTCP" where a separate thread is spun up so the client can listen to 
and receive events from the server in realtime and have much more fine grained 
control over its scheduling. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MINIFICPP-892) OPC UA Server Node Event

2019-05-29 Thread Jeremy Dyer (JIRA)
Jeremy Dyer created MINIFICPP-892:
-

 Summary: OPC UA Server Node Event
 Key: MINIFICPP-892
 URL: https://issues.apache.org/jira/browse/MINIFICPP-892
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Jeremy Dyer
Assignee: Arpad Boda
 Fix For: 0.7.0


An OPC UA server can holds values from 1-247 unique Nodes. It is often 
beneficial to allow for one of those unique nodes to trigger an event. Meaning 
the node might generate a data point above a configured threshold. In this case 
the ua server should provide a mechanism for capturing those node events and 
forwarding them on to the upstream clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread David Sargrad (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Sargrad updated NIFI-6327:

Attachment: image-2019-05-29-09-06-00-609.png

> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png, image-2019-05-29-09-04-24-313.png, 
> image-2019-05-29-09-06-00-609.png
>
>
> I followed the following instructions to clone and build NIFI.
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> If I click on one of the failed projects, I see the following error.
>  
> !image-2019-05-29-09-04-24-313.png!
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread David Sargrad (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Sargrad updated NIFI-6327:

Description: 
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

If I click on one of the failed projects, I see the following error.

 

!image-2019-05-29-09-04-24-313.png!

 

!image-2019-05-29-09-06-00-609.png!

 

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!

  was:
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

If I click on one of the failed projects, I see the following error.

 

!image-2019-05-29-09-04-24-313.png!

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!


> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png, image-2019-05-29-09-04-24-313.png, 
> image-2019-05-29-09-06-00-609.png
>
>
> I followed the following instructions to clone and build NIFI.
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> If I click on one of the failed projects, I see the following error.
>  
> !image-2019-05-29-09-04-24-313.png!
>  
> !image-2019-05-29-09-06-00-609.png!
>  
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread David Sargrad (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Sargrad updated NIFI-6327:

Description: 
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

If I click on one of the failed projects, I see the following error.

 

!image-2019-05-29-09-04-24-313.png!

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!

  was:
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

It would seem that I need a maven plugin, or several. Yet its not clear which 
and how to install them.

 

!image-2019-05-29-09-04-24-313.png!

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!


> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png, image-2019-05-29-09-04-24-313.png
>
>
> I followed the following instructions to clone and build NIFI.
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> If I click on one of the failed projects, I see the following error.
>  
> !image-2019-05-29-09-04-24-313.png!
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MINIFICPP-891) OPC UA Server Implementation

2019-05-29 Thread Jeremy Dyer (JIRA)
Jeremy Dyer created MINIFICPP-891:
-

 Summary: OPC UA Server Implementation
 Key: MINIFICPP-891
 URL: https://issues.apache.org/jira/browse/MINIFICPP-891
 Project: Apache NiFi MiNiFi C++
  Issue Type: New Feature
Reporter: Jeremy Dyer
Assignee: Arpad Boda
 Fix For: 0.7.0


In OPC UA terminology the "server" is typically the processor that sits closest 
to the actual device generating the data. The server then collects the data 
from that "sensor" and makes the data available to upstream OPC UA clients. The 
clients will then consume that data from the server. In a nutshell the server 
is the software that reads data from devices, sensors, files, etc and then 
makes that information available to the clients over the OPC communication 
protocol.

MiNiFi has a natural advantage at this part since we already have a lot of 
implementations to grab local data. My thought is to make this server 
implementation as something like a "Controller Service" in our world. And then 
introduce a correlating something like "PutOPCUAServer" processor. The 
controller service could be defined at a global level and there could be more 
than one of them. From there flows could be developed using all of the 
processors that are available to MiNiFi. Once the user has acquired the data 
that they want they could make a relationship to that "PutOPCUAServer" 
processor which would have a reference to the desired OPCUAServer controller 
service. This would allow for the flowfile contents and attributes to be placed 
into the server and all connected upstream clients to receive those values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread David Sargrad (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Sargrad updated NIFI-6327:

Description: 
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

It would seem that I need a maven plugin, or several. Yet its not clear which 
and how to install them.

 

!image-2019-05-29-09-04-24-313.png!

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!

  was:
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!


> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png, image-2019-05-29-09-04-24-313.png
>
>
> I followed the following instructions to clone and build NIFI.
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> It would seem that I need a maven plugin, or several. Yet its not clear which 
> and how to install them.
>  
> !image-2019-05-29-09-04-24-313.png!
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread David Sargrad (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Sargrad updated NIFI-6327:

Attachment: image-2019-05-29-09-04-24-313.png

> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png, image-2019-05-29-09-04-24-313.png
>
>
> I followed the following instructions to clone and build NIFI.
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (NIFI-6327) Enhance NIFI Developer documentation to assist in developing NIFI in IDE

2019-05-29 Thread David Sargrad (JIRA)


 [ 
https://issues.apache.org/jira/browse/NIFI-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Sargrad updated NIFI-6327:

Description: 
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in an IDE such 
as eclipse, or a "recommended IDE".

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!

  was:
I followed the following instructions to clone and build NIFI.

I've successfully built the system, using maven.

 

!image-2019-05-29-09-01-47-311.png!

 

However its not at all clear how to develop and run the system in the 
recommended IDE.

Currently I'm trying to get the system up and running in eclipse. 

 

However I'm seeing many problems (see image below). I'm guessing all of these 
can be solved with a simple set of configuration commands. 

Ultimately adding such details to the documentation would be useful. For now, 
I'd appreciate if someone can help with the configuration I am missing.

 

  !image-2019-05-29-09-00-39-263.png!

 

I am using the following version of eclipse, and maven

 

  !image-2019-05-29-08-59-59-849.png!

 

!image-2019-05-29-08-59-30-173.png!


> Enhance NIFI Developer documentation to assist in developing NIFI in IDE
> 
>
> Key: NIFI-6327
> URL: https://issues.apache.org/jira/browse/NIFI-6327
> Project: Apache NiFi
>  Issue Type: Wish
>  Components: Core Framework
>Affects Versions: 1.9.2
> Environment: LINUX: Centos 7
> ECLIPSE: Oxygen
>Reporter: David Sargrad
>Priority: Major
> Attachments: image-2019-05-29-08-59-30-173.png, 
> image-2019-05-29-08-59-59-849.png, image-2019-05-29-09-00-39-263.png, 
> image-2019-05-29-09-01-47-311.png
>
>
> I followed the following instructions to clone and build NIFI.
> I've successfully built the system, using maven.
>  
> !image-2019-05-29-09-01-47-311.png!
>  
> However its not at all clear how to develop and run the system in an IDE such 
> as eclipse, or a "recommended IDE".
> Currently I'm trying to get the system up and running in eclipse. 
>  
> However I'm seeing many problems (see image below). I'm guessing all of these 
> can be solved with a simple set of configuration commands. 
> Ultimately adding such details to the documentation would be useful. For now, 
> I'd appreciate if someone can help with the configuration I am missing.
>  
>   !image-2019-05-29-09-00-39-263.png!
>  
> I am using the following version of eclipse, and maven
>  
>   !image-2019-05-29-08-59-59-849.png!
>  
> !image-2019-05-29-08-59-30-173.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   >