[jira] [Created] (NIFI-6544) .mat-checkbox-layout .mat-checkbox-label incorrect line-height
Scott Aslan created NIFI-6544: - Summary: .mat-checkbox-layout .mat-checkbox-label incorrect line-height Key: NIFI-6544 URL: https://issues.apache.org/jira/browse/NIFI-6544 Project: Apache NiFi Issue Type: Bug Components: FDS Reporter: Scott Aslan Assignee: Scott Aslan Fix For: fds-0.3 .mat-checkbox-layout .mat-checkbox-label should have a 24px line-height -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-6541) The .td-expansion-label have incorrect font size.
[ https://issues.apache.org/jira/browse/NIFI-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-6541: -- Status: Patch Available (was: In Progress) > The .td-expansion-label have incorrect font size. > - > > Key: NIFI-6541 > URL: https://issues.apache.org/jira/browse/NIFI-6541 > Project: Apache NiFi > Issue Type: Bug >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: fds-0.3 > > Time Spent: 10m > Remaining Estimate: 0h > > .td-expansion-label should be font-size: 20px > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-fds] scottyaslan opened a new pull request #47: [NIFI-6541] update .td-expansion-label font
scottyaslan opened a new pull request #47: [NIFI-6541] update .td-expansion-label font URL: https://github.com/apache/nifi-fds/pull/47 Thank you for submitting a contribution to Apache NiFi Flow Design System. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with either NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder? - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6543) Add onUnscheduled support for ExecuteGroovyScript Processor
[
https://issues.apache.org/jira/browse/NIFI-6543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Wagner updated NIFI-6543:
-
Summary: Add onUnscheduled support for ExecuteGroovyScript Processor (was:
Add onUnscheduled support for ExecuteJavaProcessor)
> Add onUnscheduled support for ExecuteGroovyScript Processor
> ---
>
> Key: NIFI-6543
> URL: https://issues.apache.org/jira/browse/NIFI-6543
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Michael Wagner
>Priority: Trivial
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The ExecuteGroovyScript processor is great, and it is great to have the
> support for onStart and onStop methods. However, I often find myself wishing
> there were also a way to take some action when the processor is
> _unscheduled_. That would let the groovy code to make decisions about
> whether or not to get() another flowfile.
>
> I think it should be as easy as
> {code:java}
> diff --git
> a/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
>
> b/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
> index c35ab392d..eead4bc07 100644
> ---
> a/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
> +++
> b/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
> @@ -27,6 +27,7 @@ import
> org.apache.nifi.annotation.documentation.CapabilityDescription;
> import org.apache.nifi.annotation.documentation.SeeAlso;
> import org.apache.nifi.annotation.documentation.Tags;
> import org.apache.nifi.annotation.lifecycle.OnScheduled;
> +import org.apache.nifi.annotation.lifecycle.OnUnscheduled;
> import org.apache.nifi.annotation.lifecycle.OnStopped;
> import org.apache.nifi.components.PropertyDescriptor;
> import org.apache.nifi.components.RequiredPermission;
> @@ -264,6 +265,14 @@ public class ExecuteGroovyScript extends
> AbstractProcessor {
> throw new ProcessException("onStart failed: " + t, t);
> }
> }
> +@OnUnscheduled
> +public void onUnscheduled(final ProcessContext context) {
> +try {
> +callScriptStatic("onUnscheduled", context);
> +} catch (Throwable t) {
> +throw new ProcessException("onUnscheduled failed: " + t, t);
> +}
> +}
>
> @OnStopped
> public void onStopped(final ProcessContext context) {
> {code}
> But this is my first attempt to change Nifi; I defer to others.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi] belugabehr opened a new pull request #3643: NIFI-6542: Upgrade nifi-hadoop-bundles Hadoop version dependency to 3…
belugabehr opened a new pull request #3643: NIFI-6542: Upgrade
nifi-hadoop-bundles Hadoop version dependency to 3…
URL: https://github.com/apache/nifi/pull/3643
….2.0
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (NIFI-6543) Add onUnscheduled support for ExecuteJavaProcessor
Michael Wagner created NIFI-6543:
Summary: Add onUnscheduled support for ExecuteJavaProcessor
Key: NIFI-6543
URL: https://issues.apache.org/jira/browse/NIFI-6543
Project: Apache NiFi
Issue Type: Improvement
Components: Extensions
Reporter: Michael Wagner
The ExecuteGroovyScript processor is great, and it is great to have the support
for onStart and onStop methods. However, I often find myself wishing there
were also a way to take some action when the processor is _unscheduled_. That
would let the groovy code to make decisions about whether or not to get()
another flowfile.
I think it should be as easy as
{code:java}
diff --git
a/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
b/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
index c35ab392d..eead4bc07 100644
---
a/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
+++
b/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/main/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScript.java
@@ -27,6 +27,7 @@ import
org.apache.nifi.annotation.documentation.CapabilityDescription;
import org.apache.nifi.annotation.documentation.SeeAlso;
import org.apache.nifi.annotation.documentation.Tags;
import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnUnscheduled;
import org.apache.nifi.annotation.lifecycle.OnStopped;
import org.apache.nifi.components.PropertyDescriptor;
import org.apache.nifi.components.RequiredPermission;
@@ -264,6 +265,14 @@ public class ExecuteGroovyScript extends AbstractProcessor
{
throw new ProcessException("onStart failed: " + t, t);
}
}
+@OnUnscheduled
+public void onUnscheduled(final ProcessContext context) {
+try {
+callScriptStatic("onUnscheduled", context);
+} catch (Throwable t) {
+throw new ProcessException("onUnscheduled failed: " + t, t);
+}
+}
@OnStopped
public void onStopped(final ProcessContext context) {
{code}
But this is my first attempt to change Nifi; I defer to others.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (NIFI-6542) Upgrade nifi-hadoop-bundles Hadoop version dependency to 3.2.0
David Mollitor created NIFI-6542: Summary: Upgrade nifi-hadoop-bundles Hadoop version dependency to 3.2.0 Key: NIFI-6542 URL: https://issues.apache.org/jira/browse/NIFI-6542 Project: Apache NiFi Issue Type: New Feature Components: Core Framework Affects Versions: 1.9.2, 1.10.0 Reporter: David Mollitor Fix For: 1.10.0 Upgrade to Hadoop libraries to 3.2 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] asfgit closed pull request #3640: NIFI-6534 Improve logging in PutHive3Streaming processor
asfgit closed pull request #3640: NIFI-6534 Improve logging in PutHive3Streaming processor URL: https://github.com/apache/nifi/pull/3640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6534) Improve logging in PutHive3Streaming processor
[ https://issues.apache.org/jira/browse/NIFI-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904195#comment-16904195 ] ASF subversion and git services commented on NIFI-6534: --- Commit 2baafcc2e688d84f1531aa95bf7a6c6203fbdb6b in nifi's branch refs/heads/master from Tamas Palfy [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2baafcc ] NIFI-6534 Improve logging in PutHive3Streaming processor Added logging for PutHive3Streaming when routing to failure Signed-off-by: Matthew Burgess This closes #3640 > Improve logging in PutHive3Streaming processor > -- > > Key: NIFI-6534 > URL: https://issues.apache.org/jira/browse/NIFI-6534 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Denes Arvay >Assignee: Tamas Palfy >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In case of exception the PutHive3Streaming transfers FlowFiles to the failure > relationship without any meaningful logging. To simplify troubleshooting it'd > be good to add logging for these cases. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] mattyb149 commented on issue #3640: NIFI-6534 Improve logging in PutHive3Streaming processor
mattyb149 commented on issue #3640: NIFI-6534 Improve logging in PutHive3Streaming processor URL: https://github.com/apache/nifi/pull/3640#issuecomment-520067189 +1 LGTM, code and error messages look good. Thanks for the improvement! Merging to master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6541) The .td-expansion-label have incorrect font size.
[
https://issues.apache.org/jira/browse/NIFI-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Aslan updated NIFI-6541:
--
Description:
.td-expansion-label should be font-size: 20px
was:
```.td-expansion-label {
font-size: 20px;
}```
> The .td-expansion-label have incorrect font size.
> -
>
> Key: NIFI-6541
> URL: https://issues.apache.org/jira/browse/NIFI-6541
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
> Fix For: fds-0.3
>
>
> .td-expansion-label should be font-size: 20px
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (NIFI-6541) The .td-expansion-label have incorrect font size.
Scott Aslan created NIFI-6541:
-
Summary: The .td-expansion-label have incorrect font size.
Key: NIFI-6541
URL: https://issues.apache.org/jira/browse/NIFI-6541
Project: Apache NiFi
Issue Type: Bug
Reporter: Scott Aslan
Assignee: Scott Aslan
Fix For: fds-0.3
```.td-expansion-label {
font-size: 20px;
}```
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (NIFI-6540) td-chips background is white and missing the filter icon
[ https://issues.apache.org/jira/browse/NIFI-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-6540: -- Status: Patch Available (was: In Progress) > td-chips background is white and missing the filter icon > > > Key: NIFI-6540 > URL: https://issues.apache.org/jira/browse/NIFI-6540 > Project: Apache NiFi > Issue Type: Bug > Components: FDS >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: fds-0.3 > > Time Spent: 10m > Remaining Estimate: 0h > > The td-chips should have a transparent background color and the filter icon > should be visible. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-fds] scottyaslan opened a new pull request #46: [NIFI-6540] update td-chips remove background color and make filter i…
scottyaslan opened a new pull request #46: [NIFI-6540] update td-chips remove background color and make filter i… URL: https://github.com/apache/nifi-fds/pull/46 …con visible Thank you for submitting a contribution to Apache NiFi Flow Design System. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with either NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder? - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6540) td-chips background is white and missing the filter icon
Scott Aslan created NIFI-6540: - Summary: td-chips background is white and missing the filter icon Key: NIFI-6540 URL: https://issues.apache.org/jira/browse/NIFI-6540 Project: Apache NiFi Issue Type: Bug Components: FDS Reporter: Scott Aslan Assignee: Scott Aslan Fix For: fds-0.3 The td-chips should have a transparent background color and the filter icon should be visible. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-6535) Confirm dialogs title font is incorrect
[ https://issues.apache.org/jira/browse/NIFI-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-6535: -- Status: Patch Available (was: In Progress) > Confirm dialogs title font is incorrect > --- > > Key: NIFI-6535 > URL: https://issues.apache.org/jira/browse/NIFI-6535 > Project: Apache NiFi > Issue Type: Bug > Components: FDS >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: fds-0.3 > > Time Spent: 10m > Remaining Estimate: 0h > > As a user I expect to see the title of a confirm dialog leveraging the > mat-card-title component. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-fds] scottyaslan opened a new pull request #45: [NIFI-6535] update confirm dialog title font size
scottyaslan opened a new pull request #45: [NIFI-6535] update confirm dialog title font size URL: https://github.com/apache/nifi-fds/pull/45 Thank you for submitting a contribution to Apache NiFi Flow Design System. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with either NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you ensured that a full build and that the full suite of unit tests is executed via npm run clean:install at the root nifi-fds folder? - [ ] Have you written or updated the Apache NiFi Flow Design System demo application to demonstrate any new functionality, provide examples of usage, and to verify your changes via npm start at the nifi-fds/target folder? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-fds? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-fds? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (NIFI-6420) Controller Service references not properly tracked if multiple references from same component
[ https://issues.apache.org/jira/browse/NIFI-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne reassigned NIFI-6420: Assignee: Alessandro D'Armiento > Controller Service references not properly tracked if multiple references > from same component > - > > Key: NIFI-6420 > URL: https://issues.apache.org/jira/browse/NIFI-6420 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Alessandro D'Armiento >Priority: Major > Labels: cleanup, codesmell, refactor > Fix For: 1.10.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > The StandardControllerServiceNode keeps track of any references to it via > `addReference` and `removeReference` methods. However, if a Processor (or > another Controller Service) has two different properties that reference the > service, then the references can become incorrect. > This is due to the fact that when Properties are set for a component, we > determine that Property A previously referenced Service 123 but no longer > does and call `removeReference` on Service 123. However, if Property B also > is referencing Service 123, we have a condition where the Processor is > referencing Service 123, but Service 123 does not know about it, because of > the call to `removeReference`. > We should either be storing references as a `List` in > `StandardControllerServiceNode` or else should determine whether or not all > references have been removed before calling `removeReference`. I suspect that > the latter is less error-prone, given that calls to `addReference` currently > are idempotent and changing the data structure to a `List` would mean that > the method is no longer idempotent. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (NIFI-6420) Controller Service references not properly tracked if multiple references from same component
[ https://issues.apache.org/jira/browse/NIFI-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-6420. -- Resolution: Fixed Fix Version/s: 1.10.0 > Controller Service references not properly tracked if multiple references > from same component > - > > Key: NIFI-6420 > URL: https://issues.apache.org/jira/browse/NIFI-6420 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Priority: Major > Labels: cleanup, codesmell, refactor > Fix For: 1.10.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > The StandardControllerServiceNode keeps track of any references to it via > `addReference` and `removeReference` methods. However, if a Processor (or > another Controller Service) has two different properties that reference the > service, then the references can become incorrect. > This is due to the fact that when Properties are set for a component, we > determine that Property A previously referenced Service 123 but no longer > does and call `removeReference` on Service 123. However, if Property B also > is referencing Service 123, we have a condition where the Processor is > referencing Service 123, but Service 123 does not know about it, because of > the call to `removeReference`. > We should either be storing references as a `List` in > `StandardControllerServiceNode` or else should determine whether or not all > references have been removed before calling `removeReference`. I suspect that > the latter is less error-prone, given that calls to `addReference` currently > are idempotent and changing the data structure to a `List` would mean that > the method is no longer idempotent. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] asfgit closed pull request #3600: NIFI-6420 Controller Service references not properly tracked if multiple references from same component
asfgit closed pull request #3600: NIFI-6420 Controller Service references not properly tracked if multiple references from same component URL: https://github.com/apache/nifi/pull/3600 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] markap14 commented on issue #3600: NIFI-6420 Controller Service references not properly tracked if multiple references from same component
markap14 commented on issue #3600: NIFI-6420 Controller Service references not properly tracked if multiple references from same component URL: https://github.com/apache/nifi/pull/3600#issuecomment-520035352 Apologies that it took me a while to get back to this. All looks good to me @adarmiento . Have merged to master. Thanks for the fix! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6420) Controller Service references not properly tracked if multiple references from same component
[ https://issues.apache.org/jira/browse/NIFI-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904143#comment-16904143 ] ASF subversion and git services commented on NIFI-6420: --- Commit 35d79eaf0fbd2361b3950a8417cb5f5b82d8cd44 in nifi's branch refs/heads/master from Alessandro D'Armiento [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=35d79ea ] NIFI-6420 Controller Service references not properly tracked if multiple references from same component Changes - Instead of keeping a Set of referencing `ComponentNode`, keep instead a Map which stores, for each referencing component, also the name of the property for which the service is referenced - This is done to keep the `addReference()` idempotent - `StandardControllerService.referencingComponents` changed from HashSet to HashMap - `Key` is the combination of `ComponentNode.hashCode()` and property name - `Value` is the referencing `ComponentNode` - `ControllerServiceNode.addReference()` now requires a tuple (referring `ComponentNode`, property name) - `ControllerServiceNode.removeReference()` now requires a tuple (referring `ComponentNode`, property name) - `ControllerServiceNode.getReferences()` signature is left untouched, when it's called, the values of the `referencingComponents` map are turned into a Set, meaning a referencing component will keep being returned by this method until at least one of its properties still reference the `ControllerService` - `StandardSchedulingContext.leaseControllerService()` uses a dedicated constant - `FrameworkIntegrationTest` has a test which create a processor with two optional controller service properties and then verifies that having them referencing and dereferencing the same controller service doesn't cause the reported bug anymore Removed SchedulingContext from ClojureScriptEngineConfigurator Co-Authored-By: Marco Gaido Signed-off-by: Mark Payne This closes #3600. > Controller Service references not properly tracked if multiple references > from same component > - > > Key: NIFI-6420 > URL: https://issues.apache.org/jira/browse/NIFI-6420 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Priority: Major > Labels: cleanup, codesmell, refactor > Time Spent: 3.5h > Remaining Estimate: 0h > > The StandardControllerServiceNode keeps track of any references to it via > `addReference` and `removeReference` methods. However, if a Processor (or > another Controller Service) has two different properties that reference the > service, then the references can become incorrect. > This is due to the fact that when Properties are set for a component, we > determine that Property A previously referenced Service 123 but no longer > does and call `removeReference` on Service 123. However, if Property B also > is referencing Service 123, we have a condition where the Processor is > referencing Service 123, but Service 123 does not know about it, because of > the call to `removeReference`. > We should either be storing references as a `List` in > `StandardControllerServiceNode` or else should determine whether or not all > references have been removed before calling `removeReference`. I suspect that > the latter is less error-prone, given that calls to `addReference` currently > are idempotent and changing the data structure to a `List` would mean that > the method is no longer idempotent. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] bbende commented on issue #3642: NIFI-6382: On flow import and version change, create parameter context where necessary and add parameters where necessary
bbende commented on issue #3642: NIFI-6382: On flow import and version change, create parameter context where necessary and add parameters where necessary URL: https://github.com/apache/nifi/pull/3642#issuecomment-520024847 Will review... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6539) Ability to initialize nifi-stateless from a flow.xml.gz
David Kegley created NIFI-6539: -- Summary: Ability to initialize nifi-stateless from a flow.xml.gz Key: NIFI-6539 URL: https://issues.apache.org/jira/browse/NIFI-6539 Project: Apache NiFi Issue Type: New Feature Reporter: David Kegley nifi-stateless currently supports running a flow from a registry given a flow_id and a registry endpoint. To facilitate environments where there is no connectivity to a registry, I would like the ability to run nifi-stateless from a flow.xml.gz on the filesystem. When running in a container the flow.xml.gz could be added to the container image and tagged with a version, or mounted as a volume at runtime. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (NIFI-6538) Provide quick access to processors details
Jean-Sebastien Vachon created NIFI-6538: --- Summary: Provide quick access to processors details Key: NIFI-6538 URL: https://issues.apache.org/jira/browse/NIFI-6538 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.9.1 Reporter: Jean-Sebastien Vachon If you want to see running processors, you need to open the Summary panel, select/find your processor and then click on the "view processor details". It would be nice to have a shortcut added the contextual menu of a processor to access this information. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (NIFI-6537) Provide details about why a bin was merged in a MergeContent processor
Jean-Sebastien Vachon created NIFI-6537: --- Summary: Provide details about why a bin was merged in a MergeContent processor Key: NIFI-6537 URL: https://issues.apache.org/jira/browse/NIFI-6537 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.9.1 Reporter: Jean-Sebastien Vachon When a flow is being merged using a MergeContent processor, it would be useful to know why it was merged as there are quite some reasons for the merge to happen. The information could be saved in a special attribute and/or through different streams and should be logged somewhere as it is useful information to track and debug what's happening in a flow. In my particular case, I had trailing flows because the bin reached the "max bin age" threshold. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (NIFI-6533) listHDFS lists files from beginning after restart NIFI
[ https://issues.apache.org/jira/browse/NIFI-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-6533. -- Resolution: Duplicate Thanks [~helenzh] - will close as duplicate then. > listHDFS lists files from beginning after restart NIFI > -- > > Key: NIFI-6533 > URL: https://issues.apache.org/jira/browse/NIFI-6533 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration >Affects Versions: 1.9.0 > Environment: NIFI cluster >Reporter: helenzh >Priority: Major > Original Estimate: 4m > Remaining Estimate: 4m > > after restart NIFI, listHDFS lists files from beginning but not timestamp > saved in zookeeper. No suche issue of listSFTP. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-6382) Ensure proper integration between NiFi & NiFi Registry with respect to Parameters
[ https://issues.apache.org/jira/browse/NIFI-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-6382: - Status: Patch Available (was: Open) > Ensure proper integration between NiFi & NiFi Registry with respect to > Parameters > - > > Key: NIFI-6382 > URL: https://issues.apache.org/jira/browse/NIFI-6382 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Need to ensure that flows saved to the Flow Registry have all Parameters also > passed in, with the values (except for sensitive parameters, which should be > defined but have no values). Need to ensure that when importing a flow, that > the Parameter Context is able to be chosen, or a new one created. If a new > one is created, it should be created with the values from registry. Also, > need to ensure that when changing version that any Parameters in the 'new' > version are also included in the Parameter Context (assuming adequate > permissions to add them). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] markap14 opened a new pull request #3642: NIFI-6382: On flow import and version change, create parameter context where necessary and add parameters where necessary
markap14 opened a new pull request #3642: NIFI-6382: On flow import and version
change, create parameter context where necessary and add parameters where
necessary
URL: https://github.com/apache/nifi/pull/3642
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (NIFI-6536) Expose PGP symmetric encryption algorithm in EncryptContent
Brandon DeVries created NIFI-6536: - Summary: Expose PGP symmetric encryption algorithm in EncryptContent Key: NIFI-6536 URL: https://issues.apache.org/jira/browse/NIFI-6536 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.9.2 Reporter: Brandon DeVries EncryptContent, when using PGP, is currently hard coded to use AES_128 as its symmetric key algorithm. There is a TODO adjacent to this in the code [1]: // TODO: Refactor internal symmetric encryption algorithm to be customizable [1] [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/OpenPGPKeyBasedEncryptor.java#L348] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (NIFI-6535) Confirm dialogs title font is incorrect
[ https://issues.apache.org/jira/browse/NIFI-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-6535: - Assignee: Scott Aslan > Confirm dialogs title font is incorrect > --- > > Key: NIFI-6535 > URL: https://issues.apache.org/jira/browse/NIFI-6535 > Project: Apache NiFi > Issue Type: Bug > Components: FDS >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: fds-0.3 > > > As a user I expect to see the title of a confirm dialog leveraging the > mat-card-title component. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-registry] kevdoran closed pull request #214: Switch Travis to use OpenJDK instead of Oracle
kevdoran closed pull request #214: Switch Travis to use OpenJDK instead of Oracle URL: https://github.com/apache/nifi-registry/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] kevdoran commented on issue #214: Switch Travis to use OpenJDK instead of Oracle
kevdoran commented on issue #214: Switch Travis to use OpenJDK instead of Oracle URL: https://github.com/apache/nifi-registry/pull/214#issuecomment-519988253 Closing in favor of @bbende's changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende commented on issue #211: NIFIREG-295 Add support for proxying via Apache Knox
bbende commented on issue #211: NIFIREG-295 Add support for proxying via Apache Knox URL: https://github.com/apache/nifi-registry/pull/211#issuecomment-519958603 @ijokarumawak one more thing to consider is that some of the entities returned by the REST API have a Link object which gets populated from LinkService. Some of the links are relative, but some are full: https://github.com/apache/nifi-registry/blob/master/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/link/LinkService.java#L337 The baseURI comes from ApplicationResource getBaseUri() which looks at the proxy headers: https://github.com/apache/nifi-registry/blob/master/nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ApplicationResource.java#L80-L83 So I think we just need to make sure these links are correct when proxying through Knox. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] kevdoran opened a new pull request #214: Switch Travis to use OpenJDK instead of Oracle
kevdoran opened a new pull request #214: Switch Travis to use OpenJDK instead of Oracle URL: https://github.com/apache/nifi-registry/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] bbende opened a new pull request #213: NIFIREG-301 Added description to VersionedParameterContext
bbende opened a new pull request #213: NIFIREG-301 Added description to VersionedParameterContext URL: https://github.com/apache/nifi-registry/pull/213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFIREG-301) Add description field to VersionedParameterContext
Bryan Bende created NIFIREG-301: --- Summary: Add description field to VersionedParameterContext Key: NIFIREG-301 URL: https://issues.apache.org/jira/browse/NIFIREG-301 Project: NiFi Registry Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende Fix For: 0.5.0 In NiFi's parameter work there is a description field for a parameter context, we should capture that in the VersionedParameterContext. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-registry] bbende opened a new pull request #212: NIFIREG-300 Added nifi-registry-revision modules containg NiFi's Revi…
bbende opened a new pull request #212: NIFIREG-300 Added nifi-registry-revision modules containg NiFi's Revi… URL: https://github.com/apache/nifi-registry/pull/212 …sionManager concept with a JDBC implementation and supporting utility modules This pull request doesn't change any functionality in the application, it just establishes the nifi-registry-revision modules. It is probably easiest to review them by looking through the modules in an IDE to see how the pieces fit together, starting with nifi-registry-revision-api which directly correlates to NiFi's revision API (potentially they could share this API module once released). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFIREG-300) Create a revision manager for optimistic locking of entities in web requests
Bryan Bende created NIFIREG-300: --- Summary: Create a revision manager for optimistic locking of entities in web requests Key: NIFIREG-300 URL: https://issues.apache.org/jira/browse/NIFIREG-300 Project: NiFi Registry Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende In order to support running multiple instances of the NiFi Registry application pointing at a central shared database, we need a revision concept like NiFi has for all entities that we have CRUD operations for (bucket, flow, user, group, policy). This ticket is to define and implement the a revision management module. A follow on ticket will capture the work to integrate this module into the application. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-registry] kevdoran commented on issue #211: NIFIREG-295 Add support for proxying via Apache Knox
kevdoran commented on issue #211: NIFIREG-295 Add support for proxying via Apache Knox URL: https://github.com/apache/nifi-registry/pull/211#issuecomment-519906491 Thanks @ijokarumawak! Yes, I would agree that we should open a JIRA for adding trusted values for the various proxy headers similar to NiFi. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] avseq1234 opened a new pull request #3641: NIFI-4542, add target.dir.created to indicate if the target directory created
avseq1234 opened a new pull request #3641: NIFI-4542, add target.dir.created to
indicate if the target directory created
URL: https://github.com/apache/nifi/pull/3641
… created
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ X ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ X ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ X ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi-registry] ijokarumawak commented on issue #211: NIFIREG-295 Add support for proxying via Apache Knox
ijokarumawak commented on issue #211: NIFIREG-295 Add support for proxying via Apache Knox URL: https://github.com/apache/nifi-registry/pull/211#issuecomment-519868229 Thanks @kevdoran for checking. I haven't found anything required to change at NiFi Registry server side. Although, I noticed, NiFi Registry doesn't implement proxy context path white list as NiFi does with `nifi.web.proxy.context.path`. I'm not sure how critical it is, though. Probably we need to open another JIRA for that. How do you think? BTW, after changing the paths to call NiFi Registry APIs to relative, the UI app started working better. I'll keep testing to see if everything works as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] avseq1234 commented on issue #3235: Nifi 1893
avseq1234 commented on issue #3235: Nifi 1893 URL: https://github.com/apache/nifi/pull/3235#issuecomment-519860325 I think we can use ValidateRecord to do the same validation. I will close this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] avseq1234 closed pull request #3235: Nifi 1893
avseq1234 closed pull request #3235: Nifi 1893 URL: https://github.com/apache/nifi/pull/3235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (NIFI-6509) Date related issue in unit test VolatileComponentStatusRepositoryTest
[
https://issues.apache.org/jira/browse/NIFI-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Palfy reassigned NIFI-6509:
-
Assignee: Tamas Palfy
> Date related issue in unit test VolatileComponentStatusRepositoryTest
> -
>
> Key: NIFI-6509
> URL: https://issues.apache.org/jira/browse/NIFI-6509
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Tamas Palfy
>Assignee: Tamas Palfy
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Unit test
> {{VolatileComponentStatusRepositoryTest.testFilterDatesUsingPreferredDataPoints}}
> may fail with the following:
> {code:java}
> java.lang.AssertionError:
> Expected :Thu Jan 01 00:00:00 CET 1970
> Actual :Thu Jan 01 01:00:00 CET 1970
> {code}
> The test creates a {{VolatileComponentStatusRepository}} instance and adds
> {{java.util.Date}} objects to it starting from epoch (via {{new Date(0)}}).
> This first date at epoch is the _Actual_ in the _AssertionError_.
> Then filters this list by looking for those that are earlier or matching a
> _start_ paramater. This _start_ is created from a {{LocalDateTime}} at the
> default system time zone.
> This is the _Expected_ in the _AssertionError_.
> In general the issue is the difference in how the list is created (dates that
> are 00:00:00 GMT) and how the filter parameter date is created (00:00:00 at
> system time zone).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (NIFI-5478) PutS3Object support for new Storage Classes for Infrequent Access
[ https://issues.apache.org/jira/browse/NIFI-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-5478: - Labels: AWS aws cloud (was: ) > PutS3Object support for new Storage Classes for Infrequent Access > - > > Key: NIFI-5478 > URL: https://issues.apache.org/jira/browse/NIFI-5478 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.7.0, 1.7.1 >Reporter: Randy Bovay >Assignee: Peter Turcsanyi >Priority: Minor > Labels: AWS, aws, cloud > Time Spent: 0.5h > Remaining Estimate: 0h > > The PutS3Object processor currently supports StorageClass of 'Standard' and > 'ReducedRedundancy', but not the 2 additional Storage classes which have been > released which cost less. > This processor should also provide these new storage classes as an option. > S3 Standard-Infrequent Access (S3 Standard-IA) Storage > S3 One Zone-Infrequent Access (S3 One Zone-IA) Storage > [https://aws.amazon.com/s3/storage-classes/] > The Reduced Redundancy Class seems to be still available, although appears to > be deprecated. I would recommend no change to that as it's not fully retired > and AWS appears to be letting this die on the vine. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-5478) PutS3Object support for new Storage Classes for Infrequent Access
[ https://issues.apache.org/jira/browse/NIFI-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-5478: - Resolution: Fixed Fix Version/s: 1.10.0 Status: Resolved (was: Patch Available) > PutS3Object support for new Storage Classes for Infrequent Access > - > > Key: NIFI-5478 > URL: https://issues.apache.org/jira/browse/NIFI-5478 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.7.0, 1.7.1 >Reporter: Randy Bovay >Assignee: Peter Turcsanyi >Priority: Minor > Labels: AWS, aws, cloud > Fix For: 1.10.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The PutS3Object processor currently supports StorageClass of 'Standard' and > 'ReducedRedundancy', but not the 2 additional Storage classes which have been > released which cost less. > This processor should also provide these new storage classes as an option. > S3 Standard-Infrequent Access (S3 Standard-IA) Storage > S3 One Zone-Infrequent Access (S3 One Zone-IA) Storage > [https://aws.amazon.com/s3/storage-classes/] > The Reduced Redundancy Class seems to be still available, although appears to > be deprecated. I would recommend no change to that as it's not fully retired > and AWS appears to be letting this die on the vine. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] asfgit closed pull request #3608: NIFI-5478: PutS3Object support for new Storage Classes
asfgit closed pull request #3608: NIFI-5478: PutS3Object support for new Storage Classes URL: https://github.com/apache/nifi/pull/3608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-5478) PutS3Object support for new Storage Classes for Infrequent Access
[ https://issues.apache.org/jira/browse/NIFI-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-5478: - Component/s: Extensions > PutS3Object support for new Storage Classes for Infrequent Access > - > > Key: NIFI-5478 > URL: https://issues.apache.org/jira/browse/NIFI-5478 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.7.0, 1.7.1 >Reporter: Randy Bovay >Assignee: Peter Turcsanyi >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > The PutS3Object processor currently supports StorageClass of 'Standard' and > 'ReducedRedundancy', but not the 2 additional Storage classes which have been > released which cost less. > This processor should also provide these new storage classes as an option. > S3 Standard-Infrequent Access (S3 Standard-IA) Storage > S3 One Zone-Infrequent Access (S3 One Zone-IA) Storage > [https://aws.amazon.com/s3/storage-classes/] > The Reduced Redundancy Class seems to be still available, although appears to > be deprecated. I would recommend no change to that as it's not fully retired > and AWS appears to be letting this die on the vine. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (NIFI-5478) PutS3Object support for new Storage Classes for Infrequent Access
[ https://issues.apache.org/jira/browse/NIFI-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903705#comment-16903705 ] ASF subversion and git services commented on NIFI-5478: --- Commit a5bdecbd25a5ef46bd75bdb926d44cde8bc79c96 in nifi's branch refs/heads/master from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a5bdecb ] NIFI-5478: PutS3Object support for new Storage Classes Signed-off-by: Pierre Villard This closes #3608. > PutS3Object support for new Storage Classes for Infrequent Access > - > > Key: NIFI-5478 > URL: https://issues.apache.org/jira/browse/NIFI-5478 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.7.0, 1.7.1 >Reporter: Randy Bovay >Assignee: Peter Turcsanyi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The PutS3Object processor currently supports StorageClass of 'Standard' and > 'ReducedRedundancy', but not the 2 additional Storage classes which have been > released which cost less. > This processor should also provide these new storage classes as an option. > S3 Standard-Infrequent Access (S3 Standard-IA) Storage > S3 One Zone-Infrequent Access (S3 One Zone-IA) Storage > [https://aws.amazon.com/s3/storage-classes/] > The Reduced Redundancy Class seems to be still available, although appears to > be deprecated. I would recommend no change to that as it's not fully retired > and AWS appears to be letting this die on the vine. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] pvillard31 commented on issue #3608: NIFI-5478: PutS3Object support for new Storage Classes
pvillard31 commented on issue #3608: NIFI-5478: PutS3Object support for new Storage Classes URL: https://github.com/apache/nifi/pull/3608#issuecomment-519834222 +1, merged to master, thanks @turcsanyip This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] tpalfy commented on issue #3640: NIFI-6534 Improve logging in PutHive3Streaming processor
tpalfy commented on issue #3640: NIFI-6534 Improve logging in PutHive3Streaming processor URL: https://github.com/apache/nifi/pull/3640#issuecomment-519828816 > Looking good, just left some comments to clean up the messages a bit, but otherwise will be good to go, thanks! Thanks for the feedback, I added the recommended changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] tpalfy commented on a change in pull request #3640: NIFI-6534 Improve logging in PutHive3Streaming processor
tpalfy commented on a change in pull request #3640: NIFI-6534 Improve logging
in PutHive3Streaming processor
URL: https://github.com/apache/nifi/pull/3640#discussion_r312374730
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java
##
@@ -431,6 +431,10 @@ public void onTrigger(ProcessContext context,
ProcessSession session) throws Pro
if (rollbackOnFailure) {
throw new ProcessException(rrfe);
} else {
+log.error(
+"Failed to create {} for {}.
rollbackOnFailure='{}' - routing to failure. Exception: {}",
Review comment:
Applied all recommended changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] tpalfy commented on a change in pull request #3640: NIFI-6534 Improve logging in PutHive3Streaming processor
tpalfy commented on a change in pull request #3640: NIFI-6534 Improve logging
in PutHive3Streaming processor
URL: https://github.com/apache/nifi/pull/3640#discussion_r312374827
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java
##
@@ -474,12 +482,16 @@ public void onTrigger(ProcessContext context,
ProcessSession session) throws Pro
}
throw new ProcessException(cause.getLocalizedMessage(), cause);
} else {
-flowFile = session.penalize(flowFile);
+FlowFile outFlowFile = session.penalize(flowFile);
Map updateAttributes = new HashMap<>();
updateAttributes.put(HIVE_STREAMING_RECORD_COUNT_ATTR,
Long.toString(hiveStreamingConnection.getConnectionStats().getRecordsWritten()));
updateAttributes.put(ATTR_OUTPUT_TABLES,
options.getQualifiedTableName());
-flowFile = session.putAllAttributes(flowFile,
updateAttributes);
-session.transfer(flowFile, REL_FAILURE);
+outFlowFile = session.putAllAttributes(outFlowFile,
updateAttributes);
+log.error(
Review comment:
Applied all recommended changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] tpalfy commented on a change in pull request #3640: NIFI-6534 Improve logging in PutHive3Streaming processor
tpalfy commented on a change in pull request #3640: NIFI-6534 Improve logging
in PutHive3Streaming processor
URL: https://github.com/apache/nifi/pull/3640#discussion_r312374776
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3Streaming.java
##
@@ -445,6 +449,10 @@ public void onTrigger(ProcessContext context,
ProcessSession session) throws Pro
updateAttributes.put(HIVE_STREAMING_RECORD_COUNT_ATTR,
Long.toString(hiveStreamingConnection.getConnectionStats().getRecordsWritten()));
updateAttributes.put(ATTR_OUTPUT_TABLES,
options.getQualifiedTableName());
flowFile = session.putAllAttributes(flowFile,
updateAttributes);
+log.error(
+"Exception while processing {}. rollbackOnFailure='{}'
- routing to failure. Exception: {}",
Review comment:
Applied all recommended changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6479) Fix TestJdbcCommon timezone issues
[
https://issues.apache.org/jira/browse/NIFI-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-6479:
Resolution: Fixed
Fix Version/s: 1.10.0
Status: Resolved (was: Patch Available)
> Fix TestJdbcCommon timezone issues
> --
>
> Key: NIFI-6479
> URL: https://issues.apache.org/jira/browse/NIFI-6479
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
> Fix For: 1.10.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
> with timezone issues.
> The workaround for this issue is to add
> {code:java}
> -Dmaven.surefire.arguments=-Duser.timezone=UTC
> {code}
> when running maven. If {{-Dmaven.surefire.arguments}} is already specified
> as part of the build, add {{-Duser.timezone=UTC}} to the value supplied to
> that parameter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi] asfgit closed pull request #3630: NIFI-6479 Fixes timezone issues in TestJdbcCommon
asfgit closed pull request #3630: NIFI-6479 Fixes timezone issues in TestJdbcCommon URL: https://github.com/apache/nifi/pull/3630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6479) Fix TestJdbcCommon timezone issues
[
https://issues.apache.org/jira/browse/NIFI-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903652#comment-16903652
]
ASF subversion and git services commented on NIFI-6479:
---
Commit b938fc20a3cf93547e3250f850db33eacb8ab083 in nifi's branch
refs/heads/master from Jeff Storck
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b938fc2 ]
NIFI-6479 Fixes timezone issues in TestJdbcCommon
Dates calculated for method testConvertToAvroStreamForDateTimeAsLogicalType now
handle timezone correctly
Added debug logging of date/time calculations and expectations
This closes #3630.
Signed-off-by: Koji Kawamura
> Fix TestJdbcCommon timezone issues
> --
>
> Key: NIFI-6479
> URL: https://issues.apache.org/jira/browse/NIFI-6479
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
> with timezone issues.
> The workaround for this issue is to add
> {code:java}
> -Dmaven.surefire.arguments=-Duser.timezone=UTC
> {code}
> when running maven. If {{-Dmaven.surefire.arguments}} is already specified
> as part of the build, add {{-Duser.timezone=UTC}} to the value supplied to
> that parameter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi] ijokarumawak commented on issue #3630: NIFI-6479 Fixes timezone issues in TestJdbcCommon
ijokarumawak commented on issue #3630: NIFI-6479 Fixes timezone issues in TestJdbcCommon URL: https://github.com/apache/nifi/pull/3630#issuecomment-519812457 LGTM +1, full contrib-check build passed locally. Merging to master. Thanks @jtstorck for fixing! Thanks @pcgrenier for confirming it addresses the timezone issue! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
