[jira] [Commented] (NIFI-5955) Provide a Docker HEALTHCHECK
[
https://issues.apache.org/jira/browse/NIFI-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250872#comment-17250872
]
Ruben Laguna commented on NIFI-5955:
The problem with this kind of healthcheck (/nifi) is that the UI may be up (GET
/nifi 200 OK) but the UI may still be unusable (for example the UI is a node
that is disconnected from the cluster). In [NIFI-8100] I've requested a
healthcheck endpoint that signals that the node is actually ready and healthy
so that it can be used by external load balancers, but I guess I would be also
good to use that new endpoint for the docker healthcheck.
> Provide a Docker HEALTHCHECK
>
>
> Key: NIFI-5955
> URL: https://issues.apache.org/jira/browse/NIFI-5955
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Reporter: Anthony Mastrean
>Priority: Minor
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> It takes Nifi a noticeable amount of time to become available at
> [http://localhost:8080/nifi.] We can help indicate readiness to both human
> and machine users (see
> [depends_on|https://docs.docker.com/compose/compose-file/compose-file-v2/#depends_on]
> in Compose) by establishing a HEALTHCHECK in the Dockerfile.
> The
> [documentation|https://docs.docker.com/engine/reference/builder/#healthcheck]
> suggests
> {code:java}
> HEALTHCHECK CMD curl -f http://localhost:8080/nifi || exit 1{code}
>
> But, there are [better cURL
> flags|https://explainshell.com/explain?cmd=curl+-fsSL+example.org] for
> scripts.
> {code:java}
> HEALTHCHECK CMD curl -fsSL http://localhost:8080/nifi || exit 1
> {code}
>
> And I sometimes see problems using {{localhost}} (possibly a Docker
> networking issue?). I've seen this pattern suggested elsewhere.
> {code:java}
> HEALTHCHECK CMD curl -fsSL http://$(hostname -i || echo localhost):8080/nifi
> || exit 1
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8100) Provide a /health endpoint that do not require authentication for use in LoadBalancer (nifi UI)
[
https://issues.apache.org/jira/browse/NIFI-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruben Laguna updated NIFI-8100:
---
Description:
Usually load balancers with AWS Application Load Balancer use periodic health
checks to determine which node it should forward requests to.
Today we have the /status api endpoint but that is not suitable because it
really requires authentication on a secure nifi installation and there is no
way to provide authorization headers in the health checks performed by load
balancers.
So I would like to have a /heath or /health-check endpoint that can be "open"
that answers 200 OK *when the node is connected to the cluster and a 4xx-5xx
error if the node is disconnected* ("Only a node connected to a cluster can
process the request", "This node is currently not connect to the cluster. Any
modifications to the data flow made here will not replicate across the
cluster").
This will simplify secure nifi deployment with load balancing, right now if a
node gets disconnected users will be still be routed to it even if that node is
really not usable.
Here I'm referring to *Load balancer for the NiFi web UI*, and just checking
for / or /nifi is not good enough because t he UI may be up (GET / 200OK) but
not usable (the node is disconnected from the cluster).
was:
Usually load balancers with AWS Application Load Balancer use periodic health
checks to determine which node it should forward requests to.
Today we have the /status api endpoint but that is not suitable because it
really requires authentication on a secure nifi installation and there is no
way to provide authorization headers in the health checks performed by load
balancers.
So I would like to have a /heath or /health-check endpoint that can be "open"
that answers 200 OK *when the node is connected to the cluster and a 4xx-5xx
error if the node is disconnected* ("Only a node connected to a cluster can
process the request", "This node is currently not connect to the cluster. Any
modifications to the data flow made here will not replicate across the
cluster").
This will simplify secure nifi deployment with load balancing, right now if a
node gets disconnected users will be still be routed to it even if that node is
really not usable.
> Provide a /health endpoint that do not require authentication for use in
> LoadBalancer (nifi UI)
> ---
>
> Key: NIFI-8100
> URL: https://issues.apache.org/jira/browse/NIFI-8100
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Ruben Laguna
>Priority: Major
>
> Usually load balancers with AWS Application Load Balancer use periodic health
> checks to determine which node it should forward requests to.
> Today we have the /status api endpoint but that is not suitable because it
> really requires authentication on a secure nifi installation and there is no
> way to provide authorization headers in the health checks performed by load
> balancers.
> So I would like to have a /heath or /health-check endpoint that can be "open"
> that answers 200 OK *when the node is connected to the cluster and a 4xx-5xx
> error if the node is disconnected* ("Only a node connected to a cluster can
> process the request", "This node is currently not connect to the cluster. Any
> modifications to the data flow made here will not replicate across the
> cluster").
> This will simplify secure nifi deployment with load balancing, right now if a
> node gets disconnected users will be still be routed to it even if that node
> is really not usable.
> Here I'm referring to *Load balancer for the NiFi web UI*, and just checking
> for / or /nifi is not good enough because t he UI may be up (GET / 200OK) but
> not usable (the node is disconnected from the cluster).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8100) Provide a /health endpoint that do not require authentication for use in LoadBalancer (nifi UI)
[
https://issues.apache.org/jira/browse/NIFI-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruben Laguna updated NIFI-8100:
---
Summary: Provide a /health endpoint that do not require authentication for
use in LoadBalancer (nifi UI) (was: Provide a /health endpoint that do not
require authentication for use in LoadBalancer)
> Provide a /health endpoint that do not require authentication for use in
> LoadBalancer (nifi UI)
> ---
>
> Key: NIFI-8100
> URL: https://issues.apache.org/jira/browse/NIFI-8100
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Ruben Laguna
>Priority: Major
>
> Usually load balancers with AWS Application Load Balancer use periodic health
> checks to determine which node it should forward requests to.
> Today we have the /status api endpoint but that is not suitable because it
> really requires authentication on a secure nifi installation and there is no
> way to provide authorization headers in the health checks performed by load
> balancers.
> So I would like to have a /heath or /health-check endpoint that can be "open"
> that answers 200 OK *when the node is connected to the cluster and a 4xx-5xx
> error if the node is disconnected* ("Only a node connected to a cluster can
> process the request", "This node is currently not connect to the cluster. Any
> modifications to the data flow made here will not replicate across the
> cluster").
> This will simplify secure nifi deployment with load balancing, right now if a
> node gets disconnected users will be still be routed to it even if that node
> is really not usable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8100) Provide a /health endpoint that do not require authentication for use in LoadBalancer
[
https://issues.apache.org/jira/browse/NIFI-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruben Laguna updated NIFI-8100:
---
Description:
Usually load balancers with AWS Application Load Balancer use periodic health
checks to determine which node it should forward requests to.
Today we have the /status api endpoint but that is not suitable because it
really requires authentication on a secure nifi installation and there is no
way to provide authorization headers in the health checks performed by load
balancers.
So I would like to have a /heath or /health-check endpoint that can be "open"
that answers 200 OK* when the node is connected to the cluster and a 4xx-5xx
error if the node is disconnected *("Only a node connected to a cluster can
process the request", "This node is currently not connect to the cluster. Any
modifications to the data flow made here will not replicate across the
cluster").
This will simplify secure nifi deployment with load balancing, right now if a
node gets disconnected users will be still be routed to it even if that node is
really not usable.
was:
Usually load balancers with AWS Application Load Balancer use periodic health
checks to determine which node it should forward requests to.
Today we have the /status api endpoint but that is not suitable because it
really requires authentication on a secure nifi installation and there is no
way to provide authorization headers in the health checks performed by load
balancers.
So I would like to have a /heath or /health-check endpoint that can be "open"
that answers 200 OK when the node is connected to the cluster and a 4xx-5xx
error if the node is disconnected ("Only a node connected to a cluster can
process the request", "This node is currently not connect to the cluster. Any
modifications to the data flow made here will not replicate across the
cluster").
This will simplify secure nifi deployment with load balancing, right now if a
node gets disconnected users will be still be routed to it even if that node is
really not usable.
> Provide a /health endpoint that do not require authentication for use in
> LoadBalancer
> -
>
> Key: NIFI-8100
> URL: https://issues.apache.org/jira/browse/NIFI-8100
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Ruben Laguna
>Priority: Major
>
> Usually load balancers with AWS Application Load Balancer use periodic health
> checks to determine which node it should forward requests to.
> Today we have the /status api endpoint but that is not suitable because it
> really requires authentication on a secure nifi installation and there is no
> way to provide authorization headers in the health checks performed by load
> balancers.
> So I would like to have a /heath or /health-check endpoint that can be "open"
> that answers 200 OK* when the node is connected to the cluster and a 4xx-5xx
> error if the node is disconnected *("Only a node connected to a cluster can
> process the request", "This node is currently not connect to the cluster. Any
> modifications to the data flow made here will not replicate across the
> cluster").
> This will simplify secure nifi deployment with load balancing, right now if a
> node gets disconnected users will be still be routed to it even if that node
> is really not usable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8100) Provide a /health endpoint that do not require authentication for use in LoadBalancer
[
https://issues.apache.org/jira/browse/NIFI-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ruben Laguna updated NIFI-8100:
---
Description:
Usually load balancers with AWS Application Load Balancer use periodic health
checks to determine which node it should forward requests to.
Today we have the /status api endpoint but that is not suitable because it
really requires authentication on a secure nifi installation and there is no
way to provide authorization headers in the health checks performed by load
balancers.
So I would like to have a /heath or /health-check endpoint that can be "open"
that answers 200 OK *when the node is connected to the cluster and a 4xx-5xx
error if the node is disconnected* ("Only a node connected to a cluster can
process the request", "This node is currently not connect to the cluster. Any
modifications to the data flow made here will not replicate across the
cluster").
This will simplify secure nifi deployment with load balancing, right now if a
node gets disconnected users will be still be routed to it even if that node is
really not usable.
was:
Usually load balancers with AWS Application Load Balancer use periodic health
checks to determine which node it should forward requests to.
Today we have the /status api endpoint but that is not suitable because it
really requires authentication on a secure nifi installation and there is no
way to provide authorization headers in the health checks performed by load
balancers.
So I would like to have a /heath or /health-check endpoint that can be "open"
that answers 200 OK* when the node is connected to the cluster and a 4xx-5xx
error if the node is disconnected *("Only a node connected to a cluster can
process the request", "This node is currently not connect to the cluster. Any
modifications to the data flow made here will not replicate across the
cluster").
This will simplify secure nifi deployment with load balancing, right now if a
node gets disconnected users will be still be routed to it even if that node is
really not usable.
> Provide a /health endpoint that do not require authentication for use in
> LoadBalancer
> -
>
> Key: NIFI-8100
> URL: https://issues.apache.org/jira/browse/NIFI-8100
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Ruben Laguna
>Priority: Major
>
> Usually load balancers with AWS Application Load Balancer use periodic health
> checks to determine which node it should forward requests to.
> Today we have the /status api endpoint but that is not suitable because it
> really requires authentication on a secure nifi installation and there is no
> way to provide authorization headers in the health checks performed by load
> balancers.
> So I would like to have a /heath or /health-check endpoint that can be "open"
> that answers 200 OK *when the node is connected to the cluster and a 4xx-5xx
> error if the node is disconnected* ("Only a node connected to a cluster can
> process the request", "This node is currently not connect to the cluster. Any
> modifications to the data flow made here will not replicate across the
> cluster").
> This will simplify secure nifi deployment with load balancing, right now if a
> node gets disconnected users will be still be routed to it even if that node
> is really not usable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8101) Improvement PutDatabaseRecord for refresh table schema cache
[ https://issues.apache.org/jira/browse/NIFI-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhangCheng updated NIFI-8101: - Description: * Sometimes, the target table has changed and the `PutDatabaseRecord` cached outdated table schema informatiion. Maybe we need a new property to tell the `PutDatabaseRecord` to refresh the table schema cache under certain conditions. was:Sometimes, the target table has changed and > Improvement PutDatabaseRecord for refresh table schema cache > - > > Key: NIFI-8101 > URL: https://issues.apache.org/jira/browse/NIFI-8101 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: ZhangCheng >Assignee: ZhangCheng >Priority: Major > > * Sometimes, the target table has changed and the `PutDatabaseRecord` cached > outdated table schema informatiion. Maybe we need a new property to tell > the `PutDatabaseRecord` to refresh the table schema cache under certain > conditions. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-8101) Improvement PutDatabaseRecord for refresh table schema cache
[ https://issues.apache.org/jira/browse/NIFI-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhangCheng updated NIFI-8101: - Description: Sometimes, the target table has changed and > Improvement PutDatabaseRecord for refresh table schema cache > - > > Key: NIFI-8101 > URL: https://issues.apache.org/jira/browse/NIFI-8101 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: ZhangCheng >Assignee: ZhangCheng >Priority: Major > > Sometimes, the target table has changed and -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-8101) Improvement PutDatabaseRecord for refresh table schema cache
ZhangCheng created NIFI-8101: Summary: Improvement PutDatabaseRecord for refresh table schema cache Key: NIFI-8101 URL: https://issues.apache.org/jira/browse/NIFI-8101 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: ZhangCheng Assignee: ZhangCheng -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] markobean commented on pull request #4225: NIFI-7387: ComponentLog accepts Object varargs instead of array
markobean commented on pull request #4225: URL: https://github.com/apache/nifi/pull/4225#issuecomment-747155013 Looking for a committer for this one. @markap14, any remaining issues? If not, please merge. Appreciate it! Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory opened a new pull request #4734: NIFI-8023 Added toLocalDate() and updated toDate() in DataTypeUtils
exceptionfactory opened a new pull request #4734:
URL: https://github.com/apache/nifi/pull/4734
Description of PR
NIFI-8023 Added `DataTypeUtils.toLocalDate()` method for use in
`AvroTypeUtil` to determine epoch days when logical date types enabled.
Updated `DataTypeUtils.toDate()` with new `parseDate()` method that
evaluates the format pattern of `java.text.SimpleDateFormat` to determine
whether a Time Zone field `Z` is present in the pattern. This conditional
adjustment is necessary because absence of the Time Zone Field in a
`java.text.SimpleDateFormat` pattern definition produces different results
depending on the system time zone configuration.
This approach resolves a latent issue when using the
`DataTypeUtils.toDate()` method to parse a string that does not contain any
time zone information. Changes to `DataTypeUtils.toDate()` and updates to unit
tests in referencing classes indicate the expected behavior.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #4216: NIFI-7356 Enable TLS for embedded Zookeeper when NiFi has TLS enabled
jfrazee commented on pull request #4216: URL: https://github.com/apache/nifi/pull/4216#issuecomment-747127701 @thenatog That sounds good to me. I feel like this could end up looking different with the annotation you created to inject NiFiProperties, or maybe something similar would make sense here. It's been a while since I looked at this though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-7386) AzureStorageCredentialsControllerService should also connect to storage emulator
[ https://issues.apache.org/jira/browse/NIFI-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250707#comment-17250707 ] ASF subversion and git services commented on NIFI-7386: --- Commit 942030579a055b568eef9de2849e804ad034f174 in nifi's branch refs/heads/main from sjyang18 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=9420305 ] NIFI-7386 Added Azure Azurite emulator credentials service This closes #4286 Signed-off-by: Joey Frazee > AzureStorageCredentialsControllerService should also connect to storage > emulator > > > Key: NIFI-7386 > URL: https://issues.apache.org/jira/browse/NIFI-7386 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Eric Secules >Assignee: Seokwon Yang >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > The controller service "AzureStorageCredentialsControllerService" should be > able to take an optional parameter to connect to another azure storage > provider, like the [Azurite > emulator|https://hub.docker.com/_/microsoft-azure-storage-azurite]. This will > likely mean taking additional parameters for a base URL and possibly > switching between http and https depending on Azurite's capabilities. > I am currently setting up an isolated test environment for my application and > the only piece that I cannot effectively isolate is our azure storage > connection because NiFi doesn't support connecting to anything but the > official azure storage service. > *Acceptance Criteria:* > * AzureStorageCredentialsControllerService can connect to an alternative > azure storage provider > * Individual azure storage processors can connect to an alternative azure > storage provider > * New parameters will be optional and default to existing behaviour. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] jfrazee closed pull request #4286: NIFI-7386: Azurite emulator support
jfrazee closed pull request #4286: URL: https://github.com/apache/nifi/pull/4286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-8067) Fix 1-way SSL in GRPC processors
[ https://issues.apache.org/jira/browse/NIFI-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-8067: -- Status: Patch Available (was: Open) > Fix 1-way SSL in GRPC processors > > > Key: NIFI-8067 > URL: https://issues.apache.org/jira/browse/NIFI-8067 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.12.1 >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > 1-way SSL is broken due to a change in NIFI-7407: > SslContextFactory.createSslContext() checks that the truststore must be given > when the keystore is given, but the presence of the truststore would turn on > 2-way SSL. For this reason 1-way SSL cannot be configured currently. > The previous behavior can be restored by refactoring to remove the call to > createSslContext() and removing the unnecessary references to > SSLContext.getProvider(). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] turcsanyip opened a new pull request #4733: NIFI-8067: Fix 1-way SSL in GRPC processors
turcsanyip opened a new pull request #4733: URL: https://github.com/apache/nifi/pull/4733 https://issues.apache.org/jira/browse/NIFI-8067 In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-** where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on JDK 8? - [ ] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-747075684 Unfortunately there is no appropriate sol2 version for us that supports Lua 5.4, only the latest release which would require c++17 support, so we still need to downgrade to Lua 5.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
lordgamez closed pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez edited a comment on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
lordgamez edited a comment on pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-747074012 Summary of the issue from what I gathered: - There are incompatible changes between the Lua 5.3 and 5.4 API that causes the build failure, see 8.3 of the [Lua 5.4 reference](https://www.lua.org/manual/5.4/manual.html) - Even though sol2 library bumped the valid Lua version to 5.4 in sol2 2.20.3 it was just [experimental ](https://github.com/ThePhD/sol2/issues/649)it does not guarantee compatibility. - Lua 5.4 compatibility was introduced in sol2 v3.2.0, but sol2 v3.0+ versions make use of the c++17 and c++20 language feature and thus requires GCC 7.x.x and Clang 3.9.x compilers. Because of this we cannot upgrade to that version. We need to revisit the upgrade after we reach the required compiler version. Until then I do not see any advantage of the version upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
lordgamez commented on pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-747074012 Summary of the issue from what I gathered: - There are incompatible changes between the Lua 5.3 and 5.4 API that causes the build failure see 8.3 of the [Lua 5.4 reference](https://www.lua.org/manual/5.4/manual.html) - Even though sol2 library bumped the valid Lua version to 5.4 in sol2 2.20.3 it was just [experimental ](https://github.com/ThePhD/sol2/issues/649)it does not guarantee compatibility. - Lua 5.4 compatibility was introduced in sol2 v3.2.0, but sol2 v3.0+ versions make use of the c++17 and c++20 language feature and thus requires GCC 7.x.x and Clang 3.9.x compilers. Because of this we cannot upgrade to that version. We need to revisit the upgrade after we reach the required compiler version. Until then I do not see any advantage of the version upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings
fgerlits opened a new pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964 ... and a few others which were related or nearby in the code. https://issues.apache.org/jira/browse/MINIFICPP-1443 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] dam4rus commented on a change in pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…
dam4rus commented on a change in pull request #961:
URL: https://github.com/apache/nifi-minifi-cpp/pull/961#discussion_r544609863
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -126,7 +126,11 @@ const core::Property PublishKafka::CompressCodec(
const core::Property PublishKafka::MaxFlowSegSize(
core::PropertyBuilder::createProperty("Max Flow Segment
Size")->withDescription("Maximum flow content payload segment size for the
kafka record. 0 B means unlimited.")
->isRequired(false)->withDefaultValue("0
B")->build());
-const core::Property PublishKafka::SecurityProtocol("Security Protocol",
"Protocol used to communicate with brokers", "");
+const core::Property PublishKafka::SecurityProtocol(
+core::PropertyBuilder::createProperty("Security Protocol")
+->withDescription("Protocol used to communicate with brokers")
+->withAllowableValues({SECURITY_PROTOCOL_PLAINTEXT,
SECURITY_PROTOCOL_SSL, SECURITY_PROTOCOL_SASL_PLAINTEXT,
SECURITY_PROTOCOL_SASL_SSL})
Review comment:
> When looking at `PublishKafka.cpp:686`, it seems like only
`SECURITY_PROTOCOL_SSL` is actually supported, and the default empty value is
interpreted as plaintext.
Should I leave the unused defines in? If it doesn't breaks backward
compatibility removing them would make the code a bit clearer.
> I suggest restricting the set of "allowable values" to plaintext and ssl,
and handling plaintext near PublishKafka.cpp:687. I think doing nothing is a
valid handling of plaintext.
What's the suggested coding style in this case? Having an empty `else if
(value == SECURITY_PROTOCOL_PLAINTEXT)` branch or just using `else if (value !=
SECURITY_PROTOCOL_PLAINTEXT)` to handle unexpected values?
> I would also add a default value for PLAINTEXT as we are trying to make
the behaviour consistent with NiFi:
https://nifi.apache.org/docs/nifi-docs/components/nifi-docs/components/org.apache.nifi/nifi-kafka-2-0-nar/1.9.0/org.apache.nifi.processors.kafka.pubsub.PublishKafka_2_0/
Nifi also describes it as a required value. Should I add that too?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-1443) Get rid of most "possible loss of data" warnings
Ferenc Gerlits created MINIFICPP-1443: - Summary: Get rid of most "possible loss of data" warnings Key: MINIFICPP-1443 URL: https://issues.apache.org/jira/browse/MINIFICPP-1443 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Ferenc Gerlits Assignee: Ferenc Gerlits We often convert/assign from larger to smaller types, eg. from size_t to int. This can lead to difficult-to-track-down bugs. Visual Studio gives helpful warnings about this, eg. "warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data". Try to eliminate all, or almost all, of these. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8027) Allow semicolons in SQL Pre-Query and SQL Post-Query statements
[ https://issues.apache.org/jira/browse/NIFI-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250592#comment-17250592 ] ASF subversion and git services commented on NIFI-8027: --- Commit 989287adafefd38273c85ec5e7391d131197a90b in nifi's branch refs/heads/main from Tamas Palfy [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=989287a ] NIFI-8027 In AbstractExecuteSQL make 'SQL Pre-Query' and 'SQL Post-Query' properties support escaping semicolons to allow them be part of statements. Signed-off-by: Matthew Burgess This closes #4732 > Allow semicolons in SQL Pre-Query and SQL Post-Query statements > --- > > Key: NIFI-8027 > URL: https://issues.apache.org/jira/browse/NIFI-8027 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Certain session-wide settings require complex statements that contain > semicolons. > AbstractExecuteSQL.SQL_PRE_QUERY and AbstractExecuteSQL.SQL_POST_QUERY > however uses semicolons as the delimiter for multiple statements. > We could add the option to escape semicolons which then won't be considered a > closing of a statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NIFI-8027) Allow semicolons in SQL Pre-Query and SQL Post-Query statements
[ https://issues.apache.org/jira/browse/NIFI-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess resolved NIFI-8027. Fix Version/s: 1.13.0 Resolution: Fixed > Allow semicolons in SQL Pre-Query and SQL Post-Query statements > --- > > Key: NIFI-8027 > URL: https://issues.apache.org/jira/browse/NIFI-8027 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Fix For: 1.13.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Certain session-wide settings require complex statements that contain > semicolons. > AbstractExecuteSQL.SQL_PRE_QUERY and AbstractExecuteSQL.SQL_POST_QUERY > however uses semicolons as the delimiter for multiple statements. > We could add the option to escape semicolons which then won't be considered a > closing of a statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mattyb149 closed pull request #4732: NIFI-8027 Support semicolons in SQL Pre- and Post-Query
mattyb149 closed pull request #4732: URL: https://github.com/apache/nifi/pull/4732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #4732: NIFI-8027 Support semicolons in SQL Pre- and Post-Query
mattyb149 commented on pull request #4732: URL: https://github.com/apache/nifi/pull/4732#issuecomment-746921673 +1 LGTM, tested with multiple SET commands on PostgreSQL using Pre- and Post-Query properties. Thanks for the improvement! Merging to main This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 2.20.6
lordgamez commented on pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963#issuecomment-746910434 Even though the compatibility error disappeared, the build still fails with the following: ``` 2020-12-16T19:36:38.2089590Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5150:8: error: use of undeclared identifier 'LUA_ERRGCMM' 2020-12-16T19:36:38.2157510Z gc = LUA_ERRGCMM, 2020-12-16T19:36:38.2210480Z ^ 2020-12-16T19:36:38.2292910Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5160:8: error: use of undeclared identifier 'LUA_ERRGCMM' 2020-12-16T19:36:38.2359110Z gc = LUA_ERRGCMM, 2020-12-16T19:36:38.2411820Z ^ 2020-12-16T19:36:38.2496400Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5169:8: error: use of undeclared identifier 'LUA_ERRGCMM' 2020-12-16T19:36:38.2560740Z gc = LUA_ERRGCMM, 2020-12-16T19:36:38.2617600Z ^ 2020-12-16T19:36:38.2706010Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5216:8: error: duplicate case value: 'gc' and 'file' both equal '6' 2020-12-16T19:36:38.2808040Z case call_status::file: 2020-12-16T19:36:38.2863160Z ^ 2020-12-16T19:36:38.2922070Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5212:8: note: previous case defined here 2020-12-16T19:36:38.3010260Z case call_status::gc: 2020-12-16T19:36:38.3065550Z ^ 2020-12-16T19:36:38.3125290Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5235:8: error: duplicate case value: 'gc' and 'file' both equal '6' 2020-12-16T19:36:38.3212600Z case call_status::file: 2020-12-16T19:36:38.3267340Z ^ 2020-12-16T19:36:38.3328580Z /Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/thirdparty/sol2-2.20.6/sol.hpp:5233:8: note: previous case defined here 2020-12-16T19:36:38.3414850Z case call_status::gc: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP
tpalfy commented on a change in pull request #4721:
URL: https://github.com/apache/nifi/pull/4721#discussion_r544574271
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java
##
@@ -138,4 +144,32 @@ protected boolean isListingResetNecessary(final
PropertyDescriptor property) {
protected abstract FileTransfer getFileTransfer(final ProcessContext
context);
protected abstract String getProtocolName();
+
+protected void validateAdjustedTimeWindow(ValidationContext
validationContext, Collection results) {
+if (
+
BY_ADJUSTED_TIME_WINDOW.getValue().equals(validationContext.getProperty(FILE_TRANSFER_LISTING_STRATEGY).getValue())
+&&
+!validationContext.getProperty(TIME_ADJUSTMENT).isSet()
+) {
+results.add(new ValidationResult.Builder()
+.explanation("'" + TIME_ADJUSTMENT.getDisplayName() + "'
has to be set when '"
++ FILE_TRANSFER_LISTING_STRATEGY.getDisplayName() + "'
is set to '" + BY_ADJUSTED_TIME_WINDOW.getValue() + "'")
Review comment:
Okay
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP
tpalfy commented on a change in pull request #4721:
URL: https://github.com/apache/nifi/pull/4721#discussion_r544573935
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processor.util.list.validator;
+
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+
+import java.util.Optional;
+import java.util.TimeZone;
+import java.util.regex.Pattern;
+
+import static
org.apache.nifi.processor.util.list.AbstractListProcessor.TIME_ADJUSTMENT;
+
+public class TimeAdjustmentValidator implements Validator {
+private static final Pattern SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss =
Pattern.compile("-?(\\d{2}:\\d{2}(:\\d{2})?)|-?\\d+");
+
+@Override
+public ValidationResult validate(String subject, String input,
ValidationContext context) {
+String evaluatedValue =
Optional.ofNullable(context.getProperty(TIME_ADJUSTMENT).evaluateAttributeExpressions().getValue())
+.orElse("");
+
+boolean matches = evaluatedValue.equalsIgnoreCase("gmt")
+|| !TimeZone.getTimeZone(evaluatedValue).getID().equals("GMT") //
TimeZone.getTimeZone returns GMT for an unrecognized value
+||
SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss.matcher(evaluatedValue).matches();
+
+return new ValidationResult.Builder()
+.input(evaluatedValue)
+.subject(subject)
Review comment:
Okay
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java
##
@@ -138,4 +144,32 @@ protected boolean isListingResetNecessary(final
PropertyDescriptor property) {
protected abstract FileTransfer getFileTransfer(final ProcessContext
context);
protected abstract String getProtocolName();
+
+protected void validateAdjustedTimeWindow(ValidationContext
validationContext, Collection results) {
+if (
+
BY_ADJUSTED_TIME_WINDOW.getValue().equals(validationContext.getProperty(FILE_TRANSFER_LISTING_STRATEGY).getValue())
+&&
+!validationContext.getProperty(TIME_ADJUSTMENT).isSet()
+) {
+results.add(new ValidationResult.Builder()
+.explanation("'" + TIME_ADJUSTMENT.getDisplayName() + "'
has to be set when '"
++ FILE_TRANSFER_LISTING_STRATEGY.getDisplayName() + "'
is set to '" + BY_ADJUSTED_TIME_WINDOW.getValue() + "'")
+.valid(false)
+.subject(TIME_ADJUSTMENT.getDisplayName())
+.build());
+}
+
+if (
+
!BY_ADJUSTED_TIME_WINDOW.getValue().equals(validationContext.getProperty(FILE_TRANSFER_LISTING_STRATEGY).getValue())
+&&
+validationContext.getProperty(TIME_ADJUSTMENT).isSet()
Review comment:
Removing
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP
tpalfy commented on a change in pull request #4721:
URL: https://github.com/apache/nifi/pull/4721#discussion_r544562070
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processor.util.list.validator;
+
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+
+import java.util.Optional;
+import java.util.TimeZone;
+import java.util.regex.Pattern;
+
+import static
org.apache.nifi.processor.util.list.AbstractListProcessor.TIME_ADJUSTMENT;
+
+public class TimeAdjustmentValidator implements Validator {
+private static final Pattern SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss =
Pattern.compile("-?(\\d{2}:\\d{2}(:\\d{2})?)|-?\\d+");
+
+@Override
+public ValidationResult validate(String subject, String input,
ValidationContext context) {
+String evaluatedValue =
Optional.ofNullable(context.getProperty(TIME_ADJUSTMENT).evaluateAttributeExpressions().getValue())
+.orElse("");
+
+boolean matches = evaluatedValue.equalsIgnoreCase("gmt")
+|| !TimeZone.getTimeZone(evaluatedValue).getID().equals("GMT") //
TimeZone.getTimeZone returns GMT for an unrecognized value
+||
SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss.matcher(evaluatedValue).matches();
+
+return new ValidationResult.Builder()
+.input(evaluatedValue)
+.subject(subject)
+.valid(matches)
+.explanation(matches ? null : "Value is not a recognized as either
a valid time zone or a numerical time value.")
Review comment:
Fixing
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1442) Uplift sol2 to newer version to support LUA version 5.4
[ https://issues.apache.org/jira/browse/MINIFICPP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1442: - Description: We should uplift sol2 to support newer LUA versions. (was: Current sol2 library version is 2 years old. We should uplift sol2 to support newer LUA versions.) > Uplift sol2 to newer version to support LUA version 5.4 > --- > > Key: MINIFICPP-1442 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1442 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gabor Gyimesi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > We should uplift sol2 to support newer LUA versions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MINIFICPP-1442) Uplift sol2 to newer version to support LUA version 5.4
[ https://issues.apache.org/jira/browse/MINIFICPP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1442: - Summary: Uplift sol2 to newer version to support LUA version 5.4 (was: Uplift sol2 to latest release version) > Uplift sol2 to newer version to support LUA version 5.4 > --- > > Key: MINIFICPP-1442 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1442 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gabor Gyimesi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Current sol2 library version is 2 years old. We should uplift sol2 to support > newer LUA versions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7922) Add support for GET request in ListenHTTP for health check
[ https://issues.apache.org/jira/browse/NIFI-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250551#comment-17250551 ] Ruben Laguna commented on NIFI-7922: https://issues.apache.org/jira/plugins/servlet/mobile#issue/NIFI-8100 > Add support for GET request in ListenHTTP for health check > -- > > Key: NIFI-7922 > URL: https://issues.apache.org/jira/browse/NIFI-7922 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Gyori >Assignee: Peter Gyori >Priority: Major > Fix For: 1.13.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Add support for GET request in ListenHTTP processor, so that when put behind > a load balancer, the LB can make a health check to verify that the service is > available. > The health check service should be available on > /healthcheck. > It should be available via the listening port specified in the processor's > property, but it should optionally be configured to be available on a > different port. > Accessing the health check service via a dedicated port should use 1-way SSL > at most, even if the main service uses 2-way SSL, since some load balancers > do not support client certificate handling: > - If the processor is set not to use SSL, SSL should not be used on the > health check port, either. > - If the processor is set to use one-way SSL, one-way SSL should be used on > the health check port. > - If the processor is set to use two-way SSL, one-way SSL should be used on > the health check port. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7922) Add support for GET request in ListenHTTP for health check
[ https://issues.apache.org/jira/browse/NIFI-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250549#comment-17250549 ] Ruben Laguna commented on NIFI-7922: Can this be used to determine if the Nifi UI is “healthy” ? I mean, if a node get disconnected the listenhttp processor in that node will stop? Does this removes the need for NIFi-8100? > Add support for GET request in ListenHTTP for health check > -- > > Key: NIFI-7922 > URL: https://issues.apache.org/jira/browse/NIFI-7922 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Peter Gyori >Assignee: Peter Gyori >Priority: Major > Fix For: 1.13.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Add support for GET request in ListenHTTP processor, so that when put behind > a load balancer, the LB can make a health check to verify that the service is > available. > The health check service should be available on > /healthcheck. > It should be available via the listening port specified in the processor's > property, but it should optionally be configured to be available on a > different port. > Accessing the health check service via a dedicated port should use 1-way SSL > at most, even if the main service uses 2-way SSL, since some load balancers > do not support client certificate handling: > - If the processor is set not to use SSL, SSL should not be used on the > health check port, either. > - If the processor is set to use one-way SSL, one-way SSL should be used on > the health check port. > - If the processor is set to use two-way SSL, one-way SSL should be used on > the health check port. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-3882) Unable to run NiFi behind AWS Load Balancer
[ https://issues.apache.org/jira/browse/NIFI-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250545#comment-17250545 ] Ruben Laguna commented on NIFI-3882: Maybe it would be better to comment that in NIFI-8100. But for the purpose of setting an LB for the Nifi UI we need a single endpoint that summarizes if the load balancer should route traffic to it. I guess the other information that you mention is already accesible vía the nifi api (with authentication) but not useful for the case of load balancing to the UI > Unable to run NiFi behind AWS Load Balancer > --- > > Key: NIFI-3882 > URL: https://issues.apache.org/jira/browse/NIFI-3882 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Richard St. John >Priority: Major > > Running Apache NiFi behind an AWS Elastic Load Balancer fails. > Upon closer inspection, AWS Elastic Load Balancers only support the following > headers: >X-Forwarded-For >X-Forwarded-Proto >X-Forwarded-Port > In our case, we would like our ELB to be HTTPS enabled, but our NiFi cluster > is running in a trusted environment on port 8080. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mattyb149 commented on a change in pull request #4668: NIFI-7991 Flow Configuration History displays "annotation data not fo…
mattyb149 commented on a change in pull request #4668:
URL: https://github.com/apache/nifi/pull/4668#discussion_r544549281
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/ProcessorAuditor.java
##
@@ -400,4 +444,39 @@ private PropertyDescriptor
locatePropertyDescriptor(Set prop
return specDescriptor;
}
+/**
+ * Gets Item Paths and set path and node in Map map
+ * @param nl NodeList to generate path
+ * @param path String path to ParentNode
+ * @param map Map of path to node, and node reference
+ */
+private void getItemPaths(NodeList nl, String path, Map map){
+if(nl!=null) {
+
+
+for (int i = 0; i < nl.getLength(); i++) {
+Node n;
+if (( n = nl.item(i)) != null) {
+if(n.getNodeType() == Node.ELEMENT_NODE || n.getNodeType()
== Node.TEXT_NODE) {
+if(n.hasChildNodes()){
+ if(n.getNodeType() == Node.ELEMENT_NODE) {
+getItemPaths(n.getChildNodes(), path + ":" +
n.getNodeName(), map);
+ }
+}
+if(!n.hasChildNodes()) {
+map.put(path + ":" +
n.getNodeName().trim()+":"+n.getNodeValue(), n);
+}
+
+if (n.hasAttributes()) {
+NamedNodeMap na = n.getAttributes();
+for (int j = 0; j < na.getLength(); j++) {
+map.put(path + ":" + n.getNodeName() + ":" +
na.item(j).getNodeName().trim()+":"+na.item(j).getNodeValue(), n);
Review comment:
I'm seeing something like this displayed:
`:#document:criteria:rules:conditions:expression:#text:${filename:equals("hello!")}`
Is that intended? I would think it would be more helpful (if possible) to
have something like the Rule Name then the condition or action or whatever
changed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP
turcsanyip commented on a change in pull request #4721:
URL: https://github.com/apache/nifi/pull/4721#discussion_r544543960
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processor.util.list.validator;
+
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+
+import java.util.Optional;
+import java.util.TimeZone;
+import java.util.regex.Pattern;
+
+import static
org.apache.nifi.processor.util.list.AbstractListProcessor.TIME_ADJUSTMENT;
+
+public class TimeAdjustmentValidator implements Validator {
+private static final Pattern SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss =
Pattern.compile("-?(\\d{2}:\\d{2}(:\\d{2})?)|-?\\d+");
+
+@Override
+public ValidationResult validate(String subject, String input,
ValidationContext context) {
+String evaluatedValue =
Optional.ofNullable(context.getProperty(TIME_ADJUSTMENT).evaluateAttributeExpressions().getValue())
+.orElse("");
+
+boolean matches = evaluatedValue.equalsIgnoreCase("gmt")
+|| !TimeZone.getTimeZone(evaluatedValue).getID().equals("GMT") //
TimeZone.getTimeZone returns GMT for an unrecognized value
+||
SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss.matcher(evaluatedValue).matches();
+
+return new ValidationResult.Builder()
+.input(evaluatedValue)
+.subject(subject)
+.valid(matches)
+.explanation(matches ? null : "Value is not a recognized as either
a valid time zone or a numerical time value.")
Review comment:
The explanation will be concatenated into the middle of the error
message so it should be started with lower case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP
turcsanyip commented on a change in pull request #4721:
URL: https://github.com/apache/nifi/pull/4721#discussion_r544542796
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/validator/TimeAdjustmentValidator.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processor.util.list.validator;
+
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+
+import java.util.Optional;
+import java.util.TimeZone;
+import java.util.regex.Pattern;
+
+import static
org.apache.nifi.processor.util.list.AbstractListProcessor.TIME_ADJUSTMENT;
+
+public class TimeAdjustmentValidator implements Validator {
+private static final Pattern SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss =
Pattern.compile("-?(\\d{2}:\\d{2}(:\\d{2})?)|-?\\d+");
+
+@Override
+public ValidationResult validate(String subject, String input,
ValidationContext context) {
+String evaluatedValue =
Optional.ofNullable(context.getProperty(TIME_ADJUSTMENT).evaluateAttributeExpressions().getValue())
+.orElse("");
+
+boolean matches = evaluatedValue.equalsIgnoreCase("gmt")
+|| !TimeZone.getTimeZone(evaluatedValue).getID().equals("GMT") //
TimeZone.getTimeZone returns GMT for an unrecognized value
+||
SIGNED_INTEGER_OR_SIGNED_HHmm_OR_HHmmss.matcher(evaluatedValue).matches();
+
+return new ValidationResult.Builder()
+.input(evaluatedValue)
+.subject(subject)
Review comment:
As the validator is already tied to the
`AbstractListProcessor.TIME_ADJUSTMENT` property, the display name of the
property could be used here instead of the `subject` which is the (technical)
name.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP
turcsanyip commented on a change in pull request #4721:
URL: https://github.com/apache/nifi/pull/4721#discussion_r544537496
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java
##
@@ -138,4 +144,32 @@ protected boolean isListingResetNecessary(final
PropertyDescriptor property) {
protected abstract FileTransfer getFileTransfer(final ProcessContext
context);
protected abstract String getProtocolName();
+
+protected void validateAdjustedTimeWindow(ValidationContext
validationContext, Collection results) {
+if (
+
BY_ADJUSTED_TIME_WINDOW.getValue().equals(validationContext.getProperty(FILE_TRANSFER_LISTING_STRATEGY).getValue())
+&&
+!validationContext.getProperty(TIME_ADJUSTMENT).isSet()
+) {
+results.add(new ValidationResult.Builder()
+.explanation("'" + TIME_ADJUSTMENT.getDisplayName() + "'
has to be set when '"
++ FILE_TRANSFER_LISTING_STRATEGY.getDisplayName() + "'
is set to '" + BY_ADJUSTED_TIME_WINDOW.getValue() + "'")
+.valid(false)
+.subject(TIME_ADJUSTMENT.getDisplayName())
+.build());
+}
+
+if (
+
!BY_ADJUSTED_TIME_WINDOW.getValue().equals(validationContext.getProperty(FILE_TRANSFER_LISTING_STRATEGY).getValue())
+&&
+validationContext.getProperty(TIME_ADJUSTMENT).isSet()
Review comment:
As Time Adjustment property is hidden when the Listing Strategy is other
than Adjusted Time Window, this validation might not be necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4721: NIFI-8081 Added new Listing Strategy to ListFTP and ListSFTP
turcsanyip commented on a change in pull request #4721:
URL: https://github.com/apache/nifi/pull/4721#discussion_r544536013
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFileTransfer.java
##
@@ -138,4 +144,32 @@ protected boolean isListingResetNecessary(final
PropertyDescriptor property) {
protected abstract FileTransfer getFileTransfer(final ProcessContext
context);
protected abstract String getProtocolName();
+
+protected void validateAdjustedTimeWindow(ValidationContext
validationContext, Collection results) {
+if (
+
BY_ADJUSTED_TIME_WINDOW.getValue().equals(validationContext.getProperty(FILE_TRANSFER_LISTING_STRATEGY).getValue())
+&&
+!validationContext.getProperty(TIME_ADJUSTMENT).isSet()
+) {
+results.add(new ValidationResult.Builder()
+.explanation("'" + TIME_ADJUSTMENT.getDisplayName() + "'
has to be set when '"
++ FILE_TRANSFER_LISTING_STRATEGY.getDisplayName() + "'
is set to '" + BY_ADJUSTED_TIME_WINDOW.getValue() + "'")
Review comment:
`BY_ADJUSTED_TIME_WINDOW.getDisplayName()` should be used instead of
`getValue()`
Also in line 169.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] tpalfy opened a new pull request #4732: NIFI-8027 Support semicolons in SQL Pre- and Post-Query
tpalfy opened a new pull request #4732: URL: https://github.com/apache/nifi/pull/4732 In AbstractExecuteSQL semicolons can be escaped in SQL Pre- and Post-Query ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-** where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on JDK 8? - [ ] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746767755 Yes, exactly. But before closing this PR I would like to see if the tests pass with the upgraded sol2 version and see if anyone has any objections against the upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
szaszm commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746760913 So the original idea was to downgrade Lua, but it didn't work, so you went for the upgrade, which is a better solution anyway, do I understand it right? If so, this PR can be closed without merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746756551 > I thought this PR fixes the incompatibility issue by installing 5.3 instead of 5.4 That was the original idea as sol2 2.20.0 is hardcoded to be incompatible with LUA 5.3+ as there was no newer version back when this was released. But as it seems that the Github MacOS VMs come with LUA 5.4 pre installed, it may be counter-productive to force LUA version 5.3 in our environment instead of supporting version 5.4. Let me know if you disagree, we can discuss which would be the better way to move forward with. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
szaszm commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746747703 I thought this PR fixes the incompatibility issue by installing 5.3 instead of 5.4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-6242) PutFileTransfer generating incorrect provenance events
[ https://issues.apache.org/jira/browse/NIFI-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Smith updated NIFI-6242: Status: Patch Available (was: Open) > PutFileTransfer generating incorrect provenance events > -- > > Key: NIFI-6242 > URL: https://issues.apache.org/jira/browse/NIFI-6242 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.9.2 >Reporter: Brandon Rhys DeVries >Assignee: Tim Smith >Priority: Minor > Time Spent: 1h 40m > Remaining Estimate: 0h > > PutFileTransfer transfers a (configurable size) batch of FlowFiles. However, > the provenance SEND event generated [1] uses the hostname evaluated from the > first FlowFile of the batch. If the hostname is a hardcoded string, there's > no issue... but if the hostname uses Expression Language, the generated > provenance events will be incorrect (and very confusing). > [1] > [https://github.com/apache/nifi/blob/f60585a9b6df6b3b28be1eb80a0a60deac6c0493/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutFileTransfer.java#L146-L147] > [2] > [https://github.com/apache/nifi/blob/f60585a9b6df6b3b28be1eb80a0a60deac6c0493/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutFileTransfer.java#L97] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746733014 The issue comes from the compatibility of sol2 library that we use version 2.20.0 of. This release is 2 years old, so it might be more appropriate to uplift this library to its latest release version instead to solve this issue. The suggested change can be found in PR #963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #963: MINIFICPP-1442 Uplift sol2 from version 2.20.0 to 3.2.2
lordgamez opened a new pull request #963: URL: https://github.com/apache/nifi-minifi-cpp/pull/963 Version 3.2.2 released single hpp library was downloaded from https://github.com/ThePhD/sol2/releases Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-1442) Uplift sol2 to latest release version
Gabor Gyimesi created MINIFICPP-1442: Summary: Uplift sol2 to latest release version Key: MINIFICPP-1442 URL: https://issues.apache.org/jira/browse/MINIFICPP-1442 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Gabor Gyimesi Current sol2 library version is 2 years old. We should uplift sol2 to support newer LUA versions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] NissimShiman edited a comment on pull request #4620: NIFI-6242 PutFileTransfer generation incorrect provenance event
NissimShiman edited a comment on pull request #4620: URL: https://github.com/apache/nifi/pull/4620#issuecomment-746644194 Code has been reviewed. It is well structured and unit tested. I compiled and tested on both java 8 and java 11 and issue is fixed. Issue was that transitUri in SEND ProvenanceEvent can be incorrect when PutFTP/PutSFTP's hostname property is set to an expression. It used to evaluate the first flowfile that went through for the hostname's expression and then use that value for all future flowfiles' transitUri for their SEND events. Now the transitUri always reflects the correct hostname value for the associated flowfile. Nice job @tlsmith109! LGTM +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] NissimShiman edited a comment on pull request #4620: NIFI-6242 PutFileTransfer generation incorrect provenance event
NissimShiman edited a comment on pull request #4620: URL: https://github.com/apache/nifi/pull/4620#issuecomment-746644194 Code has been reviewed. It is well structured and unit tested. I compiled and tested on both java 8 and java 11 and issue is fixed. Issue was that transitUri in SEND ProvenanceEvent can be incorrect when PutFTP/PutSFTP's hostname property is set to an expression. It used to evaluate the first flowfile that went through for the hostname's expression and then use that value for all future flowfiles' transitUri for their SEND events. Now the transitUri always reflects the correct hostname value for the associated flowfile. Nice job @tlsmith109! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #4620: NIFI-6242 PutFileTransfer generation incorrect provenance event
NissimShiman commented on pull request #4620: URL: https://github.com/apache/nifi/pull/4620#issuecomment-746644194 Code is well structured and unit tested. I compiled and tested on both java 8 and java 11 and issue is fixed. Issue was that transitUri in SEND ProvenanceEvent can be incorrect when PutFTP/PutSFTP's hostname property is set to an expression. It used to evaluate the first flowfile that went through for the hostname's expression and then use that value for all future flowfiles' transitUri for their SEND events. Now the transitUri always reflects the correct hostname value for the associated flowfile. Nice job @tlsmith109! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: It seems like it depends on what VM we get on Github, some of them have Lua pre-installed, some don't. But when it is pre-installed, it cannot unlink it as it comes from OSX not from homebrew. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: It seems like it depends on what VM we get on Github, some of them have Lua pre-installed, some don't. But when it is pre-installed, it cannot unlink it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: It seems like it depends on what VM we get on Github, some of them have Lua pre-installed, some don't. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r50153 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: It seems like it depends on what VM we get on Github, some of them has Lua pre-installed, some don't. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962:
URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544436458
##
File path: .github/workflows/ci.yml
##
@@ -9,7 +9,7 @@ jobs:
- id: checkout
uses: actions/checkout@v2
- id: install_dependencies
-run: brew install ossp-uuid boost flex openssl python lua xz libssh2
+run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl
python xz libssh2
Review comment:
I'm not sure what the difference is, but in 2 separate runs the same
command had 2 different outcomes:
```
Run brew install ossp-uuid boost flex openssl python lua@5.3 xz libssh2 &&
brew unlink lua && brew link lua@5.3 --force --overwrite
brew install ossp-uuid boost flex openssl python lua@5.3 xz libssh2 &&
brew unlink lua && brew link lua@5.3 --force --overwrite
shell: /bin/bash -e {0}
Warning: openssl@1.1 1.1.1h is already installed and up-to-date
To reinstall 1.1.1h, run `brew reinstall openssl@1.1`
Warning: python@3.9 3.9.0_2 is already installed and up-to-date
To reinstall 3.9.0_2, run `brew reinstall python@3.9`
Warning: xz 5.2.5 is already installed and up-to-date
To reinstall 5.2.5, run `brew reinstall xz`
Warning: libssh2 1.9.0_1 is already installed and up-to-date
To reinstall 1.9.0_1, run `brew reinstall libssh2`
==> Downloading
https://homebrew.bintray.com/bottles/ossp-uuid-1.6.2_2.catalina.bottle.tar.gz
==> Pouring ossp-uuid-1.6.2_2.catalina.bottle.tar.gz
/usr/local/Cellar/ossp-uuid/1.6.2_2: 18 files, 209.5KB
==> Downloading
https://homebrew.bintray.com/bottles/boost-1.74.0.catalina.bottle.tar.gz
==> Downloading from
https://d29vzk4ow07wi7.cloudfront.net/0c3609787aac666de8db539259e2f604bda631bcc4fde5f5427ea83f4692dec1?response-content-disposition=attachment%3Bfilename%3D%22boost-1.74.0.catalina.bottle.tar.gz%22=eyJTdGF0ZW1lbnQiOiBbeyJSZXNvdXJjZSI6Imh0dHAqOi8vZDI5dnprNG93MDd3aTcuY2xvdWRmcm9udC5uZXQvMGMzNjA5Nzg3YWFjNjY2ZGU4ZGI1MzkyNTllMmY2MDRiZGE2MzFiY2M0ZmRlNWY1NDI3ZWE4M2Y0NjkyZGVjMT9yZXNwb25zZS1jb250ZW50LWRpc3Bvc2l0aW9uPWF0dGFjaG1lbnQlM0JmaWxlbmFtZSUzRCUyMmJvb3N0LTEuNzQuMC5jYXRhbGluYS5ib3R0bGUudGFyLmd6JTIyIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNjA4MTM2MDg5fSwiSXBBZGRyZXNzIjp7IkFXUzpTb3VyY2VJcCI6IjAuMC4wLjAvMCJ9fX1dfQ__=AO2Et4NcT71qnzbOdzjO2mBhgHX0F~V7NsrZjA0PKHL6Lsr5aVuRPrliKObSKf51AJ8exbhTcIuuNjtyL~AgUCx7ffhOx9~sgECVTrJp9d6fnfTTLgOc0OejJnxmjhkyK0~gwNGUIyPZ5lmvQj4Q1Q2JDmoPNVZNKfKhGwOaA7KM3efSxKK1z2hQCoiFKIpfn660BhpWHUaQ5MLd3U1dPg3k6sFUkZ3IOSU7pcUOzOhLXpNu6iVmHmImFWAnujyQZNE-QfEwH8ePpeDJgMdVBc5Qai9CZiKLmJ9B5atOGK6sH1besmT~BvSAcvQs2L
obSYE13dsdvA6nsM-dA4l0vw__=APKAIFKFWOMXM2UMTSFA
==> Pouring boost-1.74.0.catalina.bottle.tar.gz
/usr/local/Cellar/boost/1.74.0: 14,695 files, 524.4MB
==> Downloading
https://homebrew.bintray.com/bottles/flex-2.6.4_1.catalina.bottle.tar.gz
==> Downloading from
https://d29vzk4ow07wi7.cloudfront.net/902e2701bb4d8130fe3177211dda84b6ebc6a520467874a52bcd7ff043b949cc?response-content-disposition=attachment%3Bfilename%3D%22flex-2.6.4_1.catalina.bottle.tar.gz%22=eyJTdGF0ZW1lbnQiOiBbeyJSZXNvdXJjZSI6Imh0dHAqOi8vZDI5dnprNG93MDd3aTcuY2xvdWRmcm9udC5uZXQvOTAyZTI3MDFiYjRkODEzMGZlMzE3NzIxMWRkYTg0YjZlYmM2YTUyMDQ2Nzg3NGE1MmJjZDdmZjA0M2I5NDljYz9yZXNwb25zZS1jb250ZW50LWRpc3Bvc2l0aW9uPWF0dGFjaG1lbnQlM0JmaWxlbmFtZSUzRCUyMmZsZXgtMi42LjRfMS5jYXRhbGluYS5ib3R0bGUudGFyLmd6JTIyIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNjA4MTM2MTIzfSwiSXBBZGRyZXNzIjp7IkFXUzpTb3VyY2VJcCI6IjAuMC4wLjAvMCJ9fX1dfQ__=Ij8SlZH8abiKyV359dg6m6yb12JfLcNuAx8lOTPZc2V6JqJ9WEctnDbPMYtjjXt4EVREBruQIdYONmKrW6p2MEhdXw0H~qLc0ZJ6NwyyzGOpE5JKj2Qv0dL7ILuc4Q4tx6Hn7zTTqeVvrEfNVen72AU9dHygtJUAx1OhDHgVLI0mCuYHAFSFh7Z3rTNxo55ZGOWoK0b5ABAl0uRdSogj2auMgIPGTvX~CNqx0JC6LDvMX-0FZgzSiStI2Nxl-u0XVw7u5Lyf2-3aoX4CJyhO2Vx-ee~jZS2KsANb4eWnSgIHmvtTWLQTLdXAG1MJMl
I8Qv4lSiSnC4HRPcFg3A37Aw__=APKAIFKFWOMXM2UMTSFA
==> Pouring flex-2.6.4_1.catalina.bottle.tar.gz
==> Caveats
flex is keg-only, which means it was not symlinked into /usr/local,
because macOS already provides this software and installing another version
in
parallel can cause all kinds of trouble.
If you need to have flex first in your PATH run:
echo 'export PATH="/usr/local/opt/flex/bin:$PATH"' >>
/Users/runner/.bash_profile
For compilers to find flex you may need to set:
export LDFLAGS="-L/usr/local/opt/flex/lib"
export CPPFLAGS="-I/usr/local/opt/flex/include"
==> Summary
/usr/local/Cellar/flex/2.6.4_1: 45 files, 1.4MB
==> Downloading
https://homebrew.bintray.com/bottles/lua-5.3.5_1.catalina.bottle.tar.gz
==> Pouring lua-5.3.5_1.catalina.bottle.tar.gz
==> Caveats
You may also want luarocks:
brew install luarocks
==> Summary
/usr/local/Cellar/lua/5.3.5_1: 28 files, 286.6KB
==> Caveats
==> flex
flex is keg-only, which means it was not symlinked into /usr/local,
because
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
szaszm commented on pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#issuecomment-746574641 Still failing :disappointed: https://github.com/apache/nifi-minifi-cpp/pull/962/checks?check_run_id=1564459700#step:5:10792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
hunyadi-dev commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544425110 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: I think that means you did not run `brew install lua@5.3` before. If that was run it should by default automatically link it unless a previous version is already present to be found. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
hunyadi-dev commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544411596 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: How about this? ```yaml run: brew install ossp-uuid boost flex openssl python lua@5.3 xz libssh2 && brew switch lua 5.3 ``` **Update:** Brew switch is deprecated in homebrew 2.6.0:  I think we need to unlink the old version and link the new version before using it. I don't have a mac to check it now, but googling shows this might be the correct syntax: ```bash brew unlink lua brew link lua@5.3 --force --overwrite ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544419612 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: It fails with: ``` Error: lua not found in the Cellar. Error: Process completed with exit code 1. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
hunyadi-dev commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544411596 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: How about ```yaml run: brew install ossp-uuid boost flex openssl python lua@5.3 xz libssh2 && brew switch lua 5.3 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #4731: NIFI-8098 - Bump jetty.version from 9.4.34.v20201102 to 9.4.35.v20201120
thenatog commented on pull request #4731: URL: https://github.com/apache/nifi/pull/4731#issuecomment-746515095 Tested upgraded Jetty in a secure cluster. Checked the other web contexts work as expected. Tested out using ListenHTTP, PostHTTP processors, and used Site-To-Site to transmit data to an input port on the same cluster. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] thenatog opened a new pull request #4731: NIFI-8098 - Bump jetty.version from 9.4.34.v20201102 to 9.4.35.v20201120
thenatog opened a new pull request #4731:
URL: https://github.com/apache/nifi/pull/4731
dependabot[bot] Updates `jetty-server` from
9.4.34.v20201102 to 9.4.35.v20201120
- [Release notes](https://github.com/eclipse/jetty.project/releases)
-
[Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.34.v20201102...jetty-9.4.35.v20201120)
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544404215 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: I managed to make it work when lua@5.3 was installed before the other packages in a single brew command, but then it failed in the next github actions run. I thought the order of install is arbitrary if I use a single brew install command so I separated them, but seems it seems not to be the case, as it is still failing. CMake still finds lua5.4 somehow which needs to be removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544404215 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: I managed to make it work when lua@5.3 was installed before the other packages in a single brew command, but then it failed in the next github actions command. I thought the order of install is arbitrary if I use a single brew install command so I separated them, but seems it seems not to be the case, as it is still failing. CMake still finds lua5.4 somehow which needs to be removed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #624: CEM-462 CEM-417 Fixed.
szaszm commented on pull request #624: URL: https://github.com/apache/nifi-minifi-cpp/pull/624#issuecomment-746496480 Closing this because of inactivity. It seems to be fixed already, but the issue it not 100% clear from the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #624: CEM-462 CEM-417 Fixed.
szaszm closed pull request #624: URL: https://github.com/apache/nifi-minifi-cpp/pull/624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #618: POC: MINIFICPP-985 - Implement listvalidators
szaszm commented on pull request #618: URL: https://github.com/apache/nifi-minifi-cpp/pull/618#issuecomment-746490514 Closing this because of inactivity. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #618: POC: MINIFICPP-985 - Implement listvalidators
szaszm closed pull request #618: URL: https://github.com/apache/nifi-minifi-cpp/pull/618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #617: Minificpp 897
szaszm closed pull request #617: URL: https://github.com/apache/nifi-minifi-cpp/pull/617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #617: Minificpp 897
szaszm commented on pull request #617: URL: https://github.com/apache/nifi-minifi-cpp/pull/617#issuecomment-746487461 Closing this because of inactivity This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #603: MINIFICPP-929 mmap
szaszm commented on pull request #603: URL: https://github.com/apache/nifi-minifi-cpp/pull/603#issuecomment-746483791 Closing this because of inactivity. I think the community doesn't have the capacity to review such huge PRs in general. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #603: MINIFICPP-929 mmap
szaszm closed pull request #603: URL: https://github.com/apache/nifi-minifi-cpp/pull/603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #598: MINIFICPP-934: Enable all features again
szaszm commented on pull request #598: URL: https://github.com/apache/nifi-minifi-cpp/pull/598#issuecomment-746481596 This has been superseded by github actions CI, where there is a configuration with all stable features enabled. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #598: MINIFICPP-934: Enable all features again
szaszm closed pull request #598: URL: https://github.com/apache/nifi-minifi-cpp/pull/598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #563: WiP: MINIFICPP-839 - Fix memleaks
szaszm commented on pull request #563: URL: https://github.com/apache/nifi-minifi-cpp/pull/563#issuecomment-746479797 Closing this because of inactivity. Some of the leaks have been fixed on main, and I'll make sure to check this as reference when similar efforts are underway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #563: WiP: MINIFICPP-839 - Fix memleaks
szaszm closed pull request #563: URL: https://github.com/apache/nifi-minifi-cpp/pull/563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…
szaszm closed pull request #515: URL: https://github.com/apache/nifi-minifi-cpp/pull/515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…
szaszm commented on pull request #515: URL: https://github.com/apache/nifi-minifi-cpp/pull/515#issuecomment-746472846 Closing this because of inactivity This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion
szaszm closed pull request #472: URL: https://github.com/apache/nifi-minifi-cpp/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion
szaszm commented on pull request #472: URL: https://github.com/apache/nifi-minifi-cpp/pull/472#issuecomment-746471822 Closing this because of inactivity This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…
hunyadi-dev commented on a change in pull request #961:
URL: https://github.com/apache/nifi-minifi-cpp/pull/961#discussion_r544387125
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -126,7 +126,11 @@ const core::Property PublishKafka::CompressCodec(
const core::Property PublishKafka::MaxFlowSegSize(
core::PropertyBuilder::createProperty("Max Flow Segment
Size")->withDescription("Maximum flow content payload segment size for the
kafka record. 0 B means unlimited.")
->isRequired(false)->withDefaultValue("0
B")->build());
-const core::Property PublishKafka::SecurityProtocol("Security Protocol",
"Protocol used to communicate with brokers", "");
+const core::Property PublishKafka::SecurityProtocol(
+core::PropertyBuilder::createProperty("Security Protocol")
+->withDescription("Protocol used to communicate with brokers")
+->withAllowableValues({SECURITY_PROTOCOL_PLAINTEXT,
SECURITY_PROTOCOL_SSL, SECURITY_PROTOCOL_SASL_PLAINTEXT,
SECURITY_PROTOCOL_SASL_SSL})
Review comment:
I would also add a default value for `PLAINTEXT` as we are trying to
make the behaviour consistent with NiFi:
https://nifi.apache.org/docs/nifi-docs/components/nifi-docs/components/org.apache.nifi/nifi-kafka-2-0-nar/1.9.0/org.apache.nifi.processors.kafka.pubsub.PublishKafka_2_0/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #959: MINIFICPP-1424 Stabilize several flaky test suites
szaszm closed pull request #959: URL: https://github.com/apache/nifi-minifi-cpp/pull/959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
fgerlits commented on a change in pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962#discussion_r544370743 ## File path: .github/workflows/ci.yml ## @@ -9,7 +9,7 @@ jobs: - id: checkout uses: actions/checkout@v2 - id: install_dependencies -run: brew install ossp-uuid boost flex openssl python lua xz libssh2 +run: brew install lua@5.3 && brew install ossp-uuid boost flex openssl python xz libssh2 Review comment: why do we need two `brew` commands? `brew install ossp-uuid boost flex openssl python lua@5.3 xz libssh2` doesn't work, or did you just want to make this easier to spot for readers? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-3882) Unable to run NiFi behind AWS Load Balancer
[ https://issues.apache.org/jira/browse/NIFI-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250369#comment-17250369 ] Otto Fowler commented on NIFI-3882: --- Maybe there would need to be multiple endpoints, with different logical meanings? Cluster Health would be one, would there be others? One that says some set of flows are running? One that says if some set of queues are full or back pressure is being applied? > Unable to run NiFi behind AWS Load Balancer > --- > > Key: NIFI-3882 > URL: https://issues.apache.org/jira/browse/NIFI-3882 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Richard St. John >Priority: Major > > Running Apache NiFi behind an AWS Elastic Load Balancer fails. > Upon closer inspection, AWS Elastic Load Balancers only support the following > headers: >X-Forwarded-For >X-Forwarded-Proto >X-Forwarded-Port > In our case, we would like our ELB to be HTTPS enabled, but our NiFi cluster > is running in a trusted environment on port 8080. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #920: MINIFICPP-1296 - All tests should use volatile state storage
szaszm closed pull request #920: URL: https://github.com/apache/nifi-minifi-cpp/pull/920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1441) Specify Lua version instead of default
[ https://issues.apache.org/jira/browse/MINIFICPP-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1441: Assignee: Gabor Gyimesi > Specify Lua version instead of default > -- > > Key: MINIFICPP-1441 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1441 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Gabor Gyimesi >Assignee: Gabor Gyimesi >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Current default Lua version 5.4 on Mac environments in Github actions is > unsupported by third party component sol2 2.20. We need to specify version > 5.3 in the environment to fix the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #962: MINIFICPP-1441 Specify Lua version in Mac CI builds
lordgamez opened a new pull request #962: URL: https://github.com/apache/nifi-minifi-cpp/pull/962 Current default Lua version 5.4 on Mac environments in Github actions is unsupported by third party component sol2 2.20. Version 5.3 needs to be installed before flex which would install Lua 5.4 as a dependency. Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-1441) Specify Lua version instead of default
Gabor Gyimesi created MINIFICPP-1441: Summary: Specify Lua version instead of default Key: MINIFICPP-1441 URL: https://issues.apache.org/jira/browse/MINIFICPP-1441 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Gabor Gyimesi Current default Lua version 5.4 on Mac environments in Github actions is unsupported by third party component sol2 2.20. We need to specify version 5.3 in the environment to fix the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #901: MINIFICPP-1288 - Refactor YamlConfiguration::parsePropertiesNodeYaml
szaszm closed pull request #901: URL: https://github.com/apache/nifi-minifi-cpp/pull/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…
szaszm commented on a change in pull request #961:
URL: https://github.com/apache/nifi-minifi-cpp/pull/961#discussion_r544326007
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -126,7 +126,11 @@ const core::Property PublishKafka::CompressCodec(
const core::Property PublishKafka::MaxFlowSegSize(
core::PropertyBuilder::createProperty("Max Flow Segment
Size")->withDescription("Maximum flow content payload segment size for the
kafka record. 0 B means unlimited.")
->isRequired(false)->withDefaultValue("0
B")->build());
-const core::Property PublishKafka::SecurityProtocol("Security Protocol",
"Protocol used to communicate with brokers", "");
+const core::Property PublishKafka::SecurityProtocol(
+core::PropertyBuilder::createProperty("Security Protocol")
+->withDescription("Protocol used to communicate with brokers")
+->withAllowableValues({SECURITY_PROTOCOL_PLAINTEXT,
SECURITY_PROTOCOL_SSL, SECURITY_PROTOCOL_SASL_PLAINTEXT,
SECURITY_PROTOCOL_SASL_SSL})
Review comment:
When looking at `PublishKafka.cpp:686`, it seems like only
`SECURITY_PROTOCOL_SSL` is actually supported, and the default empty value is
interpreted as plaintext.
I suggest restricting the set of "allowable values" to plaintext and ssl,
and handling plaintext near `PublishKafka.cpp:687`. I think doing nothing is a
valid handling of plaintext.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFIREG-434) Support BCFKS Keystore Type
[ https://issues.apache.org/jira/browse/NIFIREG-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFIREG-434: Assignee: David Handermann > Support BCFKS Keystore Type > --- > > Key: NIFIREG-434 > URL: https://issues.apache.org/jira/browse/NIFIREG-434 > Project: NiFi Registry > Issue Type: Improvement >Affects Versions: 0.8.0 >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: security > Time Spent: 10m > Remaining Estimate: 0h > > The [Bouncy Castle FIPS Key > Store|https://cryptosense.com/blog/bouncycastle-keystore-security/] (BCFKS) > format supports storage of certificates and private keys using AES-CCM and > PBKDF2 algorithms, providing greater security than the standard JKS and > PKCS12 implementations. Support for BCFKS can be implemented using Bouncy > Castle security provider libraries that are already leveraged throughout the > system. > Initial support should include the ability to specify BCFKS as the key store > and trust store type in standard properties files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #901: MINIFICPP-1288 - Refactor YamlConfiguration::parsePropertiesNodeYaml
szaszm commented on a change in pull request #901:
URL: https://github.com/apache/nifi-minifi-cpp/pull/901#discussion_r544313026
##
File path: libminifi/src/core/yaml/YamlConfiguration.cpp
##
@@ -762,106 +762,109 @@ void YamlConfiguration::parsePortYaml(YAML::Node
*portNode, core::ProcessGroup *
}
}
-void YamlConfiguration::parsePropertiesNodeYaml(YAML::Node *propertiesNode,
std::shared_ptr processor, const std::string
_name,
-const std::string
_section) {
- // Treat generically as a YAML node so we can perform inspection on entries
to ensure they are populated
- logger_->log_trace("Entered %s", component_name);
- for (YAML::const_iterator propsIter = propertiesNode->begin(); propsIter !=
propertiesNode->end(); ++propsIter) {
-std::string propertyName = propsIter->first.as();
-YAML::Node propertyValueNode = propsIter->second;
-logger_->log_trace("Encountered %s", propertyName);
-if (!propertyValueNode.IsNull() && propertyValueNode.IsDefined()) {
- if (propertyValueNode.IsSequence()) {
-for (auto iter : propertyValueNode) {
- if (iter.IsDefined()) {
-YAML::Node nodeVal = iter.as();
-YAML::Node propertiesNode = nodeVal["value"];
-// must insert the sequence in differently.
-std::string rawValueString = propertiesNode.as();
-logger_->log_debug("Found %s=%s", propertyName, rawValueString);
-if (!processor->updateProperty(propertyName, rawValueString)) {
- std::shared_ptr proc =
std::dynamic_pointer_cast(processor);
- if (proc != 0) {
-logger_->log_warn("Received property %s with value %s but is
not one of the properties for %s. "
- "Attempting to add as dynamic property.",
- propertyName, rawValueString,
proc->getName());
-if (!processor->setDynamicProperty(propertyName,
rawValueString)) {
- logger_->log_warn("Unable to set the dynamic property %s
with value %s", propertyName.c_str(), rawValueString.c_str());
-} else {
- logger_->log_warn("Dynamic property %s with value %s set",
propertyName.c_str(), rawValueString.c_str());
-}
- }
-}
- }
-}
- } else {
-core::Property myProp(propertyName, "", "");
-processor->getProperty(propertyName, myProp);
-PropertyValue defaultValue;
-defaultValue = myProp.getDefaultValue();
-auto defaultType = defaultValue.getTypeInfo();
-PropertyValue coercedValue = defaultValue;
-
-// coerce the types. upon failure we will either exit or use the
default value.
-// we do this here ( in addition to the PropertyValue class ) to get
the earliest
-// possible YAML failure.
-try {
- if (defaultType == typeid(std::string)) {
-auto typedValue = propertyValueNode.as();
-coercedValue = typedValue;
- } else if (defaultType == typeid(int64_t)) {
-auto typedValue = propertyValueNode.as();
-coercedValue = typedValue;
- } else if (defaultType == typeid(uint64_t)) {
-try {
- auto typedValue = propertyValueNode.as();
- coercedValue = typedValue;
-} catch (...) {
- auto typedValue = propertyValueNode.as();
- coercedValue = typedValue;
-}
- } else if (defaultType == typeid(int)) {
-auto typedValue = propertyValueNode.as();
-coercedValue = typedValue;
- } else if (defaultType == typeid(bool)) {
-auto typedValue = propertyValueNode.as();
-coercedValue = typedValue;
+void YamlConfiguration::parsePropertyValueSequence(const std::string&
propertyName, const YAML::Node& propertyValueNode,
std::shared_ptr processor,
+const std::string _section) {
+ for (auto iter : propertyValueNode) {
+if (iter.IsDefined()) {
+ YAML::Node nodeVal = iter.as();
+ YAML::Node propertiesNode = nodeVal["value"];
+ // must insert the sequence in differently.
+ std::string rawValueString = propertiesNode.as();
+ logger_->log_debug("Found %s=%s", propertyName, rawValueString);
+ if (!processor->updateProperty(propertyName, rawValueString)) {
+std::shared_ptr proc =
std::dynamic_pointer_cast(processor);
+if (proc != 0) {
+ logger_->log_warn("Received property %s with value %s but is not one
of the properties for %s. Attempting to add as dynamic property.",
propertyName, rawValueString, proc->getName());
+ if (!processor->setDynamicProperty(propertyName, rawValueString)) {
+logger_->log_warn("Unable to set the dynamic property %s with
value %s", propertyName.c_str(), rawValueString.c_str());
} else {
-
[GitHub] [nifi-registry] exceptionfactory opened a new pull request #314: NIFIREG-434 Added support for BCFKS Keystore Type
exceptionfactory opened a new pull request #314:
URL: https://github.com/apache/nifi-registry/pull/314
Description of PR
NIFIREG-434 Adds support for Bouncy Castle FIPS Key Store (BCFKS) in NiFi
Registry configuration properties. BCFKS provides improved security for storage
of certificates and private keys using AES-CCM and PKBDF2 algorithms for
encryption of entries. The implementation leverages the existing Bouncy Castle
Security Provider library and updates the KeystoreType enumeration along with
related unit tests for KeystoreUtils. Updates include removing the
KeyStoreUtils.getTrustStore() method, which logged a deprecation warning for
PKCS12. PKCS12 is the default keystore type starting in Java 9, so the log
message should be removed.
The Java Keytool command can be used to convert JKS or PKCS12 keystores to
BCFKS by referencing the Bouncy Castle Security Provider library and provider
class using the following command:
keytool -importkeystore -srckeystore keystore.jks -destkeystore
keystore.bcfks -deststoretype BCFKS -providerpath bcprov-jdk15on-1.66.jar
-providerclass org.bouncycastle.jce.provider.BouncyCastleProvider
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFIREG-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi-registry` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-registry-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-registry-assembly`?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] dam4rus opened a new pull request #961: MINIFICPP-1440 PublishKafka processor's "security protocol" should ha…
dam4rus opened a new pull request #961: URL: https://github.com/apache/nifi-minifi-cpp/pull/961 …ve allowable values Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-3882) Unable to run NiFi behind AWS Load Balancer
[ https://issues.apache.org/jira/browse/NIFI-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250279#comment-17250279 ] Ruben Laguna commented on NIFI-3882: I guess, that it was really terminating the HTTPS for the NiFI UI, which is possible already today. What is not possible (IMHO) is to do it reliably due to the lack of a /health endpoint that allows the load balancer to check if the node is ready to accept UI requests. I've reported this in https://issues.apache.org/jira/browse/NIFI-8100. The gist is that for AWS Load Balancer we need an endpoint that does NOT require authentication and that gives a 4xx-5xx http status code if the node is disconnected (not part of the cluster). > Unable to run NiFi behind AWS Load Balancer > --- > > Key: NIFI-3882 > URL: https://issues.apache.org/jira/browse/NIFI-3882 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Richard St. John >Priority: Major > > Running Apache NiFi behind an AWS Elastic Load Balancer fails. > Upon closer inspection, AWS Elastic Load Balancers only support the following > headers: >X-Forwarded-For >X-Forwarded-Proto >X-Forwarded-Port > In our case, we would like our ELB to be HTTPS enabled, but our NiFi cluster > is running in a trusted environment on port 8080. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #959: MINIFICPP-1424 Stabilize several flaky test suites
lordgamez commented on a change in pull request #959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r544237854
##
File path: libminifi/test/persistence-tests/PersistenceTests.cpp
##
@@ -326,11 +335,15 @@ TEST_CASE("Persisted flowFiles are updated on
modification", "[TestP1]") {
ff_repository->start();
// wait for FlowFileRepository to start and notify the owners of
// the resurrected FlowFiles
-std::this_thread::sleep_for(std::chrono::milliseconds{100});
-
+std::this_thread::sleep_for(std::chrono::milliseconds(100));
Review comment:
It seems unfortunately wait is still needed in RepoTests and one of them
cannot be checked by any log entries either, so one sleep is necessary (updated
in
[986ff8d](https://github.com/apache/nifi-minifi-cpp/pull/959/commits/986ff8db637d6551ff5e0d68f02656b6039a28af)).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-8099) HTTP Headers is case-insentitive and overwrite attributes values
[ https://issues.apache.org/jira/browse/NIFI-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17250266#comment-17250266 ] Pierre Villard commented on NIFI-8099: -- Not sure what would the correct approach be in this case. Suggestion: * if the processor has an incoming relationship, check if the flow file has two attributes with the same name (when case insensitive), generate a bulletin and route the flow file to failure * if the processor has no incoming relationship, make the processor invalid if configured with dynamic properties with multiple values for the same attribute (when case insensitive) > HTTP Headers is case-insentitive and overwrite attributes values > > > Key: NIFI-8099 > URL: https://issues.apache.org/jira/browse/NIFI-8099 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.12.1 >Reporter: Jens M Kofoed >Priority: Major > > I've created 2 flows at 2 different NIFI instances for testing HTTP transfer > between NIFI. > RFC-2616 says that headers is case-insentitive, but if I create 3 attributes > with values as this: > MyAttribute : "MyData", myattribute : "mydata" & MYATTRIBUTE : "MYDATA" all 3 > fields is coming through as they are, but all 3 value are set to "mydata" > I'm using InvokeHTTP to trasfer data to the other instance. > IncludeDataHeaders = True and Attributes to send is set to .* and I'm using > ListenHTTP to recive data > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-8092) Fix ITPutS3Object test failure due to Outposts storage class
[ https://issues.apache.org/jira/browse/NIFI-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-8092: - Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Fix ITPutS3Object test failure due to Outposts storage class > > > Key: NIFI-8092 > URL: https://issues.apache.org/jira/browse/NIFI-8092 > Project: Apache NiFi > Issue Type: Test > Components: Extensions >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Fix For: 1.13.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > "Outposts" storage class cannot be tested on AWS cloud infrastructure. It > should be skipped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
