[GitHub] [nifi] greyp9 opened a new pull request #5613: NIFI-9330 - Kafka 3.0 support

[GitBox]

greyp9 opened a new pull request #5613:
URL: https://github.com/apache/nifi/pull/5613


    Description of PR
   
   Add new NiFi NARs `nifi-kafka-3-0-processors` and `nifi-kafka-3-0-nar`.  
These are copies of the kafka-2-6 NARs as of git commit 
`b578f183cb593eae8a845d82f7fc28615e043ae9`, with minor changes to account for 
Kafka 3.0 method API updates.
   
   To manage the size of the nifi-assembly binary distributable, we may 
consider removing certain versions of nifi-kafka.  At present, the following 
kafka nars are included:
   - nifi-kafka-1-0-nar
   - nifi-kafka-2-0-nar
   - nifi-kafka-2-6-nar
   - nifi-kafka-3-0-nar (NEW)
   
   All nifi-kafka versions will continue to be built; this would just affect 
the content of the nifi-assembly binary.
   
   The `nifi-kafka-3-0-processors` references to Scala remain at version 2.13, 
which is unchanged from `nifi-kafka-2-6-processors`.
   
   Additional information about Kafka 3.0 may be found here:
   - https://kafka.apache.org/downloads
   
   Tested a single node NiFi instance and a three node NiFi cluster against a 
local Kafka 3.0.0 instance (single node) using topics with three partitions.  
GenerateFlowFile was at the head of the data flow, with two PublishKafka_3_0 / 
ConsumeKafka_3_0 pairs, and terminating with a PutFile.
   
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [x] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [x] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [x] Have you verified that the full build is successful on JDK 8?
   - [x] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] YolandaMDavis commented on a change in pull request #5518: NIFI-9333 add Geohash functions to Expression Language

[GitBox]

YolandaMDavis commented on a change in pull request #5518:
URL: https://github.com/apache/nifi/pull/5518#discussion_r771763988



##
File path: 
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GeohashDecodeBaseEvaluator.java
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.commons.lang3.EnumUtils;
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import 
org.apache.nifi.attribute.expression.language.evaluation.NumberEvaluator;
+import 
org.apache.nifi.attribute.expression.language.evaluation.NumberQueryResult;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import 
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+import ch.hsr.geohash.GeoHash;
+import ch.hsr.geohash.WGS84Point;
+
+public abstract class GeohashDecodeBaseEvaluator extends NumberEvaluator {
+
+public enum GeohashFormat {
+BASE32, BINARY, LONG
+}
+
+public enum GeoCoord {
+LATITUDE, LONGITUDE
+}
+
+private final Evaluator subject;
+private final Evaluator format;
+
+public GeohashDecodeBaseEvaluator(final Evaluator subject, final 
Evaluator format) {
+this.subject = subject;
+this.format = format;
+}
+
+protected QueryResult geohashDecodeEvaluate(final 
EvaluationContext evaluationContext, final GeoCoord geoCoord) {
+//Optional argument. If not specified, defaults to BASE_32_STRING.
+final GeohashFormat geohashFormatValue;
+if (format != null) {
+if(!EnumUtils.isValidEnum(GeohashFormat.class, 
format.evaluate(evaluationContext).getValue())) {
+throw new AttributeExpressionLanguageException("Format values 
must be 'BASE32', 'BINARY' or 'LONG'");
+}
+geohashFormatValue = 
GeohashFormat.valueOf(format.evaluate(evaluationContext).getValue());
+} else {
+geohashFormatValue = GeohashFormat.BASE32;
+
+}
+
+final Long geohashLongValue = geohashFormatValue == GeohashFormat.LONG 
? Long.valueOf(subject.evaluate(evaluationContext).getValue()) : null;
+final String geohashStringValue = (geohashFormatValue == 
GeohashFormat.BASE32
+|| geohashFormatValue == GeohashFormat.BINARY) ? 
subject.evaluate(evaluationContext).getValue() : null;
+
+if (geohashLongValue == null && geohashStringValue == null) {
+return new NumberQueryResult(null);
+}
+
+try {
+WGS84Point boundingBoxCenter;
+switch (geohashFormatValue) {
+case LONG:
+String binaryString = 
Long.toBinaryString(geohashLongValue);
+boundingBoxCenter = 
GeoHash.fromBinaryString(binaryString).getBoundingBoxCenter();
+break;
+case BINARY:
+boundingBoxCenter = 
GeoHash.fromBinaryString(geohashStringValue).getBoundingBoxCenter();
+break;
+default:
+boundingBoxCenter = 
GeoHash.fromGeohashString(geohashStringValue).getBoundingBoxCenter();

Review comment:
   In testing with invalid data (e.g. "cat") this will throw a null pointer 
exception. We should do a null check before calling the getBoundingBoxCenter 
methods.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] bbende commented on a change in pull request #5612: NIFI-9452 Generate a RuntimeManifest for NiFi at build time

[GitBox]

bbende commented on a change in pull request #5612:
URL: https://github.com/apache/nifi/pull/5612#discussion_r771750038



##
File path: 
c2/c2-protocol/c2-protocol-component-api/src/main/java/org/apache/nifi/c2/protocol/component/api/ProcessorDefinition.java
##
@@ -85,4 +102,130 @@ public boolean getSupportsDynamicRelationships() {
 public void setSupportsDynamicRelationships(boolean 
supportsDynamicRelationships) {
 this.supportsDynamicRelationships = supportsDynamicRelationships;
 }
+
+@ApiModelProperty("Whether or not this processor should be triggered 
serially")
+public boolean getTriggerSerially() {
+return triggerSerially;
+}
+
+public void setTriggerSerially(boolean triggerSerially) {
+this.triggerSerially = triggerSerially;
+}
+
+@ApiModelProperty("Whether or not this processor should be triggered when 
incoming queues are empty")
+public boolean getTriggerWhenEmpty() {
+return triggerWhenEmpty;
+}
+
+public void setTriggerWhenEmpty(boolean triggerWhenEmpty) {
+this.triggerWhenEmpty = triggerWhenEmpty;
+}
+
+@ApiModelProperty("Whether or not this processor should be triggered when 
any destination queue has room")
+public boolean getTriggerWhenAnyDestinationAvailable() {
+return triggerWhenAnyDestinationAvailable;
+}
+
+public void setTriggerWhenAnyDestinationAvailable(boolean 
triggerWhenAnyDestinationAvailable) {
+this.triggerWhenAnyDestinationAvailable = 
triggerWhenAnyDestinationAvailable;
+}
+
+@ApiModelProperty("Whether or not this processor supports batching")
+public boolean getSupportsBatching() {
+return supportsBatching;
+}
+
+public void setSupportsBatching(boolean supportsBatching) {
+this.supportsBatching = supportsBatching;
+}
+
+@ApiModelProperty("Whether or not this processor supports event driven 
scheduling")
+public boolean getSupportsEventDriven() {
+return supportsEventDriven;
+}
+
+public void setSupportsEventDriven(boolean supportsEventDriven) {
+this.supportsEventDriven = supportsEventDriven;
+}
+
+@ApiModelProperty("Whether or not this processor should be scheduled only 
on the primary node in a cluster")
+public boolean getPrimaryNodeOnly() {
+return primaryNodeOnly;
+}
+
+public void setPrimaryNodeOnly(boolean primaryNodeOnly) {
+this.primaryNodeOnly = primaryNodeOnly;
+}
+
+@ApiModelProperty("Whether or not this processor is considered side-effect 
free")

Review comment:
   Sure I can elaborate on the docs for all the new fields.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] bbende commented on a change in pull request #5612: NIFI-9452 Generate a RuntimeManifest for NiFi at build time

[GitBox]

bbende commented on a change in pull request #5612:
URL: https://github.com/apache/nifi/pull/5612#discussion_r771749943



##
File path: nifi-manifest/nifi-runtime-manifest/pom.xml
##
@@ -0,0 +1,155 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.apache.nifi
+nifi-manifest
+1.16.0-SNAPSHOT
+
+nifi-runtime-manifest
+jar
+
+
+
${project.build.directory}
+
${project.build.directory}/classes/build.properties
+
${project.build.directory}/classes/nifi-runtime-manifest.json
+apache-nifi
+
+
+
+

[GitHub] [nifi] bbende commented on a change in pull request #5612: NIFI-9452 Generate a RuntimeManifest for NiFi at build time

[GitBox]

bbende commented on a change in pull request #5612:
URL: https://github.com/apache/nifi/pull/5612#discussion_r771749541



##
File path: c2/c2-protocol/c2-protocol-component-api/pom.xml
##
@@ -15,9 +15,9 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express 
or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
  -->
-https://maven.apache.org/POM/4.0.0;
- xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="https://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+http://maven.apache.org/POM/4.0.0;

Review comment:
   My IntelliJ couldn't resolve this one as https and others looked liked 
http so I switched, but if we think that's incorrect then I can switch it back.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] mattyb149 commented on a change in pull request #5612: NIFI-9452 Generate a RuntimeManifest for NiFi at build time

[GitBox]

mattyb149 commented on a change in pull request #5612:
URL: https://github.com/apache/nifi/pull/5612#discussion_r771740656



##
File path: c2/c2-protocol/c2-protocol-component-api/pom.xml
##
@@ -15,9 +15,9 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express 
or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
  -->
-https://maven.apache.org/POM/4.0.0;
- xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="https://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+http://maven.apache.org/POM/4.0.0;

Review comment:
   These look like an IDE did that and IIRC we were supposed to have them 
use HTTPS?

##
File path: nifi-manifest/nifi-runtime-manifest/pom.xml
##
@@ -0,0 +1,155 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.apache.nifi
+nifi-manifest
+1.16.0-SNAPSHOT
+
+nifi-runtime-manifest
+jar
+
+
+
${project.build.directory}
+
${project.build.directory}/classes/build.properties
+
${project.build.directory}/classes/nifi-runtime-manifest.json
+apache-nifi
+
+
+
+

[GitHub] [nifi] mtien-apache commented on pull request #5611: NIFI-8821 Registry - Sorting the grid-list no longer expands the listed buckets

[GitBox]

mtien-apache commented on pull request #5611:
URL: https://github.com/apache/nifi/pull/5611#issuecomment-997072201


   Reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-9502) Separate extension manifest model from nifi-registry

[Bryan Bende (Jira)]

Bryan Bende created NIFI-9502:
-

 Summary: Separate extension manifest model from nifi-registry
 Key: NIFI-9502
 URL: https://issues.apache.org/jira/browse/NIFI-9502
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Bryan Bende
Assignee: Bryan Bende


In NIFI-9452, there is a new top-level module for nifi-manifest which contains 
sub-modules that produce a C2 RuntimeManifest. We should extract the extension 
manifest model class from nifi-registry-data-model and move them to a module 
under nifi-manifest so they can be shared more easily across nifi and 
nifi-registry. Same thing for the ExtensionManifestParser currently in 
nifi-registry-bundle-utils.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-9439) Create an Elasticsearch REST processor to send the entire JSON content of a FlowFile to Elasticsearch

[Chris Sampson (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Sampson updated NIFI-9439:

Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Create an Elasticsearch REST processor to send the entire JSON content of a 
> FlowFile to Elasticsearch
> -
>
> Key: NIFI-9439
> URL: https://issues.apache.org/jira/browse/NIFI-9439
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Major
> Fix For: 1.16.0
>
> Attachments: NIFI-9439.json
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> The Elasticsearch REST Processor bundle should contain the equivalent of the 
> existing {{PutElasticsearchHttp}} procressor, which sends the entire JSON 
> contents of a FlowFile to Elasticsearch as part ofa {{_bulk}} operation.
> Adding the equivalent capability to the ES REST bundle means it can then 
> replace all the functionality previously implemented in older Elasticsearch 
> processor bundles.
> The advantage of the ES REST bundle is its use of the official Elasticsearch 
> REST API client libraries and the ability to switch that out for other 
> implementations in the future (e.g. AWS OpenSearch client libraries).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (NIFI-9501) Add REST end-point to retrieve RuntimeManifest

[Bryan Bende (Jira)]

Bryan Bende created NIFI-9501:
-

 Summary: Add REST end-point to retrieve RuntimeManifest
 Key: NIFI-9501
 URL: https://issues.apache.org/jira/browse/NIFI-9501
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Bryan Bende
Assignee: Bryan Bende


In NIFI-9452, the build will produce an artifact containing a C2 
RuntimeManifest for the overall NiFi build.

We should also support retrieving this manifest from a running NiFi instance, 
and should ensure that any NARs that are hot-loaded will also be included (i.e. 
don't create a static manifest during start up).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-9452) Produce a c2 component manifest for NiFi at build time

[Bryan Bende (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-9452:
--
Status: Patch Available  (was: Open)

> Produce a c2 component manifest for NiFi at build time
> --
>
> Key: NIFI-9452
> URL: https://issues.apache.org/jira/browse/NIFI-9452
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Once NIFI-9430 is completed, we will have an initial c2-protocol-api module 
> that defines an agent manifest, which contains a component manifest.
> We also have all of the extension-manifest.xml definitions that are in each 
> NAR, and are now bundled up as part of the assembly.
> We should take all of the extension-manifest.xml definitions and use them as 
> input to produce a single c2 runtime manifest for the nifi build.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] bbende opened a new pull request #5612: NIFI-9452 Generate a RuntimeManifest for NiFi at build time

[GitBox]

bbende opened a new pull request #5612:
URL: https://github.com/apache/nifi/pull/5612


   - Write additional fields to extnesion-manifest.xml for processors
   - Update C2 model classes to support new fields for processors, properties, 
and scheduling
   - Create converter between NiFi model and C2 model
   - Create generator and execute during the build
   
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   _Enables X functionality; fixes bug NIFI-._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-9500) Add set-single-user-credentials command to Windows script

[David Handermann (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461656#comment-17461656
 ] 

David Handermann commented on NIFI-9500:


The following command can be used to call the Java class directly as a 
workaround:
{noformat}
java -cp 'lib/bootstrap/*' -Dnifi.properties.file.path=conf/nifi.properties 
org.apache.nifi.authentication.single.user.command.SetSingleUserCredentials 
username passwordpassword
{noformat}

> Add set-single-user-credentials command to Windows script
> -
>
> Key: NIFI-9500
> URL: https://issues.apache.org/jira/browse/NIFI-9500
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: David Handermann
>Priority: Minor
>
> The shell script that provides the {{set-single-user-credentials}} command 
> works on Linux and macOS, but Windows deployments use a separate batch 
> script.  The Windows script should be updated the support the command.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (NIFI-9500) Add set-single-user-credentials command to Windows script

[David Handermann (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann reassigned NIFI-9500:
--

Assignee: David Handermann

> Add set-single-user-credentials command to Windows script
> -
>
> Key: NIFI-9500
> URL: https://issues.apache.org/jira/browse/NIFI-9500
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> The shell script that provides the {{set-single-user-credentials}} command 
> works on Linux and macOS, but Windows deployments use a separate batch 
> script.  The Windows script should be updated the support the command.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (NIFI-9500) Add set-single-user-credentials command to Windows script

[David Handermann (Jira)]

David Handermann created NIFI-9500:
--

 Summary: Add set-single-user-credentials command to Windows script
 Key: NIFI-9500
 URL: https://issues.apache.org/jira/browse/NIFI-9500
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: David Handermann


The shell script that provides the {{set-single-user-credentials}} command 
works on Linux and macOS, but Windows deployments use a separate batch script.  
The Windows script should be updated the support the command.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (MINIFICPP-1703) ExecuteScript Lua documentation, tests and fixes

[Martin Zink (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Zink updated MINIFICPP-1703:
---
Summary: ExecuteScript Lua documentation, tests and fixes  (was: 
ExecuteScript Lua documentation tests and fixes)

> ExecuteScript Lua documentation, tests and fixes
> 
>
> Key: MINIFICPP-1703
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1703
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Martin Zink
>Assignee: Martin Zink
>Priority: Minor
>
> The TestExecuteScriptProcessorWithLuaScript integration test is not included 
> in the CI, it has couple build/test errors, these should be fixed and enabled 
> on some CI.
> It seems lua script errors dont cause exceptions (like they do in Nifi or in 
> python). This should fixed aswell.
> We should also add some examples/documentations how to use it.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (MINIFICPP-1703) ExecuteScript Lua documentation tests and fixes

[Martin Zink (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Zink updated MINIFICPP-1703:
---
Description: 
The TestExecuteScriptProcessorWithLuaScript integration test is not included in 
the CI, it has couple build/test errors, these should be fixed and enabled on 
some CI.

It seems lua script errors dont cause exceptions (like they do in Nifi or in 
python). This should fixed aswell.

We should also add some examples/documentations how to use it.

  was:
The TestExecuteScriptProcessorWithLuaScript integration test is not included 
anywhere so no tests are not tests to verify the LUA_SCRIPTING extension in the 
libminifi/test/script-tests/CMakeLists.txt

It has couple build/test errors, these should be fixed and enabled on some CI. 


> ExecuteScript Lua documentation tests and fixes
> ---
>
> Key: MINIFICPP-1703
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1703
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Martin Zink
>Assignee: Martin Zink
>Priority: Minor
>
> The TestExecuteScriptProcessorWithLuaScript integration test is not included 
> in the CI, it has couple build/test errors, these should be fixed and enabled 
> on some CI.
> It seems lua script errors dont cause exceptions (like they do in Nifi or in 
> python). This should fixed aswell.
> We should also add some examples/documentations how to use it.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (MINIFICPP-1703) ExecuteScript Lua documentation tests and fixes

[Martin Zink (Jira)]

 [ 
https://issues.apache.org/jira/browse/MINIFICPP-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Zink updated MINIFICPP-1703:
---
Summary: ExecuteScript Lua documentation tests and fixes  (was: Enable and 
fix TestExecuteScriptProcessorWithLuaScript)

> ExecuteScript Lua documentation tests and fixes
> ---
>
> Key: MINIFICPP-1703
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1703
> Project: Apache NiFi MiNiFi C++
>  Issue Type: Improvement
>Reporter: Martin Zink
>Assignee: Martin Zink
>Priority: Minor
>
> The TestExecuteScriptProcessorWithLuaScript integration test is not included 
> anywhere so no tests are not tests to verify the LUA_SCRIPTING extension in 
> the libminifi/test/script-tests/CMakeLists.txt
> It has couple build/test errors, these should be fixed and enabled on some 
> CI. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] turcsanyip commented on a change in pull request #5413: NIFI-8676 Added 'Tracking Entities' listing strategy to 'ListS3' and 'ListGCSBucket'

[GitBox]

turcsanyip commented on a change in pull request #5413:
URL: https://github.com/apache/nifi/pull/5413#discussion_r771628390



##
File path: 
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/ListGCSBucket.java
##
@@ -461,6 +592,84 @@ public void finishListing(final int listCount, final long 
maxTimestamp, final Se
 }
 }
 
+protected class ListedBlobTracker extends 
ListedEntityTracker {
+public ListedBlobTracker() {
+super(getIdentifier(), getLogger(), 
RecordBlobWriter.RECORD_SCHEMA);
+}
+
+@Override
+protected void createRecordsForEntities(ProcessContext context, 
ProcessSession session, List updatedEntities) throws IOException, 
SchemaNotFoundException {
+publishListing(context, session, updatedEntities);
+}
+
+@Override
+protected void createFlowFilesForEntities(ProcessContext context, 
ProcessSession session, List updatedEntities, 
Function> createAttributes) {
+publishListing(context, session, updatedEntities);
+}
+
+private void publishListing(ProcessContext context, ProcessSession 
session, List updatedEntities) {
+final BlobWriter writer;
+final RecordSetWriterFactory writerFactory = 
context.getProperty(RECORD_WRITER).asControllerService(RecordSetWriterFactory.class);
+if (writerFactory == null) {
+writer = new AttributeBlobWriter(session);
+} else {
+writer = new RecordBlobWriter(session, writerFactory, 
getLogger());
+}
+
+try {
+writer.beginListing();
+
+int listCount = 0;
+int pageNr = -1;
+for (ListableBlob listableBlob : updatedEntities) {
+Blob blob = listableBlob.getRawEntity();
+int currentPageNr = listableBlob.getPageNr();
+
+writer.addToListing(blob);
+
+listCount++;
+
+if (pageNr != -1 && pageNr != currentPageNr && 
writer.isCheckpoint()) {
+commit(session, listCount);
+listCount = 0;
+}
+
+pageNr = currentPageNr;
+}
+
+writer.finishListing();

Review comment:
   It seems ListGCSBucket does not store the listed items but lists all the 
files again and again.
   Maybe `alreadyListedEntities.put(updatedEntity.getIdentifier(), 
listedEntity);` is missing here (see the same method in ListS3).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-9498) Ability to report what components a flow is actually using

[Otto Fowler (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461597#comment-17461597
 ] 

Otto Fowler commented on NIFI-9498:
---

Thanks Mark!

> Ability to report what components a flow is actually using
> --
>
> Key: NIFI-9498
> URL: https://issues.apache.org/jira/browse/NIFI-9498
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Otto Fowler
>Priority: Major
>
> Nifi may have 100s of NARS and their components loaded, but for any flow the 
> actual working set of NARS and components is a subset.
> We often recommend that people remove NARS that aren't used from the nifi 
> working set for various reasons, but there is no concrete way to identify 
> what NARs you can remove.
> NIFI should provide some set of features around allowing visibility into what 
> the working set of NARS and components are for a given flow.
> There are different levels of feature around this idea to be explored:
> * a cli command that produces a report document from a live instance or from 
> flow definition file
> * a ui component that visualizes the graph and can export a report
> * Actions from these things, to remove or restrict what is loaded in a 
> cluster ( imagine a cluster whitelist for NARS that is share in the cluster )
> * ???
> * profit!!!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Assigned] (NIFI-9001) Integrate Parameter Providers into Parameter Contexts - UI changes

[Margot Tien (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Margot Tien reassigned NIFI-9001:
-

Assignee: Margot Tien

> Integrate Parameter Providers into Parameter Contexts - UI changes
> --
>
> Key: NIFI-9001
> URL: https://issues.apache.org/jira/browse/NIFI-9001
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Joe Gresock
>Assignee: Margot Tien
>Priority: Major
>
> This covers the UI changes for 
> https://cwiki.apache.org/confluence/display/NIFI/Parameter+Providers%3A+Fetching+Parameters+from+External+Sources



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (NIFI-9461) Unable to save description when editing a Parameter

[Peter Turcsanyi (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi resolved NIFI-9461.
---
Fix Version/s: 1.16.0
   Resolution: Fixed

> Unable to save description when editing a Parameter
> ---
>
> Key: NIFI-9461
> URL: https://issues.apache.org/jira/browse/NIFI-9461
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Margot Tien
>Assignee: Joe Gresock
>Priority: Minor
> Fix For: 1.16.0
>
> Attachments: parameter-update-request-screenshot.png
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> When editing a parameter and only its description is changed, after saving 
> and opening the Parameter Context again, the new description is not saved. In 
> the screenshot you can see the frontend sends the description in the update 
> request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (NIFI-9461) Unable to save description when editing a Parameter

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461566#comment-17461566
 ] 

ASF subversion and git services commented on NIFI-9461:
---

Commit 66f36eaf5ab5798d60cba59b0a7b1a758671f3c7 in nifi's branch 
refs/heads/main from Joe Gresock
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=66f36ea ]

NIFI-9461: Correcting equality comparison in Parameter update test

This closes #5609.

Signed-off-by: Peter Turcsanyi 


> Unable to save description when editing a Parameter
> ---
>
> Key: NIFI-9461
> URL: https://issues.apache.org/jira/browse/NIFI-9461
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Margot Tien
>Assignee: Joe Gresock
>Priority: Minor
> Attachments: parameter-update-request-screenshot.png
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When editing a parameter and only its description is changed, after saving 
> and opening the Parameter Context again, the new description is not saved. In 
> the screenshot you can see the frontend sends the description in the update 
> request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] asfgit closed pull request #5609: NIFI-9461: Correcting equality comparison in Parameter update test

[GitBox]

asfgit closed pull request #5609:
URL: https://github.com/apache/nifi/pull/5609


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1208: MINIFICPP-1678 Create PutUDP processor

[GitBox]

szaszm commented on a change in pull request #1208:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1208#discussion_r771550804



##
File path: extensions/standard-processors/tests/unit/PutUDPTests.cpp
##
@@ -0,0 +1,171 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "range/v3/view/transform.hpp"
+#include "range/v3/range/conversion.hpp"
+#include "TestBase.h"
+#include "PutUDP.h"
+#include "utils/net/DNS.h"
+#include "utils/net/Socket.h"
+#include "utils/OptionalUtils.h"
+
+namespace org::apache::nifi::minifi::processors {
+
+namespace {
+class SingleInputTestController : public TestController {

Review comment:
   In the end I spent a few hours on `RouteTextController` and saw that 
performing this would require a rewrite of the tests, which I don't want to do.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-8821) UI - Sorting the grid-list expands the listed buckets

[Adam Kocsis (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Kocsis updated NIFI-8821:
--
Status: Patch Available  (was: Open)

> UI - Sorting the grid-list expands the listed buckets
> -
>
> Key: NIFI-8821
> URL: https://issues.apache.org/jira/browse/NIFI-8821
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: NiFi Registry
>Reporter: Rob Fellows
>Assignee: Adam Kocsis
>Priority: Major
> Attachments: sort expands list.mov
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When choosing a sort option from the dropdown, the resulting sorted items in 
> the list are expanded. View the attached screen recording



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] koccs opened a new pull request #5611: NIFI-8821 Registry - Sorting the grid-list no longer expands the listed buckets

[GitBox]

koccs opened a new pull request #5611:
URL: https://github.com/apache/nifi/pull/5611


   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
    Description of PR
   
   Fixes an issue in NiFi Registry: When choosing a sort option from the 
dropdown, the resulting sorted items in the list were expanded.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [x] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-9497) Upgrade Bouncy Castle to 1.70

[Pierre Villard (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Villard updated NIFI-9497:
-
Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Upgrade Bouncy Castle to 1.70
> -
>
> Key: NIFI-9497
> URL: https://issues.apache.org/jira/browse/NIFI-9497
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions, MiNiFi, NiFi Registry, NiFi 
> Stateless
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.16.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> [Bouncy Castle 1.70|https://www.bouncycastle.org/releasenotes.html#r1rv70] 
> includes a number of bug fixes and improvements, including updates to OpenPGP 
> handling. All references to version 1.69 should be upgraded to 1.70.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (NIFI-9497) Upgrade Bouncy Castle to 1.70

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461545#comment-17461545
 ] 

ASF subversion and git services commented on NIFI-9497:
---

Commit be9f2540562b614650bbf80a576f7e13f845f5c3 in nifi's branch 
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=be9f254 ]

NIFI-9497 Upgraded Bouncy Castle from 1.69 to 1.70

Signed-off-by: Pierre Villard 

This closes #5610.


> Upgrade Bouncy Castle to 1.70
> -
>
> Key: NIFI-9497
> URL: https://issues.apache.org/jira/browse/NIFI-9497
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions, MiNiFi, NiFi Registry, NiFi 
> Stateless
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> [Bouncy Castle 1.70|https://www.bouncycastle.org/releasenotes.html#r1rv70] 
> includes a number of bug fixes and improvements, including updates to OpenPGP 
> handling. All references to version 1.69 should be upgraded to 1.70.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] pvillard31 commented on pull request #5610: NIFI-9497 Upgrade Bouncy Castle from 1.69 to 1.70

[GitBox]

pvillard31 commented on pull request #5610:
URL: https://github.com/apache/nifi/pull/5610#issuecomment-996857487


   Merged, thanks @exceptionfactory 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #5610: NIFI-9497 Upgrade Bouncy Castle from 1.69 to 1.70

[GitBox]

asfgit closed pull request #5610:
URL: https://github.com/apache/nifi/pull/5610


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] YolandaMDavis commented on a change in pull request #5518: NIFI-9333 add Geohash functions to Expression Language

[GitBox]

YolandaMDavis commented on a change in pull request #5518:
URL: https://github.com/apache/nifi/pull/5518#discussion_r771515093



##
File path: 
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GeohashStringEncodeEvaluator.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.commons.lang3.EnumUtils;
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import 
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+import 
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import 
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+import ch.hsr.geohash.GeoHash;
+
+
+public class GeohashStringEncodeEvaluator extends StringEvaluator {
+
+public enum GeohashStringFormat {
+BASE32, BINARY
+}
+
+private final Evaluator latitude;
+private final Evaluator longitude;
+private final Evaluator level;
+private final Evaluator format;
+
+public GeohashStringEncodeEvaluator(final Evaluator latitude, 
final Evaluator longitude, final Evaluator level, final 
Evaluator format) {
+this.latitude = latitude;
+this.longitude = longitude;
+this.level = level;
+this.format = format;
+}
+
+@Override
+public QueryResult evaluate(final EvaluationContext 
evaluationContext) {
+final Number latitudeValue = 
latitude.evaluate(evaluationContext).getValue();
+if (latitudeValue == null) {
+return new StringQueryResult(null);
+}
+if (latitudeValue.doubleValue() < -90 || latitudeValue.doubleValue() > 
90) {
+throw new AttributeExpressionLanguageException("Latitude values 
must be between -90 and 90.");
+}
+
+final Number longitudeValue = 
longitude.evaluate(evaluationContext).getValue();
+if (longitudeValue == null) {
+return new StringQueryResult(null);
+}
+if (longitudeValue.doubleValue() < -180 || 
longitudeValue.doubleValue() > 180) {
+throw new AttributeExpressionLanguageException("Longitude values 
must be between -180 and 180.");
+}
+
+final Long levelValue = level.evaluate(evaluationContext).getValue();
+if (levelValue == null || levelValue < 1 || levelValue > 12) {
+throw new AttributeExpressionLanguageException("Level values must 
be between 1 and 12");
+}

Review comment:
   ```suggestion
   final Number latitudeValue = 
latitude.evaluate(evaluationContext).getValue();
   
   if (latitudeValue == null || latitudeValue.doubleValue() < -90 || 
latitudeValue.doubleValue() > 90) {
   throw new AttributeExpressionLanguageException("Latitude values 
must be between -90 and 90.");
   }
   
   final Number longitudeValue = 
longitude.evaluate(evaluationContext).getValue();
   
   if (longitudeValue == null || longitudeValue.doubleValue() < -180 || 
longitudeValue.doubleValue() > 180) {
   throw new AttributeExpressionLanguageException("Longitude values 
must be between -180 and 180.");
   }
   ```
   
   Per my previous comment this is what I tried to resolve the issue of invalid 
data




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-9498) Ability to report what components a flow is actually using

[Mark Payne (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461533#comment-17461533
 ] 

Mark Payne commented on NIFI-9498:
--

[~otto] though not a NiFi feature per se - if helpful, you can easily determine 
this from command-line given

{{zgrep "" conf/flow.xml.gz | cut -d">" -f2 | cut -d"<" -f1 | sort | 
uniq}}

 

> Ability to report what components a flow is actually using
> --
>
> Key: NIFI-9498
> URL: https://issues.apache.org/jira/browse/NIFI-9498
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Otto Fowler
>Priority: Major
>
> Nifi may have 100s of NARS and their components loaded, but for any flow the 
> actual working set of NARS and components is a subset.
> We often recommend that people remove NARS that aren't used from the nifi 
> working set for various reasons, but there is no concrete way to identify 
> what NARs you can remove.
> NIFI should provide some set of features around allowing visibility into what 
> the working set of NARS and components are for a given flow.
> There are different levels of feature around this idea to be explored:
> * a cli command that produces a report document from a live instance or from 
> flow definition file
> * a ui component that visualizes the graph and can export a report
> * Actions from these things, to remove or restrict what is loaded in a 
> cluster ( imagine a cluster whitelist for NARS that is share in the cluster )
> * ???
> * profit!!!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] YolandaMDavis commented on a change in pull request #5518: NIFI-9333 add Geohash functions to Expression Language

[GitBox]

YolandaMDavis commented on a change in pull request #5518:
URL: https://github.com/apache/nifi/pull/5518#discussion_r771510043



##
File path: 
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/GeohashLongEncodeEvaluator.java
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.EvaluationContext;
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import 
org.apache.nifi.attribute.expression.language.evaluation.WholeNumberEvaluator;
+import 
org.apache.nifi.attribute.expression.language.evaluation.WholeNumberQueryResult;
+import 
org.apache.nifi.attribute.expression.language.exception.AttributeExpressionLanguageException;
+
+import ch.hsr.geohash.GeoHash;
+
+public class GeohashLongEncodeEvaluator extends WholeNumberEvaluator {
+
+private final Evaluator latitude;
+private final Evaluator longitude;
+private final Evaluator level;
+
+public GeohashLongEncodeEvaluator(final Evaluator latitude, final 
Evaluator longitude, final Evaluator level) {
+this.latitude = latitude;
+this.longitude = longitude;
+this.level = level;
+}
+@Override
+public QueryResult evaluate(final EvaluationContext 
evaluationContext) {
+final Number latitudeValue = 
latitude.evaluate(evaluationContext).getValue();
+if (latitudeValue == null) {

Review comment:
   After testing this behavior I still recommend that we throw an exception 
if latitude and longitude are also null.  In the tested scenario  with the 
below data:
   ```
   {"latitude": 27.2046,"longitude": "cat"}
   ```
   I would expect the processor to report an error however it does not. In 
current form the evaluator looks to determine whether the provided string is 
actually a string form of a number, however if it's not a number it returns 
null. I think this should be an invalid case and users should be alerted.  
   
   I also think that in the case where one or the other or even both values 
were truly provided as null it should also treat it as an exception. Users 
leveraging this function could provide a check in a previous flow step if need 
to divert data that may fail. I would assume that if someone calls this 
function their intent is for valid lat/lons to be available.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-9499) FAILED TO start nifi 1.15.1 with existing Keystore

[mayki (Jira)]

mayki created NIFI-9499:
---

 Summary: FAILED TO start nifi 1.15.1 with existing Keystore
 Key: NIFI-9499
 URL: https://issues.apache.org/jira/browse/NIFI-9499
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 1.15.1
Reporter: mayki


+Hello,+

I have installed 1.15.1, update existing flow.xml.gz with encrypt-config.sh to 
setup
 * nifi.sensitive.props.key=xx
 * nifi.sensitive.props.algorithm=NIFI_ARGON2_AES_GCM_256

NIFI started and failed after 60 seconds

There are no messages on nifi-bootstrap-app.log

Here only the error on nifi-app.log:

 
{code:java}
2021-12-17 15:40:14,715 INFO [main] org.apache.nifi.web.server.JettyServer 
https://xxx:9091/nifi
2021-12-17 15:40:14,716 INFO [main] org.apache.nifi.BootstrapListener 
Successfully initiated communication with Bootstrap
2021-12-17 15:40:14,716 INFO [main] org.apache.nifi.NiFi Started Application 
Controller in 13.043 seconds (13043620626 ns)
2021-12-17 15:40:17,344 INFO [Timer-Driven Process Thread-4] 
o.a.n.c.s.TimerDrivenSchedulingAgent 
SiteToSiteBulletinReportingTask[id=c3518aae-016f-1000-377c-cd9ac73fbbc2] 
started.
2021-12-17 15:40:42,815 INFO [Timer-Driven Process Thread-9] 
o.a.n.p.store.WriteAheadStorePartition Successfully rolled over Event Writer 
for Provenance Event Store 
Partition[directory=/data/nifi/provenance_repository] due to MAX_TIME_REACHED. 
Event File was 14.47 KB and contained 1 events.
2021-12-17 15:41:09,040 INFO [Cleanup Archive for repo0] 
o.a.n.c.repository.FileSystemRepository Successfully deleted 0 files (0 bytes) 
from archive
2021-12-17 15:41:19,014 INFO [Thread-1] org.apache.nifi.NiFi Application Server 
shutdown started
2021-12-17 15:41:19,021 INFO [Thread-1] 
o.eclipse.jetty.server.AbstractConnector Stopped ServerConnector@7ee3d262{SSL, 
(ssl, http/1.1)}{:9091}
2021-12-17 15:41:19,021 INFO [Thread-1] org.eclipse.jetty.server.session node0 
Stopped scavenging
 {code}
 

A lot nifi.properties leaves by default except 

 
{code:java}
# For security, NiFi will present the UI on 127.0.0.1 and only be accessible 
through this loopback interface.
# Be aware that changing these properties may affect how your instance can be 
accessed without any restriction.
nifi.web.war.directory=./lib
nifi.web.http.host=
nifi.web.http.port=
nifi.web.http.network.interface.default=
nifi.web.https.host=xx
nifi.web.https.port=9091
nifi.web.https.network.interface.default=
nifi.web.jetty.working.directory=./work/jetty
nifi.web.jetty.threads=200
nifi.web.max.header.size=16 KB
nifi.web.proxy.context.path=
nifi.web.proxy.host=
nifi.web.max.content.size=
nifi.web.max.requests.per.second=3
nifi.web.max.access.token.requests.per.second=25
nifi.web.request.timeout=60 secs
nifi.web.request.ip.whitelist=
nifi.web.should.send.server.version=true


# security properties #
nifi.sensitive.props.key=xxx
nifi.sensitive.props.key.protected=
nifi.sensitive.props.algorithm=NIFI_ARGON2_AES_GCM_256
nifi.sensitive.props.additional.keys=
nifi.security.autoreload.enabled=true
nifi.security.autoreload.interval=10s
nifi.security.keystore=./conf/keystore.jks
nifi.security.keystoreType=jks
nifi.security.keystorePasswd=x
nifi.security.keyPasswd=xx
nifi.security.truststore=./conf/truststore.jks
nifi.security.truststoreType=jks
nifi.security.truststorePasswd=
nifi.security.user.authorizer=managed-authorizer
nifi.security.allow.anonymous.authentication=false
nifi.security.user.login.identity.provider=
nifi.security.user.jws.key.rotation.period=PT1H
nifi.security.ocsp.responder.url=
nifi.security.ocsp.responder.certificate= {code}
And here the status of systemctl
{code:java}
â nifi.service - Apache NiFi
   Loaded: loaded (/etc/systemd/system/nifi.service; enabled; vendor preset: 
disabled)
   Active: failed (Result: timeout) since Fri 2021-12-17 15:41:21 CET; 2min 17s 
ago
  Process: 3049107 ExecStop=/appl/nifi/nifi-current/bin/nifi.sh stop 
(code=exited, status=0/SUCCESS)
  Process: 104916 ExecStart=/appl/nifi/nifi-current/bin/nifi.sh start 
(code=exited, status=0/SUCCESS)
  Process: 104914 ExecStartPre=/usr/bin/chown -R nifi /var/run/nifi 
(code=exited, status=0/SUCCESS)
  Process: 104911 ExecStartPre=/usr/bin/mkdir -p /var/run/nifi (code=exited, 
status=0/SUCCESS)
 Main PID: 2962458Dec 17 15:39:48 s3632tos systemd[1]: Starting Apache NiFi...
Dec 17 15:39:49 s3632tos nifi.sh[104916]: Java home: /appl/pkg/jdk1.8.0_211
Dec 17 15:39:49 s3632tos nifi.sh[104916]: NiFi home: /appl/nifi/nifi-1.15.1
Dec 17 15:39:49 s3632tos nifi.sh[104916]: Bootstrap Config File: 
/appl/nifi/nifi-1.15.1/conf/bootstrap.conf
Dec 17 15:39:52 s3632tos systemd[1]: Can't open PID file /var/run/nifi/nifi.pid 
(yet?) after start: No such file or directory
Dec 17 15:41:19 s3632tos systemd[1]: nifi.service start operation timed out. 
Terminating.
Dec 17 15:41:21 s3632tos systemd[1]: 

[jira] [Resolved] (NIFI-5684) Add a Warning / Indicator in the UI if a property value begins or ends with white space

[Mark Payne (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne resolved NIFI-5684.
--
Fix Version/s: 1.16.0
   Resolution: Duplicate

> Add a Warning / Indicator in the UI if a property value begins or ends with 
> white space
> ---
>
> Key: NIFI-5684
> URL: https://issues.apache.org/jira/browse/NIFI-5684
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Mark Payne
>Priority: Major
> Fix For: 1.16.0
>
>
> It is not uncommon to see a user enter a property value into the UI where the 
> property value begins or ends with whitespace (both trailing spaces and 
> trailing newlines are fairly common to see), especially when they copy & 
> paste the value in. NiFi does not trim whitespace because there are also very 
> valid use cases for having the white space there (for example, if the 
> property value is used as a prefix for some string, or as a delimiter).
> However, when this happens, users often end up with errors that say something 
> like "User my-user-name  does not exist" because the property value is set to 
> "my-user-name" and the error message leads the user astray, leading to 
> a lot of confusion.
> Therefore, I propose adding an indicator to the UI, so that when a user 
> configures a property value that begins with or ends with white space, the UI 
> warns to this fact so that the user is able to detect and fix this easily, 
> avoiding the confusion described above.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-9497) Upgrade Bouncy Castle to 1.70

[David Handermann (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-9497:
---
Status: Patch Available  (was: Open)

> Upgrade Bouncy Castle to 1.70
> -
>
> Key: NIFI-9497
> URL: https://issues.apache.org/jira/browse/NIFI-9497
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions, MiNiFi, NiFi Registry, NiFi 
> Stateless
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>
> [Bouncy Castle 1.70|https://www.bouncycastle.org/releasenotes.html#r1rv70] 
> includes a number of bug fixes and improvements, including updates to OpenPGP 
> handling. All references to version 1.69 should be upgraded to 1.70.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] exceptionfactory opened a new pull request #5610: NIFI-9497 Upgrade Bouncy Castle from 1.69 to 1.70

[GitBox]

exceptionfactory opened a new pull request #5610:
URL: https://github.com/apache/nifi/pull/5610


    Description of PR
   
   NIFI-9497 Upgrades Bouncy Castle from 1.69 to 1.70 for all NiFi components. 
[Version 1.70](https://www.bouncycastle.org/releasenotes.html#r1rv70) includes 
a variety of bug fixes and several improvements related to OpenPGP processing.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [X] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [X] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (NIFI-8821) UI - Sorting the grid-list expands the listed buckets

[Adam Kocsis (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Kocsis reassigned NIFI-8821:
-

Assignee: Adam Kocsis

> UI - Sorting the grid-list expands the listed buckets
> -
>
> Key: NIFI-8821
> URL: https://issues.apache.org/jira/browse/NIFI-8821
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: NiFi Registry
>Reporter: Rob Fellows
>Assignee: Adam Kocsis
>Priority: Major
> Attachments: sort expands list.mov
>
>
> When choosing a sort option from the dropdown, the resulting sorted items in 
> the list are expanded. View the attached screen recording



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (NIFI-9498) Ability to report what components a flow is actually using

[Otto Fowler (Jira)]

Otto Fowler created NIFI-9498:
-

 Summary: Ability to report what components a flow is actually using
 Key: NIFI-9498
 URL: https://issues.apache.org/jira/browse/NIFI-9498
 Project: Apache NiFi
  Issue Type: New Feature
Reporter: Otto Fowler


Nifi may have 100s of NARS and their components loaded, but for any flow the 
actual working set of NARS and components is a subset.

We often recommend that people remove NARS that aren't used from the nifi 
working set for various reasons, but there is no concrete way to identify what 
NARs you can remove.

NIFI should provide some set of features around allowing visibility into what 
the working set of NARS and components are for a given flow.

There are different levels of feature around this idea to be explored:
* a cli command that produces a report document from a live instance or from 
flow definition file
* a ui component that visualizes the graph and can export a report
* Actions from these things, to remove or restrict what is loaded in a cluster 
( imagine a cluster whitelist for NARS that is share in the cluster )
* ???
* profit!!!




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (NIFI-9491) Exclude Apache Commons Logging

[Matt Burgess (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-9491:
---
Fix Version/s: 1.16.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Exclude Apache Commons Logging
> --
>
> Key: NIFI-9491
> URL: https://issues.apache.org/jira/browse/NIFI-9491
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions, MiNiFi, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.16.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Multiple framework and extension modules include the Apache Commons Logging 
> library with different versions. The current runtime loading strategy avoids 
> using these libraries due to the presence of {{jcl-over-slf4j}} in the 
> primary library directory. Excluding references to {{commons-logging}} will 
> reduce the size of binary artifacts and avoid potential confusion related to 
> runtime behavior.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (NIFI-9491) Exclude Apache Commons Logging

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/NIFI-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461469#comment-17461469
 ] 

ASF subversion and git services commented on NIFI-9491:
---

Commit 7c6bdcb035094db521b3007e1ccd298052cbfddd in nifi's branch 
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7c6bdcb ]

NIFI-9491 Excluded commons-logging and added jcl-over-slf4j references

Signed-off-by: Matthew Burgess 

This closes #5608


> Exclude Apache Commons Logging
> --
>
> Key: NIFI-9491
> URL: https://issues.apache.org/jira/browse/NIFI-9491
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions, MiNiFi, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Multiple framework and extension modules include the Apache Commons Logging 
> library with different versions. The current runtime loading strategy avoids 
> using these libraries due to the presence of {{jcl-over-slf4j}} in the 
> primary library directory. Excluding references to {{commons-logging}} will 
> reduce the size of binary artifacts and avoid potential confusion related to 
> runtime behavior.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (NIFI-9497) Upgrade Bouncy Castle to 1.70

[David Handermann (Jira)]

David Handermann created NIFI-9497:
--

 Summary: Upgrade Bouncy Castle to 1.70
 Key: NIFI-9497
 URL: https://issues.apache.org/jira/browse/NIFI-9497
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework, Extensions, MiNiFi, NiFi Registry, NiFi 
Stateless
Reporter: David Handermann
Assignee: David Handermann


[Bouncy Castle 1.70|https://www.bouncycastle.org/releasenotes.html#r1rv70] 
includes a number of bug fixes and improvements, including updates to OpenPGP 
handling. All references to version 1.69 should be upgraded to 1.70.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] mattyb149 closed pull request #5608: NIFI-9491 Exclude commons-logging

[GitBox]

mattyb149 closed pull request #5608:
URL: https://github.com/apache/nifi/pull/5608


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #5608: NIFI-9491 Exclude commons-logging

[GitBox]

mattyb149 commented on pull request #5608:
URL: https://github.com/apache/nifi/pull/5608#issuecomment-996756845


   +1 LGTM, tried on a live NiFi instance with logging, verified all is well. 
Thanks for the improvement! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-9491) Exclude Apache Commons Logging

[Matt Burgess (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-9491:
---
Status: Patch Available  (was: Open)

> Exclude Apache Commons Logging
> --
>
> Key: NIFI-9491
> URL: https://issues.apache.org/jira/browse/NIFI-9491
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions, MiNiFi, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Multiple framework and extension modules include the Apache Commons Logging 
> library with different versions. The current runtime loading strategy avoids 
> using these libraries due to the presence of {{jcl-over-slf4j}} in the 
> primary library directory. Excluding references to {{commons-logging}} will 
> reduce the size of binary artifacts and avoid potential confusion related to 
> runtime behavior.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] exceptionfactory commented on pull request #5571: NIFI-9435 Add filtering parameters to Flow Metrics

[GitBox]

exceptionfactory commented on pull request #5571:
URL: https://github.com/apache/nifi/pull/5571#issuecomment-996751849


   Thanks for following up on this @timeabarna, I will look at making the 
updates to this PR soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-9496) StandardParameterContext.parameters map may contain inconsistent key and value

[Peter Turcsanyi (Jira)]

 [ 
https://issues.apache.org/jira/browse/NIFI-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Turcsanyi updated NIFI-9496:
--
Component/s: Core Framework

> StandardParameterContext.parameters map may contain inconsistent key and value
> --
>
> Key: NIFI-9496
> URL: https://issues.apache.org/jira/browse/NIFI-9496
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Peter Turcsanyi
>Priority: Major
>
> {{StandardParameterContext.parameters}} map stores {{ParameterDescriptor}} 
> (key) to {{Parameter}} (value). The {{Parameter}} also has a reference to its 
> {{{}ParameterDescriptor{}}}.
> When the {{Parameter}} is updated (e.g. its description is changed), the 
> {{Parameter}} will reference the new {{ParameterDescriptor}} but the map key 
> will still be the old one (because {{ParameterDescriptor.equals()}} is based 
> on the {{name}} field only).
> This is an inconsistent data structure that may lead to bugs.
> Using simple String key with {{ParameterDescriptor.name}} could be a solution.
> To replicate the issue:
>  - debug {{TestStandardParameterContext.testUpdateDescription()}} and stop at 
> this line:
> [https://github.com/apache/nifi/blob/7d8f99a1f41bb1806706c5db857f109c5d7b4e7f/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/java/org/apache/nifi/parameter/TestStandardParameterContext.java#L128]
>  - check the key/value in {{context.parameters}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (NIFI-9496) StandardParameterContext.parameters map may contain inconsistent key and value

[Peter Turcsanyi (Jira)]

Peter Turcsanyi created NIFI-9496:
-

 Summary: StandardParameterContext.parameters map may contain 
inconsistent key and value
 Key: NIFI-9496
 URL: https://issues.apache.org/jira/browse/NIFI-9496
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Peter Turcsanyi


{{StandardParameterContext.parameters}} map stores {{ParameterDescriptor}} 
(key) to {{Parameter}} (value). The {{Parameter}} also has a reference to its 
{{{}ParameterDescriptor{}}}.
When the {{Parameter}} is updated (e.g. its description is changed), the 
{{Parameter}} will reference the new {{ParameterDescriptor}} but the map key 
will still be the old one (because {{ParameterDescriptor.equals()}} is based on 
the {{name}} field only).
This is an inconsistent data structure that may lead to bugs.
Using simple String key with {{ParameterDescriptor.name}} could be a solution.

To replicate the issue:
 - debug {{TestStandardParameterContext.testUpdateDescription()}} and stop at 
this line:
[https://github.com/apache/nifi/blob/7d8f99a1f41bb1806706c5db857f109c5d7b4e7f/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/java/org/apache/nifi/parameter/TestStandardParameterContext.java#L128]
 - check the key/value in {{context.parameters}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [nifi] gresockj opened a new pull request #5609: NIFI-9461: Correcting equality comparison in Parameter update test

[GitBox]

gresockj opened a new pull request #5609:
URL: https://github.com/apache/nifi/pull/5609


   Correcting a bug in the NIFI-9461 fix.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
in the commit message?
   
   - [ ] Does your PR title start with **NIFI-** where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional 
commits in response to PR reviewer feedback should be made on this branch and 
pushed to allow change tracking. Do not `squash` or use `--force` when pushing 
to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn 
-Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main 
`LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main 
`NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to 
.name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for 
build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org