[GitHub] [nifi] lizhizhou commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB
lizhizhou commented on code in PR #6416: URL: https://github.com/apache/nifi/pull/6416#discussion_r1048073076 ## nifi-nar-bundles/nifi-iotdb-bundle/pom.xml: ## @@ -0,0 +1,48 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + +nifi-nar-bundles +org.apache.nifi +1.19.0-SNAPSHOT + +4.0.0 + +org.apache.nifi +nifi-iotdb-bundle + + +nifi-iotdb-processors +nifi-iotdb-nar + +pom + +0.13.0 Review Comment: Upgrage sdk version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] lizhizhou commented on a diff in pull request #6416: NIFI-10234 implement PutIoTDB
lizhizhou commented on code in PR #6416:
URL: https://github.com/apache/nifi/pull/6416#discussion_r1048072863
##
nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/test/java/org/apache/nifi/processors/AbstractIoTDBUT.java:
##
@@ -0,0 +1,282 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.nifi.processors.model.IoTDBSchema;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSEncoding;
+import org.apache.iotdb.tsfile.write.record.Tablet;
+import org.apache.iotdb.tsfile.write.schema.MeasurementSchema;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processors.model.ValidationResult;
+
+import org.junit.Before;
+import org.junit.Test;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertEquals;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class AbstractIoTDBUT {
+private static TestAbstractIoTDBProcessor processor;
+
+@Before
+public void init() {
+processor = new TestAbstractIoTDBProcessor();
+}
+
+@Test
+public void testValidateSchemaAttribute() {
+// normal schema
+String schemaAttribute =
+"{\n"
++ "\t\"timeName\": \"Time\",\n"
++ "\t\"fields\": [{\n"
++ "\t\t\"tsName\": \"s1\",\n"
++ "\t\t\"dataType\": \"INT32\",\n"
++ "\t\t\"encoding\": \"RLE\"\n"
++ "\t}, {\n"
++ "\t\t\"tsName\": \"s2\",\n"
++ "\t\t\"dataType\": \"DOUBLE\",\n"
++ "\t\t\"encoding\": \"PLAIN\"\n"
++ "\t}]\n"
++ "}";
+
+ValidationResult result =
processor.validateSchemaAttribute(schemaAttribute);
+ assertTrue(result.getKey());
+ assertEquals(null, result.getValue());
+
+// schema with wrong field
+schemaAttribute =
+"{\n"
++ "\t\"time\": \"Time\",\n"
++ "\t\"fields\": [{\n"
++ "\t\t\"tsName\": \"s1\",\n"
++ "\t\t\"dataType\": \"INT32\",\n"
++ "\t\t\"encoding\": \"RLE\"\n"
++ "\t}, {\n"
++ "\t\t\"tsName\": \"s2\",\n"
++ "\t\t\"dataType\": \"DOUBLE\",\n"
++ "\t\t\"encoding\": \"PLAIN\"\n"
++ "\t}]\n"
++ "}";
+result = processor.validateSchemaAttribute(schemaAttribute);
+String exceptedMsg = "The JSON of schema must contain `timeName` and
`fields`";
+
+ assertEquals(false, result.getKey());
+ assertEquals(exceptedMsg, result.getValue());
+
+// schema without tsName
+schemaAttribute =
+"{\n"
++ "\t\"timeName\": \"Time\",\n"
++ "\t\"fields\": [{\n"
++ "\t\t\"dataType\": \"INT32\",\n"
++ "\t\t\"encoding\": \"RLE\"\n"
++ "\t}, {\n"
++ "\t\t\"tsName\": \"s2\",\n"
++ "\t\t\"dataType\": \"DOUBLE\",\n"
++ "\t\t\"encoding\": \"PLAIN\"\n"
++ "\t}]\n"
++ "}";
+result = processor.validateSchemaAttribute(schemaAttribute);
+exceptedMsg = "`tsName` or `dataType` has not been set";
+
+assertEquals(false, result.getKey());
+assertEquals(exceptedMsg, result.getValue());
+
+// schema without data type
+schemaAttribute =
+"{\n"
++ "\t\"timeName\": \"Time\",\n"
++ "\
[jira] [Created] (NIFI-10980) Component property Allowable Values should only be sorted for Controller Service types
Paul Grey created NIFI-10980: Summary: Component property Allowable Values should only be sorted for Controller Service types Key: NIFI-10980 URL: https://issues.apache.org/jira/browse/NIFI-10980 Project: Apache NiFi Issue Type: Bug Reporter: Paul Grey Assignee: Paul Grey The change set for NIFI-10916 adjusted ordering of Controller Service allowable values, but incorrectly applied the same ordering logic to allowable values not associated with Controller Services. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] emiliosetiadarma opened a new pull request, #6780: NIFI-10971: improved edge case handling while fetching objects using …
emiliosetiadarma opened a new pull request, #6780: URL: https://github.com/apache/nifi/pull/6780 …Azure Key Vault Client and added unit tests # Summary [NIFI-10971](https://issues.apache.org/jira/browse/NIFI-10971) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 8 - [x] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10979) Refactor nifi-framework-bundle to use JUnit 5 Part 3
[ https://issues.apache.org/jira/browse/NIFI-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-10979: Priority: Minor (was: Major) > Refactor nifi-framework-bundle to use JUnit 5 Part 3 > > > Key: NIFI-10979 > URL: https://issues.apache.org/jira/browse/NIFI-10979 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > > Will make changes in the following directories: > # > nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components > # > nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils > # > nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils > # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils > # > nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-repository-models > # > nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-shell-authorizer > # > nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site > # > nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-standard-prioritizers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-10979) Refactor nifi-framework-bundle to use JUnit 5 Part 3
Daniel Stieglitz created NIFI-10979: --- Summary: Refactor nifi-framework-bundle to use JUnit 5 Part 3 Key: NIFI-10979 URL: https://issues.apache.org/jira/browse/NIFI-10979 Project: Apache NiFi Issue Type: Sub-task Reporter: Daniel Stieglitz Assignee: Daniel Stieglitz Will make changes in the following directories: # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-utils # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-repository-models # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-shell-authorizer # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site # nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-standard-prioritizers -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10975) Add Kubernetes Leader Election Manager and State Provider
[ https://issues.apache.org/jira/browse/NIFI-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10975: Status: Patch Available (was: Open) > Add Kubernetes Leader Election Manager and State Provider > - > > Key: NIFI-10975 > URL: https://issues.apache.org/jira/browse/NIFI-10975 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core Framework >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The initial implementation should include both a Kubernetes Leader Election > Manager and State Provider to provide basic cluster capabilities without any > dependencies on ZooKeeper. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6779: NIFI-10975 Add Kubernetes Leader Election and State Provider
exceptionfactory opened a new pull request, #6779: URL: https://github.com/apache/nifi/pull/6779 # Summary [NIFI-10975](https://issues.apache.org/jira/browse/NIFI-10975) Adds an initial implementation of Kubernetes cluster leader election and state management, supporting deployments without the need for ZooKeeper. ## State Management Implementation The state management implementation uses Kubernetes [ConfigMaps](https://kubernetes.io/docs/concepts/configuration/configmap/) to persist cluster information for stateful components. The `KubernetesConfigMapStateProvider` uses the standard `data` property, but encodes property names using Base64 URL encoding without padding to meet [ConfigMap object](https://kubernetes.io/docs/concepts/configuration/configmap/) property naming requirements. The new State Provider can be configured in `state-management.xml` using the following element definition, which is included in a commented section of the configuration: ``` kubernetes-provider org.apache.nifi.kubernetes.state.provider.KubernetesConfigMapStateProvider ``` ## Leader Election Implementation The leader election implementation uses Kubernetes [Leases](https://kubernetes.io/docs/concepts/architecture/leases/) for distributed tracking of the current cluster leader. Kubernetes Lease names must adhere to [RFC 1123 subdomain naming requirements](https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-subdomain-names), requiring a mapping from NiFi application names to Lease names. The new Leader Election implementation can be configured using a new property in `nifi.properties` as follows: ``` nifi.cluster.leader.election.implementation=KubernetesLeaderElectionManager ``` ## Framework Changes The leader election implementation required promoting the `LeaderElectionManager` interface to `nifi-framework-api` to support NAR bundle extension loading. The `LeaderElectionManager` had two methods without runtime references, which were removed. Refactoring also involved creating a new `nifi-framework-leader-election-shared` module for abstracting tracking operations. The `nifi.properties` configuration includes a new property with a default value of `CuratorLeaderElectionManager`, which provides current cluster coordination using ZooKeeper. ## Kubernetes Client The implementation includes a new `nifi-kubernetes-client` library which provides utility components for Kubernetes Client access and service namespace determination. The `nifi-kubernetes-client` library depends on the [Fabric8 Kubernetes Client](https://github.com/fabric8io/kubernetes-client) which supports current versions of Kubernetes and provides separation of API and implementation classes. Both the State Provider and Leader Election Manager implementations attempt to resolve the Kubernetes namespace based on the standard [Service Account](https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/) namespace secret. In absence of a readable namespace secret, the provider returns `default` as the namespace for storing Leases and ConfigMaps. ## Additional Changes Additional changes include removing several integration test classes specific to ZooKeeper. These integration tests are less useful with current system integration tests run on a scheduled basis. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 8 - [X] JDK 11 - [X] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue
[GitHub] [nifi] dan-s1 commented on pull request #6753: NIFI-10941 Remove TestNG references
dan-s1 commented on PR #6753: URL: https://github.com/apache/nifi/pull/6753#issuecomment-1349646454 @exceptionfactory I see ImportFlowIt on line 59 still has `import org.junit.Test; ` instead of `import org.junit.jupiter.api.Test;` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10964) FetchSmb Processor should have the option to delete file after being fetched
[ https://issues.apache.org/jira/browse/NIFI-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646809#comment-17646809 ] Sam Williams commented on NIFI-10964: - https://github.com/samuelwilliams/nifi/tree/NIFI-10964 > FetchSmb Processor should have the option to delete file after being fetched > > > Key: NIFI-10964 > URL: https://issues.apache.org/jira/browse/NIFI-10964 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Sam Williams >Priority: Minor > > It would be good to have the option to delete a file once the FetchSmb > processor has collected the file. This could either be a whole new processor, > or just a property on the existing FetSmb processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-8006) Additional UI to invoke "Leave group" function
[ https://issues.apache.org/jira/browse/NIFI-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646806#comment-17646806 ] John Wise commented on NIFI-8006: - Is this configurable so that we can *prevent* the "esc" hotkey from forcing us out of process groups? We've spent years hitting "esc" to exit out of dialogs, and now find ourselves unintentionally backing out of multiple levels of process groups. My whole team is complaining about this new "feature". > Additional UI to invoke "Leave group" function > -- > > Key: NIFI-8006 > URL: https://issues.apache.org/jira/browse/NIFI-8006 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.12.1 >Reporter: Svyatoslav >Assignee: Adam Kocsis >Priority: Major > Fix For: 1.16.0 > > Attachments: image-2020-11-14-21-58-10-635.png > > Time Spent: 4.5h > Remaining Estimate: 0h > > It's not very convenient to open popup-menu and click on the "Leave group" > item to leave the group, especially if a program contains many hierarchically > organized groups. > !image-2020-11-14-21-58-10-635.png! > It would be much easier to move around groups with: > # Toolbar button > # Hot key -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6777: NIFI-10969: Created extension point for Signer Override in AWS S3 pro…
exceptionfactory commented on code in PR #6777:
URL: https://github.com/apache/nifi/pull/6777#discussion_r1047648938
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java:
##
@@ -95,50 +100,29 @@ public boolean proxyVariablesValidForAssumeRole(final
Map validate(final ValidationContext
validationContext,
final CredentialsStrategy
primaryStrategy) {
-final boolean assumeRoleArnIsSet =
validationContext.getProperty(ASSUME_ROLE_ARN).isSet();
-final boolean assumeRoleNameIsSet =
validationContext.getProperty(ASSUME_ROLE_NAME).isSet();
-final Integer maxSessionTime =
validationContext.getProperty(MAX_SESSION_TIME).asInteger();
-final boolean assumeRoleExternalIdIsSet =
validationContext.getProperty(ASSUME_ROLE_EXTERNAL_ID).isSet();
-final boolean assumeRoleProxyHostIsSet =
validationContext.getProperty(ASSUME_ROLE_PROXY_HOST).isSet();
-final boolean assumeRoleProxyPortIsSet =
validationContext.getProperty(ASSUME_ROLE_PROXY_PORT).isSet();
-final boolean assumeRoleSTSEndpointIsSet =
validationContext.getProperty(ASSUME_ROLE_STS_ENDPOINT).isSet();
-
-final Collection validationFailureResults = new
ArrayList();
-
-// Both role and arn name are req if present
-if (assumeRoleArnIsSet ^ assumeRoleNameIsSet ) {
-validationFailureResults.add(new
ValidationResult.Builder().input("Assume Role Arn and Name")
-.valid(false).explanation("Assume role requires both arn
and name to be set").build());
-}
+final Collection validationFailureResults = new
ArrayList<>();
-// Session time only b/w 900 to 3600 sec (see sts session class)
-if ( maxSessionTime < 900 || maxSessionTime > 3600 )
-validationFailureResults.add(new
ValidationResult.Builder().valid(false).input(maxSessionTime + "")
-.explanation(MAX_SESSION_TIME.getDisplayName() +
-" must be between 900 and 3600 seconds").build());
-
-// External ID should only be provided with viable Assume Role ARN and
Name
-if (assumeRoleExternalIdIsSet && (!assumeRoleArnIsSet ||
!assumeRoleNameIsSet)) {
-validationFailureResults.add(new
ValidationResult.Builder().input("Assume Role External ID")
-.valid(false)
-.explanation("Assume role requires both arn and name to be
set with External ID")
-.build());
-}
-
-// STS Endpoint should only be provided with viable Assume Role ARN
and Name
-if (assumeRoleSTSEndpointIsSet && (!assumeRoleArnIsSet ||
!assumeRoleNameIsSet)) {
-validationFailureResults.add(new
ValidationResult.Builder().input("Assume Role STS Endpoint")
-.valid(false)
-.explanation("Assume role requires both arn and name to be
set with STS Endpoint")
-.build());
-}
+final boolean assumeRoleArnIsSet =
validationContext.getProperty(ASSUME_ROLE_ARN).isSet();
-// Both proxy host and proxy port are required if present
-if (assumeRoleProxyHostIsSet ^ assumeRoleProxyPortIsSet){
-validationFailureResults.add(new
ValidationResult.Builder().input("Assume Role Proxy Host and Port")
-.valid(false)
-.explanation("Assume role with proxy requires both host
and port for the proxy to be set")
-.build());
+if (assumeRoleArnIsSet) {
+final Integer maxSessionTime =
validationContext.getProperty(MAX_SESSION_TIME).asInteger();
+
+// Session time only b/w 900 to 3600 sec (see sts session class)
+if (maxSessionTime < 900 || maxSessionTime > 3600)
Review Comment:
Opening and closing braces should be used:
```suggestion
if (maxSessionTime < 900 || maxSessionTime > 3600) {
```
Is it necessary to implement this check if the logic is already implemented
in AWS code?
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java:
##
@@ -95,50 +100,29 @@ public boolean proxyVariablesValidForAssumeRole(final
Map validate(final ValidationContext
validationContext,
final CredentialsStrategy
primaryStrategy) {
-final boolean assumeRoleArnIsSet =
validationContext.getProperty(ASSUME_ROLE_ARN).isSet();
-final boolean assumeRoleNameIsSet =
validationContext.getProperty(ASSUME_ROLE_NAME).isSet();
-final Integer maxSessionTime =
validationContext.getProperty(MAX_SESSION_TIME).asInteger();
-final boolean assumeRoleExternalIdIsSe
[GitHub] [nifi] exceptionfactory commented on pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…
exceptionfactory commented on PR #6775: URL: https://github.com/apache/nifi/pull/6775#issuecomment-1349491017 > I had tried to expand last night and nothing expanded and the only thing I saw was error. Today I see the logs. Is there a delay of some sort for that to be populated? The logs are available immediately, but you have to be logged in to GitHub in order to view the logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a diff in pull request #6778: NIFI-10970: Added a count RecordPath function
MikeThomsen commented on code in PR #6778:
URL: https://github.com/apache/nifi/pull/6778#discussion_r1047383469
##
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Count.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.record.path.functions;
+
+import org.apache.nifi.record.path.FieldValue;
+import org.apache.nifi.record.path.RecordPathEvaluationContext;
+import org.apache.nifi.record.path.StandardFieldValue;
+import org.apache.nifi.record.path.paths.RecordPathSegment;
+import org.apache.nifi.serialization.record.RecordField;
+import org.apache.nifi.serialization.record.RecordFieldType;
+
+import java.util.stream.Stream;
+
+public class Count extends RecordPathSegment {
+private final RecordPathSegment recordPath;
+
+public Count(final RecordPathSegment recordPath, final boolean absolute) {
+super("replace", null, absolute);
Review Comment:
Shouldn't the first parameter be `count`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-10832) Create PutSalesforceObject processor
[ https://issues.apache.org/jira/browse/NIFI-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646760#comment-17646760 ] ASF subversion and git services commented on NIFI-10832: Commit ed6ba537249ea781402dc0ac7e341907ba5b0c94 in nifi's branch refs/heads/main from Lehel Boér [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ed6ba53724 ] NIFI-10832: Create PutSalesforceRecord processor This closes #6670. Signed-off-by: Tamas Palfy > Create PutSalesforceObject processor > > > Key: NIFI-10832 > URL: https://issues.apache.org/jira/browse/NIFI-10832 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Fix For: 1.20.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Processor able to create new entries in Salesforce -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 commented on pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…
dan-s1 commented on PR #6775: URL: https://github.com/apache/nifi/pull/6775#issuecomment-1349308626 > > @exceptionfactory I took care of those. Let me know if there is anything else. Thank you for pointing out the the Checkstyle issues as from the CI-workflow it did not give any information other than error. > > You're welcome, thanks for addressing the issue. The output from the [Static Analysis](https://github.com/apache/nifi/actions/runs/3686971055/jobs/6239929188) job has a `Maven Build` section that can be expanded to show the particular error. This can also be verified in a local build using `mvn validate -P contrib-check`. I had tried to expand last night and nothing expanded and the only thing I saw was error. Today I see the logs. Is there a delay of some sort for that to be populated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10978) Allow docker user to override LDAP Referral Strategy
[
https://issues.apache.org/jira/browse/NIFI-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominique Jean-Prost updated NIFI-10978:
Component/s: Docker
(was: NiFi Registry)
Description:
As a docker user, I cannot override {{Referral Strategy}} when launching a nifi
instance.
For the moment, in {{{}update_login_providers.sh{}}}, this variable is not
defined, and is not overridable.
The actual ENV defined variables are :
{code:java}
edit_property 'Authentication Strategy' "${LDAP_AUTHENTICATION_STRATEGY}"
edit_property 'Manager DN' "${LDAP_MANAGER_DN}"
edit_property 'Manager Password'"${LDAP_MANAGER_PASSWORD}"
edit_property 'TLS - Keystore' "${LDAP_TLS_KEYSTORE}"
edit_property 'TLS - Keystore Password' "${LDAP_TLS_KEYSTORE_PASSWORD}"
edit_property 'TLS - Keystore Type' "${LDAP_TLS_KEYSTORE_TYPE}"
edit_property 'TLS - Truststore'"${LDAP_TLS_TRUSTSTORE}"
edit_property 'TLS - Truststore Password' "${LDAP_TLS_TRUSTSTORE_PASSWORD}"
edit_property 'TLS - Truststore Type' "${LDAP_TLS_TRUSTSTORE_TYPE}"
edit_property 'TLS - Protocol' "${LDAP_TLS_PROTOCOL}"
edit_property 'Url' "${LDAP_URL}"
edit_property 'User Search Base'"${LDAP_USER_SEARCH_BASE}"
edit_property 'User Search Filter' "${LDAP_USER_SEARCH_FILTER}"
edit_property 'Identity Strategy' "${LDAP_IDENTITY_STRATEGY}"
{code}
The aim of this issue is to add
{code:java}
edit_property 'Referral Strategy' "${LDAP_REFERRAL_STRATEGY}"
{code}
was:
As a docker user, I cannot override {{Referral Strategy}} when launching a nifi
registry instance.
For the moment, in {{update_login_providers.sh}}, this variable is not defined,
and is not overridable.
The actual ENV defined variables are :
{code}
edit_property 'Authentication Strategy' "${LDAP_AUTHENTICATION_STRATEGY}"
edit_property 'Manager DN' "${LDAP_MANAGER_DN}"
edit_property 'Manager Password'"${LDAP_MANAGER_PASSWORD}"
edit_property 'TLS - Keystore' "${LDAP_TLS_KEYSTORE}"
edit_property 'TLS - Keystore Password' "${LDAP_TLS_KEYSTORE_PASSWORD}"
edit_property 'TLS - Keystore Type' "${LDAP_TLS_KEYSTORE_TYPE}"
edit_property 'TLS - Truststore'"${LDAP_TLS_TRUSTSTORE}"
edit_property 'TLS - Truststore Password' "${LDAP_TLS_TRUSTSTORE_PASSWORD}"
edit_property 'TLS - Truststore Type' "${LDAP_TLS_TRUSTSTORE_TYPE}"
edit_property 'TLS - Protocol' "${LDAP_TLS_PROTOCOL}"
edit_property 'Url' "${LDAP_URL}"
edit_property 'User Search Base'"${LDAP_USER_SEARCH_BASE}"
edit_property 'User Search Filter' "${LDAP_USER_SEARCH_FILTER}"
edit_property 'Identity Strategy' "${LDAP_IDENTITY_STRATEGY}"
{code}
The aim of this issue is to add
{code}
edit_property 'Referral Strategy' "${LDAP_REFERRAL_STRATEGY}"
{code}
> Allow docker user to override LDAP Referral Strategy
>
>
> Key: NIFI-10978
> URL: https://issues.apache.org/jira/browse/NIFI-10978
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Docker
>Reporter: Dominique Jean-Prost
>Assignee: Dominique Jean-Prost
>Priority: Minor
> Fix For: 1.20.0
>
>
> As a docker user, I cannot override {{Referral Strategy}} when launching a
> nifi instance.
> For the moment, in {{{}update_login_providers.sh{}}}, this variable is not
> defined, and is not overridable.
> The actual ENV defined variables are :
> {code:java}
> edit_property 'Authentication Strategy' "${LDAP_AUTHENTICATION_STRATEGY}"
> edit_property 'Manager DN' "${LDAP_MANAGER_DN}"
> edit_property 'Manager Password'"${LDAP_MANAGER_PASSWORD}"
> edit_property 'TLS - Keystore' "${LDAP_TLS_KEYSTORE}"
> edit_property 'TLS - Keystore Password' "${LDAP_TLS_KEYSTORE_PASSWORD}"
> edit_property 'TLS - Keystore Type' "${LDAP_TLS_KEYSTORE_TYPE}"
> edit_property 'TLS - Truststore'"${LDAP_TLS_TRUSTSTORE}"
> edit_property 'TLS - Truststore Password' "${LDAP_TLS_TRUSTSTORE_PASSWORD}"
> edit_property 'TLS - Truststore Type' "${LDAP_TLS_TRUSTSTORE_TYPE}"
> edit_property 'TLS - Protocol' "${LDAP_TLS_PROTOCOL}"
> edit_property 'Url' "${LDAP_URL}"
> edit_property 'User Search Base'"${LDAP_USER_SEARCH_BASE}"
> edit_property 'User Search Filter' "${LDAP_USER_SEARCH_FILTER}"
> edit_property 'Identity Strategy' "${LDAP_IDENTITY_STRATEGY}"
> {code}
> The aim of this issue is to add
> {code:java}
> edit_property 'Referral Strategy' "${LDAP_REFERRAL_STRATEGY}"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010
[jira] [Created] (NIFI-10978) Allow docker user to override LDAP Referral Strategy
Dominique Jean-Prost created NIFI-10978:
---
Summary: Allow docker user to override LDAP Referral Strategy
Key: NIFI-10978
URL: https://issues.apache.org/jira/browse/NIFI-10978
Project: Apache NiFi
Issue Type: Improvement
Components: NiFi Registry
Reporter: Dominique Jean-Prost
Assignee: Dominique Jean-Prost
Fix For: 1.20.0
As a docker user, I cannot override {{Referral Strategy}} when launching a nifi
registry instance.
For the moment, in {{update_login_providers.sh}}, this variable is not defined,
and is not overridable.
The actual ENV defined variables are :
{code}
edit_property 'Authentication Strategy' "${LDAP_AUTHENTICATION_STRATEGY}"
edit_property 'Manager DN' "${LDAP_MANAGER_DN}"
edit_property 'Manager Password'"${LDAP_MANAGER_PASSWORD}"
edit_property 'TLS - Keystore' "${LDAP_TLS_KEYSTORE}"
edit_property 'TLS - Keystore Password' "${LDAP_TLS_KEYSTORE_PASSWORD}"
edit_property 'TLS - Keystore Type' "${LDAP_TLS_KEYSTORE_TYPE}"
edit_property 'TLS - Truststore'"${LDAP_TLS_TRUSTSTORE}"
edit_property 'TLS - Truststore Password' "${LDAP_TLS_TRUSTSTORE_PASSWORD}"
edit_property 'TLS - Truststore Type' "${LDAP_TLS_TRUSTSTORE_TYPE}"
edit_property 'TLS - Protocol' "${LDAP_TLS_PROTOCOL}"
edit_property 'Url' "${LDAP_URL}"
edit_property 'User Search Base'"${LDAP_USER_SEARCH_BASE}"
edit_property 'User Search Filter' "${LDAP_USER_SEARCH_FILTER}"
edit_property 'Identity Strategy' "${LDAP_IDENTITY_STRATEGY}"
{code}
The aim of this issue is to add
{code}
edit_property 'Referral Strategy' "${LDAP_REFERRAL_STRATEGY}"
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-10877) Refactor nifi-framework-bundle to use JUnit 5 Part 2
[ https://issues.apache.org/jira/browse/NIFI-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646750#comment-17646750 ] ASF subversion and git services commented on NIFI-10877: Commit e21f622643236e110f39a65ba28abdb484756051 in nifi's branch refs/heads/main from dan-s1 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e21f622643 ] NIFI-10877 Converted more nifi-framework-core tests from JUnit 4 to 5 This closes #6775 Signed-off-by: David Handermann > Refactor nifi-framework-bundle to use JUnit 5 Part 2 > > > Key: NIFI-10877 > URL: https://issues.apache.org/jira/browse/NIFI-10877 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 3h 10m > Remaining Estimate: 0h > > Will make changes in the following directory > nifi-framework-bundle/nifi-framework/nifi-framework-core -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10877) Refactor nifi-framework-bundle to use JUnit 5 Part 2
[ https://issues.apache.org/jira/browse/NIFI-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10877: Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Refactor nifi-framework-bundle to use JUnit 5 Part 2 > > > Key: NIFI-10877 > URL: https://issues.apache.org/jira/browse/NIFI-10877 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Fix For: 1.20.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Will make changes in the following directory > nifi-framework-bundle/nifi-framework/nifi-framework-core -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…
exceptionfactory closed pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J… URL: https://github.com/apache/nifi/pull/6775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6670: NIFI-10832: Create PutSalesforceObject processor
exceptionfactory commented on PR #6670: URL: https://github.com/apache/nifi/pull/6670#issuecomment-1349199366 @turcsanyip It looks like the commit did not get applied to the `main` branch, and instead references a different branch named `commit`: https://gitbox.apache.org/repos/asf?p=nifi.git;h=df7ed8ee3f Can you check the `main` branch and update as needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-10977) Add Documentation for Kubernetes Cluster Deployments
David Handermann created NIFI-10977: --- Summary: Add Documentation for Kubernetes Cluster Deployments Key: NIFI-10977 URL: https://issues.apache.org/jira/browse/NIFI-10977 Project: Apache NiFi Issue Type: Sub-task Reporter: David Handermann Project documentation should be expanded to describe the basic features and implementation of Kubernetes Leader Election and State Management. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-10976) Add Migration Capabilities from ZooKeeper to Kubernetes
David Handermann created NIFI-10976: --- Summary: Add Migration Capabilities from ZooKeeper to Kubernetes Key: NIFI-10976 URL: https://issues.apache.org/jira/browse/NIFI-10976 Project: Apache NiFi Issue Type: Sub-task Reporter: David Handermann Following initial implementation for the Kubernetes State Provider, migration tools should be created to read from ZooKeeper and write to Kubernetes ConfigMaps. This should facilitate moving existing deployments from ZooKeeper to Kubernetes while preserving cluster state information. The existing ZooKeeper migrator provides a basis for the implementation, but additional work will be necessary to support TLS connections to ZooKeeper. Refactoring the current implementation for more intuitive command design, as support for configurable destinations may be required. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-10975) Add Kubernetes Leader Election Manager and State Provider
David Handermann created NIFI-10975: --- Summary: Add Kubernetes Leader Election Manager and State Provider Key: NIFI-10975 URL: https://issues.apache.org/jira/browse/NIFI-10975 Project: Apache NiFi Issue Type: Sub-task Components: Core Framework Reporter: David Handermann Assignee: David Handermann The initial implementation should include both a Kubernetes Leader Election Manager and State Provider to provide basic cluster capabilities without any dependencies on ZooKeeper. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…
exceptionfactory commented on PR #6775: URL: https://github.com/apache/nifi/pull/6775#issuecomment-1349006249 > @exceptionfactory I took care of those. Let me know if there is anything else. Thank you for pointing out the the Checkstyle issues as from the CI-workflow it did not give any information other than error. You're welcome, thanks for addressing the issue. The output from the [Static Analysis](https://github.com/apache/nifi/actions/runs/3686971055/jobs/6239929188) job has a `Maven Build` section that can be expanded to show the particular error. This can also be verified in a local build using `mvn validate -P contrib-check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2015) Increase the default thread count
[ https://issues.apache.org/jira/browse/MINIFICPP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-2015: Fix Version/s: 0.14.0 Assignee: Marton Szasz Status: Patch Available (was: Open) > Increase the default thread count > - > > Key: MINIFICPP-2015 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2015 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Trivial > Fix For: 0.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The default thread pool thread count is 2, which is fairly low in many use > cases. Some processors block whole threads for IO and network operations, > causing starvation of other parts of the flow. Increasing the default to 5 > would be a better starting point. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 commented on pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…
dan-s1 commented on PR #6775: URL: https://github.com/apache/nifi/pull/6775#issuecomment-1348862970 @exceptionfactory I took care of those. Let me know if there is anything else. Thank you for pointing out the the Checkstyle issues as from the CI-workflow it did not give any information other than error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-2009) CWEL Identifier resolution in attributes is incompatible with JSON output format
[ https://issues.apache.org/jira/browse/MINIFICPP-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink reassigned MINIFICPP-2009: -- Assignee: Martin Zink > CWEL Identifier resolution in attributes is incompatible with JSON output > format > > > Key: MINIFICPP-2009 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2009 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Marton Szasz >Assignee: Martin Zink >Priority: Major > > Slack thread: > https://apachenifi.slack.com/archives/CDF1VC1UZ/p1669668751115139 > Replacement in the content still works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mattyb149 commented on pull request #6725: NIFI-10888: When inferring a schema using a Record Reader, buffer up …
mattyb149 commented on PR #6725: URL: https://github.com/apache/nifi/pull/6725#issuecomment-1348813980 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1475: MINIFICPP-2015 increase default flow engine thread count to 5
szaszm opened a new pull request, #1475: URL: https://github.com/apache/nifi-minifi-cpp/pull/1475 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2015) Increase the default thread count
Marton Szasz created MINIFICPP-2015: --- Summary: Increase the default thread count Key: MINIFICPP-2015 URL: https://issues.apache.org/jira/browse/MINIFICPP-2015 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Marton Szasz The default thread pool thread count is 2, which is fairly low in many use cases. Some processors block whole threads for IO and network operations, causing starvation of other parts of the flow. Increasing the default to 5 would be a better starting point. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1471: MINIFICPP-2012 - Make free unconditional
szaszm closed pull request #1471: MINIFICPP-2012 - Make free unconditional URL: https://github.com/apache/nifi-minifi-cpp/pull/1471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1469: MINIFICPP-1932 Increase the timeout in TailFileTest
szaszm closed pull request #1469: MINIFICPP-1932 Increase the timeout in TailFileTest URL: https://github.com/apache/nifi-minifi-cpp/pull/1469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINIFICPP-1697) Give a better error message on unsupported algorithms in HashContent
[
https://issues.apache.org/jira/browse/MINIFICPP-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink reassigned MINIFICPP-1697:
--
Assignee: Martin Zink
> Give a better error message on unsupported algorithms in HashContent
>
>
> Key: MINIFICPP-1697
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1697
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Ferenc Gerlits
>Assignee: Martin Zink
>Priority: Minor
> Labels: MiNiFi-CPP-Hygiene
>
> If you specify an unsupported hash algorithm in the {{Hash Algorithm}}
> property of the {{HashContent}} processor, it will fail with an error like
> this in {{onTrigger}}:
> {noformat}
> [2021-12-07 10:48:56.508] [org::apache::nifi::minifi::core::Processor]
> [warning] Caught "map::at" (St12out_of_range) during Processor::onTrigger of
> processor: 345ddcb9-a73b-4d4e-8c3d-66ed162d60fc (HashContent)
> [2021-12-07 10:48:56.508] [org::apache::nifi::minifi::core::ProcessSession]
> [info] Penalizing c1565920-5742-11ec-bc73-5c879c2c3c60 for 3ms at
> HashContent
> [2021-12-07 10:48:56.508] [org::apache::nifi::minifi::core::ProcessSession]
> [warning] ProcessSession rollback for HashContent executed
> {noformat}
> It would be better to check the value in {{onSchedule}}, and if it is not
> supported, then log a better error message like "algorithm X is not
> supported; supported algorithms are: ..." and throw an exception, ie. fail to
> schedule the processor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1471: MINIFICPP-2012 - Make free unconditional
szaszm commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1047284129
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+#include "utils/OsUtils.h"
+#include "../TestBase.h"
+#include "../Catch.h"
+
+namespace org::apache::nifi::minifi::test {
+
+#ifdef WIN32
+TEST_CASE("Test userIdToUsername for well-known SIDs", "[OsUtils]") {
+ CHECK("Nobody" == minifi::utils::OsUtils::userIdToUsername("S-1-0-0"));
+ CHECK("Everyone" == minifi::utils::OsUtils::userIdToUsername("S-1-1-0"));
+ CHECK("Local" == minifi::utils::OsUtils::userIdToUsername("S-1-2-0"));
+ CHECK("Console Logon" ==
minifi::utils::OsUtils::userIdToUsername("S-1-2-1"));
+ CHECK("Creator Owner" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-0"));
+ CHECK("Creator Group" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-1"));
+ CHECK("CREATOR OWNER SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-2"));
+ CHECK("CREATOR GROUP SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-3"));
+ CHECK("OWNER RIGHTS" == minifi::utils::OsUtils::userIdToUsername("S-1-3-4"));
+ CHECK("NT SERVICE\\ALL SERVICES" ==
minifi::utils::OsUtils::userIdToUsername("S-1-5-80-0"));
Review Comment:
I like the new version with the emptiness checks. We can possibly change
them to checking actual values in MINIFICPP-2013.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-10974) Incorrect warning message on memory usage from MonitorMemory
Mark Bathori created NIFI-10974:
---
Summary: Incorrect warning message on memory usage from
MonitorMemory
Key: NIFI-10974
URL: https://issues.apache.org/jira/browse/NIFI-10974
Project: Apache NiFi
Issue Type: Bug
Reporter: Mark Bathori
Assignee: Mark Bathori
There are certain cases when the MonitorMemory reporting task is sending
incorrect warning messages on memory usage crossing the threshold.
{+}Repro steps{+}:
* In the MonitorMemory reporting task, set the threshold value to low enough
that the current memory usage is crossing that value.
* Restart NiFi while the monitoring task is still running.
* After the restart set the threshold to higher value above the actual memory
usage.
* The warning messages will be still send despite the threshold is above the
actual memory usage.
The main problem is that the *isCollectionUsageThresholdExceeded()* method call
on *MemoryPoolMXBean* have a *gcSensor* registered at the VM that's 'on'
attribute will get stuck on 'true' value. This will cause the method to always
return with exceeded. The sensor will get reseted on the next garbage
collection but until that it will send false messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-4150) NiFi starting failure and key file already existing
[
https://issues.apache.org/jira/browse/NIFI-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646680#comment-17646680
]
John Wise commented on NIFI-4150:
-
We're experiencing the leftover sensitive.key file fairly frequently with
1.16.3, so it's definitely still an issue. Ideally, since NiFi is already
programmed to detect it & display the message, it should also just delete that
file so that startup can continue.
> NiFi starting failure and key file already existing
> ---
>
> Key: NIFI-4150
> URL: https://issues.apache.org/jira/browse/NIFI-4150
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.2.0, 1.3.0
>Reporter: Pierre Villard
>Assignee: Andy LoPresto
>Priority: Major
>
> In some cases, if NiFi cannot start (in my case: debug port was already in
> use), the key file is still created and not deleted. Then it won't be
> possible to restart NiFi unless the key file is manually deleted.
> Logs from bootstrap:
> {code}
> 2017-07-04 13:57:40,460 INFO [main] o.a.n.b.NotificationServiceManager
> Successfully loaded the following 0 services: []
> 2017-07-04 13:57:40,466 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_STARTED
> 2017-07-04 13:57:40,466 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_STOPPED
> 2017-07-04 13:57:40,466 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_DIED
> 2017-07-04 13:57:40,508 INFO [main] org.apache.nifi.bootstrap.Command
> Starting Apache NiFi...
> 2017-07-04 13:57:40,509 INFO [main] org.apache.nifi.bootstrap.Command Working
> Directory: /usr/hdf/current/nifi
> 2017-07-04 13:57:40,510 INFO [main] org.apache.nifi.bootstrap.Command
> Command: /usr/jdk64/jdk1.8.0_112/bin/java -classpath
> /usr/hdf/current/nifi/conf:/usr/hdf/current/nifi/lib/nifi-runtime-1.2.0.3.0.0.0-453.jar:/usr/hdf/current/nifi/lib/javax.servlet-api-3.1.0.jar:/usr/hdf/current/nifi/lib/jcl-over-slf4j-1.7.25.jar:/usr/hdf/current/nifi/lib/jetty-schemas-3.1.jar:/usr/hdf/current/nifi/lib/jul-to-slf4j-1.7.25.jar:/usr/hdf/current/nifi/lib/log4j-over-slf4j-1.7.25.jar:/usr/hdf/current/nifi/lib/logback-classic-1.2.3.jar:/usr/hdf/current/nifi/lib/logback-core-1.2.3.jar:/usr/hdf/current/nifi/lib/nifi-api-1.2.0.3.0.0.0-453.jar:/usr/hdf/current/nifi/lib/nifi-nar-utils-1.2.0.3.0.0.0-453.jar:/usr/hdf/current/nifi/lib/nifi-properties-1.2.0.3.0.0.0-453.jar:/usr/hdf/current/nifi/lib/slf4j-api-1.7.25.jar:/usr/hdf/current/nifi/lib/nifi-framework-api-1.2.0.3.0.0.0-453.jar
> -Dorg.apache.jasper.compiler.disablejsr199=true
> -Djava.security.auth.login.config=/usr/hdf/current/nifi/conf/nifi_jaas.conf
> -Xmx512m -Xms512m
> -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8000
> -Dambari.application.id=nifi
> -Dambari.metrics.collector.url=http://pvillard-1:6188/ws/v1/timeline/metrics
> -Dsun.net.http.allowRestrictedHeaders=true -Djava.net.preferIPv4Stack=true
> -Djava.awt.headless=true -XX:+UseG1GC
> -Djava.protocol.handler.pkgs=sun.net.www.protocol
> -Dnifi.properties.file.path=/usr/hdf/current/nifi/conf/nifi.properties
> -Dnifi.bootstrap.listen.port=33910 -Dapp=NiFi
> -Dorg.apache.nifi.bootstrap.config.log.dir=/var/log/nifi org.apache.nifi.NiFi
> -K /usr/hdf/current/nifi/conf/sensitive.key
> 2017-07-04 13:57:40,532 INFO [main] org.apache.nifi.bootstrap.Command
> Launched Apache NiFi with Process ID 30029
> 2017-07-04 13:57:40,647 ERROR [NiFi logging handler] org.apache.nifi.StdErr
> ERROR: transport error 202: bind failed: Address already in use
> 2017-07-04 13:57:40,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr
> ERROR: JDWP Transport dt_socket failed to initialize, TRANSPORT_INIT(510)
> 2017-07-04 13:57:40,648 ERROR [NiFi logging handler] org.apache.nifi.StdErr
> JDWP exit error AGENT_ERROR_TRANSPORT_INIT(197): No transports initialized
> [debugInit.c:750]
> 2017-07-04 13:57:41,536 INFO [main] org.apache.nifi.bootstrap.RunNiFi NiFi
> never started. Will not restart NiFi
> 2017-07-04 14:03:26,828 INFO [main] o.a.n.b.NotificationServiceManager
> Successfully loaded the following 0 services: []
> 2017-07-04 14:03:26,834 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_STARTED
> 2017-07-04 14:03:26,835 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_STOPPED
> 2017-07-04 14:03:26,835 INFO [main] org.apache.nifi.bootstrap.RunNiFi
> Registered no Notification Services for Notification Type NIFI_DIED
> 2017-07-04 14:03:26,838 INFO [main] org.apache.nifi.bootstrap.Command Apache
> NiFi is not currentl
[GitHub] [nifi] tpalfy commented on pull request #6670: NIFI-10832: Create PutSalesforceObject processor
tpalfy commented on PR #6670: URL: https://github.com/apache/nifi/pull/6670#issuecomment-1348708673 LGTM Thanks for your work @Lehel44 and @turcsanyip for closing the PR (after I forgot it during the merge). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10832) Create PutSalesforceObject processor
[ https://issues.apache.org/jira/browse/NIFI-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy updated NIFI-10832: --- Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Create PutSalesforceObject processor > > > Key: NIFI-10832 > URL: https://issues.apache.org/jira/browse/NIFI-10832 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Fix For: 1.20.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > Processor able to create new entries in Salesforce -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] turcsanyip commented on pull request #6670: NIFI-10832: Create PutSalesforceObject processor
turcsanyip commented on PR #6670: URL: https://github.com/apache/nifi/pull/6670#issuecomment-1348704501 Closing PR manually due to missing PR reference in the commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip closed pull request #6670: NIFI-10832: Create PutSalesforceObject processor
turcsanyip closed pull request #6670: NIFI-10832: Create PutSalesforceObject processor URL: https://github.com/apache/nifi/pull/6670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-10081) MergeContent processor is not executed when Scheduling Strategy is set to Cron Driven.
[ https://issues.apache.org/jira/browse/NIFI-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646663#comment-17646663 ] Florian Schmidt commented on NIFI-10081: Hi [~Firenz] , we configured the Processor before the MergeContent as Cron driven and the MergeContent set to timer driven with 0 sec as the Rund Schedule. This solved our problem. > MergeContent processor is not executed when Scheduling Strategy is set to > Cron Driven. > -- > > Key: NIFI-10081 > URL: https://issues.apache.org/jira/browse/NIFI-10081 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.16.1, 1.16.2 > Environment: RHEL 7.9, Linux 3.10.0-1160.21.1.el7.x86_64 > java version "1.8.0_331" > Java(TM) SE Runtime Environment (build 1.8.0_331-b09) > Java HotSpot(TM) 64-Bit Server VM (build 25.331-b09, mixed mode) > Intel(R) Xeon(R) Silver 4110 CPU @ 2.10GHz > 6 cores >Reporter: Angel Oropeza >Priority: Minor > Labels: crondriven, merge-content, scheduling > Attachments: image-2022-06-01-22-22-32-958.png, > image-2022-06-01-22-33-10-811.png, image-2022-06-01-22-33-47-519.png > > > I was able to replicate my problem using the following configuration: > !image-2022-06-01-22-22-32-958.png! > The MergeContent configuration is as follows > !image-2022-06-01-22-33-10-811.png! > !image-2022-06-01-22-33-47-519.png! > Although the conditions of the MergeContent processor are met, it does not > concatenate the incoming flowfiles. > The last version in which the above flow worked was version 1.15.3. > Any suggestions on how to solve this? Is this a bug? > P.S.: The flow is so designed due to a dependency on only writing one file > per day. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10081) MergeContent processor is not executed when Scheduling Strategy is set to Cron Driven.
[ https://issues.apache.org/jira/browse/NIFI-10081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646653#comment-17646653 ] Mermillod commented on NIFI-10081: -- Hello, We have the same issues with mergeContent. We have issues with Cron driven (for some flows) but also issues with TimerDrive. We were in 1.15 and upgraded to 1.18.0 (with a 1.16 mi-stop for the migration). The use case with cron is super convenient when you need to have exactly one file by hour (for batch-driven partners). We are struggling looking for alternative (ie : using groovy to write/append local file). > MergeContent processor is not executed when Scheduling Strategy is set to > Cron Driven. > -- > > Key: NIFI-10081 > URL: https://issues.apache.org/jira/browse/NIFI-10081 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.16.1, 1.16.2 > Environment: RHEL 7.9, Linux 3.10.0-1160.21.1.el7.x86_64 > java version "1.8.0_331" > Java(TM) SE Runtime Environment (build 1.8.0_331-b09) > Java HotSpot(TM) 64-Bit Server VM (build 25.331-b09, mixed mode) > Intel(R) Xeon(R) Silver 4110 CPU @ 2.10GHz > 6 cores >Reporter: Angel Oropeza >Priority: Minor > Labels: crondriven, merge-content, scheduling > Attachments: image-2022-06-01-22-22-32-958.png, > image-2022-06-01-22-33-10-811.png, image-2022-06-01-22-33-47-519.png > > > I was able to replicate my problem using the following configuration: > !image-2022-06-01-22-22-32-958.png! > The MergeContent configuration is as follows > !image-2022-06-01-22-33-10-811.png! > !image-2022-06-01-22-33-47-519.png! > Although the conditions of the MergeContent processor are met, it does not > concatenate the incoming flowfiles. > The last version in which the above flow worked was version 1.15.3. > Any suggestions on how to solve this? Is this a bug? > P.S.: The flow is so designed due to a dependency on only writing one file > per day. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-10832) Create PutSalesforceObject processor
[ https://issues.apache.org/jira/browse/NIFI-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646645#comment-17646645 ] ASF subversion and git services commented on NIFI-10832: Commit df7ed8ee3f7ae4c7748067703499eb822d08343a in nifi's branch refs/heads/commit from Lehel Boér [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=df7ed8ee3f ] NIFI-10832: Create PutSalesforceRecord processor > Create PutSalesforceObject processor > > > Key: NIFI-10832 > URL: https://issues.apache.org/jira/browse/NIFI-10832 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Lehel Boér >Assignee: Lehel Boér >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Processor able to create new entries in Salesforce -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1471: MINIFICPP-2012 - Make free unconditional
adamdebreceni commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1047179473
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+#include "utils/OsUtils.h"
+#include "../TestBase.h"
+#include "../Catch.h"
+
+namespace org::apache::nifi::minifi::test {
+
+#ifdef WIN32
+TEST_CASE("Test userIdToUsername for well-known SIDs", "[OsUtils]") {
+ CHECK("Nobody" == minifi::utils::OsUtils::userIdToUsername("S-1-0-0"));
+ CHECK("Everyone" == minifi::utils::OsUtils::userIdToUsername("S-1-1-0"));
+ CHECK("Local" == minifi::utils::OsUtils::userIdToUsername("S-1-2-0"));
+ CHECK("Console Logon" ==
minifi::utils::OsUtils::userIdToUsername("S-1-2-1"));
+ CHECK("Creator Owner" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-0"));
+ CHECK("Creator Group" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-1"));
+ CHECK("CREATOR OWNER SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-2"));
+ CHECK("CREATOR GROUP SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-3"));
+ CHECK("OWNER RIGHTS" == minifi::utils::OsUtils::userIdToUsername("S-1-3-4"));
+ CHECK("NT SERVICE\\ALL SERVICES" ==
minifi::utils::OsUtils::userIdToUsername("S-1-5-80-0"));
Review Comment:
I am open to suggestions on how to test this, @martinzink is right, that we
should have some way of verifying this change, running the tests manually with
drmemory would provide such an options, we could also commit this test without
any actual verification (so without `CHECK` calls) but that would mean
committing an otherwise noop test, although a simple comment could signal its
purpose and prevent accidental removal in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1471: MINIFICPP-2012 - Make free unconditional
szaszm commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1047169874
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+#include "utils/OsUtils.h"
+#include "../TestBase.h"
+#include "../Catch.h"
+
+namespace org::apache::nifi::minifi::test {
+
+#ifdef WIN32
+TEST_CASE("Test userIdToUsername for well-known SIDs", "[OsUtils]") {
+ CHECK("Nobody" == minifi::utils::OsUtils::userIdToUsername("S-1-0-0"));
+ CHECK("Everyone" == minifi::utils::OsUtils::userIdToUsername("S-1-1-0"));
+ CHECK("Local" == minifi::utils::OsUtils::userIdToUsername("S-1-2-0"));
+ CHECK("Console Logon" ==
minifi::utils::OsUtils::userIdToUsername("S-1-2-1"));
+ CHECK("Creator Owner" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-0"));
+ CHECK("Creator Group" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-1"));
+ CHECK("CREATOR OWNER SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-2"));
+ CHECK("CREATOR GROUP SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-3"));
+ CHECK("OWNER RIGHTS" == minifi::utils::OsUtils::userIdToUsername("S-1-3-4"));
+ CHECK("NT SERVICE\\ALL SERVICES" ==
minifi::utils::OsUtils::userIdToUsername("S-1-5-80-0"));
Review Comment:
I managed to test this on a hungarian windows installation. It fails:
https://pastebin.com/qHW8B7Et
I prefer not to check in a failing test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-10973) NiFi Registry Client with Nested PGs/Flows - sync issue (again)
[
https://issues.apache.org/jira/browse/NIFI-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Bence reassigned NIFI-10973:
--
Assignee: Simon Bence
> NiFi Registry Client with Nested PGs/Flows - sync issue (again)
> ---
>
> Key: NIFI-10973
> URL: https://issues.apache.org/jira/browse/NIFI-10973
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Assignee: Simon Bence
>Priority: Critical
> Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
> Sync_issue_local_changes.png
>
>
> We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
> Client in combination with nested PGs (parent PG and child PGs are both
> commited as NiFi Registry flows).
> Steps to reproduce the issue (based on the attached template xml):
> Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
> {color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import
> the flow from Registry
> * {color:#57d9a3}Import the XML template{color}
> * {color:#57d9a3}Start Version Control for "Child PG"{color}
> * {color:#57d9a3}Start Version Control for "Parent PG"{color}
> * {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
> "Import from Registry", select the "Parent PG" flow{color}
> * {color:#57d9a3}On the original "Child PG" rename the only existing
> processor, eg. to "UpdateCounter New"{color}
> * {color:#57d9a3}Commit the change for the "Child PG" (Processor
> Rename){color}
> * {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
> "Child PG"){color}
> * {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
> switch to the newest version for the "Parent PG", which seems to be
> successful. *However* *now we are hitting the issue, NiFi shows a successful
> change, but NiFi shows as well "Local Changes" for the "Child PG" (not for
> the "Parent PG"). To get a good state you have to click to "Revert Local
> Changes" on the "Child PG" which makes no sense, it should directly sync the
> "Child PG" according to the commited version. At least the version number of
> the "Child PG" has been changed but not the real configuration as you see
> below in the screenshots. It shows that there has been a component name
> change, which is true for the version but to get to the new version we have
> to revert the local changes*{color}
>
> Screenshots with the Failure State below, "Parent PG" is in sync, but not the
> "Child PG". The only thing I've done is to change the Version on the "Parent
> PG":
> {color:#4c9aff}*!Sync_issue_State.png!*{color}
>
> {color:#4c9aff}*!Sync_issue_local_changes.png!*{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1948) Possibility to display in the logs the uid of the component to which the logging relates
[
https://issues.apache.org/jira/browse/MINIFICPP-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1948:
--
Description:
Is it possible, when logging to spdlog, to add the output of the identifier of
the component by which logging occurs, for example like this
spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
Processor ID or Controller Services ID or Connection ID or Flow Controller ID
Example before:
{code:java}
[2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
[2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from 0{code}
and after:
{code:java}
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1993] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test1.txt from 0
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1994] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test2.txt from 0 {code}
was:
Is it possible, when logging to spdlog, to add the output of the identifier of
the component by which logging occurs, for example like this
spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
Processor ID or Controller Services ID or Connection ID or Flow Controller ID
Example before:
{code:java}
[2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
[2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from 0{code}
and after:
{code:java}
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1993] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test1.txt from 0
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1994] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test2.txt from 0 {code}
> Possibility to display in the logs the uid of the component to which the
> logging relates
>
>
> Key: MINIFICPP-1948
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1948
> Project: Apache NiFi MiNiFi C++
> Issue Type: Wish
>Affects Versions: 0.12.0
>Reporter: Kondakov Artem
>Assignee: Ferenc Gerlits
>Priority: Major
> Fix For: 0.14.0
>
>
> Is it possible, when logging to spdlog, to add the output of the identifier
> of the component by which logging occurs, for example like this
> spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
> where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
> Processor ID or Controller Services ID or Connection ID or Flow Controller ID
>
> Example before:
> {code:java}
> [2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile1
> [2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile2
> [2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
> [debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
> [2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
> [debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from
> 0{code}
> and after:
> {code:java}
> [2022-12-13 13:
[jira] [Updated] (MINIFICPP-1948) Possibility to display in the logs the uid of the component to which the logging relates
[
https://issues.apache.org/jira/browse/MINIFICPP-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1948:
--
Description:
Is it possible, when logging to spdlog, to add the output of the identifier of
the component by which logging occurs, for example like this
spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
Processor ID or Controller Services ID or Connection ID or Flow Controller ID
Example before:
{code:java}
[2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
[2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from 0{code}
and after:
{code:java}
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1993] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test1.txt from 0
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1994] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test2.txt from 0 {code}
was:
Is it possible, when logging to spdlog, to add the output of the identifier of
the component by which logging occurs, for example like this
spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
Processor ID or Controller Services ID or Connection ID or Flow Controller ID
> Possibility to display in the logs the uid of the component to which the
> logging relates
>
>
> Key: MINIFICPP-1948
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1948
> Project: Apache NiFi MiNiFi C++
> Issue Type: Wish
>Affects Versions: 0.12.0
>Reporter: Kondakov Artem
>Assignee: Ferenc Gerlits
>Priority: Major
> Fix For: 0.14.0
>
>
> Is it possible, when logging to spdlog, to add the output of the identifier
> of the component by which logging occurs, for example like this
> spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
> where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
> Processor ID or Controller Services ID or Connection ID or Flow Controller ID
>
> Example before:
>
> {code:java}
> [2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile1
> [2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile2
> [2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
> [debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
> [2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
> [debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from
> 0{code}
> and after:
>
>
> {code:java}
> [2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile1
> [2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile2
> [2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
> [debug] [2438e3c8-015a-1000-79ca-83af40ec1993] Tailing file
> /var/tmp/nifi-minifi-cpp.test.7OKHeD/test1.txt from 0
> [2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
> [debug] [2438e3c8-015a-1000-79ca-83af40ec1994] Tailing file
> /var/tmp/nifi-minifi-cpp.test.7OKHeD/test2.txt from 0 {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1948) Possibility to display in the logs the uid of the component to which the logging relates
[
https://issues.apache.org/jira/browse/MINIFICPP-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1948:
--
Description:
Is it possible, when logging to spdlog, to add the output of the identifier of
the component by which logging occurs, for example like this
spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
Processor ID or Controller Services ID or Connection ID or Flow Controller ID
Example before:
{code:java}
[2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
[2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from 0{code}
and after:
{code:java}
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1993] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test1.txt from 0
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1994] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test2.txt from 0 {code}
was:
Is it possible, when logging to spdlog, to add the output of the identifier of
the component by which logging occurs, for example like this
spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
Processor ID or Controller Services ID or Connection ID or Flow Controller ID
Example before:
{code:java}
[2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
[2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
[debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from 0{code}
and after:
{code:java}
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile1
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::core::ProcessSession]
[trace] ProcessSession created for TailFile2
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1993] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test1.txt from 0
[2022-12-13 13:45:45.330] [org::apache::nifi::minifi::processors::TailFile]
[debug] [2438e3c8-015a-1000-79ca-83af40ec1994] Tailing file
/var/tmp/nifi-minifi-cpp.test.7OKHeD/test2.txt from 0 {code}
> Possibility to display in the logs the uid of the component to which the
> logging relates
>
>
> Key: MINIFICPP-1948
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1948
> Project: Apache NiFi MiNiFi C++
> Issue Type: Wish
>Affects Versions: 0.12.0
>Reporter: Kondakov Artem
>Assignee: Ferenc Gerlits
>Priority: Major
> Fix For: 0.14.0
>
>
> Is it possible, when logging to spdlog, to add the output of the identifier
> of the component by which logging occurs, for example like this
> spdlog.pattern=[%Y-%m-%d %H:%M:%S.%e] [%n] [%l] [%uid] %v
> where [%uid] is the output [45b07291-7c57-46f0-ab48-6d4c88386f7f] of the
> Processor ID or Controller Services ID or Connection ID or Flow Controller ID
>
> Example before:
>
> {code:java}
> [2022-12-13 13:44:04.001] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile1
> [2022-12-13 13:44:04.002] [org::apache::nifi::minifi::core::ProcessSession]
> [trace] ProcessSession created for TailFile2
> [2022-12-13 13:44:04.004] [org::apache::nifi::minifi::processors::TailFile]
> [debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test1.txt from 0
> [2022-12-13 13:44:04.005] [org::apache::nifi::minifi::processors::TailFile]
> [debug] Tailing file /var/tmp/nifi-minifi-cpp.test.iVfGaM/test2.txt from
> 0{code}
> and after:
> {code:java}
> [2
[jira] [Updated] (NIFI-10973) NiFi Registry Client with Nested PGs/Flows - sync issue (again)
[
https://issues.apache.org/jira/browse/NIFI-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josef Zahner updated NIFI-10973:
Summary: NiFi Registry Client with Nested PGs/Flows - sync issue (again)
(was: NiFi Registry Client with Nested PGs - sync issue (again))
> NiFi Registry Client with Nested PGs/Flows - sync issue (again)
> ---
>
> Key: NIFI-10973
> URL: https://issues.apache.org/jira/browse/NIFI-10973
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 1.19.1
>Reporter: Josef Zahner
>Priority: Critical
> Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
> Sync_issue_local_changes.png
>
>
> We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
> Client in combination with nested PGs (parent PG and child PGs are both
> commited as NiFi Registry flows).
> Steps to reproduce the issue (based on the attached template xml):
> Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
> {color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import
> the flow from Registry
> * {color:#57d9a3}Import the XML template{color}
> * {color:#57d9a3}Start Version Control for "Child PG"{color}
> * {color:#57d9a3}Start Version Control for "Parent PG"{color}
> * {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
> "Import from Registry", select the "Parent PG" flow{color}
> * {color:#57d9a3}On the original "Child PG" rename the only existing
> processor, eg. to "UpdateCounter New"{color}
> * {color:#57d9a3}Commit the change for the "Child PG" (Processor
> Rename){color}
> * {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
> "Child PG"){color}
> * {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
> switch to the newest version for the "Parent PG", which seems to be
> successful. *However* *now we are hitting the issue, NiFi shows a successful
> change, but NiFi shows as well "Local Changes" for the "Child PG" (not for
> the "Parent PG"). To get a good state you have to click to "Revert Local
> Changes" on the "Child PG" which makes no sense, it should directly sync the
> "Child PG" according to the commited version. At least the version number of
> the "Child PG" has been changed but not the real configuration as you see
> below in the screenshots. It shows that there has been a component name
> change, which is true for the version but to get to the new version we have
> to revert the local changes*{color}
>
> Screenshots with the Failure State below, "Parent PG" is in sync, but not the
> "Child PG". The only thing I've done is to change the Version on the "Parent
> PG":
> {color:#4c9aff}*!Sync_issue_State.png!*{color}
>
> {color:#4c9aff}*!Sync_issue_local_changes.png!*{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1474: MINIFICPP-2008 Differentiate successful onTriggers from throwing onTr…
martinzink opened a new pull request, #1474: URL: https://github.com/apache/nifi-minifi-cpp/pull/1474 …iggers in ScheduleAgents Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-10973) NiFi Registry Client with Nested PGs - sync issue (again)
Josef Zahner created NIFI-10973:
---
Summary: NiFi Registry Client with Nested PGs - sync issue (again)
Key: NIFI-10973
URL: https://issues.apache.org/jira/browse/NIFI-10973
Project: Apache NiFi
Issue Type: Bug
Components: NiFi Registry
Affects Versions: 1.19.1
Reporter: Josef Zahner
Attachments: Nested_PG_Test.xml, Sync_issue_State.png,
Sync_issue_local_changes.png
We just upgraded to NiFi 1.19.1 and we have an issue with the NiFi Registry
Client in combination with nested PGs (parent PG and child PGs are both
commited as NiFi Registry flows).
Steps to reproduce the issue (based on the attached template xml):
Hint: {color:#57d9a3}Green Color {color}-> NiFi Registry flow Master;
{color:#4c9aff}Blue Color{color} -> Secondary NiFi/Canvas where you import the
flow from Registry
* {color:#57d9a3}Import the XML template{color}
* {color:#57d9a3}Start Version Control for "Child PG"{color}
* {color:#57d9a3}Start Version Control for "Parent PG"{color}
* {color:#4c9aff}On an independent canvas/nifi click "Add Process Group" and
"Import from Registry", select the "Parent PG" flow{color}
* {color:#57d9a3}On the original "Child PG" rename the only existing
processor, eg. to "UpdateCounter New"{color}
* {color:#57d9a3}Commit the change for the "Child PG" (Processor Rename){color}
* {color:#57d9a3}Commit the change for the "Parent PG" (Version change of
"Child PG"){color}
* {color:#4c9aff}Now click "Change Version" on the other NiFi/Canvas and
switch to the newest version for the "Parent PG", which seems to be successful.
*However* *now we are hitting the issue, NiFi shows a successful change, but
NiFi shows as well "Local Changes" for the "Child PG" (not for the "Parent
PG"). To get a good state you have to click to "Revert Local Changes" on the
"Child PG" which makes no sense, it should directly sync the "Child PG"
according to the commited version. At least the version number of the "Child
PG" has been changed but not the real configuration as you see below in the
screenshots. It shows that there has been a component name change, which is
true for the version but to get to the new version we have to revert the local
changes*{color}
Screenshots with the Failure State below, "Parent PG" is in sync, but not the
"Child PG". The only thing I've done is to change the Version on the "Parent
PG":
{color:#4c9aff}*!Sync_issue_State.png!*{color}
{color:#4c9aff}*!Sync_issue_local_changes.png!*{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2014) Add ProcessSession::remove to Lua API
[ https://issues.apache.org/jira/browse/MINIFICPP-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2014: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi-minifi-cpp/pull/1472 > Add ProcessSession::remove to Lua API > - > > Key: MINIFICPP-2014 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2014 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > MINIFICPP-1990 added ProcessSession::remove to the Python API, we should add > this to lua as well to mantain feature parity between lua and python engines > in ExecuteScript -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1973) Refactor ResourceQueue
[ https://issues.apache.org/jira/browse/MINIFICPP-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-1973: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi-minifi-cpp/pull/1473 > Refactor ResourceQueue > -- > > Key: MINIFICPP-1973 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1973 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Adam Debreceni >Assignee: Martin Zink >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently ResourceQueue::getResource does not guarantee that the returned > cached object is in any way similar to the constructor function provided. It > also does not guarantee that the modified object is "reset" before adding it > back into the queue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1473: MINIFICPP-1973 Refactor ResourceQueue
martinzink opened a new pull request, #1473: URL: https://github.com/apache/nifi-minifi-cpp/pull/1473 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1472: MINIFICPP-2014 Add ProcessSession::remove to Lua API
martinzink opened a new pull request, #1472: URL: https://github.com/apache/nifi-minifi-cpp/pull/1472 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-7246) JWT Generated by a node in the cluster is not honored by other nodes in the cluster.
[ https://issues.apache.org/jira/browse/NIFI-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646587#comment-17646587 ] Nurullah Çalışkan commented on NIFI-7246: - I would like to mention one thing here. Our problem is this: even if we are using sticky session. If one of the nodes is down, we will have the token I received from it and requests that will go to the server that is down, in this case all the requests we have sent with the token will give an invalid token error. In order to prevent this, the token we receive from any node must be valid on all nodes. Thus, even if the node drops, we will still be able to send requests with tokens. We also talked about this topic in this slack thread, I would like to continue the thread for possible issues. https://apachenifi.slack.com/archives/C0L9VCD47/p1669881981704059 > JWT Generated by a node in the cluster is not honored by other nodes in the > cluster. > > > Key: NIFI-7246 > URL: https://issues.apache.org/jira/browse/NIFI-7246 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Security >Reporter: Shreyas KC >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In an externally load balanced cluster without sticky session, it is not > possible to currently share the JWT generated by one node with the rest of > the nodes in the cluster. > Hence we need a mechanism where we can introduce static key in the > nifi.properties in its chosen by the cluster administrator. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-7246) JWT Generated by a node in the cluster is not honored by other nodes in the cluster.
[ https://issues.apache.org/jira/browse/NIFI-7246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646587#comment-17646587 ] Nurullah Çalışkan edited comment on NIFI-7246 at 12/13/22 11:45 AM: I would like to mention one thing here. Our problem is this: even if we are using sticky session. If one of the nodes is down, we will have the token I received from it and requests that will go to the server that is down, in this case all the requests we have sent with the token will give an invalid token error. In order to prevent this, the token we receive from any node must be valid on all nodes. Thus, even if the node drops, we will still be able to send requests with tokens. We also talked about this topic in this slack thread, I would like to continue the thread for possible issues. [https://apachenifi.slack.com/archives/C0L9VCD47/p1669881981704059] cc://[~exceptionfactory] was (Author: JIRAUSER279864): I would like to mention one thing here. Our problem is this: even if we are using sticky session. If one of the nodes is down, we will have the token I received from it and requests that will go to the server that is down, in this case all the requests we have sent with the token will give an invalid token error. In order to prevent this, the token we receive from any node must be valid on all nodes. Thus, even if the node drops, we will still be able to send requests with tokens. We also talked about this topic in this slack thread, I would like to continue the thread for possible issues. https://apachenifi.slack.com/archives/C0L9VCD47/p1669881981704059 > JWT Generated by a node in the cluster is not honored by other nodes in the > cluster. > > > Key: NIFI-7246 > URL: https://issues.apache.org/jira/browse/NIFI-7246 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Security >Reporter: Shreyas KC >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In an externally load balanced cluster without sticky session, it is not > possible to currently share the JWT generated by one node with the rest of > the nodes in the cluster. > Hence we need a mechanism where we can introduce static key in the > nifi.properties in its chosen by the cluster administrator. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINIFICPP-2014) Add ProcessSession::remove to Lua API
Martin Zink created MINIFICPP-2014: -- Summary: Add ProcessSession::remove to Lua API Key: MINIFICPP-2014 URL: https://issues.apache.org/jira/browse/MINIFICPP-2014 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Martin Zink Assignee: Martin Zink MINIFICPP-1990 added ProcessSession::remove to the Python API, we should add this to lua as well to mantain feature parity between lua and python engines in ExecuteScript -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6777: NIFI-10969: Created extension point for Signer Override in AWS S3 pro…
turcsanyip commented on code in PR #6777:
URL: https://github.com/apache/nifi/pull/6777#discussion_r1046970850
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java:
##
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.signer;
+
+import com.amazonaws.auth.Signer;
+
+public interface AwsCustomSignerFactory {
Review Comment:
@exceptionfactory Updated the PR.
Found a more straightforward way to access region and service type:
`AWS4Signer` implementation of the `Signer` interface has `serviceName` and
`regionName` fields and this class may be used as a base class for custom
signers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-10972) PutBigQuery - Invalid project resource name projects/${Project}
[
https://issues.apache.org/jira/browse/NIFI-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hipotures updated NIFI-10972:
-
Description:
Processor: *PutBigQuery*
Parameter: *Project ID*
Value for Project ID: *${Project}*
Problem: *attributes are unevaluated*
Error log:
{code:java}
2022-12-13 10:40:18,955 ERROR [Timer-Driven Process Thread-9]
o.a.n.p.gcp.bigquery.PutBigQuery
PutBigQuery[id=121711dc-1182-1bfc-7f3d-6fb3bcfc7d0b] Processing halted:
yielding [1 sec]
com.google.api.gax.rpc.InvalidArgumentException:
io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Invalid project resource name
projects/${Project}; Project id: ${Project}
at
com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:92)
at
com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:41)
at
com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:86)
at
com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:66)
at
com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.onFailure(GrpcExceptionCallable.java:97)
at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:67)
at
com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1132)
at
com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
at
com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1270)
at
com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:1038)
at
com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:808)
at io.grpc.stub.ClientCalls$GrpcFuture.setException(ClientCalls.java:563)
at
io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:533)
at
io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)
at
io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)
at
io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)
at
com.google.api.gax.grpc.ChannelPool$ReleasingClientCall$1.onClose(ChannelPool.java:535)
at
io.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:463)
at
io.grpc.internal.DelayedClientCall$DelayedListener.delayOrExecute(DelayedClientCall.java:427)
at
io.grpc.internal.DelayedClientCall$DelayedListener.onClose(DelayedClientCall.java:460)
at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:562)
at io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:70)
at
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInternal(ClientCallImpl.java:743)
at
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:722)
at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
Suppressed: com.google.api.gax.rpc.AsyncTaskException: Asynchronous task
failed
at
com.google.api.gax.rpc.ApiExceptions.callAndTranslateApiException(ApiExceptions.java:57)
at com.google.api.gax.rpc.UnaryCallable.call(UnaryCallable.java:112)
at
com.google.cloud.bigquery.storage.v1.BigQueryWriteClient.createWriteStream(BigQueryWriteClient.java:231)
at
org.apache.nifi.processors.gcp.bigquery.PutBigQuery.createWriteStream(PutBigQuery.java:380)
at
org.apache.nifi.processors.gcp.bigquery.PutBigQuery.onTrigger(PutBigQuery.java:207)
at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1356)
at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
at
org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
... 3 common frames omitted
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Invalid project
resource
[jira] [Created] (NIFI-10972) PutBigQuery - Invalid project resource name projects/${Project}
hipotures created NIFI-10972:
Summary: PutBigQuery - Invalid project resource name
projects/${Project}
Key: NIFI-10972
URL: https://issues.apache.org/jira/browse/NIFI-10972
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Affects Versions: 1.19.1, 1.19.0
Environment: Debian
Reporter: hipotures
Processor: *PutBigQuery*
Parameter: *Project ID*
Value for Project ID: *${Project}*
Problem: *attributes are unevaluated*
Error log:
{code:java}
2022-12-13 10:40:18,983 WARN [Timer-Driven Process Thread-9]
o.a.n.controller.tasks.ConnectableTask Processing halted: uncaught exception in
Component [PutBigQuery[id=121711dc-1182-1bfc-7f3d-6fb3bcfc7d0b]]
com.google.api.gax.rpc.InvalidArgumentException:
io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Invalid project resource name
projects/${Project}; Project id: ${Project}
at
com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:92)
at
com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:41)
at
com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:86)
at
com.google.api.gax.grpc.GrpcApiExceptionFactory.create(GrpcApiExceptionFactory.java:66)
at
com.google.api.gax.grpc.GrpcExceptionCallable$ExceptionTransformingFuture.onFailure(GrpcExceptionCallable.java:97)
at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:67)
at
com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1132)
at
com.google.common.util.concurrent.DirectExecutor.execute(DirectExecutor.java:31)
at
com.google.common.util.concurrent.AbstractFuture.executeListener(AbstractFuture.java:1270)
at
com.google.common.util.concurrent.AbstractFuture.complete(AbstractFuture.java:1038)
at
com.google.common.util.concurrent.AbstractFuture.setException(AbstractFuture.java:808)
at io.grpc.stub.ClientCalls$GrpcFuture.setException(ClientCalls.java:563)
at io.grpc.stub.ClientCalls$UnaryStreamToFuture.onClose(ClientCalls.java:533)
at
io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)
at
io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)
at
io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)
at
com.google.api.gax.grpc.ChannelPool$ReleasingClientCall$1.onClose(ChannelPool.java:535)
at
io.grpc.internal.DelayedClientCall$DelayedListener$3.run(DelayedClientCall.java:463)
at
io.grpc.internal.DelayedClientCall$DelayedListener.delayOrExecute(DelayedClientCall.java:427)
at
io.grpc.internal.DelayedClientCall$DelayedListener.onClose(DelayedClientCall.java:460)
at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:562)
at io.grpc.internal.ClientCallImpl.access$300(ClientCallImpl.java:70)
at
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInternal(ClientCallImpl.java:743)
at
io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:722)
at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:750)
Suppressed: com.google.api.gax.rpc.AsyncTaskException: Asynchronous task failed
at
com.google.api.gax.rpc.ApiExceptions.callAndTranslateApiException(ApiExceptions.java:57)
at com.google.api.gax.rpc.UnaryCallable.call(UnaryCallable.java:112)
at
com.google.cloud.bigquery.storage.v1.BigQueryWriteClient.createWriteStream(BigQueryWriteClient.java:231)
at
org.apache.nifi.processors.gcp.bigquery.PutBigQuery.createWriteStream(PutBigQuery.java:380)
at
org.apache.nifi.processors.gcp.bigquery.PutBigQuery.onTrigger(PutBigQuery.java:207)
at
org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
at
org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1356)
at
org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:246)
at
org.apache.nifi.controller.scheduling.AbstractTimeBasedSchedulingAgent.lambda$doScheduleOnce$0(AbstractTimeBasedSchedulingAgent.java:59)
at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
... 3 common frames omitted
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Inv
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1471: MINIFICPP-2012 - Make free unconditional
adamdebreceni commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1046845372
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+#include "utils/OsUtils.h"
+#include "../TestBase.h"
+#include "../Catch.h"
+
+namespace org::apache::nifi::minifi::test {
+
+#ifdef WIN32
+TEST_CASE("Test userIdToUsername for well-known SIDs", "[OsUtils]") {
+ CHECK("Nobody" == minifi::utils::OsUtils::userIdToUsername("S-1-0-0"));
+ CHECK("Everyone" == minifi::utils::OsUtils::userIdToUsername("S-1-1-0"));
+ CHECK("Local" == minifi::utils::OsUtils::userIdToUsername("S-1-2-0"));
+ CHECK("Console Logon" ==
minifi::utils::OsUtils::userIdToUsername("S-1-2-1"));
+ CHECK("Creator Owner" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-0"));
+ CHECK("Creator Group" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-1"));
+ CHECK("CREATOR OWNER SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-2"));
+ CHECK("CREATOR GROUP SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-3"));
+ CHECK("OWNER RIGHTS" == minifi::utils::OsUtils::userIdToUsername("S-1-3-4"));
+ CHECK("NT SERVICE\\ALL SERVICES" ==
minifi::utils::OsUtils::userIdToUsername("S-1-5-80-0"));
Review Comment:
`userIdToUsername` first checks a fixed set of identifiers in
`resolve_common_identifiers`, which returns english users, so if localization
becomes an issue, this test will fail and we will have to look into
`resolve_common_identifiers` as well, created a ticket to handle this:
[MINIFICPP-2013](https://issues.apache.org/jira/browse/MINIFICPP-2013)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MINIFICPP-2013) Ensure localization-correctness in `OsUtils::userIdToUsername`
Adam Debreceni created MINIFICPP-2013: - Summary: Ensure localization-correctness in `OsUtils::userIdToUsername` Key: MINIFICPP-2013 URL: https://issues.apache.org/jira/browse/MINIFICPP-2013 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Adam Debreceni We currently do not take the necessary steps to ensure that user ids are mapped to usernames in an installation-language-conforming way. We should look into it if it is a problem. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1471: MINIFICPP-2012 - Make free unconditional
szaszm commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1046825301
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+#include "utils/OsUtils.h"
+#include "../TestBase.h"
+#include "../Catch.h"
+
+namespace org::apache::nifi::minifi::test {
+
+#ifdef WIN32
+TEST_CASE("Test userIdToUsername for well-known SIDs", "[OsUtils]") {
+ CHECK("Nobody" == minifi::utils::OsUtils::userIdToUsername("S-1-0-0"));
+ CHECK("Everyone" == minifi::utils::OsUtils::userIdToUsername("S-1-1-0"));
+ CHECK("Local" == minifi::utils::OsUtils::userIdToUsername("S-1-2-0"));
+ CHECK("Console Logon" ==
minifi::utils::OsUtils::userIdToUsername("S-1-2-1"));
+ CHECK("Creator Owner" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-0"));
+ CHECK("Creator Group" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-1"));
+ CHECK("CREATOR OWNER SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-2"));
+ CHECK("CREATOR GROUP SERVER" ==
minifi::utils::OsUtils::userIdToUsername("S-1-3-3"));
+ CHECK("OWNER RIGHTS" == minifi::utils::OsUtils::userIdToUsername("S-1-3-4"));
+ CHECK("NT SERVICE\\ALL SERVICES" ==
minifi::utils::OsUtils::userIdToUsername("S-1-5-80-0"));
Review Comment:
I believe these usernames are localized, so non-english installations will
have different names there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
