Re: [PR] [NIFI-12748] apply panelClass to snackbars to apply lighter color to … [nifi]
scottyaslan commented on code in PR #8365:
URL: https://github.com/apache/nifi/pull/8365#discussion_r1480848712
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/_app.component-theme.scss:
##
@@ -27,8 +27,13 @@
// Get hues from palette
$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
+$primary-palette-300: mat.get-color-from-palette($primary-palette, 300);
.splash {
background-color: $primary-palette-500;
}
+
+.nifi-snackbar .mat-mdc-button:not(:disabled) .mdc-button__label {
+color: $primary-palette-300;
+}
Review Comment:
I think you mean $accent-palette-A400. I just updated the references to the
primary palette A100 - A700 here: https://github.com/apache/nifi/pull/8364.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [NIFI-12665] fetch parameter provider parameters [nifi]
rfellows opened a new pull request, #8367: URL: https://github.com/apache/nifi/pull/8367 [NIFI-12665](https://issues.apache.org/jira/browse/NIFI-12665) * add permissions checks to parameter provider table actions for edit, delete, and fetch. * error handling * routing to fetch parameter provider dialog * list the parameter groups * parameter sensitivity selction/deselection * show banner error if any affected/referencing components are not readable and writeable * add indicators to parameters for changed, new, removed, ... * refactored parameter-references component to the common area. leveraged it in the fetch dialog. * validate the fetch form * submit the fetch parameter provider parameters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12748] apply panelClass to snackbars to apply lighter color to … [nifi]
rfellows commented on code in PR #8365:
URL: https://github.com/apache/nifi/pull/8365#discussion_r1480636980
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/_app.component-theme.scss:
##
@@ -27,8 +27,13 @@
// Get hues from palette
$primary-palette-500: mat.get-color-from-palette($primary-palette, 500);
+$primary-palette-300: mat.get-color-from-palette($primary-palette, 300);
.splash {
background-color: $primary-palette-500;
}
+
+.nifi-snackbar .mat-mdc-button:not(:disabled) .mdc-button__label {
+color: $primary-palette-300;
+}
Review Comment:
@scottyaslan we probably also need a setting for the `:hover` state. ATM,
the button highlight on hover isn't visible like it is in dark-mode.
Might want to add something like this
```
.nifi-snackbar .mat-mdc-button:hover {
background-color: $primary-palette-A400;
}
```
I don't love the color, but we use it for other button hover states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12742) Users, Summary, Queue Listing - General error handling in API responses
[ https://issues.apache.org/jira/browse/NIFI-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12742: --- Status: Patch Available (was: In Progress) > Users, Summary, Queue Listing - General error handling in API responses > --- > > Key: NIFI-12742 > URL: https://issues.apache.org/jira/browse/NIFI-12742 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Introduce error handling to web requests on the Users, Summary, Queue Listing > page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12742: Error Handling in Summary, Users, and Queue Listing [nifi]
mcgilman opened a new pull request, #8366: URL: https://github.com/apache/nifi/pull/8366 NIFI-12742: - Error Handling in Summary, Users, and Queue Listing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts ** Provenance ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board
[jira] [Updated] (NIFI-12742) Users, Summary, Queue Listing - General error handling in API responses
[ https://issues.apache.org/jira/browse/NIFI-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12742: --- Description: Introduce error handling to web requests on the Users, Summary, Queue Listing page. (was: Introduce error handling to web requests on the Users page.) > Users, Summary, Queue Listing - General error handling in API responses > --- > > Key: NIFI-12742 > URL: https://issues.apache.org/jira/browse/NIFI-12742 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > Introduce error handling to web requests on the Users, Summary, Queue Listing > page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12742) Users, Summary, Queue Listing - General error handling in API responses
[ https://issues.apache.org/jira/browse/NIFI-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12742: --- Summary: Users, Summary, Queue Listing - General error handling in API responses (was: Users - General error handling in API responses) > Users, Summary, Queue Listing - General error handling in API responses > --- > > Key: NIFI-12742 > URL: https://issues.apache.org/jira/browse/NIFI-12742 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > > Introduce error handling to web requests on the Users page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster * Flow Configuration History * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) * Help * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts ** Provenance ** Queue Listing ** Summary (NIFI-12742) ** Users (NIFI-12742) * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Prompt user to save Parameter Context when Edit form is dirty * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) * Bulletin Board (NIFI-12560)
[jira] [Updated] (NIFI-12747) BUG - incorrect theming references
[ https://issues.apache.org/jira/browse/NIFI-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12747: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > BUG - incorrect theming references > -- > > Key: NIFI-12747 > URL: https://issues.apache.org/jira/browse/NIFI-12747 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12747) BUG - incorrect theming references
[ https://issues.apache.org/jira/browse/NIFI-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815007#comment-17815007 ] ASF subversion and git services commented on NIFI-12747: Commit 72f6d8a6800c643d5f283ae9bff6d7de25b503e9 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=72f6d8a680 ] [NIFI-12747] correct theming references (#8364) This closes #8364 > BUG - incorrect theming references > -- > > Key: NIFI-12747 > URL: https://issues.apache.org/jira/browse/NIFI-12747 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12747] correct theming references [nifi]
mcgilman merged PR #8364: URL: https://github.com/apache/nifi/pull/8364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12748) BUG - snackbar action button text in light mode is too dark
Scott Aslan created NIFI-12748: -- Summary: BUG - snackbar action button text in light mode is too dark Key: NIFI-12748 URL: https://issues.apache.org/jira/browse/NIFI-12748 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan Attachments: Screenshot 2024-02-06 at 4.02.36 PM.png !Screenshot 2024-02-06 at 4.02.36 PM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12747] correct theming references [nifi]
mcgilman commented on PR #8364: URL: https://github.com/apache/nifi/pull/8364#issuecomment-1930716968 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12727] Detect theme based on OS setting, allow user override [nifi]
mcgilman commented on code in PR #8352:
URL: https://github.com/apache/nifi/pull/8352#discussion_r1480501385
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/app.component.ts:
##
@@ -37,5 +43,22 @@ export class AppComponent {
this.guardLoading = false;
}
});
+
+let theme = this.storage.getItem('theme');
+
+// Initially check if dark mode is enabled on system
+const darkModeOn = window.matchMedia &&
window.matchMedia('(prefers-color-scheme: dark)').matches;
+
+// If dark mode is enabled then directly switch to the dark-theme
+this.themingService.toggleTheme(darkModeOn, theme);
+
+if (window.matchMedia) {
+// Watch for changes of the preference
+window.matchMedia('(prefers-color-scheme: dark)').addListener((e)
=> {
+theme = this.storage.getItem('theme');
+const newColorScheme = e.matches ? 'dark' : 'light';
Review Comment:
If `e.matches` is a boolean, do we need to convert it into a string here?
Can `e.matches` be passed to `toggleTheme` just like it is above?
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/navigation/navigation.component.ts:
##
@@ -94,10 +114,10 @@ export class Navigation {
);
}
-toggleTheme(value = !this.isDarkMode) {
-this.isDarkMode = value;
-this._document.body.classList.toggle('dark-theme', value);
-
-// TODO: save to local storage or read OS settings???
+toggleTheme(theme: string) {
+this.theme = theme;
+this.storage.setItem('theme', theme);
+this.darkModeOn = window.matchMedia &&
window.matchMedia('(prefers-color-scheme: dark)').matches;
Review Comment:
Does `darkModeOn` need to be re-assigned here? It is currently being
assigned in the listener above so I suspect it should be always up to date.
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/service/theming.service.ts:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Inject, Injectable } from '@angular/core';
+import { DOCUMENT } from '@angular/common';
+
+export const DARK_THEME = 'DARK_THEME';
+export const LIGHT_THEME = 'LIGHT_THEME';
+export const OS_SETTING = 'OS_SETTING';
+
+@Injectable({ providedIn: 'root' })
+export class ThemingService {
+constructor(@Inject(DOCUMENT) private _document: Document) {}
+
+toggleTheme(darkModeOn: boolean, theme: any) {
+if (darkModeOn) {
+if (theme === DARK_THEME) {
+this._document.body.classList.toggle('dark-theme', true);
+} else if (theme === LIGHT_THEME) {
+this._document.body.classList.toggle('dark-theme', false);
+} else {
+this._document.body.classList.toggle('dark-theme', true);
+}
+} else if (!darkModeOn) {
Review Comment:
Can this just be `else` instead of `else if`?
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/navigation/navigation.component.ts:
##
@@ -44,23 +47,40 @@ import { MatSlideToggleModule } from
'@angular/material/slide-toggle';
NgIf,
RouterLink,
MatButtonModule,
-MatSlideToggleModule,
-FormsModule
+FormsModule,
+MatCheckboxModule
],
templateUrl: './navigation.component.html',
styleUrls: ['./navigation.component.scss']
})
export class Navigation {
+theme: any | undefined;
+darkModeOn: boolean | undefined;
+LIGHT_THEME: string = LIGHT_THEME;
+DARK_THEME: string = DARK_THEME;
+OS_SETTING: string = OS_SETTING;
currentUser$ = this.store.select(selectCurrentUser);
flowConfiguration$ = this.store.select(selectFlowConfiguration);
-isDarkMode = false;
constructor(
private store: Store,
private authStorage: AuthStorage,
private authService: AuthService,
-@Inject(DOCUMENT)
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
dan-s1 commented on code in PR #8362:
URL: https://github.com/apache/nifi/pull/8362#discussion_r1480489960
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -458,156 +476,148 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final CsvPreference csvPref = getPreference(context, flowFile);
final boolean header = context.getProperty(HEADER).asBoolean();
final ComponentLog logger = getLogger();
-final String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
-final CellProcessor[] cellProcs = this.parseSchema(schema);
-final boolean isWholeFFValidation =
context.getProperty(VALIDATION_STRATEGY).getValue().equals(VALIDATE_WHOLE_FLOWFILE.getValue());
+String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
+CellProcessor[] cellProcs = null;
+if (schema != null) {
+cellProcs = this.parseSchema(schema);
+}
Review Comment:
Why isn't that code pulled up here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
dan-s1 commented on code in PR #8362:
URL: https://github.com/apache/nifi/pull/8362#discussion_r1480489960
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -458,156 +476,148 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final CsvPreference csvPref = getPreference(context, flowFile);
final boolean header = context.getProperty(HEADER).asBoolean();
final ComponentLog logger = getLogger();
-final String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
-final CellProcessor[] cellProcs = this.parseSchema(schema);
-final boolean isWholeFFValidation =
context.getProperty(VALIDATION_STRATEGY).getValue().equals(VALIDATE_WHOLE_FLOWFILE.getValue());
+String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
+CellProcessor[] cellProcs = null;
+if (schema != null) {
+cellProcs = this.parseSchema(schema);
+}
Review Comment:
Why isn't that code pulled up here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12737) Skip transition when updating the canvas transform
[ https://issues.apache.org/jira/browse/NIFI-12737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12737: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Skip transition when updating the canvas transform > -- > > Key: NIFI-12737 > URL: https://issues.apache.org/jira/browse/NIFI-12737 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12737) Skip transition when updating the canvas transform
[ https://issues.apache.org/jira/browse/NIFI-12737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814995#comment-17814995 ] ASF subversion and git services commented on NIFI-12737: Commit 13c70c0f30a87b87d58ba85843df364a61e22385 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=13c70c0f30 ] NIFI-12737: Removing all transitions when updating the Canvas transform (#8355) * NIFI-12737: - Recording last canvas URL in local storage. - Using last canvas URL in global menu Canvas item. - Conditionally applying transitions when centering components. - Always applying transitions during zoom events (1:1, fit, zoom in/out). - Adding support to center more than one component. * NIFI-12737: - Fixing bug when attempting to click on the search result of the currently selected component. - Handling centering of a single selection different from a bulk selection as it performs betters with Connections. This closes #8355 > Skip transition when updating the canvas transform > -- > > Key: NIFI-12737 > URL: https://issues.apache.org/jira/browse/NIFI-12737 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12737: Removing all transitions when updating the Canvas transform [nifi]
rfellows merged PR #8355: URL: https://github.com/apache/nifi/pull/8355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
dan-s1 commented on code in PR #8362: URL: https://github.com/apache/nifi/pull/8362#discussion_r1480469583 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java: ## @@ -458,156 +476,148 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final CsvPreference csvPref = getPreference(context, flowFile); final boolean header = context.getProperty(HEADER).asBoolean(); final ComponentLog logger = getLogger(); -final String schema = context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue(); -final CellProcessor[] cellProcs = this.parseSchema(schema); -final boolean isWholeFFValidation = context.getProperty(VALIDATION_STRATEGY).getValue().equals(VALIDATE_WHOLE_FLOWFILE.getValue()); +String schema = context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue(); Review Comment: Good point though instead of modifying it couldn't you just have `cellProcs = this.parseSchema(newSchema.substring(0, newSchema.length() - 1));` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
Freedom9339 commented on code in PR #8362:
URL: https://github.com/apache/nifi/pull/8362#discussion_r1480459517
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -458,156 +476,148 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final CsvPreference csvPref = getPreference(context, flowFile);
final boolean header = context.getProperty(HEADER).asBoolean();
final ComponentLog logger = getLogger();
-final String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
-final CellProcessor[] cellProcs = this.parseSchema(schema);
-final boolean isWholeFFValidation =
context.getProperty(VALIDATION_STRATEGY).getValue().equals(VALIDATE_WHOLE_FLOWFILE.getValue());
+String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
+CellProcessor[] cellProcs = null;
+if (schema != null) {
+cellProcs = this.parseSchema(schema);
+}
Review Comment:
cellProcs cannot be final because I modify it in line 520 if the schema was
null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
Freedom9339 commented on code in PR #8362: URL: https://github.com/apache/nifi/pull/8362#discussion_r1480457085 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java: ## @@ -458,156 +476,148 @@ public void onTrigger(final ProcessContext context, final ProcessSession session final CsvPreference csvPref = getPreference(context, flowFile); final boolean header = context.getProperty(HEADER).asBoolean(); final ComponentLog logger = getLogger(); -final String schema = context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue(); -final CellProcessor[] cellProcs = this.parseSchema(schema); -final boolean isWholeFFValidation = context.getProperty(VALIDATION_STRATEGY).getValue().equals(VALIDATE_WHOLE_FLOWFILE.getValue()); +String schema = context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue(); Review Comment: The schema cannot be final because if it's null, I modify it in line 519. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
dan-s1 commented on code in PR #8362:
URL: https://github.com/apache/nifi/pull/8362#discussion_r1480382625
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -458,156 +476,148 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final CsvPreference csvPref = getPreference(context, flowFile);
final boolean header = context.getProperty(HEADER).asBoolean();
final ComponentLog logger = getLogger();
-final String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
-final CellProcessor[] cellProcs = this.parseSchema(schema);
-final boolean isWholeFFValidation =
context.getProperty(VALIDATION_STRATEGY).getValue().equals(VALIDATE_WHOLE_FLOWFILE.getValue());
+String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
+CellProcessor[] cellProcs = null;
+if (schema != null) {
+cellProcs = this.parseSchema(schema);
+}
Review Comment:
```suggestion
final CellProcessor[] cellProcs = schema != null ?
this.parseSchema(schema) : null;
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -458,156 +476,148 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final CsvPreference csvPref = getPreference(context, flowFile);
final boolean header = context.getProperty(HEADER).asBoolean();
final ComponentLog logger = getLogger();
-final String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
-final CellProcessor[] cellProcs = this.parseSchema(schema);
-final boolean isWholeFFValidation =
context.getProperty(VALIDATION_STRATEGY).getValue().equals(VALIDATE_WHOLE_FLOWFILE.getValue());
+String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
Review Comment:
```suggestion
final String schema =
context.getProperty(SCHEMA).evaluateAttributeExpressions(flowFile).getValue();
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java:
##
@@ -171,7 +174,16 @@ public class ValidateCsv extends AbstractProcessor {
.description("Strategy to apply when routing input files to output
relationships.")
.required(true)
.defaultValue(VALIDATE_WHOLE_FLOWFILE.getValue())
-.allowableValues(VALIDATE_LINES_INDIVIDUALLY,
VALIDATE_WHOLE_FLOWFILE)
+.allowableValues(VALIDATE_LINES_INDIVIDUALLY,
VALIDATE_WHOLE_FLOWFILE, VALIDATE_ATTRIBUTE_AS_CSV)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor VALIDATION_ATTRIBUTE = new
PropertyDescriptor.Builder()
+.name("validate-csv-attribute")
+.displayName("Validation attribute")
Review Comment:
```suggestion
.name("Validation Attribute")
.displayName("Validation Attribute")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
Freedom9339 commented on PR #8362: URL: https://github.com/apache/nifi/pull/8362#issuecomment-1930514574 @pvillard31 The ValidateRecord processor splits the input FlowFile into 2 Flowfiles, one for valid and another for invalid records. With the change to ValidateCSV, the whole file will be routed to either valid or invalid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12710: Allow for microsecond precision timestamps when pushing t… [nifi]
markap14 commented on PR #8332: URL: https://github.com/apache/nifi/pull/8332#issuecomment-1930511688 Thanks for the review @exceptionfactory @dan-s1 . Agreed, the tests needed some cleanup. I actually simplified them significantly by just avoiding the use of the current time and trying to manipulate it into the format desired and instead just create predefined timestamps. This is simpler, cleaner, and far less error prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] nifi-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
pvillard31 commented on PR #8362: URL: https://github.com/apache/nifi/pull/8362#issuecomment-1930475648 Any reason for not using ValidateRecord processor if the only requirement is to confirm that the data is valid CSV without any specific constraint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12734: Import from Registry [nifi]
mcgilman commented on PR #8354: URL: https://github.com/apache/nifi/pull/8354#issuecomment-1930455729 > Current Nifi has a tooltip on the "Keep Existing Paramter Contexts" option: Thank you for raising this one. We have a line item in NIFI-12400 for introducing info icons though out the application. There are some considerations for placement depending on the usage that we'll need to be established. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12734: Import from Registry [nifi]
mcgilman commented on PR #8354: URL: https://github.com/apache/nifi/pull/8354#issuecomment-1930452534 > Should I be able to stop version control or change version? Not in this PR. This PR is focused on the Import use case. There are line items for the remaining version control use cases in NIFI-12400. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12734: Import from Registry [nifi]
mcgilman commented on PR #8354: URL: https://github.com/apache/nifi/pull/8354#issuecomment-1930450441 > So I am not sure what the correct UX is here... I'll update this PR to render the form validation error to make the situation more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12734: Import from Registry [nifi]
scottyaslan commented on code in PR #8354:
URL: https://github.com/apache/nifi/pull/8354#discussion_r1480315690
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/new-canvas-item.component.scss:
##
@@ -15,23 +15,24 @@
* limitations under the License.
*/
-.icon {
-font-size: 32px;
+.new-canvas-item {
Review Comment:
OK makes sense and LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12747) BUG - incorrect theming references
[ https://issues.apache.org/jira/browse/NIFI-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12747: --- Status: Patch Available (was: In Progress) > BUG - incorrect theming references > -- > > Key: NIFI-12747 > URL: https://issues.apache.org/jira/browse/NIFI-12747 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-12747] correct theming references [nifi]
scottyaslan opened a new pull request, #8364: URL: https://github.com/apache/nifi/pull/8364 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12747) BUG - incorrect theming references
Scott Aslan created NIFI-12747: -- Summary: BUG - incorrect theming references Key: NIFI-12747 URL: https://issues.apache.org/jira/browse/NIFI-12747 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12659: Refactored so that when a Python Process dies, NiFi will … [nifi]
markap14 opened a new pull request, #8363: URL: https://github.com/apache/nifi/pull/8363 …detect this, respawn the process, recreate the Processors that exist in the process, re-initialize them, and restart them. In testing, found the PythonControllerInteractionIT had bugs that were causing Python Processors to be re-initialized many times; this resulted in threading issues that caused processors to be invalid, indicating that property descriptors didn't exist, etc. Addressed these concerns in the same commit, since they were necessary to properly run tests # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] nifi-12674 Modified ValidateCSV to make the schema optional if a head… [nifi]
Freedom9339 opened a new pull request, #8362: URL: https://github.com/apache/nifi/pull/8362 …er is provided. Added validate on attribute option. # Summary [NIFI-12674](https://issues.apache.org/jira/browse/NIFI-12674) Made the schema optional for the ValidateCSV processor if a header is provided. In this case, only the structure of the CSV will validated, using the header to determine how many fields each line should have. Additionally, a new validation strategy was implemented, Validate on Attribute. This works similar to the way ValidateXML works in which the value of a given attribute of a FlowFile will be treated as the contents of a CSV file. Validation will be done on that attribute and not on the content of the FlowFile. I would also like to note that I made the stream a variable that can be assigned to either the FlowFile content or the value of the attribute. In doing this, I removed the need for an inner method, and thus all of the variables that previously needed to be Atomic References could now be regular variables. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [X] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12743) Property Table Fixes
[ https://issues.apache.org/jira/browse/NIFI-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12743: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Property Table Fixes > > > Key: NIFI-12743 > URL: https://issues.apache.org/jira/browse/NIFI-12743 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > 1) Enter should save the Property. Shift-Enter should insert a new line. > 2) Currently, it is not possible to delete a Property and add a new one with > the same name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12743: Property Table Fixes [nifi]
rfellows merged PR #8358: URL: https://github.com/apache/nifi/pull/8358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12743) Property Table Fixes
[ https://issues.apache.org/jira/browse/NIFI-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814874#comment-17814874 ] ASF subversion and git services commented on NIFI-12743: Commit 91f339bf0f24ca376d4273da8f1d6652d747ac22 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=91f339bf0f ] NIFI-12743: (#8358) - Updating property editing so that Shift-Enter inserts a new line and Enter commits the edit. - Fixing bug that prevented deleting a Property and then re-adding a new Property with the same name. This closes #8358 > Property Table Fixes > > > Key: NIFI-12743 > URL: https://issues.apache.org/jira/browse/NIFI-12743 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > 1) Enter should save the Property. Shift-Enter should insert a new line. > 2) Currently, it is not possible to delete a Property and add a new one with > the same name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12745) AvroReader silently drops record if it's malformed
[
https://issues.apache.org/jira/browse/NIFI-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajmund Takacs updated NIFI-12745:
--
Assignee: Rajmund Takacs
Status: Patch Available (was: Open)
> AvroReader silently drops record if it's malformed
> --
>
> Key: NIFI-12745
> URL: https://issues.apache.org/jira/browse/NIFI-12745
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 2.0.0-M2, 1.25.0, 1.23.2, 1.23.1, 1.24.0, 1.23.0,
> 1.22.0, 1.21.0, 1.19.1, 1.20.0, 1.19.0, 1.18.0, 2.0.0-M1
>Reporter: Rajmund Takacs
>Assignee: Rajmund Takacs
>Priority: Major
> Attachments: engesc_ValidateRecord_1.18.0.NiFi_Flow.json
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See the attached example flow. It reproduces the issue very reliably.
> {{GenerateFlowFile}} is set to generate the following Json:
> {code:json}
> [{
> "field_1" : 123456789,
> "field_2" : "44",
> "field_3" : 5
> }]
> {code}
> This input is converted to Avro format, using the {{ConvertRecord}}
> processor. The 'Schema Write Strategy' of {{AvroRecordSetWriter}} is set to
> anything different than 'Embed Avro Schema'.
> Then, the resulting FF is routed to a processor that uses an {{AvroReader}}
> to work on the records. The reader is set to use a predefined, fixed schema,
> which does not match with the input avro file, contains at least an extra
> field. It does not matter if that field has a default value or not.
> {code:json}
> {
> "type":"record",
> "name":"message_name",
> "namespace":"message_namespace",
> "fields":[
> {
> "name":"field_1",
> "type":["long"]
> },
> {
> "name":"field_2",
> "type":["string"]
> },
> {
> "name":"field_3",
> "type":["int"]
> },
> {
> "name":"extra_field",
> "type":["string"],
> "default":"empty"
> }
> ]
> }
> {code}
> When this processor consumes the input, the reader silently drops the record,
> without even making an error log message. At the processor level, this is
> equivalent to having no records to process, so nothing happens. The user
> won't notice that there is a misconfiguration somewhere until they start
> noticing the missing the flow files.
> The expected behavior from the processors would be to route the malformed
> input FF to their failure relationship, and shout an error on its bulletin.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12745: Fix AvroReader silently dropping malformed records [nifi]
takraj opened a new pull request, #8361: URL: https://github.com/apache/nifi/pull/8361 # Summary [NIFI-12745](https://issues.apache.org/jira/browse/NIFI-12745) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12746) BUG - Search closes when user attempts to put focus back in search box
[ https://issues.apache.org/jira/browse/NIFI-12746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12746: --- Attachment: Kapture 2024-02-06 at 10.29.59.gif > BUG - Search closes when user attempts to put focus back in search box > -- > > Key: NIFI-12746 > URL: https://issues.apache.org/jira/browse/NIFI-12746 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Priority: Major > Attachments: Kapture 2024-02-06 at 10.29.59.gif > > > If you search for something, then select a result, then attempt to place the > focus back in the search box to modify the search term, it closes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12746) BUG - Search closes when user attempts to put focus back in search box
Rob Fellows created NIFI-12746: -- Summary: BUG - Search closes when user attempts to put focus back in search box Key: NIFI-12746 URL: https://issues.apache.org/jira/browse/NIFI-12746 Project: Apache NiFi Issue Type: Sub-task Reporter: Rob Fellows If you search for something, then select a result, then attempt to place the focus back in the search box to modify the search term, it closes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12734: Import from Registry [nifi]
mcgilman commented on code in PR #8354:
URL: https://github.com/apache/nifi/pull/8354#discussion_r1479984109
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/header/new-canvas-item/new-canvas-item.component.scss:
##
@@ -15,23 +15,24 @@
* limitations under the License.
*/
-.icon {
-font-size: 32px;
+.new-canvas-item {
Review Comment:
This aligned the style structure from the scss partial. Since
`new-canvas-item` is the root element it should be functionally equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12739) Python custom processor cannot import ProcessPoolExecutor
[
https://issues.apache.org/jira/browse/NIFI-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Ethier updated NIFI-12739:
---
Status: Patch Available (was: In Progress)
> Python custom processor cannot import ProcessPoolExecutor
> -
>
> Key: NIFI-12739
> URL: https://issues.apache.org/jira/browse/NIFI-12739
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M2
>Reporter: Alex Ethier
>Assignee: Alex Ethier
>Priority: Major
>
> A runtime exception is thrown when trying to import ProcessPoolExecutor in a
> Python custom processor. This affects other libraries such as llama-index
> when it tries to import ProcessPoolExecutor.
> My system's full stack trace (see below for a simpler stack trace):
> {code:java}
> py4j.Py4JException: An exception was raised by the Python Proxy. Return
> Message: Traceback (most recent call last):
> File "/opt/nifi-2.0.0-SNAPSHOT/python/framework/py4j/java_gateway.py", line
> 2466, in _call_proxy
> return_value = getattr(self.pool[obj_id], method)(*params)
>^^^
> File "/opt/nifi-2.0.0-SNAPSHOT/./python/framework/Controller.py", line 75,
> in createProcessor
> processorClass = self.extensionManager.getProcessorClass(processorType,
> version, work_dir)
>
> ^
> File "/opt/nifi-2.0.0-SNAPSHOT/python/framework/ExtensionManager.py", line
> 104, in getProcessorClass
> processor_class = self.__load_extension_module(module_file,
> details.local_dependencies)
>
> ^
> File "/opt/nifi-2.0.0-SNAPSHOT/python/framework/ExtensionManager.py", line
> 360, in __load_extension_module
> module_spec.loader.exec_module(module)
> File "", line 940, in exec_module
> File "", line 241, in _call_with_frames_removed
> File
> "/Users/aethier/playground/the_source/datavolo/datavolo-resources/demo/advanced_rag_small_to_big/processors/RedisVectorStoreProcessor.py",
> line 4, in
> from llama_index import GPTVectorStoreIndex, StorageContext,
> ServiceContext, Document
> File
> "/opt/nifi-2.0.0-SNAPSHOT/./work/python/extensions/RedisVectorStoreProcessor/2.0.0-M1/llama_index/__init__.py",
> line 24, in
> from llama_index.indices import (
> File
> "/opt/nifi-2.0.0-SNAPSHOT/./work/python/extensions/RedisVectorStoreProcessor/2.0.0-M1/llama_index/indices/__init__.py",
> line 4, in
> from llama_index.indices.composability.graph import ComposableGraph
> File
> "/opt/nifi-2.0.0-SNAPSHOT/./work/python/extensions/RedisVectorStoreProcessor/2.0.0-M1/llama_index/indices/composability/__init__.py",
> line 4, in
> from llama_index.indices.composability.graph import ComposableGraph
> File
> "/opt/nifi-2.0.0-SNAPSHOT/./work/python/extensions/RedisVectorStoreProcessor/2.0.0-M1/llama_index/indices/composability/graph.py",
> line 7, in
> from llama_index.indices.base import BaseIndex
> File
> "/opt/nifi-2.0.0-SNAPSHOT/./work/python/extensions/RedisVectorStoreProcessor/2.0.0-M1/llama_index/indices/base.py",
> line 10, in
> from llama_index.ingestion import run_transformations
> File
> "/opt/nifi-2.0.0-SNAPSHOT/./work/python/extensions/RedisVectorStoreProcessor/2.0.0-M1/llama_index/ingestion/__init__.py",
> line 2, in
> from llama_index.ingestion.pipeline import (
> File
> "/opt/nifi-2.0.0-SNAPSHOT/./work/python/extensions/RedisVectorStoreProcessor/2.0.0-M1/llama_index/ingestion/pipeline.py",
> line 5, in
> from concurrent.futures import ProcessPoolExecutor
> File "", line 1229, in _handle_fromlist
> File
> "/opt/homebrew/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/__init__.py",
> line 44, in __getattr__
> from .process import ProcessPoolExecutor as pe
> File
> "/opt/homebrew/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/process.py",
> line 106, in
> threading._register_atexit(_python_exit)
> File
> "/opt/homebrew/Cellar/python@3.11/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/threading.py",
> line 1527, in _register_atexit
> raise RuntimeError("can't register atexit after shutdown")
> RuntimeError: can't register atexit after shutdown
> at py4j.Protocol.getReturnValue(Protocol.java:476)
> at
> org.apache.nifi.py4j.client.PythonProxyInvocationHandler.invoke(PythonProxyInvocationHandler.java:64)
> at jdk.proxy8/jdk.proxy8.$Proxy95.createProcessor(Unknown Source)
> at
>
[jira] [Updated] (NIFI-12732) ListS3 should reset its tracking state after configuration change
[
https://issues.apache.org/jira/browse/NIFI-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Palfy updated NIFI-12732:
---
Fix Version/s: 2.0.0
1.26.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> ListS3 should reset its tracking state after configuration change
> -
>
> Key: NIFI-12732
> URL: https://issues.apache.org/jira/browse/NIFI-12732
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Fix For: 2.0.0, 1.26.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {{List}} processors can reset their listing tracking state (stored in the
> component state or in a distributed cache depending on the {{{}Listing
> Strategy{}}}) when a relevant property has been modified (e.g. the directory
> to list). The functionality was implemented in {{{}AbstractListProcessor{}}},
> the child processors only need to provide the property list when the reset
> should occur.
> {{ListS3}} is not a child of {{AbstractListProcessor}} and the listing logic
> was implemented separately. The reset function is missing in the processor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-12674) Modify ValidateCSV to make schema optional
[ https://issues.apache.org/jira/browse/NIFI-12674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reynaldo Rea reassigned NIFI-12674: --- Assignee: Reynaldo Rea > Modify ValidateCSV to make schema optional > -- > > Key: NIFI-12674 > URL: https://issues.apache.org/jira/browse/NIFI-12674 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Reynaldo Rea >Assignee: Reynaldo Rea >Priority: Minor > > The schema for ValidateCSV should be optional. Whenever a schema is not > supplied, the processor should only validate the structural consistency of > the CSV using the header. > In addition, the processor will be given the ability to validate against a > given attribute. The value for the given attribute will be treated as CSV > text and validation will be done to that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479952728
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.questdb.embedded;
+
+import org.apache.commons.lang3.SystemUtils;
+import org.apache.nifi.questdb.Client;
+import org.apache.nifi.questdb.DatabaseException;
+import org.apache.nifi.questdb.DatabaseManager;
+import org.apache.nifi.questdb.mapping.RequestMapping;
+import org.apache.nifi.questdb.rollover.RolloverStrategy;
+import org.apache.nifi.questdb.util.Event;
+import org.apache.nifi.questdb.util.QuestDbTestUtil;
+import org.apache.nifi.util.file.FileUtils;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.time.Instant;
+import java.time.temporal.ChronoUnit;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.stream.StreamSupport;
+
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.CREATE_EVENT2_TABLE;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.CREATE_EVENT_TABLE;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.EVENT2_TABLE_NAME;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.EVENT_TABLE_NAME;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.SELECT_QUERY;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.getRandomTestData;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.getTestData;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertIterableEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class EmbeddedDatabaseManagerTest extends EmbeddedQuestDbTest {
+private static final Logger LOGGER =
LoggerFactory.getLogger(EmbeddedDatabaseManagerTest.class);
+private static final int DAYS_TO_KEEP_EVENT = 1;
+private static final String NON_EXISTING_PLACE = SystemUtils.IS_OS_WINDOWS
? "T:/nonExistingPlace" : "/nonExistingPlace";
+
+@Test
+public void testAcquiringWithoutInitialization() {
+final EmbeddedDatabaseManager testSubject = new
EmbeddedDatabaseManager(new SimpleEmbeddedDatabaseManagerContext());
+assertThrows(IllegalStateException.class, () ->
testSubject.acquireClient());
+}
+
+@Test
+public void testHappyPath() throws DatabaseException {
+final List testData = getTestData();
+final DatabaseManager testSubject = getTestSubject();
+assertDatabaseFolderIsNotEmpty();
+
+final Client client = testSubject.acquireClient();
+
+client.insert(EVENT_TABLE_NAME,
QuestDbTestUtil.getEventTableDataSource(testData));
+final List result = client.query(SELECT_QUERY,
RequestMapping.getResultProcessor(QuestDbTestUtil.EVENT_TABLE_REQUEST_MAPPING));
+
+assertIterableEquals(testData, result);
+
+testSubject.close();
+
+// Even if the client itself is not connected, manager prevents client
to reach database after closing
+assertFalse(client.query(SELECT_QUERY,
RequestMapping.getResultProcessor(QuestDbTestUtil.EVENT_TABLE_REQUEST_MAPPING)).iterator().hasNext());
+}
+
+@Test
+public void testRollover() throws DatabaseException, InterruptedException {
+final List testData = new ArrayList<>();
+testData.add(new Event(Instant.now().minus((DAYS_TO_KEEP_EVENT + 1),
ChronoUnit.DAYS), "A", 1));
+testData.add(new Event(Instant.now(), "B",
Re: [PR] NIFI-12732 Backport ListS3 resets its tracking state after configuration change [nifi]
tpalfy commented on PR #8360: URL: https://github.com/apache/nifi/pull/8360#issuecomment-1929917142 LGTM Thank you for your work @turcsanyip ! Merged to support/nifi-1.x. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12732 Backport ListS3 resets its tracking state after configuration change [nifi]
tpalfy closed pull request #8360: NIFI-12732 Backport ListS3 resets its tracking state after configuration change URL: https://github.com/apache/nifi/pull/8360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479945239
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.questdb.embedded;
+
+import org.apache.commons.lang3.SystemUtils;
+import org.apache.nifi.questdb.Client;
+import org.apache.nifi.questdb.DatabaseException;
+import org.apache.nifi.questdb.DatabaseManager;
+import org.apache.nifi.questdb.mapping.RequestMapping;
+import org.apache.nifi.questdb.rollover.RolloverStrategy;
+import org.apache.nifi.questdb.util.Event;
+import org.apache.nifi.questdb.util.QuestDbTestUtil;
+import org.apache.nifi.util.file.FileUtils;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.Timeout;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.time.Instant;
+import java.time.temporal.ChronoUnit;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.stream.StreamSupport;
+
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.CREATE_EVENT2_TABLE;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.CREATE_EVENT_TABLE;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.EVENT2_TABLE_NAME;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.EVENT_TABLE_NAME;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.SELECT_QUERY;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.getRandomTestData;
+import static org.apache.nifi.questdb.util.QuestDbTestUtil.getTestData;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertIterableEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class EmbeddedDatabaseManagerTest extends EmbeddedQuestDbTest {
+private static final Logger LOGGER =
LoggerFactory.getLogger(EmbeddedDatabaseManagerTest.class);
+private static final int DAYS_TO_KEEP_EVENT = 1;
+private static final String NON_EXISTING_PLACE = SystemUtils.IS_OS_WINDOWS
? "T:/nonExistingPlace" : "/nonExistingPlace";
+
+@Test
+public void testAcquiringWithoutInitialization() {
+final EmbeddedDatabaseManager testSubject = new
EmbeddedDatabaseManager(new SimpleEmbeddedDatabaseManagerContext());
+assertThrows(IllegalStateException.class, () ->
testSubject.acquireClient());
+}
+
+@Test
+public void testHappyPath() throws DatabaseException {
+final List testData = getTestData();
+final DatabaseManager testSubject = getTestSubject();
+assertDatabaseFolderIsNotEmpty();
+
+final Client client = testSubject.acquireClient();
+
+client.insert(EVENT_TABLE_NAME,
QuestDbTestUtil.getEventTableDataSource(testData));
+final List result = client.query(SELECT_QUERY,
RequestMapping.getResultProcessor(QuestDbTestUtil.EVENT_TABLE_REQUEST_MAPPING));
+
+assertIterableEquals(testData, result);
+
+testSubject.close();
+
+// Even if the client itself is not connected, manager prevents client
to reach database after closing
+assertFalse(client.query(SELECT_QUERY,
RequestMapping.getResultProcessor(QuestDbTestUtil.EVENT_TABLE_REQUEST_MAPPING)).iterator().hasNext());
+}
+
+@Test
+public void testRollover() throws DatabaseException, InterruptedException {
+final List testData = new ArrayList<>();
+testData.add(new Event(Instant.now().minus((DAYS_TO_KEEP_EVENT + 1),
ChronoUnit.DAYS), "A", 1));
+testData.add(new Event(Instant.now(), "B",
[jira] [Commented] (NIFI-12732) ListS3 should reset its tracking state after configuration change
[
https://issues.apache.org/jira/browse/NIFI-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814844#comment-17814844
]
ASF subversion and git services commented on NIFI-12732:
Commit 47c41ba8d72d3f3494d42f6d4c32da53fc009a7b in nifi's branch
refs/heads/support/nifi-1.x from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=47c41ba8d7 ]
NIFI-12732 ListS3 resets its tracking state after configuration change
This closes #8360.
Signed-off-by: Tamas Palfy
> ListS3 should reset its tracking state after configuration change
> -
>
> Key: NIFI-12732
> URL: https://issues.apache.org/jira/browse/NIFI-12732
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{List}} processors can reset their listing tracking state (stored in the
> component state or in a distributed cache depending on the {{{}Listing
> Strategy{}}}) when a relevant property has been modified (e.g. the directory
> to list). The functionality was implemented in {{{}AbstractListProcessor{}}},
> the child processors only need to provide the property list when the reset
> should occur.
> {{ListS3}} is not a child of {{AbstractListProcessor}} and the listing logic
> was implemented separately. The reset function is missing in the processor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12745) AvroReader silently drops record if it's malformed
Rajmund Takacs created NIFI-12745:
-
Summary: AvroReader silently drops record if it's malformed
Key: NIFI-12745
URL: https://issues.apache.org/jira/browse/NIFI-12745
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Affects Versions: 2.0.0-M2, 1.25.0, 1.23.2, 1.23.1, 1.24.0, 1.23.0, 1.22.0,
1.21.0, 1.19.1, 1.20.0, 1.19.0, 1.18.0, 2.0.0-M1
Reporter: Rajmund Takacs
Attachments: engesc_ValidateRecord_1.18.0.NiFi_Flow.json
See the attached example flow. It reproduces the issue very reliably.
{{GenerateFlowFile}} is set to generate the following Json:
{code:json}
[{
"field_1" : 123456789,
"field_2" : "44",
"field_3" : 5
}]
{code}
This input is converted to Avro format, using the {{ConvertRecord}} processor.
The 'Schema Write Strategy' of {{AvroRecordSetWriter}} is set to anything
different than 'Embed Avro Schema'.
Then, the resulting FF is routed to a processor that uses an {{AvroReader}} to
work on the records. The reader is set to use a predefined, fixed schema, which
does not match with the input avro file, contains at least an extra field. It
does not matter if that field has a default value or not.
{code:json}
{
"type":"record",
"name":"message_name",
"namespace":"message_namespace",
"fields":[
{
"name":"field_1",
"type":["long"]
},
{
"name":"field_2",
"type":["string"]
},
{
"name":"field_3",
"type":["int"]
},
{
"name":"extra_field",
"type":["string"],
"default":"empty"
}
]
}
{code}
When this processor consumes the input, the reader silently drops the record,
without even making an error log message. At the processor level, this is
equivalent to having no records to process, so nothing happens. The user won't
notice that there is a misconfiguration somewhere until they start noticing the
missing the flow files.
The expected behavior from the processors would be to route the malformed input
FF to their failure relationship, and shout an error on its bulletin.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12732 ListS3 resets its tracking state after configuration change [nifi]
tpalfy commented on PR #8348: URL: https://github.com/apache/nifi/pull/8348#issuecomment-1929817412 LGTM Thank you for your work @turcsanyip and for your review @mark-bathori ! Merged into main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12732) ListS3 should reset its tracking state after configuration change
[
https://issues.apache.org/jira/browse/NIFI-12732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814831#comment-17814831
]
ASF subversion and git services commented on NIFI-12732:
Commit 8f63e928a9d1ed5c3bf90ebf9766b5fcf4655e46 in nifi's branch
refs/heads/main from Peter Turcsanyi
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8f63e928a9 ]
NIFI-12732 ListS3 resets its tracking state after configuration change
This closes #8348.
Signed-off-by: Tamas Palfy
> ListS3 should reset its tracking state after configuration change
> -
>
> Key: NIFI-12732
> URL: https://issues.apache.org/jira/browse/NIFI-12732
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{List}} processors can reset their listing tracking state (stored in the
> component state or in a distributed cache depending on the {{{}Listing
> Strategy{}}}) when a relevant property has been modified (e.g. the directory
> to list). The functionality was implemented in {{{}AbstractListProcessor{}}},
> the child processors only need to provide the property list when the reset
> should occur.
> {{ListS3}} is not a child of {{AbstractListProcessor}} and the listing logic
> was implemented separately. The reset function is missing in the processor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12732 ListS3 resets its tracking state after configuration change [nifi]
asfgit closed pull request #8348: NIFI-12732 ListS3 resets its tracking state after configuration change URL: https://github.com/apache/nifi/pull/8348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479876942
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.questdb.embedded;
+
+import io.questdb.cairo.CairoConfiguration;
+import io.questdb.cairo.CairoEngine;
+import io.questdb.cairo.DefaultCairoConfiguration;
+import io.questdb.cairo.TableToken;
+import io.questdb.cairo.sql.TableRecordMetadata;
+import org.apache.commons.lang3.concurrent.BasicThreadFactory;
+import org.apache.nifi.questdb.Client;
+import org.apache.nifi.questdb.DatabaseException;
+import org.apache.nifi.questdb.DatabaseManager;
+import org.apache.nifi.util.file.FileUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.UUID;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.concurrent.locks.ReadWriteLock;
+import java.util.concurrent.locks.ReentrantReadWriteLock;
+import java.util.stream.Collectors;
+
+final class EmbeddedDatabaseManager implements DatabaseManager {
+private static final Logger LOGGER =
LoggerFactory.getLogger(EmbeddedDatabaseManager.class);
+
+private final String id = UUID.randomUUID().toString();
+private final AtomicReference state = new
AtomicReference(EmbeddedDatabaseManagerStatus.UNINITIALIZED);
+private final ReadWriteLock databaseStructureLock = new
ReentrantReadWriteLock();
+private final EmbeddedDatabaseManagerContext context;
+private final AtomicReference engine = new
AtomicReference<>();
+private final List> scheduledFutures = new
ArrayList<>();
+private final ScheduledExecutorService scheduledExecutorService = Executors
+.newScheduledThreadPool(2, new
BasicThreadFactory.Builder().namingPattern("EmbeddedQuestDbManagerWorker-" + id
+ "-%d").build());
+
+EmbeddedDatabaseManager(final EmbeddedDatabaseManagerContext context) {
+this.context = context;
+}
+
+@Override
+public void init() {
+if (state.get() != EmbeddedDatabaseManagerStatus.UNINITIALIZED) {
+throw new IllegalStateException("Manager is already initialized");
+}
+
+ensureDatabaseIsReady();
+startRollover();
+}
+
+private void ensureDatabaseIsReady() {
+boolean successful = false;
+
+try {
+databaseStructureLock.writeLock().lock();
+state.set(EmbeddedDatabaseManagerStatus.REPAIRING);
+
+try {
+ensurePersistLocationIsAccessible();
+ensureConnectionEstablished();
+ensureTablesAreInPlaceAndHealthy();
+successful = true;
+} catch (final CorruptedDatabaseException e) {
+boolean couldMoveOldToBackup = false;
+
+try {
+LOGGER.error("Database is corrupted. Recreation is
triggered. Manager tries to move corrupted database files to the backup
location: {}", context.getBackupLocation(), e);
+final File backupFolder = new
File(context.getBackupLocationAsPath().toFile(), "backup_" +
System.currentTimeMillis());
+
FileUtils.ensureDirectoryExistAndCanAccess(context.getBackupLocationAsPath().toFile());
+Files.move(context.getPersistLocationAsPath(),
backupFolder.toPath());
+couldMoveOldToBackup = true;
+} catch (IOException ex) {
+LOGGER.error("Could not create backup", ex);
+}
+
+if (!couldMoveOldToBackup) {
+try {
+
FileUtils.deleteFile(context.getPersistLocationAsPath().toFile(), true);
+
[jira] [Assigned] (MINIFICPP-2231) Avoid global CXX flags, especially -Werror
[ https://issues.apache.org/jira/browse/MINIFICPP-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2231: Assignee: Gábor Gyimesi > Avoid global CXX flags, especially -Werror > -- > > Key: MINIFICPP-2231 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2231 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Major > > We should only set compiler flags on our own targets, not globally. All > FetchContent dependencies inherit our global settings, but we don't want to > compile our dependencies with Werror enabled. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12737: Removing all transitions when updating the Canvas transform [nifi]
rfellows commented on PR #8355: URL: https://github.com/apache/nifi/pull/8355#issuecomment-1929576279 Reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12723) Remainder of Settings, Bulletins, Counters - General error handling in API responses
[ https://issues.apache.org/jira/browse/NIFI-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814798#comment-17814798 ] ASF subversion and git services commented on NIFI-12723: Commit 82c7cf65b513c3a6cf2978ab7a4a17108e2e68fe in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=82c7cf65b5 ] NIFI-12723: Error Handling in Settings, Bulletin Board, and Counters (#8349) * NIFI-12723: - Error handling in General and Flow Analysis Rules. - Fixed saving flag in management Controller Service listing. * NIFI-12723: - Error handling in Reporting Tasks and Registry Clients. * NIFI-12723: - Error handling in Bulletin Board. * NIFI-12723: - Error handling in Counters. * NIFI-12723: - Fixing lint issues. * NIFI-12723: - Addressing review feedback. This closes #8349 > Remainder of Settings, Bulletins, Counters - General error handling in API > responses > > > Key: NIFI-12723 > URL: https://issues.apache.org/jira/browse/NIFI-12723 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Introduce error handling in the remainder of the tabs in the settings pages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12723) Remainder of Settings, Bulletins, Counters - General error handling in API responses
[ https://issues.apache.org/jira/browse/NIFI-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12723: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Remainder of Settings, Bulletins, Counters - General error handling in API > responses > > > Key: NIFI-12723 > URL: https://issues.apache.org/jira/browse/NIFI-12723 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Introduce error handling in the remainder of the tabs in the settings pages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12723: Error Handling in Settings, Bulletin Board, and Counters [nifi]
rfellows merged PR #8349: URL: https://github.com/apache/nifi/pull/8349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]
szaszm commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1929456214 I tried running this on windows 10, in a VS2022 developer command prompt. It prompted me to install the vs2022 build tools, which shouldn't be necessary with a full VS installation, and failed to run when I answered with no.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12744) Solr processors do not work with Nifi 2 M2
[
https://issues.apache.org/jira/browse/NIFI-12744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Koch updated NIFI-12744:
Description:
*steps to reproduce*
* we launched Nifi in Docker
* build the nar file for nifi-solr-processor
* deploy the nar file to nifi
* Configure Query Solr Processor for cloude
* execute query
{code:java}
// code placeholder2024-02-06 08:47:28,886 ERROR [Timer-Driven Process
Thread-4] o.apache.nifi.processors.solr.QuerySolr
QuerySolr[id=7d932b59-018d-1000-404a-2744f73f9f8c] Failed to properly
initialize Processor. If still scheduled to run, NiFi will attempt to
initialize and run the Processor again after the 'Administrative Yield
Duration' has elapsed. Failure is due to
java.lang.IncompatibleClassChangeError: class
org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has interface
org.eclipse.jetty.util.Pool as super class
java.lang.IncompatibleClassChangeError: class
org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has interface
org.eclipse.jetty.util.Pool as super class at
java.base/java.lang.ClassLoader.defineClass1(Native Method) at
java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
at
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427) at
java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421) at
java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
at
java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420) at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593) at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) at
org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:148)
at
org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:95)
at
org.eclipse.jetty.io.MappedByteBufferPool$Retained.(MappedByteBufferPool.java:317)
at
org.eclipse.jetty.io.MappedByteBufferPool.newRetainableByteBufferPool(MappedByteBufferPool.java:140)
at
org.eclipse.jetty.io.AbstractByteBufferPool.(AbstractByteBufferPool.java:68)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:133)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:89)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:77)
at org.eclipse.jetty.client.HttpClient.doStart(HttpClient.java:206)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at
org.apache.solr.client.solrj.impl.Http2SolrClient.createHttpClient(Http2SolrClient.java:288)
at
org.apache.solr.client.solrj.impl.Http2SolrClient.(Http2SolrClient.java:180)
at
org.apache.solr.client.solrj.impl.Http2SolrClient$Builder.build(Http2SolrClient.java:1099)
at
org.apache.nifi.processors.solr.SolrUtils.createSolrClient(SolrUtils.java:201)
at
org.apache.nifi.processors.solr.SolrProcessor.createSolrClient(SolrProcessor.java:153)
at
org.apache.nifi.processors.solr.SolrProcessor.onScheduled(SolrProcessor.java:79)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
at
org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
{code}
* jetty-io.jar from the nifi-solr-processors (version 10.0.18) is used but
jetty-util. form the jetty-bundle (version 12.0.5) is used.
was:
*steps to reproduce*
* we launched Nifi in Docker
* build the nar file for
[jira] [Updated] (NIFI-12744) Solr processors do not work with Nifi 2 M2
[
https://issues.apache.org/jira/browse/NIFI-12744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Koch updated NIFI-12744:
Description:
*steps to reproduce*
* we launched Nifi in Docker
* build the nar file for nifi-solr-processor
* deploy the nar file to nifi
* Configure Query Solr Processor for cloude
* execute query
{code:java}
// code placeholder
{code}
2024-02-06 08:47:28,886 ERROR [Timer-Driven Process Thread-4]
o.apache.nifi.processors.solr.QuerySolr
QuerySolr[id=7d932b59-018d-1000-404a-2744f73f9f8c] Failed to properly
initialize Processor. If still scheduled to run, NiFi will attempt to
initialize and run the Processor again after the 'Administrative Yield
Duration' has elapsed. Failure is due to
java.lang.IncompatibleClassChangeError: class
org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has interface
org.eclipse.jetty.util.Pool as super class
java.lang.IncompatibleClassChangeError: class
org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has interface
org.eclipse.jetty.util.Pool as super class at
java.base/java.lang.ClassLoader.defineClass1(Native Method) at
java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
at
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427) at
java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421) at
java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
at
java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420) at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593) at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) at
org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:148)
at
org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:95)
at
org.eclipse.jetty.io.MappedByteBufferPool$Retained.(MappedByteBufferPool.java:317)
at
org.eclipse.jetty.io.MappedByteBufferPool.newRetainableByteBufferPool(MappedByteBufferPool.java:140)
at
org.eclipse.jetty.io.AbstractByteBufferPool.(AbstractByteBufferPool.java:68)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:133)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:89)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:77)
at org.eclipse.jetty.client.HttpClient.doStart(HttpClient.java:206)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at
org.apache.solr.client.solrj.impl.Http2SolrClient.createHttpClient(Http2SolrClient.java:288)
at
org.apache.solr.client.solrj.impl.Http2SolrClient.(Http2SolrClient.java:180)
at
org.apache.solr.client.solrj.impl.Http2SolrClient$Builder.build(Http2SolrClient.java:1099)
at
org.apache.nifi.processors.solr.SolrUtils.createSolrClient(SolrUtils.java:201)
at
org.apache.nifi.processors.solr.SolrProcessor.createSolrClient(SolrProcessor.java:153)
at
org.apache.nifi.processors.solr.SolrProcessor.onScheduled(SolrProcessor.java:79)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
at
org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
> Solr processors do not work with Nifi 2 M2
> --
>
> Key: NIFI-12744
> URL: https://issues.apache.org/jira/browse/NIFI-12744
> Project: Apache NiFi
>
[jira] [Updated] (NIFI-12744) Solr processors do not work with Nifi 2 M2
[
https://issues.apache.org/jira/browse/NIFI-12744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Koch updated NIFI-12744:
Description:
*steps to reproduce*
* we launched Nifi in Docker
* build the nar file for nifi-solr-processor
* deploy the nar file to nifi
* Configure Query Solr Processor for cloude
* execute query
{code:java}
// code placeholder2024-02-06 08:47:28,886 ERROR [Timer-Driven Process
Thread-4] o.apache.nifi.processors.solr.QuerySolr
QuerySolr[id=7d932b59-018d-1000-404a-2744f73f9f8c] Failed to properly
initialize Processor. If still scheduled to run, NiFi will attempt to
initialize and run the Processor again after the 'Administrative Yield
Duration' has elapsed. Failure is due to
java.lang.IncompatibleClassChangeError: class
org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has interface
org.eclipse.jetty.util.Pool as super class
java.lang.IncompatibleClassChangeError: class
org.eclipse.jetty.io.ArrayRetainableByteBufferPool$RetainedBucket has interface
org.eclipse.jetty.util.Pool as super class at
java.base/java.lang.ClassLoader.defineClass1(Native Method) at
java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027) at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
at
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427) at
java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421) at
java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
at
java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420) at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593) at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) at
org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:148)
at
org.eclipse.jetty.io.ArrayRetainableByteBufferPool.(ArrayRetainableByteBufferPool.java:95)
at
org.eclipse.jetty.io.MappedByteBufferPool$Retained.(MappedByteBufferPool.java:317)
at
org.eclipse.jetty.io.MappedByteBufferPool.newRetainableByteBufferPool(MappedByteBufferPool.java:140)
at
org.eclipse.jetty.io.AbstractByteBufferPool.(AbstractByteBufferPool.java:68)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:133)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:89)
at
org.eclipse.jetty.io.MappedByteBufferPool.(MappedByteBufferPool.java:77)
at org.eclipse.jetty.client.HttpClient.doStart(HttpClient.java:206)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at
org.apache.solr.client.solrj.impl.Http2SolrClient.createHttpClient(Http2SolrClient.java:288)
at
org.apache.solr.client.solrj.impl.Http2SolrClient.(Http2SolrClient.java:180)
at
org.apache.solr.client.solrj.impl.Http2SolrClient$Builder.build(Http2SolrClient.java:1099)
at
org.apache.nifi.processors.solr.SolrUtils.createSolrClient(SolrUtils.java:201)
at
org.apache.nifi.processors.solr.SolrProcessor.createSolrClient(SolrProcessor.java:153)
at
org.apache.nifi.processors.solr.SolrProcessor.onScheduled(SolrProcessor.java:79)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:145)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:133)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotations(ReflectionUtils.java:78)
at
org.apache.nifi.util.ReflectionUtils.invokeMethodsWithAnnotation(ReflectionUtils.java:55)
at
org.apache.nifi.controller.StandardProcessorNode.lambda$initiateStart$10(StandardProcessorNode.java:1668)
at org.apache.nifi.engine.FlowEngine$3.call(FlowEngine.java:123)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
{code}
2024-02-06 08:47:28,886 ERROR [Timer-Driven Process Thread-4]
o.apache.nifi.processors.solr.QuerySolr
QuerySolr[id=7d932b59-018d-1000-404a-2744f73f9f8c] Failed to properly
initialize Processor. If still scheduled to run, NiFi will
[jira] [Created] (NIFI-12744) Solr processors do not work with Nifi 2 M2
Andreas Koch created NIFI-12744: --- Summary: Solr processors do not work with Nifi 2 M2 Key: NIFI-12744 URL: https://issues.apache.org/jira/browse/NIFI-12744 Project: Apache NiFi Issue Type: Bug Reporter: Andreas Koch -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12732 Backport ListS3 resets its tracking state after configuration change [nifi]
turcsanyip opened a new pull request, #8360: URL: https://github.com/apache/nifi/pull/8360 # Summary [NIFI-12732](https://issues.apache.org/jira/browse/NIFI-12732) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12672) Implement Azure option for FileResourceService
[ https://issues.apache.org/jira/browse/NIFI-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balázs Gerner updated NIFI-12672: - Status: Patch Available (was: In Progress) > Implement Azure option for FileResourceService > -- > > Key: NIFI-12672 > URL: https://issues.apache.org/jira/browse/NIFI-12672 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Balázs Gerner >Assignee: Balázs Gerner >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Add Azure based implementation for the FileResourceService interface to be > able to fetch data directly from Azure storage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12672 Added AzureFileResourceService and ADLSFileResourceService [nifi]
balazsgerner opened a new pull request, #8359: URL: https://github.com/apache/nifi/pull/8359 # Summary [NIFI-12672](https://issues.apache.org/jira/browse/NIFI-12672) Implemented the **Azure Blob Storage** and **Azure Data Lake Storage (ADLS)** specific versions of `FileResourceService` to be able to fetch data directly from these services, by-passing the content repository. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12644) Exported json flows does not match minifi json schema
[ https://issues.apache.org/jira/browse/NIFI-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Premarajan reassigned NIFI-12644: -- Assignee: Ajay Premarajan > Exported json flows does not match minifi json schema > - > > Key: NIFI-12644 > URL: https://issues.apache.org/jira/browse/NIFI-12644 > Project: Apache NiFi > Issue Type: Bug > Components: MiNiFi >Affects Versions: 2.0.0-M1 >Reporter: Valiantsin Shukaila >Assignee: Ajay Premarajan >Priority: Major > Attachments: flow-exported-from-nifi2.json, > minifi-example-flow-from-tests.json > > > In documentation for Minifi java agent project it is mentioned that in order > to import process flow, now it is necessary to export nifi flow as json and > put it in minifi. here link to doc: > [https://github.com/apache/nifi/blob/main/minifi/minifi-docs/src/main/markdown/minifi-java-agent-quick-start.md] > But in fact the JSON formats compeltelly do not match. Minifi expect format > of legacy nifi flow templates just in JSON. But exported nifi flows is > something very much different. > Therefore it is not really possible to import flows from nifi-2.0 version to > minifi 2.0 version. > It is only possible to export template from nifi 1.2.x version and convert it > into json format for minifi-2.0 version. > for file differences please see attached files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12732 ListS3 resets its tracking state after configuration change [nifi]
turcsanyip commented on PR #8348: URL: https://github.com/apache/nifi/pull/8348#issuecomment-1929140145 @mark-bathori @tpalfy Thanks for your review comments! Updated the PR based on your recommendations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2278 Add dynamic relationship support for python processors [nifi-minifi-cpp]
lordgamez opened a new pull request, #1722: URL: https://github.com/apache/nifi-minifi-cpp/pull/1722 https://issues.apache.org/jira/browse/MINIFICPP-2278 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2295) Support controller services when using NiFi Python processors
Gábor Gyimesi created MINIFICPP-2295: Summary: Support controller services when using NiFi Python processors Key: MINIFICPP-2295 URL: https://issues.apache.org/jira/browse/MINIFICPP-2295 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Gábor Gyimesi NiFi python processors support controller service properties, that can be retrieved using context.getProperty().asControllerService() and used in the processor. Although MiNiFi does not have all controller services that NiFi has, we should support the same syntax for the controllers that are available in MiNiFi C++ as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
