[jira] [Commented] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout
[
https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830121#comment-17830121
]
Peter Turcsanyi commented on NIFI-12895:
[~andersns] Thanks for your suggestion! Yes, it was that easy to add the
property.
> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --
>
> Key: NIFI-12895
> URL: https://issues.apache.org/jira/browse/NIFI-12895
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj
> library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can
> configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as
> well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and
> GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout
[
https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-12895:
---
Status: Patch Available (was: Open)
> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --
>
> Key: NIFI-12895
> URL: https://issues.apache.org/jira/browse/NIFI-12895
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 2.0.0-M2, 1.25.0
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj
> library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can
> configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as
> well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and
> GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout
[
https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-12895:
---
Affects Version/s: 2.0.0-M2
> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --
>
> Key: NIFI-12895
> URL: https://issues.apache.org/jira/browse/NIFI-12895
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.25.0, 2.0.0-M2
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj
> library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can
> configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as
> well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and
> GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout
[
https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-12895:
---
Priority: Minor (was: Major)
> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --
>
> Key: NIFI-12895
> URL: https://issues.apache.org/jira/browse/NIFI-12895
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj
> library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can
> configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as
> well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and
> GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout
[
https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-12895:
---
Issue Type: Improvement (was: Bug)
> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --
>
> Key: NIFI-12895
> URL: https://issues.apache.org/jira/browse/NIFI-12895
> Project: Apache NiFi
> Issue Type: Improvement
>Affects Versions: 1.25.0
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj
> library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can
> configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as
> well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and
> GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout
[
https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-12895:
---
Component/s: Extensions
> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --
>
> Key: NIFI-12895
> URL: https://issues.apache.org/jira/browse/NIFI-12895
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.25.0
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj
> library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can
> configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as
> well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and
> GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-12895) GetSmbFile and PutSmbFile has forced 5 sec timeout
[
https://issues.apache.org/jira/browse/NIFI-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi reassigned NIFI-12895:
--
Assignee: Peter Turcsanyi
> GetSmbFile and PutSmbFile has forced 5 sec timeout
> --
>
> Key: NIFI-12895
> URL: https://issues.apache.org/jira/browse/NIFI-12895
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.25.0
>Reporter: Anders
>Assignee: Peter Turcsanyi
>Priority: Major
>
> It seems like timeout was introduced with the SmbjClientProviderService, and
> SmbUtils.java defines the withTimeout setting from the underlying smbj
> library.
> In SmbProperties.java, the default timeout value is set to 5 sec and you can
> configure it in the SmbjClientProviderService.
> However, the older GetSmbFile and PutSmbFile processors uses SmbUtils.java as
> well, but the timeout configuration item is not exposed in their config ui.
> The timeout setting should be added to the UI for GetSmbFile and PutSmbFile.
> I think it's enough to add the following lines to PutSmbFile.java and
> GetSmbFile.java:
> {code}
> ...
> import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
> ...
> descriptors.add(TIMEOUT);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-12895 Added Timeout property to GetSmbFile and PutSmbFile [nifi]
turcsanyip opened a new pull request, #8551: URL: https://github.com/apache/nifi/pull/8551 # Summary [NIFI-12895](https://issues.apache.org/jira/browse/NIFI-12895) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check * Bulletin Board (NIFI-12560) ** When the bulletin board polls it is missing the offset "after" query parameter * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Load FlowConfiguration in guard * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx [1] [https://github.com/apache/nifi/pull/8053] was:
[jira] [Created] (NIFI-12937) Error Handling in Parameter Context Page
Matt Gilman created NIFI-12937: -- Summary: Error Handling in Parameter Context Page Key: NIFI-12937 URL: https://issues.apache.org/jira/browse/NIFI-12937 Project: Apache NiFi Issue Type: Sub-task Reporter: Matt Gilman Assignee: Matt Gilman -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2282 Support re-encryption of sensitive properties [nifi-minifi-cpp]
fgerlits commented on code in PR #1739:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1536612041
##
libminifi/include/core/json/JsonFlowSerializer.h:
##
@@ -26,12 +26,12 @@ class JsonFlowSerializer : public
core::flow::FlowSerializer {
explicit JsonFlowSerializer(rapidjson::Document document) :
flow_definition_json_(std::move(document)) {}
[[nodiscard]] std::string serialize(const core::ProcessGroup& process_group,
const core::flow::FlowSchema& schema, const utils::crypto::EncryptionProvider&
encryption_provider,
- const std::unordered_map>& overrides) const override;
+ const core::flow::Overrides& overrides) const override;
private:
void encryptSensitiveProperties(rapidjson::Value& property_jsons,
rapidjson::Document::AllocatorType& alloc,
const std::map& properties, const
utils::crypto::EncryptionProvider& encryption_provider,
- std::unordered_map component_overrides) const;
+ const core::flow::Overrides& overrides, const utils::Identifier&
component_id) const;
Review Comment:
fixed in dd8b12e336e34acbd33de3b7bc41c66431bd50ae
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
