[GitHub] nifi-minifi-cpp pull request #426: MINIFICPP-650 - Fix MiNiFi typos
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/426 MINIFICPP-650 - Fix MiNiFi typos Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-650 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/426.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #426 commit 3b90ea0eac4dad2b7adf39a0a9ab5833a669fdd6 Author: Dustin Rodrigues Date: 2018-10-21T23:47:18Z MINIFICPP-650 - Fix MiNiFi typos ---
[GitHub] nifi-minifi-cpp pull request #425: MINIFICPP-650 - Fix MiNiFi typos
Github user dtrodrigues closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/425 ---
[GitHub] nifi-minifi-cpp issue #425: MINIFICPP-650 - Fix MiNiFi typos
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/425 closing due to GitHub degradation, will re-open when webhooks are functional ---
[GitHub] nifi-minifi-cpp pull request #425: MINIFICPP-650 - Fix MiNiFi typos
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/425 MINIFICPP-650 - Fix MiNiFi typos Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-650 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/425.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #425 commit 4fa40e0d1579db3f36f8b93f39da5c9dc50cbc35 Author: Dustin Rodrigues Date: 2018-10-21T23:47:18Z MINIFICPP-650 - Fix MiNiFi typos ---
[GitHub] nifi-minifi pull request #135: MINIFI-469 - support OSX in travis automated ...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi/pull/135 MINIFI-469 - support OSX in travis automated builds Thank you for submitting a contribution to Apache NiFi - MiNiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi MINIFI-469 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi/pull/135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #135 commit b5d8739bb1729c5c4269f8dfda6c7b852ff7dfc3 Author: Dustin Rodrigues Date: 2018-08-01T10:56:58Z MINIFI-469 - support OSX in travis automated builds ---
[GitHub] nifi-minifi-cpp pull request #386: MINIFICPP-587 - fix typo in bstrp_functio...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/386 MINIFICPP-587 - fix typo in bstrp_functions.sh Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-587 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #386 commit c401be89b606e556f70222bb6c1577f4f0fefb95 Author: Dustin Rodrigues Date: 2018-08-01T04:13:13Z MINIFICPP-587 - fix typo in bstrp_functions.sh ---
[GitHub] nifi-minifi-cpp pull request #385: MINIFICPP-584 - update pybind to prevent ...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/385 MINIFICPP-584 - update pybind to prevent hang for Python3.7 on OSX Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-584 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #385 commit a28cbbc54de76e2180458fc726c6a56b67ea7101 Author: Dustin Rodrigues Date: 2018-08-01T03:01:53Z MINIFICPP-584 - update pybind to prevent hang for Python3.7 on OSX ---
[GitHub] nifi-minifi-cpp issue #360: MINIFICPP-427 - add PublishKafka headers support
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/360 I've pushed a commit which updates the README regarding the GCC version required and refactored the extension code slightly. I'm not sure of the best way to incorporate the GCC version requirement into the bootstrap script -- I'm not seeing how it enforces the appropriate compiler versions for Lua/bustache currently. ---
[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...
Github user dtrodrigues commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198361089 --- Diff: extensions/librdkafka/PublishKafka.h --- @@ -28,6 +28,7 @@ #include "core/Property.h" #include "core/logging/LoggerConfiguration.h" #include "rdkafka.h" +#include --- End diff -- I believe GCC prior to 4.9 didn't support C++11 regex. I'm leaning towards not supporting older compilers for this processor but can look into using regex.h instead if desired. ---
[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...
Github user dtrodrigues commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198360594
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -115,14 +121,35 @@ class PublishKafka: public core::Processor {
buffer.reserve(max_seg_size_);
read_size_ = 0;
status_ = 0;
+ rd_kafka_resp_err_t err;
+
+ for (auto kv : flowFile_->getAttributes()) {
+if (regex_match(kv.first, attributeNameRegex_)) {
+ if (!hdrs) {
+hdrs = rd_kafka_headers_new(8);
--- End diff --
8 was mostly arbitrary, I used the value from
https://github.com/edenhill/librdkafka/blob/master/examples/rdkafka_example.c#L416
since some value needed to be used. 0 is also an option but it looks like if 0
is chosen, any additions will grow the list to 16 elements. If a number besides
0 is chosen, when list runs out of room, the list is grown by 2*the list size.
---
[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...
Github user dtrodrigues commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198359374 --- Diff: extensions/librdkafka/PublishKafka.cpp --- @@ -262,7 +269,7 @@ void PublishKafka::onTrigger(const std::shared_ptr if (flowFile->getAttribute(KAFKA_KEY_ATTRIBUTE, value)) kafkaKey = value; - PublishKafka::ReadCallback callback(flowFile->getSize(), max_seg_size_, kafkaKey, rkt_); + PublishKafka::ReadCallback callback(flowFile->getSize(), max_seg_size_, kafkaKey, rkt_, rk_, flowFile, attributeNameRegex); --- End diff -- Now that we're sending the flowFile so we have access to the attributes, we don't need to send the size by itself anymore. I'll update this. ---
[GitHub] nifi-minifi-cpp pull request #366: MINIFICPP-546 - exit code of 0 for minifi...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/366 MINIFICPP-546 - exit code of 0 for minifi.sh status when process isn'⦠â¦t running Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-546 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/366.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #366 commit 2151a600b22ec92d23a1294db79a0f7aae070f54 Author: Dustin Rodrigues Date: 2018-06-27T03:00:57Z MINIFICPP-546 - exit code of 0 for minifi.sh status when process isn't running ---
[GitHub] nifi-minifi-cpp pull request #364: MINIFICPP-538 - only print error on actua...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/364 MINIFICPP-538 - only print error on actual error during shutdown, upd⦠â¦ate semaphore name Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-538 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/364.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #364 commit 79a6b4083d433b9f96ac0fa9484f020a50c158af Author: Dustin Rodrigues Date: 2018-06-24T17:30:02Z MINIFICPP-538 - only print error on actual error during shutdown, update semaphore name ---
[GitHub] nifi-minifi-cpp pull request #363: MINIFICPP-541 - fix openssl endif cmake w...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/363 MINIFICPP-541 - fix openssl endif cmake warning Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-541 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #363 commit 7146abee8bfe3798485715d9d02329f3314a3f8c Author: Dustin Rodrigues Date: 2018-06-24T14:30:22Z MINIFICPP-541 - fix openssl endif cmake warning ---
[GitHub] nifi-minifi-cpp pull request #362: MINIFICPP-540 - add issue tracker link to...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/362 MINIFICPP-540 - add issue tracker link to README.md Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-540 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit 91f4607a0edb60869e6036450f7f7d046528adbe Author: Dustin Rodrigues Date: 2018-06-21T01:22:16Z MINIFICPP-540 - add issue tracker link to README.md ---
[GitHub] nifi-minifi-cpp pull request #361: MINIFICPP-522 - more robust minifi.sh sto...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/361 MINIFICPP-522 - more robust minifi.sh stop command Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #361 commit 58a035dfff84704f9f93c0486af390f8f6650fb8 Author: Dustin Rodrigues Date: 2018-06-20T04:11:44Z MINIFICPP-522 - more robust minifi.sh stop command ---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2800 I updated the test X-Mailer header to be more explicit that it's non-ASCII ---
[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header
Github user dtrodrigues commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2800#discussion_r195935356
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java
---
@@ -137,7 +137,7 @@ public void testOutgoingMessage() throws Exception {
public void testOutgoingMessageWithOptionalProperties() throws
Exception {
// verifies that optional attributes are set on the outgoing
Message correctly
--- End diff --
The test is for the non-ascii accented 'i' here in the first 'i' of
"TestingNÃfi" on lines 140/167 as well as for the accented 'u' in "Búlk"
---
[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2800 Header setting is now refactored into a function and there are tests for non-ascii headers ---
[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi/pull/2800 NIFI-5317 - support non-ASCII X-Mailer header Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi NIFI-5317 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2800.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2800 commit 263413c37c0db84e3269aa2a0118c00b77226813 Author: Dustin Rodrigues Date: 2018-06-16T18:01:00Z NIFI-5317 - support non-ASCII X-Mailer header ---
[GitHub] nifi-minifi-cpp pull request #360: MINIFICPP-427 - add PublishKafka headers ...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/360 MINIFICPP-427 - add PublishKafka headers support Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-427 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/360.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #360 commit 7c4a8f2e5a4d1bb4335c0d46ca26e07e8b48f7a3 Author: Dustin Rodrigues Date: 2018-06-16T16:46:09Z MINIFICPP-427 - add PublishKafka headers support ---
[GitHub] nifi issue #2787: NIFI-5252 - support arbitrary headers in PutEmail processo...
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2787 moved regex compilation to when processor is scheduled and ensured header values are encoded appropriately ---
[GitHub] nifi pull request #2787: NIFI-5252 - support arbitrary headers in PutEmail p...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi/pull/2787 NIFI-5252 - support arbitrary headers in PutEmail processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi NIFI-5252 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2787.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2787 commit 250736cc14ffb6c44925fe606b5de67d7a53638a Author: Dustin Rodrigues Date: 2018-06-12T02:00:28Z NIFI-5252 - support arbitrary headers in PutEmail processor ---
[GitHub] nifi-minifi-cpp issue #345: MINIFICPP-512 - upgrade to librdkafka 0.11.4
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/345 @phrocker I've removed tests and windows directories and updated CMakeLists.txt in librdkafka to not build the examples or tests. ---
[GitHub] nifi-minifi-cpp pull request #345: MINIFICPP-512 - upgrade to librdkafka 0.1...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/345 MINIFICPP-512 - upgrade to librdkafka 0.11.4 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-512 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/345.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #345 commit 55e1f440d378595f1e59236e9d47f6dfbd315e75 Author: Dustin Rodrigues <dust.rod@...> Date: 2018-05-26T22:34:31Z MINIFICPP-512 - upgrade to librdkafka 0.11.4 ---
[GitHub] nifi-minifi-cpp pull request #240: MINIFICPP-313: correctly implement unique...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/240 MINIFICPP-313: correctly implement unique flowfiles param for GenerateFlowFile Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-313 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/240.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #240 commit 6ac3279d62e1e511d8a5b8f3cef149816510a31b Author: Dustin Rodrigues <dust.rod@...> Date: 2018-01-12T20:47:37Z MINIFICPP-313: correctly implement unique flowfiles param for GenerateFlowFile ---
[GitHub] nifi-minifi-cpp pull request #239: MINIFICPP-371: document Maximum File Coun...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/239 MINIFICPP-371: document Maximum File Count in PutFile processor Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-371 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #239 commit 44d1c8583d7161e40e1cbe14181d8a4d2229a758 Author: Dustin Rodrigues <dust.rod@...> Date: 2018-01-12T16:32:04Z MINIFICPP-371: document Maximum File Count in PutFile processor ---
[GitHub] nifi-minifi-cpp pull request #221: MINIFICPP-350: fix PutFile and Expression...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/221 MINIFICPP-350: fix PutFile and Expression compilation warnings Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-350 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #221 commit 0701e91c6e60f14c7b221b0471fc6d89eb11dcd5 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-12-16T02:41:34Z MINIFICPP-350: fix PutFile and Expression compilation warnings ---
[GitHub] nifi pull request #2316: NIFI-4657 update update dir-only in travis
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi/pull/2316 NIFI-4657 update update dir-only in travis Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi NIFI-4657 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2316.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2316 commit 306f5bd878d6d7ee9aee969eb3585f4a90a32ab8 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-12-04T22:47:11Z NIFI-4657 update update dir-only in travis ---
[GitHub] nifi-minifi-cpp issue #211: MINIFICPP-321: Support Maximum File Count in Put...
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/211 Fixed the `max_dest_files_` name. Also resolved file descriptor leak. The opendir pattern now matches what's currently in the GetFile and TailFile processors. ---
[GitHub] nifi-minifi-cpp pull request #211: MINIFICPP-321: Support Maximum File Count...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/211 MINIFICPP-321: Support Maximum File Count in PutFile Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-321 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #211 commit 155a45f35689a01036c80330f24dca2738bd08c0 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-29T03:18:11Z MINIFICPP-321: Support Maximum File Count in PutFile ---
[GitHub] nifi-minifi-cpp pull request #196: MINIFICPP-315 - allow plain b suffix on p...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/196 MINIFICPP-315 - allow plain b suffix on properties Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-315 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #196 commit 5e18e4f42112bd65aaecf65cb6c1434182addb87 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-18T22:04:25Z MINIFICPP-315 - allow plain b suffix on properties ---
[GitHub] nifi-minifi-cpp issue #195: MINIFICPP-307: Support text mode in GenerateFlow...
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/195 Linter issues should be fixed now ---
[GitHub] nifi-minifi-cpp pull request #195: MINIFICPP-307: Support text mode in Gener...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/195 MINIFICPP-307: Support text mode in GenerateFlowFile Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-307 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #195 commit 481c4268710fa92db21951a8393025e6e75c6b12 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-10-28T06:28:40Z remove unncessary Boost header dependency from core commit 431494fe24d29a77e06767af873f3dce0c97c435 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-10-29T22:52:33Z Merge branch 'MINIFICPP-271' commit f4766c6ee5e92020d847c9c599461fd9ec6f3d77 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-01T14:51:30Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 3572c044b131a096cfdfc2bbd270975701d80391 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-02T14:44:24Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 05708ce5681d8bc83d4740b3878ce6893fa43708 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-04T16:15:02Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 182cb5ce0a62a4d0ac479b40999eb44f45c47ccb Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-07T00:08:46Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 471b3889cfd0be97e0ca6b12637e4b0a236486d7 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-08T04:44:03Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit d8cfc9159df53013be2f3818e11ef6b315f9883e Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-09T00:46:29Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 0358c3a081cfbe7cc74b358d9332221e7435e757 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-09T17:06:12Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 209ec9f25a78fdf95a5bd0b70c5515ded56a747e Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-11T23:40:53Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 0a9bad9be0ea4b249cfb123f9f23a3b6af1917f1 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-14T12:52:41Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 11b2db6bd943e1124c2011515c88e674a317d6cd Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-15T02:53:08Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 068aa80bd9ea0e5700aabca6428056633e72664c Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-17T01:49:14Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 345bdf4e3390953876d9c0073aa418ec1ce37975 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-18T03:05:06Z Merge branch 'master' of https://github.com/apache/nifi-minifi-cpp commit 76e09c4be88ce5faefa060eb505a2405bebdf7bd Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-11-18T19:45:52Z MINIFICPP-307 - support text mode in GenerateFlowFile ---
[GitHub] nifi-minifi-cpp pull request #160: Minificpp 272
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/160 Minificpp 272 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-272 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit 481c4268710fa92db21951a8393025e6e75c6b12 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-10-28T06:28:40Z remove unncessary Boost header dependency from core commit 431494fe24d29a77e06767af873f3dce0c97c435 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-10-29T22:52:33Z Merge branch 'MINIFICPP-271' commit 67e70269ffceba00e447e910538bb1969b3c7a58 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-10-30T01:44:49Z MINIFICPP-272: fix Boost CMakeLists.txt ordering ---
[GitHub] nifi-minifi-cpp pull request #159: remove unncessary Boost header dependency...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/159 remove unncessary Boost header dependency from core Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-271 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/159.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #159 commit 481c4268710fa92db21951a8393025e6e75c6b12 Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-10-28T06:28:40Z remove unncessary Boost header dependency from core ---
[GitHub] nifi-minifi-cpp pull request #121: MINIFI-357 fixing PutFile bug that caused...
GitHub user dtrodrigues opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/121 MINIFI-357 fixing PutFile bug that caused all writes to fail Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dtrodrigues/nifi-minifi-cpp issue-357 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit 38857fb6782a0cecfb946c7e00d6e556f30fe63e Author: Dustin Rodrigues <dust@gmail.com> Date: 2017-07-30T07:44:44Z MINIFI-357 fixing PutFile bug that caused all writes to fail --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp pull request #:
Github user dtrodrigues commented on the pull request: https://github.com/apache/nifi-minifi-cpp/commit/fe63485342fc0e84250887871826b9f17b1f9a94#commitcomment-23376815 In libminifi/src/processors/PutFile.cpp: In libminifi/src/processors/PutFile.cpp on line 167: Returning here before setting `_writeSucceeded` to `true` causes the PutFile processor to always fail. Creating issue/PR now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
