[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman Implementation of the nearest versioned group is done. ---
[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman In my experience, the top level group information was not really as useful as the parent one. So I don't mind the change you proposed. Anyway, @mattyb149 should be asked since he had created the original request. ---
[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman The merge conflict should be resolved now. ---
[GitHub] nifi issue #2157: NIFI-4390 - Add a keyboard shortcut for Connection...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2157 @mcgilman This PR was created solely in order to speed up the connection creation. There was a follow-up discussion at https://issues.apache.org/jira/browse/NIFI-4390. So I'm not sure if this particular PR is still valid. ---
[GitHub] nifi pull request #2222: NIFI-3926 - Edit Template information
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/#discussion_r160052865
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
---
@@ -2601,6 +2601,25 @@ public MutableVariableRegistry getVariableRegistry()
{
return variableRegistry;
}
+@Override
+public void verifyCanUpdateTemplate(final String name, final String
templateId) {
+// ensure the name is specified
+if (StringUtils.isBlank(name)) {
+throw new IllegalArgumentException("Template name cannot be
blank.");
+}
+
+for (final Template template : getTemplates()) {
+canUpdateTemplate(name, templateId, template.getDetails());
+}
+}
+
+private void canUpdateTemplate(final String name, final String
templateId, final TemplateDTO processGroupTemplate) {
+// prevent renaming to another template's name
+if (name.equals(processGroupTemplate.getName()) &&
!templateId.equals(processGroupTemplate.getId())) {
--- End diff --
@alopresto I was sloppy with that name validation, my mistake.
---
[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 @mcgilman OK, I'll redesign the REST API change to a non-breaking one. ---
[GitHub] nifi issue #2364: NIFI-4538 - Add Process Group information to...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2364 The PG names/IDs display style improvements are welcomed. Note: The `GET flow/search-results` API was changed. ---
[GitHub] nifi pull request #2364: NIFI-4538 - Add Process Group information to...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2364 NIFI-4538 - Add Process Group information to... ...Search results * Separated the search functionality. * Added a unit test. * Added the PG info to UI (a mere draft). ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4538 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2364.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2364 commit dfb4490c0bd0c7ff96734dae8ecaf5b6faef89c9 Author: yuri1969 <1969yuri1969@...> Date: 2017-12-22T19:18:20Z NIFI-4538 - Add Process Group information to... ...Search results * Separated the search functionality. * Added a unit test. * Added the PG info to UI (a mere draft). ---
[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 About that _close/done/ok_ button, currently the advanced UI is implemented as an `iframe` inside `nfShell`. The close 'X' button is a part of to the `nfShell`. So for closing down the advanced UI you need to close the `nfShell` too. I guess it can be done by traversing to the `nfShell` via the standard `window` object. Is this approach ok? Since it feels, it introduces another coupling element. ---
[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2269#discussion_r155931362
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-ui/src/main/frontend/package.json
---
@@ -0,0 +1,12 @@
+{
+ "name": "nifi-scripting-ui",
+ "dependencies": {
+"angular-ui-codemirror": "^0.3.0",
+"angular-ui-router": "^0.2.18"
--- End diff --
Fixated the versions
---
[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2269#discussion_r155931287 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-ui/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,61 @@ +nifi-transform-json-ui +Copyright 2014-2017 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +** +Apache Software License v2 +** + +The following binary components are provided under the Apache Software License v2 + + (ASLv2) Apache Commons Lang +The following NOTICE information applies: + Apache Commons Lang + Copyright 2001-2014 The Apache Software Foundation + + This product includes software from the Spring Framework, + under the Apache License 2.0 (see: StringUtils.containsWhitespace()) + + (ASLv2) Jettison +The following NOTICE information applies: + Copyright 2006 Envoi Solutions LLC + + (ASLv2) Jolt --- End diff -- Removed ---
[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2269#discussion_r155931289 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-ui/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,61 @@ +nifi-transform-json-ui --- End diff -- Removed ---
[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 Good points @moranr. Thanks. ---
[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 @scottyaslan Thank you for the kind words. I'll check the issues you mentioned. The AngularJS choice was made in order to keep it consistent with the rest of the existing advanced UI components and not to introduce unnecessary dependencies. Also, it allowed me to reuse a lot of the code-base from the Jolt transform component. Moving to Angular 2+ for the Registry and the shared lib makes sense. However, in the context of the existing advanced UI components it still feels a bit inconsistent. Introducing any kind of tests and code style for the UI is a good idea. I'll try to integrate a test suite to this UI. Using the advanced UI extensively made me think about optimizing the loading times of the UIs (AngularJS mini-apps). I guess a combination of minify/gz should help here. ---
[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 @pvillard31 I'll look into the 'X' button behavior. I was thinking about making the 'save' button as save & close as well. But this way it felt more _natural_ to me. I'll think this over, ---
[GitHub] nifi issue #2269: NIFI-4400 - Advanced UI with code editor for...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2269 Any suggestions are welcome. I'm not sure whether the license of new CodeMirror modes is handled properly. Please check that, thanks. ---
[GitHub] nifi pull request #2269: NIFI-4400 - Advanced UI with code editor for...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2269 NIFI-4400 - Advanced UI with code editor for... ...scripted processors Enabled a simple code editor in a form of an Advanced UI based on the nifi-jolt-transform-json-ui. The editor reuses the CodeMirror lib. The UI is enabled for the following scripted components: * ExecuteScript, InvokeScriptedProcessor * ScriptedLookupService, ScriptedReader, ScriptedRecordSetWriter * ScriptedReportingTask. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4400 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2269 commit f9e52a74b342f4178c0f2677d2e0c14940865b70 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-10-24T19:16:18Z NIFI-4400 - Advanced UI with code editor for... ...scripted processors Enabled a simple code editor in a form of an Advanced UI based on the nifi-jolt-transform-json-ui. The editor reuses the CodeMirror lib. The UI is enabled for the following scripted components: * ExecuteScript, InvokeScriptedProcessor * ScriptedLookupService, ScriptedReader, ScriptedRecordSetWriter * ScriptedReportingTask. ---
[GitHub] nifi pull request #2195: NIFI-4402 - Add component location in Summary view
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2195#discussion_r150084382
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/summary/nf-summary-table.js
---
@@ -417,7 +426,7 @@
var markup = '';
if (isInShell) {
-markup += '';
+markup += '';
--- End diff --
I've pushed the change. Thanks @pvillard31.
---
[GitHub] nifi pull request #2222: NIFI-3926 - Edit Template information
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/ NIFI-3926 - Edit Template information * Added a new edit dialog to 'Global Menu - Templates'. * Omitted Process Group Id editing functionality. * Added a unit test for template DAO update logic. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-3926 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes # commit 95953de1ba2bdbff388022577bb2b05877afe7ba Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-10-11T18:59:42Z NIFI-3926 - Edit Template information * Added a new edit dialog to 'Global Menu - Templates'. * Omitted Process Group Id editing functionality. * Added a unit test for template DAO update logic. ---
[GitHub] nifi issue #2200: NIFI-4470 - Variables Registry: Increase space...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2200 @scottyaslan You are welcome. I'm afraid, I don't have permissions to assign JIRA Issues to myself. Who should I ask to elevate my JIRA permissions? Thanks. ---
[GitHub] nifi pull request #2200: NIFI-4470 - Variables Registry: Increase space...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2200 NIFI-4470 - Variables Registry: Increase space... ...between Bulletin icon and Controller Service name Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4470 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2200 commit 14672678f52e6fa0e993c15c221a29c419e0961a Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-10-07T18:20:51Z NIFI-4470 - Variables Registry: Increase space... ...between Bulletin icon and Controller Service name ---
[GitHub] nifi pull request #2195: NIFI-4402 - Add component location in Summary view
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2195 NIFI-4402 - Add component location in Summary view Implemented as described in the issue. Improvements are welcome. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2195 commit 5f079b018a058164a6e3cb9723b4f720a4607d55 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-10-04T20:53:16Z NIFI-4402 - Add component location in Summary view Implemented as described in the issue. Improvements are welcome. ---
[GitHub] nifi issue #2178: NIFI-4423 - Add a confirmation of a Counter...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2178 @mcgilman Sorry about that missing sanitization. ---
[GitHub] nifi pull request #2178: NIFI-4423 - Add a confirmation of a Counter...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2178 NIFI-4423 - Add a confirmation of a Counter... ...reset action Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4423 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2178 commit 39111d8dcb57918528d1048f6f058848fd167fc0 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-09-26T18:18:39Z NIFI-4423 - Add a confirmation of a Counter... ...reset action ---
[GitHub] nifi issue #2170: NIFI-3803 - Allow use of up/down arrow keys...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2170 @mcgilman - Thanks for pointing out this one. I forgot to include the _Add Reporting Task_ dialog completely... - Now the `nfFilteredDialogCommon` should follow the SlickGrid's PageUp/Down navigation style. Please, check whether there are any differences. ---
[GitHub] nifi pull request #2157: NIFI-4390 - Add a keyboard shortcut for Connection....
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2157 NIFI-4390 - Add a keyboard shortcut for Connection... ...related dialogs Connection related dialogs can be confirmed by the Enter key. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4390 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2157 commit 8636a3864df5308ed361bf963609f48b77c48f83 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-09-17T10:08:00Z NIFI-4390 - Add a keyboard shortcut for Connection... ...related dialogs Connection related dialogs can be confirmed by the Enter key. ---
[GitHub] nifi pull request #2152: NIFI-3369 - Disable "Add" button on new connection ...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2152 NIFI-3369 - Disable "Add" button on new connection dialog if no relationships selected Disabled confirmation button for both Create and Configure Connection dialogs when no relationship was selected. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-3369 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2152.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2152 commit cce5f28b3440a4a117390bf3cf5eff2fb5bc06d3 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-09-12T17:51:10Z NIFI-3369 - Disable "Add" button on new... ...connection dialog if no relationships selected Disabled confirmation button for both Create and Configure Connection dialogs when no relationship was selected. ---
[GitHub] nifi pull request #2126: NIFI-4347 - Extend documentation with...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2126 NIFI-4347 - Extend documentation with... ...double-click shortcuts info Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4347 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2126.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2126 commit 01d5a4180e01256800e8dfd6fc38ab8b5e952637 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-09-03T12:25:39Z NIFI-4347 - Extend documentation with... ...double-click shortcuts info --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2124: NIFI-3941 - Clarify tab name for controller...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2124 @alopresto There already is an info sentence at the bottom. Should the dialog really contain two info sentences? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2124: NIFI-3941 - Clarify tab name for controller...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2124 NIFI-3941 - Clarify tab name for controller... ...level controller services dialog * Changed the tab title since sharing the name makes things less clear for newcomers. * Suggested info sentence is omitted. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-3941 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2124 commit 2109cf8946a3b91247f40085396fc2559424e251 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-09-01T19:59:17Z NIFI-3941 - Clarify tab name for controller... ...level controller services dialog * Changed the tab title since sharing the name makes things less clear for newcomers. * Suggested info sentence is omitted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2100: NIFI-2715 - When performing a Queue Listing, if...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2100 @scottyaslan The text's style should match the one used on detail values now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2102: NIFI-3781 - Controller Service Config Dialog...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2102 @moranr @scottyaslan Changed the tooltip to _View Configuration_. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2102: NIFI-3781 - Controller Service Config Dialog...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2102 NIFI-3781 - Controller Service Config Dialog... ..'View Details' button feels confusing and inconsistent with Processors * Merged 'View Details' and 'Edit' buttons to a single 'Configure'/'View Details' one. * Fixed confusing 'View Details' modal's title. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-3781 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2102.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2102 commit af69559ba3979ee6155f8a0d9fc885c4cb51e854 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-08-19T18:49:33Z NIFI-3781 - Controller Service Config Dialog... ..'View Details' button feels confusing and inconsistent with Processors * Merged 'View Details' and 'Edit' buttons to a single 'Configure'/'View Details' one. * Fixed confusing 'View Details' modal's title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2100: NIFI-2715 - When performing a Queue Listing, if...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2100 NIFI-2715 - When performing a Queue Listing, if... ...FlowFile has no content, UI does not indicate this fact For FlowFiles with no content: * Added a simple title replacing the Content Claim's one. * Defaulted File Size to 0 bytes using common formatting. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-2715 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2100 commit 24fbffbedb7d264af61918f931742278d124e41d Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-08-16T20:42:08Z NIFI-2715 - When performing a Queue Listing, if... ...FlowFile has no content, UI does not indicate this fact For FlowFiles with no content: * Added a simple title replacing the Content Claim's one. * Defaulted File Size to 0 bytes using common formatting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2081 A misclick, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...
GitHub user yuri1969 reopened a pull request: https://github.com/apache/nifi/pull/2081 NIFI-3780 - Should be able to specify Service... ...name when I create a new Controller Service within a Processor/Service configuration dialog I'm not sure how to integrate/style the text box. Suggestions are welcome. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-3780 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2081.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2081 commit 47acf746b8b7bb8c7250c9a87db530ed01d80392 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-08-13T18:15:38Z NIFI-3780 - Should be able to specify Service... ...name when I create a new Controller Service within a Processor/Service configuration dialog I'm not sure how to integrate/style the text box. Suggestions are welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2081: NIFI-3780 - Should be able to specify Service...
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2081 OK, @scottyaslan and @moranr. I'll try to push an update tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...
Github user yuri1969 closed the pull request at: https://github.com/apache/nifi/pull/2081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2081: NIFI-3780 - Should be able to specify Service...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2081 NIFI-3780 - Should be able to specify Service... ...name when I create a new Controller Service within a Processor/Service configuration dialog I'm not sure how to integrate/style the text box. Suggestions are welcome. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-3780 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2081.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2081 commit 47acf746b8b7bb8c7250c9a87db530ed01d80392 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-08-13T18:15:38Z NIFI-3780 - Should be able to specify Service... ...name when I create a new Controller Service within a Processor/Service configuration dialog I'm not sure how to integrate/style the text box. Suggestions are welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @pvillard31 - The reverting PR is #2064. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2064: NIFI-4271 - Revert double-click behavior back...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2064 NIFI-4271 - Revert double-click behavior back... ...to delete a bend point Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4271 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2064.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @pvillard31 - I will submit a new PR to revert the current bend points behavior later today or tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2059: NIFI-1027 - Treat label and node of a provenance
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2059 NIFI-1027 - Treat label and node of a provenance ...graph event as one unit The JIRA issue asks for treating both node and its label as one unit. Described cursor issues seems to be fixed already. However, there is an annoying dead space between a node and label preventing displaying context menu, etc. Due to SVG group's nature there has been added an opaque joint to remove the dead space. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-1027 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2059.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2059 commit 77511871ed13935abfac1aae0e9e8b0473f17d71 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-08-05T14:57:48Z NIFI-1027 - Treat label and node of a provenance ...graph event as one unit The JIRA issue asks for treating both node and its label as one unit. Described cursor issues seems to be fixed already. However, there is an annoying dead space between a node and label preventing displaying context menu, etc. Due to SVG group's nature there has been added an opaque joint to remove the dead space. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2058: NIFI-4266 - Allow double-click to display Event
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2058 NIFI-4266 - Allow double-click to display Event ...details Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-4266 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2058.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2058 commit 8d0ac85928ad0561f69aec009c26ae82638083f5 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-08-05T13:15:25Z NIFI-4266 - Allow double-click to display Event ...details --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan OK, but I'm afraid the merged version still has the `quickSelect` activated for mid nodes/bends. It seems this should be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 - I find it natural to double-click on the 'line' when I want to add a new bend. - In order to check connection's config I would try to double-click on its rectangular stats box. - Connection's 'nodes' being able to open the config dialog feels OK to me. However, I wouldn't double-click on them intuitively. I have got a Mule Anypoint Studio background so my opinion might be skewed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan Thanks. So the problem is just with the start and end nodes, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/2009 @scottyaslan It seems I omitted `quickSelect` activation for both start and end "nodes". Please, can you confirm that a double-click displays the connection configuration dialog when performed on a connection's mid "node"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-site pull request #21: NIFI-4219 - Describe partial builds in Quickstar...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi-site/pull/21 NIFI-4219 - Describe partial builds in Quickstart ... guide Suggestions are welcome. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi-site NIFI-4219 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-site/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit f05c14a4964b2b8e4aa5142c958c39ed0f53539f Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-07-24T19:57:29Z NIFI-4219 - Describe partial builds in Quickstart ... guide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2009#discussion_r128583974
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-graph.js
---
@@ -198,13 +201,13 @@
var nfGraph = {
init: function () {
// initialize the object responsible for each type of component
-nfLabel.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu);
+nfLabel.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu, nfQuickSelect);
nfFunnel.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu);
-nfPort.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu);
+nfPort.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu, nfQuickSelect);
nfRemoteProcessGroup.init(nfConnectable, nfDraggable,
nfSelectable, nfContextMenu);
--- End diff --
@scottyaslan OK, I'll enable configure by double clicking for RPG.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2009: NIFI-1580 - Allow double-click to display config
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2009#discussion_r127677617
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-graph.js
---
@@ -198,13 +201,13 @@
var nfGraph = {
init: function () {
// initialize the object responsible for each type of component
-nfLabel.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu);
+nfLabel.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu, nfQuickSelect);
nfFunnel.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu);
-nfPort.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu);
+nfPort.init(nfConnectable, nfDraggable, nfSelectable,
nfContextMenu, nfQuickSelect);
nfRemoteProcessGroup.init(nfConnectable, nfDraggable,
nfSelectable, nfContextMenu);
--- End diff --
I haven't thought about RPGs (the ticket mentions _processors_ only). So
RPGs should feature this functionality too, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2009: NIFI-1580 - Allow double-click to display config
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/2009 NIFI-1580 - Allow double-click to display config * Added double-click shortcut opening config/details dialog to processors, connections, ports and labels. * Created a base for further default action selection, disabling, etc. * Omitted default action configuration UI - that might be a separate JIRA ticket. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi NIFI-1580 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2009.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2009 commit 32cf57cafda0ae70c8d71c784b2a7e20d3881a98 Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-06-29T18:19:23Z NIFI-1580 - Allow double-click to display config * Added double-click shortcut opening config/details dialog to processors, connections, ports and labels. * Created a base for further default action selection, disabling, etc. * Omitted default action configuration UI - that might be a separate JIRA ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1946: NIFI-4125 - Add basic security settings to TransformXml
Github user yuri1969 commented on the issue: https://github.com/apache/nifi/pull/1946 Reverted back to turned on by default. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1946#discussion_r124119598
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -98,6 +99,16 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.build();
+public static final PropertyDescriptor SECURE_PROCESSING = new
PropertyDescriptor.Builder()
+.name("secure-processing")
+.displayName("Secure processing")
+.description("Whether or not to mitigate various XML-related
attacks like XXE (XML External Entity) attacks.")
+.required(true)
+.defaultValue("true")
--- End diff --
Fair enough. I'll set the default to false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1946#discussion_r124116697
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -98,6 +99,16 @@
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
.build();
+public static final PropertyDescriptor SECURE_PROCESSING = new
PropertyDescriptor.Builder()
+.name("secure-processing")
+.displayName("Secure processing")
+.description("Whether or not to mitigate various XML-related
attacks like XXE (XML External Entity) attacks.")
+.required(true)
+.defaultValue("true")
--- End diff --
You are right, it alters `TransformXml` output in specific cases. TBH I
don't know what is the NiFi's backwards-compatibility policy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...
Github user yuri1969 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1946#discussion_r124115889
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java
---
@@ -166,8 +178,17 @@ protected PropertyDescriptor
getSupportedDynamicPropertyDescriptor(final String
.build();
}
-private Templates newTemplates(String path) throws
TransformerConfigurationException {
+private Templates newTemplates(ProcessContext context, String path)
throws TransformerConfigurationException {
+final Boolean secureProcessing =
context.getProperty(SECURE_PROCESSING).asBoolean();
TransformerFactory factory = TransformerFactory.newInstance();
+
+if (secureProcessing) {
+factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING,
true);
+// don't be overly DTD-unfriendly forcing
http://apache.org/xml/features/disallow-doctype-decl
+
factory.setFeature("http://saxon.sf.net/feature/parserFeature?uri=http://xml.org/sax/features/external-parameter-entities;,
false);
--- End diff --
The URL is Saxon's (horrible) feature name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...
GitHub user yuri1969 reopened a pull request: https://github.com/apache/nifi/pull/1946 NIFI-4125 - Add basic security settings to TransformXml Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi XSLT-securing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1946.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1946 commit 9469c21f3f3dc3ba137e258e3be711cb2ea5a14d Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-06-25T20:10:31Z Initial propose --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...
Github user yuri1969 closed the pull request at: https://github.com/apache/nifi/pull/1946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1946: NIFI-4125 - Add basic security settings to Transfor...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/1946 NIFI-4125 - Add basic security settings to TransformXml Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi XSLT-securing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1946.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1946 commit 9469c21f3f3dc3ba137e258e3be711cb2ea5a14d Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-06-25T20:10:31Z Initial propose --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi pull request #1940: NIFI-4119 - Improve UX of canvas label configuratio...
GitHub user yuri1969 opened a pull request: https://github.com/apache/nifi/pull/1940 NIFI-4119 - Improve UX of canvas label configuration Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yuri1969/nifi master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1940.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1940 commit 302cd74a9a1f43af2e79221d03db141adb16934a Author: yuri1969 <1969yuri1...@gmail.com> Date: 2017-06-25T16:56:54Z NIFI-4119 - Improve UX of canvas label configuration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
