[GitHub] [nifi] ChrisSamo632 commented on pull request #7537: NIFI-11778 Initial check in of refactored Groovy tests in nifi-elasticsearch-restapi-processors to Java (and JUnit 5)
ChrisSamo632 commented on PR #7537:
URL: https://github.com/apache/nifi/pull/7537#issuecomment-1662792006
> @ChrisSamo632 Sorry by accident closed this PR and the reopened. Would it
be okay to fix the test errors by placing in `setUpBeforeClass`
>
> `TimeZone.setDefault(TimeZone.getTimeZone("UTC"));` ?
I'm not sure this sounds like the right way to fix this - the Checks run
against multiple timezones for good reason, we want to be sure that processors
can handle changes in locale. Having to set the tests to use a specific
timezone to pass, seems like we might be hiding a potential issue either in the
tests or the processor code itself.
Unfortunately, handling multiple timezones isn't my strong suite, although
I'll try to take a look. I wonder whether @exceptionfactory or @markap14 might
be able to provide some guidance on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on pull request #7537: NIFI-11778 Initial check in of refactored Groovy tests in nifi-elasticsearch-restapi-processors to Java (and JUnit 5)
ChrisSamo632 commented on PR #7537: URL: https://github.com/apache/nifi/pull/7537#issuecomment-1656717225 @dan-s1 I re-triggered the Checks, definitely looks like ES related assertion failures now (originally you were right that the tests for for some unrelated transient issue) ``` Error: Failures: Error:PutElasticsearchRecordTest.testDateTimeFormatting:600 org.opentest4j.AssertionFailedError: expected: <2> but was: <0> Error:PutElasticsearchRecordTest.testRecordPathFeatures:337 org.opentest4j.AssertionFailedError: expected: <1> but was: <0> Error: Tests run: 124, Failures: 2, Errors: 0, Skipped: 0 Error: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0:test (default-test) on project nifi-elasticsearch-restapi-processors: There are test failures. Error: Error: Please refer to /home/runner/work/nifi/nifi/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/target/surefire-reports for the individual test results. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
