[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-11-20 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-731381074


   Thanks @jfrazee 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-11-14 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-727243683


   @jfrazee any chance we can close this out?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-11-10 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-724825411


   @jfrazee we should be all good now. Even got the L language updated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-11-10 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-724761862


   > Just a consistency thing, but the UUID-related functions in EL are 
uppercase and here it's lower.
   
   Everything on record path looks camel case, so that's what I was going with.
   
   > The other modules in nifi-commons aren't nifi-commons-* so I think this 
should just be nifi-uuid5.
   
   Yup. The name will be changed when I push the updates.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-11-08 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-723679625


   @jfrazee do you think you'll have any time to review this week?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-10-16 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-710678688


   @jfrazee do you have any time to take another look?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-10-09 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-705690546


   @jfrazee I moved the majority of the UUID5 evaluator into a common jar and 
referenced that in both places in the updates.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-10-08 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-705690546


   @jfrazee I moved the majority of the UUID5 evaluator into a common jar and 
referenced that in both places in the updates.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-10-06 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-704366359


   @jfrazee Yes, definitely. Worst case scenario would be a tiny little jar 
file shared between the two. I'll get working on that this afternoon if I have 
time. Thanks for finding that.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] MikeThomsen commented on pull request #4570: NIFI-7879 Created record path function for UUID v5

2020-10-04 Thread GitBox


MikeThomsen commented on pull request #4570:
URL: https://github.com/apache/nifi/pull/4570#issuecomment-703293195


   @joewitt added a small ASL-licensed dependency. Not sure where it should go 
for L purposes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org