[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6310: NIFI-10366: Make Default Run Duration configurable
exceptionfactory commented on code in PR #6310:
URL: https://github.com/apache/nifi/pull/6310#discussion_r952801009
##
nifi-api/src/main/java/org/apache/nifi/annotation/behavior/DefaultRunDuration.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.annotation.behavior;
+
+import java.time.Duration;
+
+public enum DefaultRunDuration {
+NO_BATCHING(Duration.ZERO),
+TWENTY_FIVE_MILLIS(Duration.ofMillis(25)),
+FIFTY_MILLIS(Duration.ofMillis(50)),
+ONE_HUNDRED_MILLIS(Duration.ofMillis(100)),
+TWO_HUNDRED_FIFTY_MILLIS(Duration.ofMillis(250)),
+FIVE_HUNDRED_MILLIS(Duration.ofMillis(500)),
+ONE_SECOND(Duration.ofSeconds(1)),
+TWO_SECONDS(Duration.ofSeconds(2));
+
+private final Duration duration;
+
+DefaultRunDuration(final Duration duration) {
+this.duration = duration;
+}
+
+public Duration getDuration() {
+return Duration.ofMillis(1000);
Review Comment:
This needs to be changed to return the `duration` property.
```suggestion
return duration;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6310: NIFI-10366: Make Default Run Duration configurable
exceptionfactory commented on code in PR #6310:
URL: https://github.com/apache/nifi/pull/6310#discussion_r950241739
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/ExtensionBuilder.java:
##
@@ -359,6 +363,19 @@ private void applyDefaultSettings(final ProcessorNode
processorNode) {
}
}
+private void applyDefaultRunDuration(final ProcessorNode processorNode) {
+try {
+final Class procClass = processorNode.getProcessor().getClass();
+
+final SupportsBatching sb =
procClass.getAnnotation(SupportsBatching.class);
+if (sb != null) {
+
processorNode.setRunDuration(sb.defaultDuration().getDuration().toMillis(),
TimeUnit.MILLISECONDS);
+}
+} catch (final Exception ex) {
+logger.error("Error while setting default run duration from
SupportsBatching annotation: {}", ex.toString(), ex);
Review Comment:
Including the `ex.toString()` argument should not be necessary since the
exception stack trace will include the same details.
```suggestion
logger.error("Set default Run Duration failed", ex);
```
##
nifi-api/src/main/java/org/apache/nifi/annotation/behavior/DefaultRunDuration.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.annotation.behavior;
+
+import java.time.Duration;
+
+public enum DefaultRunDuration {
+NO_BATCHING(0),
+TWENTY_FIVE_MILLIS(25),
+FIFTY_MILLIS(50),
+ONE_HUNDRED_MILLIS(100),
+TWO_HUNDRED_FIFTY_MILLIS(250),
+FIVE_HUNDRED_MILLIS(500),
+ONE_SECOND(1000),
+TWO_SECONDS(2000);
+
+private final long millis;
+
+DefaultRunDuration(final long millis) {
Review Comment:
Minor detail, but with the change to use `java.time.Duration` in the
`getDuration()` method, recommend changing the constructor argument as well.
That will provide the opportunity for more semantic definition of the enum
options, such as `Duration.ofMillis()` for smaller values, and
`Duration.ofSeconds()` for larger values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6310: NIFI-10366: Make Default Run Duration configurable
exceptionfactory commented on code in PR #6310:
URL: https://github.com/apache/nifi/pull/6310#discussion_r948394015
##
nifi-api/src/main/java/org/apache/nifi/annotation/behavior/RunDuration.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.annotation.behavior;
+
+public enum RunDuration {
+ZERO_MILLIS(0),
+TWENTY_FIVE_MILLIS(25),
+FIFTY_MILLIS(50),
+ONE_HUNDRED_MILLIS(100),
+TWO_HUNDRED_FIFTY_MILLIS(250),
+FIVE_HUNDRED_MILLIS(500),
+ONE_SECONDS(1000),
+TWO_SECONDS(2000);
+
+private final long millis;
+
+RunDuration(final long millis) {
+this.millis = millis;
+}
+
+public long getMillis() {
+return millis;
+}
Review Comment:
@Lehel44 and @markap14, what do you think about returning a
[java.time.Duration](https://docs.oracle.com/javase/8/docs/api/java/time/Duration.html)
object? That would provide greater flexibility on the consuming side, and also
preserve the intent of the time being a duration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
