[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6967: NIFI-11193 Improve GitFlowPersisenceProvider logging

[via GitHub]

exceptionfactory commented on code in PR #6967:
URL: https://github.com/apache/nifi/pull/6967#discussion_r1108996488


##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowPersistenceProvider.java:
##########
@@ -94,9 +94,12 @@ public void onConfigured(ProviderConfigurationContext 
configurationContext) thro
             flowStorageDir = new File(flowStorageDirValue);
             final boolean localRepoExists = 
flowMetaData.localRepoExists(flowStorageDir);
             if (remoteRepo != null && !remoteRepo.isEmpty() && 
!localRepoExists){
+                logger.info("Validating remote repo '%s'...", remoteRepo);
                 flowMetaData.remoteRepoExists(remoteRepo);
+                logger.info("Cloning remote repo '%s' to '%s'...", remoteRepo, 
flowStorageDirValue);
                 flowMetaData.cloneRepository(flowStorageDir, remoteRepo);
             }
+            logger.info("Loading remote repo '%s'...", remoteRepo);

Review Comment:
   ```suggestion
               logger.info("Loading remote repository [{}]", remoteRepo);
   ```



##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowPersistenceProvider.java:
##########
@@ -94,9 +94,12 @@ public void onConfigured(ProviderConfigurationContext 
configurationContext) thro
             flowStorageDir = new File(flowStorageDirValue);
             final boolean localRepoExists = 
flowMetaData.localRepoExists(flowStorageDir);
             if (remoteRepo != null && !remoteRepo.isEmpty() && 
!localRepoExists){
+                logger.info("Validating remote repo '%s'...", remoteRepo);
                 flowMetaData.remoteRepoExists(remoteRepo);
+                logger.info("Cloning remote repo '%s' to '%s'...", remoteRepo, 
flowStorageDirValue);

Review Comment:
   ```suggestion
                   logger.info("Cloning remote repository [{}] to [{}]", 
remoteRepo, flowStorageDirValue);
   ```



##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowPersistenceProvider.java:
##########
@@ -94,9 +94,12 @@ public void onConfigured(ProviderConfigurationContext 
configurationContext) thro
             flowStorageDir = new File(flowStorageDirValue);
             final boolean localRepoExists = 
flowMetaData.localRepoExists(flowStorageDir);
             if (remoteRepo != null && !remoteRepo.isEmpty() && 
!localRepoExists){
+                logger.info("Validating remote repo '%s'...", remoteRepo);

Review Comment:
   Placeholder values for logging should be `{}` instead of `%s`, also 
recommend the wording adjustment:
   ```suggestion
                   logger.info("Validating remote repository [{}]", remoteRepo);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org