[GitHub] [nifi] gerdansantos commented on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via

2022-01-28 Thread GitBox 


gerdansantos commented on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1024617409


   I have tested this code.
   
   ✅ Build without exceptions ✅ The mock tests seem enough ✅ The CDC start 
without problems including PostgreSQL slots ✅ The Syncing Turn On process runs 
fine ✅ The recovery process, dont conect and recovery from abrutal shutdown of 
PostgreSQL of NiFi. I beleive the processor stat came be definied before 
PostgreSQL lsn Commit, so the PostgreSQL cannot resync with the last past LSN. 
✅If the stop process, the processor restart from last step without problems. ✅ 
The connection with a slot previously created don't run.
   
   @joewitt @mattyb149 please go on with ci/cd flow!!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] gerdansantos commented on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via

2022-01-25 Thread GitBox 


gerdansantos commented on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1020644890


   I have tested this code.
   
   ✅ Build without exceptions
   ✅ The mock tests seem enough
   ✅ The CDC start without problems including PostgreSQL slots
   ✅ The Syncing Turn On process runs fine
   ❌ The recovery process, dont conect and recovery from abrutal shutdown of 
PostgreSQL of NiFi. I beleive the processor stat came be definied before 
PostgreSQL lsn Commit, so the PostgreSQL cannot resync with the last past LSN.
   ✅If the stop process, the processor restart from last step without problems.
   ❌ The connection with a slot previously created don't run.
   
   
   Congrats for the evolution of this processor code.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] gerdansantos commented on pull request #5710: NIFI-4239 - Adding (REFACTORED) CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) in PostgreSQL tables via

2022-01-24 Thread GitBox 


gerdansantos commented on pull request #5710:
URL: https://github.com/apache/nifi/pull/5710#issuecomment-1020644890


   I have tested this code.
   
   ✅ Build without exceptions
   ✅ The mock tests seem enough
   ✅ The CDC start without problems including PostgreSQL slots
   ✅ The Syncing Turn On process runs fine
   ❌ The recovery process, dont conect and recovery from abrutal shutdown of 
PostgreSQL of NiFi. I beleive the processor stat came be definied before 
PostgreSQL lsn Commit, so the PostgreSQL cannot resync with the last past LSN.
   ✅If the stop process, the processor restart from last step without problems.
   ❌ The connection with a slot previously created don't run.
   
   
   Congrats for the evolution of this processor code.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org