joewitt commented on a change in pull request #3968: NIFI-3833 Implemented
encrypted flowfile repository
URL: https://github.com/apache/nifi/pull/3968#discussion_r365371051
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/WriteAheadFlowFileRepository.java
##########
@@ -200,17 +211,19 @@ protected void initialize(final ResourceClaimManager
claimManager, final Reposit
// delete backup. On restore, if no files exist in partition's
directory, would have to check backup directory
this.serdeFactory = serdeFactory;
- if (walImplementation.equals(SEQUENTIAL_ACCESS_WAL)) {
+ // The specified implementation can be plaintext or encrypted; the
only difference is the serde factory
+ if (isSequentialAccessWAL(walImplementation)) {
+ // TODO: May need to instantiate ESAWAL for clarity?
Review comment:
This todo seems not necessary. Given the todos related to follow on work
with NIFI-6617 though this seems fine for now to help get more evaluation
cycles on this new capability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
