[GitHub] [nifi] markap14 commented on pull request #6317: NIFI-10375: If a class is not allowed in the AllowListClassLoader by …

2022-08-23 Thread GitBox 


markap14 commented on PR #6317:
URL: https://github.com/apache/nifi/pull/6317#issuecomment-1224126078

   Thanks for reviewing @turcsanyip . Pushed a fix that addresses both concerns.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] markap14 commented on pull request #6317: NIFI-10375: If a class is not allowed in the AllowListClassLoader by …

2022-08-22 Thread GitBox 


markap14 commented on PR #6317:
URL: https://github.com/apache/nifi/pull/6317#issuecomment-1222674869

   > If you can name a module anything you want, like 
java.ottobackwards.whatever, would that introduce a hole in the allowlist?
   
   @ottobackwards yes, if you created a module and named it 
`java.ottobackwards.whatever` it would be allowed through. Not sure if Java 
allows you to create a module with name or not, to be honest (they don't allow 
you to create a Class in a package called `java.ottobackwards`, though.)
   
   But in any case, I think that's fine. If you were to put something like that 
on the classpath we'd allow loading it from the extensions. 路‍♂️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org