[GitHub] [nifi] mattyb149 commented on pull request #4635: NIFI-7821 Added Cassandra-based DMC.

2020-11-29 Thread GitBox


mattyb149 commented on pull request #4635:
URL: https://github.com/apache/nifi/pull/4635#issuecomment-735479160


   +1 LGTM, tested with latest, all looks good. Thanks for the feature! Merging 
to main



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] mattyb149 commented on pull request #4635: NIFI-7821 Added Cassandra-based DMC.

2020-11-29 Thread GitBox


mattyb149 commented on pull request #4635:
URL: https://github.com/apache/nifi/pull/4635#issuecomment-735478201


   blob, int, text, varchar
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] mattyb149 commented on pull request #4635: NIFI-7821 Added Cassandra-based DMC.

2020-11-25 Thread GitBox


mattyb149 commented on pull request #4635:
URL: https://github.com/apache/nifi/pull/4635#issuecomment-733960057


   +1 LGTM, ran contrib-check and integration tests, and tested on a NiFi 
instance. @MikeThomsen I can merge now if you want to do the other key/value 
types later, or if you want to do them as part of this, I can review the 
updated PR after the holiday/weekend.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org