[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-756752576 @NissimShiman – good catch. That style text is used elsewhere in that way, so I'd say you're correct to apply here as well. Looks good to me; thanks for your work and attention to detail! CC @markap14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-756752576 @NissimShiman – good catch. That style text is used elsewhere in that way, so I'd say you're correct to apply here as well. Looks good to me; thanks for your work and attention to detail! CC @markap14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] moranr commented on pull request #4563: NIFI-7738 Reverse Provenance Query
moranr commented on pull request #4563: URL: https://github.com/apache/nifi/pull/4563#issuecomment-754772546 @markap14 @NissimShiman I don’t think the tabular like appearance is necessary. Much like Start Date/Time, etc. these are just other fields upon which the user can search. I would suggest listing them out in the same format as the others. Then, per applicable field, include a checkbox option to perform the inverse query action. I would recommend presenting that option as a short phrase, with the goal of clearly explaining to the user what it will mean for their search results. The (?) icon tooltip can explain in more technical terms what is happening and provide an example if necessary. Here’s an example to help illustrate:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
