[GitHub] [nifi] nandorsoma commented on pull request #6225: NIFI-10251 Add v5 protocol support for existing MQTT processors
nandorsoma commented on PR #6225: URL: https://github.com/apache/nifi/pull/6225#issuecomment-1230980728 Thank you for your additional review @exceptionfactory! Please see my latest commit! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #6225: NIFI-10251 Add v5 protocol support for existing MQTT processors
nandorsoma commented on PR #6225: URL: https://github.com/apache/nifi/pull/6225#issuecomment-1227128897 After a discussion I've removed commit (NIFI-10251 use ReceivedMqttMessageHandler instead of a generic callback which was mostly used by Paho and in the 2/3 of the cases it didn't require callback [52204e4]). Probably I will open a separate pr for that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #6225: NIFI-10251 Add v5 protocol support for existing MQTT processors
nandorsoma commented on PR #6225: URL: https://github.com/apache/nifi/pull/6225#issuecomment-1225043867 Rebased on top of current main, that's why the force push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #6225: NIFI-10251 Add v5 protocol support for existing MQTT processors
nandorsoma commented on PR #6225: URL: https://github.com/apache/nifi/pull/6225#issuecomment-1224352753 Thank you for the review @turcsanyip, @tpalfy and @exceptionfactory! I've tried to address your comments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #6225: NIFI-10251 Add v5 protocol support for existing MQTT processors
nandorsoma commented on PR #6225: URL: https://github.com/apache/nifi/pull/6225#issuecomment-1191244151 > Thanks for the contribution @nandorsoma! > > On initial review, the `Static Analysis` check failed due to multiple files missing the standard Apache License header. Please review the output of that check and add the header to the files indicated. Interesting, because I've run the build with `contrib-check` enabled which I thought checks for that. Nevertheless I will add them of course! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
