[GitHub] [nifi] pvillard31 commented on pull request #4573: NIFI-7534 Consume MQTT Processor. Support Expression Language for Topic Filter Property
pvillard31 commented on pull request #4573: URL: https://github.com/apache/nifi/pull/4573#issuecomment-705526018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4573: NIFI-7534 Consume MQTT Processor. Support Expression Language for Topic Filter Property
pvillard31 commented on pull request #4573: URL: https://github.com/apache/nifi/pull/4573#issuecomment-705573972 That's fine, it's not causing any issue and could be useful for people not willing to move to parameters right away. But going forward we really want to have people using Parameters instead of Variables. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4573: NIFI-7534 Consume MQTT Processor. Support Expression Language for Topic Filter Property
pvillard31 commented on pull request #4573: URL: https://github.com/apache/nifi/pull/4573#issuecomment-705556236 I'd also add that with the addition of this concept of parameters (as a far better replacement of the variables), expression language should only be set where it makes sense to call some EL functions or to reference attributes of incoming flow files. But I'm not sure this is required for this specific use case since it does not accept incoming connections. Having said that, your change is valid from a code point of view, so I can merge it if there is use case that requires it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4573: NIFI-7534 Consume MQTT Processor. Support Expression Language for Topic Filter Property
pvillard31 commented on pull request #4573: URL: https://github.com/apache/nifi/pull/4573#issuecomment-705554920 On your process group, you can associate a parameter context where you can define your parameters. Parameters are referenced by using ``#{myParameter}`` in the property and parameters are supported everywhere (including sensitive properties and properties where expression language is not enabled). More details here: http://nifi.apache.org/docs/nifi-docs/html/user-guide.html#Parameters This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4573: NIFI-7534 Consume MQTT Processor. Support Expression Language for Topic Filter Property
pvillard31 commented on pull request #4573: URL: https://github.com/apache/nifi/pull/4573#issuecomment-705526018 Any reason for not using parameters? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org