[GitHub] [nifi] pvillard31 commented on pull request #4939: NIFI-8341 Support Multi Hosts in AMQP Processors
pvillard31 commented on pull request #4939: URL: https://github.com/apache/nifi/pull/4939#issuecomment-816772902 Merged, thanks @nabmoh123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4939: NIFI-8341 Support Multi Hosts in AMQP Processors
pvillard31 commented on pull request #4939: URL: https://github.com/apache/nifi/pull/4939#issuecomment-815002530 Yeah fair enough. Not in a position to merge right now but will do later today if no one else does before me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #4939: NIFI-8341 Support Multi Hosts in AMQP Processors
pvillard31 commented on pull request #4939: URL: https://github.com/apache/nifi/pull/4939#issuecomment-814235193 I still think that a custom validate method makes sense. Especially to make the processor invalid if brokers, host, and port are all set. Because in that case it could confuse the users wrt to which properties are actually used. I acknowledge this is explained in the properties description but this would make things more "obvious". We do that for some processors where it's possible to configure the same "thing" via multiple properties after we added some new properties over time and we kept the old ones to not break backward compatibility. That's my only remaining comment, latest changes look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
