[GitHub] [nifi] tpalfy commented on pull request #6899: NIFI-11123: fix default value and update docs
tpalfy commented on PR #6899: URL: https://github.com/apache/nifi/pull/6899#issuecomment-1414136415 LGTM Thank you for your work @KalmanJantner and @exceptionfactory for your review! Merged into main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on pull request #6899: NIFI-11123: fix default value and update docs
tpalfy commented on PR #6899: URL: https://github.com/apache/nifi/pull/6899#issuecomment-1413836494 LGTM @exceptionfactory if you are okay with the recent changes I'll merge into main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on pull request #6899: NIFI-11123: fix default value and update docs
tpalfy commented on PR #6899: URL: https://github.com/apache/nifi/pull/6899#issuecomment-1412386797 Instead of relying on a parameter context for the output bucket we could add a property on the processor. For that property and the incoming flowfile attributes we could build a custom map and add that as parameter to the `evaluateAttributeExpression` call when getting the value of the payload JSON. When both the property and a similar flowfile attribute is set, flowfile attributes should have precedence. Also the type of Vision action (like `DOCUMENT_TEXT_DETECTION`) could come from a property as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
