bakaid commented on issue #708: MINIFICPP-1118 - MiNiFi C++ on Windows stops
running in a secure env …
URL: https://github.com/apache/nifi-minifi-cpp/pull/708#issuecomment-574229762
> > @arpadboda review fixes look good. Did you test this on Linux as well?
>
> We have a test called "SecureSocketGetTCPTest" (in standard processors
extension), which verifies communication via TLS sockets, so together with the
Win verification I trust it.
> What's your opinion?
Yep, for the time being it should be OK, but I think it warrants a follow-up
task to:
- test the name resolution failure path in our integration test
- create a docker test to actually test at least the positive (and
preferable negative) cases with a real NiFi instance
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
