[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #849: MINIFICPP-1261 - Mark ScopeGuard class deprecated

[GitBox]

hunyadi-dev commented on a change in pull request #849:
URL: https://github.com/apache/nifi-minifi-cpp/pull/849#discussion_r460746457



##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -340,7 +341,7 @@ void ConsumeWindowsEventLog::onTrigger(const 
std::shared_ptr

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #849: MINIFICPP-1261 - Mark ScopeGuard class deprecated

[GitBox]

hunyadi-dev commented on a change in pull request #849:
URL: https://github.com/apache/nifi-minifi-cpp/pull/849#discussion_r460746457



##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -340,7 +341,7 @@ void ConsumeWindowsEventLog::onTrigger(const 
std::shared_ptr

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #849: MINIFICPP-1261 - Mark ScopeGuard class deprecated

[GitBox]

hunyadi-dev commented on a change in pull request #849:
URL: https://github.com/apache/nifi-minifi-cpp/pull/849#discussion_r460689205



##
File path: extensions/opc/src/opc.cpp
##
@@ -302,7 +303,7 @@ void Client::traverse(UA_NodeId nodeId, 
std::function cb,
 
   UA_BrowseResponse bResp = UA_Client_Service_browse(client_, bReq);
 
-  utils::ScopeGuard guard([]() {
+  gsl::finally guard([]() {

Review comment:
   PR updated with the correct signature.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #849: MINIFICPP-1261 - Mark ScopeGuard class deprecated

[GitBox]

hunyadi-dev commented on a change in pull request #849:
URL: https://github.com/apache/nifi-minifi-cpp/pull/849#discussion_r460144896



##
File path: extensions/opc/src/opc.cpp
##
@@ -302,7 +303,7 @@ void Client::traverse(UA_NodeId nodeId, 
std::function cb,
 
   UA_BrowseResponse bResp = UA_Client_Service_browse(client_, bReq);
 
-  utils::ScopeGuard guard([]() {
+  gsl::finally guard([]() {

Review comment:
   Oh, I see, will correct it. I wonder why my replacement did not produce 
syntax errors locally though.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org