[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0
phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/518#discussion_r267413595 ## File path: NOTICE ## @@ -1,5 +1,5 @@ Apache NiFi MiNiFi -Copyright 2017 The Apache Software Foundation +Copyright 2019 The Apache Software Foundation Review comment: Thanks. If the date of first publication is fine as per copy right law, I imagine a range is fine too, in which case I would prefer a singular date to avoid giving the impression that we "haven't updated" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0
phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/518#discussion_r267341765 ## File path: NOTICE ## @@ -1,5 +1,5 @@ Apache NiFi MiNiFi -Copyright 2017 The Apache Software Foundation +Copyright 2019 The Apache Software Foundation Review comment: This is a copyright notice, so that's the year of the first publication. Section 4.3 of ALV2 doesn't stipulate that a date is needed; however, the date is from the original notice. Typically copyrights are good for the lifetime of author, so a range doesn't make particular sense either. Does ASF provide any additional information on this @apiri ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0
phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/518#discussion_r267341765 ## File path: NOTICE ## @@ -1,5 +1,5 @@ Apache NiFi MiNiFi -Copyright 2017 The Apache Software Foundation +Copyright 2019 The Apache Software Foundation Review comment: This is a copyright notice, so that's the year of the first publication. Section 4.3 of ALV2 doesn't stipulate that a date is needed; however, the date is from the original notice. Typically copyrights are good for the lifetime of author, so a range doesn't particularly. Does ASF provide any additional information on this @apiri ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0
phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/518#discussion_r267341765 ## File path: NOTICE ## @@ -1,5 +1,5 @@ Apache NiFi MiNiFi -Copyright 2017 The Apache Software Foundation +Copyright 2019 The Apache Software Foundation Review comment: This is a copyright notice, so that's the year of the first publication. Section 4.3 of ALV2 doesn't stipulate that a date is needed; however, the original notice was from the original notice. Typically copyrights are good for the lifetime of author, so a range doesn't particularly. Does ASF provide any additional information on this @apiri ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0
phrocker commented on a change in pull request #518: MINIFICPP-781 - Fix documentation typos found in 0.6.0 URL: https://github.com/apache/nifi-minifi-cpp/pull/518#discussion_r267341765 ## File path: NOTICE ## @@ -1,5 +1,5 @@ Apache NiFi MiNiFi -Copyright 2017 The Apache Software Foundation +Copyright 2019 The Apache Software Foundation Review comment: This is a copyright notice, so that's the year of the first publication. Section 4.3 of ALV2 doesn't stipulate that a date is needed; however, the original notice was from the original notice. Typically copyrights are good for the lifetime of author, so a range doesn't particularly make sense in any scenario for copyrights. Does ASF provide any additional information on this @apiri ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services