[GitHub] [nifi-minifi-cpp] phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work on Windows

2019-12-11 Thread GitBox
phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work 
on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/687#issuecomment-564759117
 
 
   @bakaid  I saw some updates in my email and have been jumping around between 
projects, so I don't want to be the long pole. I have it on my white board to  
re-try on windows * server, so if you don't get a chance to try it I'd go ahead 
and merge. I'm good with the changes. We can always make a follow on task if 
issues arise. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work on Windows

2019-12-05 Thread GitBox
phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work 
on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/687#issuecomment-562114223
 
 
   We may/should add those variants to appveyor if they have licensing to 
support that. I have paid for those licenses in the past -- but I imagine 
apache has access through appveyor. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work on Windows

2019-12-05 Thread GitBox
phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work 
on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/687#issuecomment-562113592
 
 
   > > This is awesome. I'll try to split some time to check but I had some 
compile time errors as this could be my instance. I'll spin up another windows 
instance on windows 10 home server as my current one may have an unrelated 
issue...but I see appveyor errors. are those related?
   > 
   > I have compiled and tried it on a 64-bit Windows 10 machine. The AppVeyor 
error seems unrelated: `CUSTOMBUILD : error : timer thread did not terminate 
timely [C:\projects\nifi-minifi-cpp\build\curl-external.vcxproj]`
   
   Cool. I'll run the build across variants of 10, 2012 server, 2016 server, 
and 2019 server later today as I usually do. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work on Windows

2019-12-05 Thread GitBox
phrocker commented on issue #687: MINIFICPP-1092 - Make CoAP compile and work 
on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/687#issuecomment-562111023
 
 
   This is awesome. I'll try to split some time to check but I had some compile 
time errors as this could be my instance. I'll spin up another windows instance 
on windows 10 home server as my current one may have an unrelated issue...but I 
see appveyor errors. are those related?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services