[GitHub] [nifi-registry] kevdoran commented on issue #245: NIFIREG-252: adding mavendocker build profile
kevdoran commented on issue #245: NIFIREG-252: adding mavendocker build profile URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-546028884 +1 for relocating it and making it a maven project, as well as for doing that as a separate jira/pr. I will re-review this PR as-is. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] kevdoran commented on issue #245: NIFIREG-252: adding mavendocker build profile
kevdoran commented on issue #245: NIFIREG-252: adding mavendocker build profile URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-545951655 Yeah, good points. I would support moving nifi-registry-core/nifi-registry-docker to a top level module that is responsible for both dockerhub and dockermaven. Do you think we should do that now or save that improvement for later? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-registry] kevdoran commented on issue #245: NIFIREG-252: adding mavendocker build profile
kevdoran commented on issue #245: NIFIREG-252: adding mavendocker build profile URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-543936060 reviewing... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
